ldionne requested changes to this revision. ldionne added a comment. This revision now requires changes to proceed.
In D46443#2566394 <https://reviews.llvm.org/D46443#2566394>, @hubert.reinterpretcast wrote: > The resolution of LWG 2828 > <https://cplusplus.github.io/LWG/lwg-closed.html#2828> means that > `<cstdalign>` exists in C++11 and C++14. The rationale from > https://reviews.llvm.org/D96786#2566110 can be taken as saying that adding > this header for C++11 conformance is reasonable. Yes, I agree, let's add it. But the header needs to be added in `include/CMakeLists.txt`. There also needs to be a test added to check for the contents of the headers, and the auto-generated header tests should be modified. Take a look at what I did in https://reviews.llvm.org/D97870 for `<cuchar>`. Repository: rCXX libc++ CHANGES SINCE LAST ACTION https://reviews.llvm.org/D46443/new/ https://reviews.llvm.org/D46443 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
