Author: Yaxun (Sam) Liu Date: 2021-03-05T08:46:58-05:00 New Revision: 5b3fc7180c8e4a2c57946d5e3cc325744a770717
URL: https://github.com/llvm/llvm-project/commit/5b3fc7180c8e4a2c57946d5e3cc325744a770717 DIFF: https://github.com/llvm/llvm-project/commit/5b3fc7180c8e4a2c57946d5e3cc325744a770717.diff LOG: [HIP] do not use -munsafe-fp-atomics by default A bug was introduced when adding -munsafe-fp-atomics. By default it should be off. Reviewed by: Artem Belevich Differential Revision: https://reviews.llvm.org/D97967 Added: Modified: clang/lib/Driver/ToolChains/Clang.cpp clang/test/Driver/hip-options.hip Removed: ################################################################################ diff --git a/clang/lib/Driver/ToolChains/Clang.cpp b/clang/lib/Driver/ToolChains/Clang.cpp index 8e50e8f7d139..28ac00e970c4 100644 --- a/clang/lib/Driver/ToolChains/Clang.cpp +++ b/clang/lib/Driver/ToolChains/Clang.cpp @@ -6437,7 +6437,7 @@ void Clang::ConstructJob(Compilation &C, const JobAction &JA, handleAMDGPUCodeObjectVersionOptions(D, Args, CmdArgs); if (Args.hasFlag(options::OPT_munsafe_fp_atomics, - options::OPT_mno_unsafe_fp_atomics)) + options::OPT_mno_unsafe_fp_atomics, /*Default=*/false)) CmdArgs.push_back("-munsafe-fp-atomics"); } diff --git a/clang/test/Driver/hip-options.hip b/clang/test/Driver/hip-options.hip index e1050dfab1be..99e9f0c24719 100644 --- a/clang/test/Driver/hip-options.hip +++ b/clang/test/Driver/hip-options.hip @@ -36,6 +36,10 @@ // RUN: --cuda-gpu-arch=gfx906 %s 2>&1 | FileCheck -check-prefix=UNSAFE-FP-ATOMICS %s // UNSAFE-FP-ATOMICS: clang{{.*}} "-triple" "amdgcn-amd-amdhsa" {{.*}} "-munsafe-fp-atomics" +// RUN: %clang -### -nogpuinc -nogpulib \ +// RUN: --cuda-gpu-arch=gfx906 %s 2>&1 | FileCheck -check-prefix=DEFAULT-UNSAFE-FP-ATOMICS %s +// DEFAULT-UNSAFE-FP-ATOMICS-NOT: clang{{.*}} "-triple" "amdgcn-amd-amdhsa" {{.*}} "-munsafe-fp-atomics" + // RUN: %clang -### -target x86_64-unknown-linux-gnu -nogpuinc -nogpulib -fgpu-exclude-wrong-side-overloads \ // RUN: --cuda-gpu-arch=gfx906 %s 2>&1 | FileCheck -check-prefix=FIX-OVERLOAD %s // FIX-OVERLOAD: clang{{.*}} "-triple" "amdgcn-amd-amdhsa" {{.*}} "-fgpu-exclude-wrong-side-overloads" "-fgpu-defer-diag" _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
