[PATCH] D92662: [Clang][Coroutine] Drop const attribute on pthread_self when coroutine is enabled

lxfind updated this revision to Diff 310599. lxfind added a comment. Fix test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92662/new/ https://reviews.llvm.org/D92662 Files: clang/lib/Sema/SemaDecl.cpp clang/test/CodeGenCoroutines/coro-pthread

[clang] 8278922 - Frontend: Migrate to FileEntryRef in VerifyDiagnosticConsumer.cpp, NFC

Author: Duncan P. N. Exon Smith Date: 2020-12-09T11:51:43-08:00 New Revision: 82789228c65317ceea3fdcc08c573c5ca780021e URL: https://github.com/llvm/llvm-project/commit/82789228c65317ceea3fdcc08c573c5ca780021e DIFF: https://github.com/llvm/llvm-project/commit/82789228c65317ceea3fdcc08c573c5ca780

[PATCH] D92699: Frontend: Migrate to FileEntryRef in VerifyDiagnosticConsumer.cpp, NFC

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG82789228c653: Frontend: Migrate to FileEntryRef in VerifyDiagnosticConsumer.cpp, NFC (authored by dexonsmith). Repository: rG LLVM Github Monorepo

[PATCH] D92715: [Clang][RISCV] Define RISC-V V builtin types

craig.topper added a comment. Can we discuss this patch in tomorrows RISC-V meeting? @jrtc27 @kito-cheng @khchen @liaolucy CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92715/new/ https://reviews.llvm.org/D92715 ___ cfe-commits mailing list

[PATCH] D92955: [openmp] Remove clause from OMPKinds.def and use OMP.td info

clementval added a comment. In D92955#2443313 , @jdoerfert wrote: > I like this a lot. We might even look into generating the clang OpenMPClause > classes via TableGen later, thanks a lot. > > There is a file missing, right? The list of actual clauses. T

[PATCH] D92808: [ObjC][ARC] Annotate calls with attributes instead of emitting retainRV or claimRV calls in the IR

ahatanak added a comment. Hmm, it seems that calls to some of the ARC runtime functions don't get the token. In some cases, I'm seeing WinEHPrepare (ToT clang, without this patch) turn a call to @objc_unsafeClaimAutoreleasedReturnValue in an EH cleanup block into an unreachable. Repository:

[PATCH] D92039: [-Wcalled-once-parameter] Introduce 'called_once' attribute

aaron.ballman added a comment. In D92039#2441992 , @vsavchenko wrote: > @aaron.ballman Can you please take a look at the attribute side of this? Thank you for your patience, sorry it took me a while to get to this! Comment at: clang/in

[PATCH] D92160: [clang] Fix wrong FDs are used for files with same name in Tooling

dexonsmith added a comment. Thanks for your patience; I missed this when I was on holiday, and I'm just noticing it now. Can you tell me more about the scenario this happens? Why is the `FileManager` being reused after the working directory change? Do the `FileEntry`s need to remain valid? I'

[PATCH] D92381: [clangd] Extract per-dir CDB cache to its own threadsafe class. NFC

thakis added a comment. Looks like this breaks tests on Windows: http://45.33.8.238/win/29513/step_9.txt Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92381/new/ https://reviews.llvm.org/D92381 ___ cfe-c

[PATCH] D92160: [clang] Fix wrong FDs are used for files with same name in Tooling

dexonsmith added a comment. In D92160#2443405 , @dexonsmith wrote: > - Don't specifically track relative paths / absolute paths. > - Add an API, something like: `dropRelativePaths()`, which drops all > `{File,Directory}Entry{,Ref}` that are somehow based

[PATCH] D92024: [clang] Implement P0692R1 from C++20 (access checking on specializations and instantiations)

Quuxplusone added a comment. > And I came to that we can get rid of this hack and simplify the patch pretty > much Wow, this certainly looks massively better than it was before! :) Glad I could help. ;) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D92955: [openmp] Remove clause from OMPKinds.def and use OMP.td info

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LGTM. (I missed the part that we duplicated the information so far) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92955/new/ https://revi

[PATCH] D90159: [DDG] Data Dependence Graph - DOT printer

bmahjour updated this revision to Diff 310607. bmahjour marked 5 inline comments as done. bmahjour added a comment. Herald added subscribers: cfe-commits, dexonsmith, ecnelises, martong, javed.absar, MatzeB. Herald added a project: clang. Thanks for the review @Meinersbur and sorry for taking so

[PATCH] D90159: [DDG] Data Dependence Graph - DOT printer

bmahjour added inline comments. Comment at: llvm/include/llvm/Analysis/DDG.h:480 +return OS.str(); + unsigned count = 0; + for (auto &D : Deps) { Meinersbur wrote: > [suggestion] Instead of count, you can use `llvm::enumerate`. I think it's > nicer to chec

[clang] 997a719 - PR48434: Work around crashes due to deserialization cycles via typedefs.

Author: Richard Smith Date: 2020-12-09T12:22:35-08:00 New Revision: 997a719d5a70100fcbbec1e51ce44cd66041bddc URL: https://github.com/llvm/llvm-project/commit/997a719d5a70100fcbbec1e51ce44cd66041bddc DIFF: https://github.com/llvm/llvm-project/commit/997a719d5a70100fcbbec1e51ce44cd66041bddc.diff

[clang] 2a2c228 - Add new 'preferred_name' attribute.

Author: Richard Smith Date: 2020-12-09T12:22:35-08:00 New Revision: 2a2c228c7ada0a5d77c48b4d445ab0013ca0ae19 URL: https://github.com/llvm/llvm-project/commit/2a2c228c7ada0a5d77c48b4d445ab0013ca0ae19 DIFF: https://github.com/llvm/llvm-project/commit/2a2c228c7ada0a5d77c48b4d445ab0013ca0ae19.diff

[clang] 4ae8651 - Add another test for PR48434.

Author: Richard Smith Date: 2020-12-09T12:22:35-08:00 New Revision: 4ae8651c59241bca0c1ea5adaf8f06b292696b6f URL: https://github.com/llvm/llvm-project/commit/4ae8651c59241bca0c1ea5adaf8f06b292696b6f DIFF: https://github.com/llvm/llvm-project/commit/4ae8651c59241bca0c1ea5adaf8f06b292696b6f.diff

[PATCH] D92600: [ASTImporter] Add support for importing GenericSelectionExpr AST nodes.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92600/new/ https://reviews.llvm.org/D92600 __

[clang] a5e6590 - [ASTImporter] Support CXXDeductionGuideDecl with local typedef

Author: Gabor Marton Date: 2020-12-09T21:25:04+01:00 New Revision: a5e6590b15b17793d7a82f8b39998381acb73109 URL: https://github.com/llvm/llvm-project/commit/a5e6590b15b17793d7a82f8b39998381acb73109 DIFF: https://github.com/llvm/llvm-project/commit/a5e6590b15b17793d7a82f8b39998381acb73109.diff

[PATCH] D92209: [ASTImporter] Support CXXDeductionGuideDecl with local typedef

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa5e6590b15b1: [ASTImporter] Support CXXDeductionGuideDecl with local typedef (authored by martong). Changed prior to commit: https://reviews.llvm.

[PATCH] D92267: [clang-tidy][NFC] Use moves instead of copies when constructing OptionsProviders.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92267/new/ https://reviews.llvm.org/D92267 ___

[PATCH] D92181: [clangd] NFC: Add client-side logging for remote index requests

kbobyrev updated this revision to Diff 310614. kbobyrev added a comment. Rebase on top of master. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92181/new/ https://reviews.llvm.org/D92181 Files: clang-tools-extra/clangd/index/remote/Client.cpp

[PATCH] D72241: [clang-tidy] new altera single work item barrier check

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72241/new/ https://reviews.llvm.org/D72241 ___ cfe-commits mailing list

[PATCH] D92181: [clangd] NFC: Add client-side logging for remote index requests

kbobyrev updated this revision to Diff 310616. kbobyrev added a comment. Change logging format to be consistent with another patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92181/new/ https://reviews.llvm.org/D92181 Files: clang-tools-extra

[clang-tools-extra] 5a1bc69 - [clangd] NFC: Add client-side logging for remote index requests

Author: Kirill Bobyrev Date: 2020-12-09T21:40:37+01:00 New Revision: 5a1bc69f811059b8f62d381e3526d92fffa7d91a URL: https://github.com/llvm/llvm-project/commit/5a1bc69f811059b8f62d381e3526d92fffa7d91a DIFF: https://github.com/llvm/llvm-project/commit/5a1bc69f811059b8f62d381e3526d92fffa7d91a.diff

[PATCH] D92181: [clangd] NFC: Add client-side logging for remote index requests

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5a1bc69f8110: [clangd] NFC: Add client-side logging for remote index requests (authored by kbobyrev). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D91673: [PGO] Enable preinline and cleanup when optimize for size

zequanwu updated this revision to Diff 310619. zequanwu added a comment. Herald added a subscriber: steven_wu. - fix existing failed testcase. - add new testcases for npm and lpm. - add comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91673/n

[PATCH] D92962: [ASTImporter] Fix import of a typedef that has an attribute

martong created this revision. martong added a reviewer: teemperor. Herald added subscribers: gamesh411, Szelethus, dkrupp, rnkovacs. Herald added a reviewer: a.sidorin. Herald added a reviewer: shafik. martong requested review of this revision. Herald added a project: clang. Herald added a subscri

[PATCH] D92617: [DWARF] Allow toolchain to adjust specified DWARF version.

tra updated this revision to Diff 310622. tra added a comment. Herald added a reviewer: jdoerfert. Herald added a subscriber: sstefan1. Reorganized tests for unsupported debug options & dwarf version clamping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D92920: [clang-tidy] Add a diagnostic callback to parseConfiguration

aaron.ballman added a comment. Nothing is calling the new `parseConfigurationWithDiags()`, is that intentional? Also, is there a way to add test coverage for the change? Comment at: clang-tools-extra/clang-tidy/ClangTidyOptions.cpp:400 +DiagCallback

[PATCH] D92617: [DWARF] Allow toolchain to adjust specified DWARF version.

tra added inline comments. Comment at: clang/test/Driver/cuda-unsupported-debug-options.cu:18 +// RUN: %clang -### -target x86_64-linux-gnu -c %s -gdwarf-5 -gembed-source 2>&1 | FileCheck %s --check-prefix=DWARF-CLAMP +// CHECK: debug information option '{{-gz|-fdebug-info-for-

[PATCH] D92617: [DWARF] Allow toolchain to adjust specified DWARF version.

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Fair enough - thanks for your patience/explanations! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92617/new/ https://reviews.llvm.org/D9261

[clang] 8b23b3a - [NFCI] Add missing triple to several LTO tests

Author: Yuanfang Chen Date: 2020-12-09T13:13:58-08:00 New Revision: 8b23b3ab3aea28b91e5aa48f29fe9eb1828515a3 URL: https://github.com/llvm/llvm-project/commit/8b23b3ab3aea28b91e5aa48f29fe9eb1828515a3 DIFF: https://github.com/llvm/llvm-project/commit/8b23b3ab3aea28b91e5aa48f29fe9eb1828515a3.diff

[PATCH] D92930: [Clang] Add vcmla and rotated variants for Arm ACLE.

fhahn updated this revision to Diff 310632. fhahn added a comment. Updated to use new VCMLA_ROTS multiclass to define rotated variants. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92930/new/ https://reviews.llvm.org/D92930 Files: clang/include

[PATCH] D92930: [Clang] Add vcmla and rotated variants for Arm ACLE.

fhahn added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:5237 NEONMAP1(vcaddq_rot90_v, arm_neon_vcadd_rot90, Add1ArgType), + NEONMAP1(vcaddq_rot90_v, arm_neon_vcadd_rot90, Add1ArgType), NEONMAP1(vcage_v, arm_neon_vacge, 0), t.p.northover wr

[clang] a5c89bb - Frontend: Migrate to FileEntryRef in CompilerInstance::InitializeSourceManager, NFC

Author: Duncan P. N. Exon Smith Date: 2020-12-09T13:28:29-08:00 New Revision: a5c89bb02195a97aa71a406d9864098c764f URL: https://github.com/llvm/llvm-project/commit/a5c89bb02195a97aa71a406d9864098c764f DIFF: https://github.com/llvm/llvm-project/commit/a5c89bb02195a97aa71a406d9864098c

[PATCH] D92680: Frontend: Migrate to FileEntryRef in CompilerInstance::InitializeSourceManager, NFC

This revision was automatically updated to reflect the committed changes. Closed by commit rGa5c89bb02195: Frontend: Migrate to FileEntryRef in CompilerInstance::InitializeSourceManager… (authored by dexonsmith). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D92967: Tooling: Migrate RewriterTestContext to FileEntryRef, NFC

dexonsmith created this revision. dexonsmith added reviewers: jansvoboda11, arphaman. Herald added a subscriber: ributzka. dexonsmith requested review of this revision. Herald added a project: clang. Migrate to the `FileEntryRef` overload of `SourceManager::createFileID` (using `FileManager::getOp

[PATCH] D92600: [ASTImporter] Add support for importing GenericSelectionExpr AST nodes.

tmroeder added a comment. @aaron.ballman It looks like those template tests fail on x64 windows; this is a problem that came up with D58292 as well. It ended up getting rolled back because template-based tests failed on windows, and I had to remove the tests an

[PATCH] D77598: Integral template argument suffix and cast printing

rsmith added inline comments. Comment at: clang/include/clang/AST/DeclTemplate.h:213 +else if (Idx >= TPL->size()) + return false; +else { We should return `true` in this case; we don't know what the corresponding parameter is so we don't know if th

[PATCH] D92198: [clangd] Log remote index connectivity status

kbobyrev updated this revision to Diff 310642. kbobyrev marked 5 inline comments as done. kbobyrev added a comment. Resolve review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92198/new/ https://reviews.llvm.org/D92198 Files: clang-to

[PATCH] D92920: [clang-tidy] Add a diagnostic callback to parseConfiguration

njames93 added a comment. In D92920#2443578 , @aaron.ballman wrote: > Nothing is calling the new `parseConfigurationWithDiags()`, is that > intentional? Also, is there a way to add test coverage for the change? Yes it is intentional, the idea is for pro

[PATCH] D92968: Frontend: Migrate to FileEntryRef in TextDiagnosticTest, NFC

dexonsmith created this revision. dexonsmith added reviewers: arphaman, jansvoboda11. Herald added a subscriber: ributzka. dexonsmith requested review of this revision. Herald added a project: clang. Migrate over to the `FileEntryRef` overloads of `SourceManager::createFileID` and `overrideFileCon

[PATCH] D92788: [clangd] NFC: Use SmallVector where possible

kbobyrev updated this revision to Diff 310650. kbobyrev marked an inline comment as done. kbobyrev added a comment. Revert the case flagged by @njames93. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92788/new/ https://reviews.llvm.org/D92788 File

[PATCH] D92788: [clangd] NFC: Use SmallVector where possible

kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/unittests/TestTU.cpp:190 const NamedDecl &findDecl(ParsedAST &AST, llvm::StringRef QName) { - llvm::SmallVector Components; + llvm::SmallVector Components; QName.split(Components, "::"); n

[PATCH] D92915: [Driver] Add -f[no-]new-pass-manager to supersede -f[no-]experimental-new-pass-manager

rsmith added a comment. I don't like having `new` in the name of the flag; I think that's going to age badly (and I would argue it already has done; the "new pass manager" isn't really all that new any more). Given that the new pass manager is considered stable and not experimental, can we cha

[PATCH] D92969: [AST] Fix a constexpr-evaluator crash on error-dependent returnstmt.

hokein created this revision. hokein added reviewers: sammccall, rsmith. hokein requested review of this revision. Herald added a project: clang. When the evaluator encounters an error-dependent returnstmt, before this patch it returned a ESR_Returned without setting the result, the callsides thin

[PATCH] D92886: [Sema] Warn about unused functions even when they're inline

aaronpuchert added a comment. In D92886#2443176 , @aaronpuchert wrote: >> Non-static inline functions in C have confusing semantics. > > I'm not terribly familiar with C, but judging from C11 6.7.4 it seems that C > is a bit more permissive, but then say

[PATCH] D92915: [Driver] Add -f[no-]legacy-pass-manager to supersede -f[no-]experimental-new-pass-manager

MaskRay updated this revision to Diff 310654. MaskRay retitled this revision from "[Driver] Add -f[no-]new-pass-manager to supersede -f[no-]experimental-new-pass-manager" to "[Driver] Add -f[no-]legacy-pass-manager to supersede -f[no-]experimental-new-pass-manager". MaskRay edited the summary of

[PATCH] D92971: clang-import-test: Clean up error output for files that cannot be found

dexonsmith created this revision. dexonsmith added reviewers: shafik, arphaman, jansvoboda11. Herald added a subscriber: ributzka. dexonsmith requested review of this revision. Herald added a project: clang. Pass on the filesystem error string `FileManager::getFileRef` in `clang-import-test`'s `Pa

[PATCH] D92971: clang-import-test: Clean up error output for files that cannot be found

dexonsmith added a comment. If the error output changes seem imprudent, I'm happy to skip those; the only thing I need here is the migration to the other overload of `createFileID` (the "side effect"); could just call `llvm::consumeError` and be done with it. Repository: rG LLVM Github Monor

[PATCH] D92721: [PATCH] [clang] Create SPIRABIInfo to enable SPIR_FUNC calling convention

mibintc updated this revision to Diff 310655. mibintc added a comment. I rebased and applied clang-format patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92721/new/ https://reviews.llvm.org/D92721 Files: clang/lib/CodeGen/CGBuiltin.cpp cla

[PATCH] D92678: ARCMigrate: Migrate ObjCMT.cpp over to FileEntryRef

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG898d61b3cff5: ARCMigrate: Migrate ObjCMT.cpp over to FileEntryRef (authored by dexonsmith). Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[clang] 898d61b - ARCMigrate: Migrate ObjCMT.cpp over to FileEntryRef

Author: Duncan P. N. Exon Smith Date: 2020-12-09T14:16:05-08:00 New Revision: 898d61b3cff5d79870d964c76d82764fef73efbb URL: https://github.com/llvm/llvm-project/commit/898d61b3cff5d79870d964c76d82764fef73efbb DIFF: https://github.com/llvm/llvm-project/commit/898d61b3cff5d79870d964c76d82764fef73

[clang] c3ff993 - Remove RemappedFiles param from ASTUnit::LoadFromASTFile, NFC

Author: Duncan P. N. Exon Smith Date: 2020-12-09T14:44:31-08:00 New Revision: c3ff9939bf7efeb11da49f100a277b4d8bbeff9f URL: https://github.com/llvm/llvm-project/commit/c3ff9939bf7efeb11da49f100a277b4d8bbeff9f DIFF: https://github.com/llvm/llvm-project/commit/c3ff9939bf7efeb11da49f100a277b4d8bbe

[PATCH] D90889: Remove RemappedFiles param from ASTUnit::LoadFromASTFile, NFC

This revision was automatically updated to reflect the committed changes. Closed by commit rGc3ff9939bf7e: Remove RemappedFiles param from ASTUnit::LoadFromASTFile, NFC (authored by dexonsmith). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.org/D90889?vs=303265&id

[PATCH] D92662: [Clang][Coroutine] Drop const attribute on pthread_self when coroutine is enabled

MaskRay added a comment. It is worth requesting clarification on GCC `__attribute__((const))`: (https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66512) If the attribute is not suitable, glibc should drop it. The compiler can add `readnone`/`readonly` if appropriate. Repository: rG LLVM Github M

[PATCH] D92975: Lex: Migrate HeaderSearch::LoadedModuleMaps to FileEntryRef

dexonsmith created this revision. dexonsmith added reviewers: arphaman, jansvoboda11. Herald added a subscriber: ributzka. dexonsmith requested review of this revision. Herald added a project: clang. Migrate `HeaderSearch::LoadedModuleMaps` and a number of APIs over to `FileEntryRef`. This should

[clang] 75a95bc - clang-format: Migrate createInMemoryFile to FileEntryRef, NFC

Author: Duncan P. N. Exon Smith Date: 2020-12-09T15:00:53-08:00 New Revision: 75a95bc80eae0c539b342f2cb19a92a0de02d2e1 URL: https://github.com/llvm/llvm-project/commit/75a95bc80eae0c539b342f2cb19a92a0de02d2e1 DIFF: https://github.com/llvm/llvm-project/commit/75a95bc80eae0c539b342f2cb19a92a0de02

[PATCH] D92962: [ASTImporter] Fix import of a typedef that has an attribute

shafik added a comment. LGTM Comment at: clang/unittests/AST/ASTImporterTest.cpp:6098 + FirstDeclMatcher().match(TU, typedefDecl(hasName("X"))); + auto *ToD = Import(FromD, Lang_CXX17); + ASSERT_TRUE(ToD); We can't check the attribute is present? Repos

[PATCH] D92977: [clangd] Improve hover and goToDefinition on auto and dectype

qchateau created this revision. Herald added subscribers: usaxena95, kadircet, arphaman. qchateau requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. Make the hover content on auto and decltype look like the hover content

[PATCH] D92808: [ObjC][ARC] Annotate calls with attributes instead of emitting retainRV or claimRV calls in the IR

ahatanak updated this revision to Diff 310693. ahatanak edited the summary of this revision. ahatanak added a comment. Enable the optimization on Windows. Move `createCallInst` defined in ObjCARCContract.cpp to ObjCARC.h and use it to create calls to retainRV/claimRV with funclet tokens when ARC

[PATCH] D92600: [ASTImporter] Add support for importing GenericSelectionExpr AST nodes.

tmroeder updated this revision to Diff 310701. tmroeder added a comment. Moved the result-dependent tests into a different test class, one that explicitly uses templates already. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92600/new/ https://rev

[PATCH] D92967: Tooling: Migrate some tests to FileEntryRef, NFC

dexonsmith updated this revision to Diff 310702. dexonsmith retitled this revision from "Tooling: Migrate RewriterTestContext to FileEntryRef, NFC" to "Tooling: Migrate some tests to FileEntryRef, NFC". dexonsmith edited the summary of this revision. dexonsmith added a comment. Found another Tool

[PATCH] D92808: [ObjC][ARC] Annotate calls with attributes instead of emitting retainRV or claimRV calls in the IR

ahatanak added a comment. ToT clang/llvm (without this patch) is turning the call to `@objc_unsafeClaimAutoreleasedReturnValue` in the EH cleanup block into an unreachable when compiling the following code. It looks like this happens because the inliner isn't adding the funclet token, but it's

[PATCH] D85788: [Clang test] Update to allow passing extra default clang arguments in use_clang

guiand added a comment. This whole thing is a little unfortunate, but maybe a better substitution would be leaving `%clang` as referring to the pure clang binary, with default arguments. Then we can have a `%clang_cc` which may only be used for a standard C compiler invocation. Returning to th

[clang] 347e1f6 - Frontend: Use a getVirtualFileRef for a named pipe main file, NFC

Author: Duncan P. N. Exon Smith Date: 2020-12-09T16:17:14-08:00 New Revision: 347e1f621355d9b58901f3579fde91783c24ca29 URL: https://github.com/llvm/llvm-project/commit/347e1f621355d9b58901f3579fde91783c24ca29 DIFF: https://github.com/llvm/llvm-project/commit/347e1f621355d9b58901f3579fde91783c24

[PATCH] D90159: [DDG] Data Dependence Graph - DOT printer

Meinersbur accepted this revision. Meinersbur added a comment. This revision is now accepted and ready to land. Thanks, LGTM. Comment at: llvm/include/llvm/Analysis/DDG.h:489 + }, + [&] { OS << ", "; }); + return OS.str(); `llvm::interleaveComma` doe

[PATCH] D92808: [ObjC][ARC] Annotate calls with attributes instead of emitting retainRV or claimRV calls in the IR

ahatanak updated this revision to Diff 310709. ahatanak added a comment. Elaborate on when `createCallInstWithColors` should be called. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92808/new/ https://reviews.llvm.org/D92808 Files: clang/lib/Cod

[PATCH] D92662: [Clang][Coroutine] Drop const attribute on pthread_self when coroutine is enabled

lxfind added a comment. In D92662#2443970 , @MaskRay wrote: > If the attribute is not suitable, glibc should drop it. The compiler can add > `readnone`/`readonly` if appropriate. It's a C library interface though, and Coroutine is likely too new for this

[PATCH] D92975: Lex: Migrate HeaderSearch::LoadedModuleMaps to FileEntryRef

dexonsmith updated this revision to Diff 310713. dexonsmith added a comment. I must have just been building `clangLex` before, since I missed (until now) updating the other API users. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92975/new/ https://reviews.llvm.org/D92975 Files: cla

[clang] 2ea8c69 - Tooling: Migrate to FileEntryRef in clang::tooling::applyAllReplacements, NFC

Author: Duncan P. N. Exon Smith Date: 2020-12-09T16:31:38-08:00 New Revision: 2ea8c69eff07c491c7cb14dd46afd30529b89d91 URL: https://github.com/llvm/llvm-project/commit/2ea8c69eff07c491c7cb14dd46afd30529b89d91 DIFF: https://github.com/llvm/llvm-project/commit/2ea8c69eff07c491c7cb14dd46afd30529b8

[clang] 016e4eb - [DWARF] Allow toolchain to adjust specified DWARF version.

Author: Artem Belevich Date: 2020-12-09T16:34:34-08:00 New Revision: 016e4ebfde28d6bb1ab6399fc8abd8cfc6a1d9fd URL: https://github.com/llvm/llvm-project/commit/016e4ebfde28d6bb1ab6399fc8abd8cfc6a1d9fd DIFF: https://github.com/llvm/llvm-project/commit/016e4ebfde28d6bb1ab6399fc8abd8cfc6a1d9fd.diff

[PATCH] D92617: [DWARF] Allow toolchain to adjust specified DWARF version.

This revision was automatically updated to reflect the committed changes. Closed by commit rG016e4ebfde28: [DWARF] Allow toolchain to adjust specified DWARF version. (authored by tra). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92617/new/ https:/

[PATCH] D92983: SourceManager: Migrate to FileEntryRef in getOrCreateContentCache, NFC

dexonsmith created this revision. dexonsmith added reviewers: arphaman, jansvoboda11. Herald added a subscriber: ributzka. dexonsmith requested review of this revision. Herald added a project: clang. Change `SourceManager::getOrCreateContentCache` to take a `FileEntryRef` and update call sites (mo

[PATCH] D92915: [Driver] Add -f[no-]legacy-pass-manager to supersede -f[no-]experimental-new-pass-manager

MaskRay added a comment. Thanks! @rsmith highlit the coroutine problem https://bugs.llvm.org/show_bug.cgi?id=48190 (" ... it breaks support for a C++20 language feature (coroutines)") Perhaps this means that "EXPERIMENTAL" in `ENABLE_EXPERIMENTAL_NEW_PASS_MANAGER` should not be removed until

[PATCH] D92915: [Driver] Add -f[no-]legacy-pass-manager to supersede -f[no-]experimental-new-pass-manager

aeubanks added a comment. In D92915#2444242 , @MaskRay wrote: > Thanks! > > @rsmith highlit the coroutine problem > https://bugs.llvm.org/show_bug.cgi?id=48190 (" ... it breaks support for a > C++20 language feature (coroutines)") > > Perhaps this means

[PATCH] D92915: [Driver] Add -f[no-]legacy-pass-manager to supersede -f[no-]experimental-new-pass-manager

MaskRay updated this revision to Diff 310720. MaskRay edited the summary of this revision. MaskRay added a comment. -plugin-opt=no-new-pass-manager => -plugin-opt=legacy-pass-manager Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92915/new/ https://

[clang] f9c0d1b - [Driver] Add -f[no-]legacy-pass-manager to supersede -f[no-]experimental-new-pass-manager

Author: Fangrui Song Date: 2020-12-09T16:57:36-08:00 New Revision: f9c0d1b0562c4789638a91ce97f1c2d99608005b URL: https://github.com/llvm/llvm-project/commit/f9c0d1b0562c4789638a91ce97f1c2d99608005b DIFF: https://github.com/llvm/llvm-project/commit/f9c0d1b0562c4789638a91ce97f1c2d99608005b.diff

[PATCH] D92915: [Driver] Add -f[no-]legacy-pass-manager to supersede -f[no-]experimental-new-pass-manager

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf9c0d1b0562c: [Driver] Add -f[no-]legacy-pass-manager to supersede -f[no-]experimental-new… (authored by MaskRay). Repository: rG LLVM Github Mono

[PATCH] D92917: [Driver] Pass -plugin-opt=no-new-pass-manager to the linker

MaskRay abandoned this revision. MaskRay added a comment. I just merged this into D92915 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92917/new/ https://reviews.llvm.org/D92917 ___

[clang-tools-extra] 028e55d - clangd: Migrate to FileEntryRef in TweakTests, NFC

Author: Duncan P. N. Exon Smith Date: 2020-12-09T17:00:42-08:00 New Revision: 028e55d2d411f19e193e3d5df589162a317ab5f1 URL: https://github.com/llvm/llvm-project/commit/028e55d2d411f19e193e3d5df589162a317ab5f1 DIFF: https://github.com/llvm/llvm-project/commit/028e55d2d411f19e193e3d5df589162a317a

[PATCH] D92984: SourceManager: Change getOrCreateFileID API to take FileEntryRef, NFC

dexonsmith created this revision. dexonsmith added reviewers: arphaman, jansvoboda11, JDevlieghere. Herald added subscribers: ributzka, jfb. dexonsmith requested review of this revision. Herald added a project: clang. Update `SourceManager::getOrCreateFileID` to take a `FileEntryRef` and migrate a

[PATCH] D92915: [Driver] Add -f[no-]legacy-pass-manager to supersede -f[no-]experimental-new-pass-manager

thakis added a comment. Seems to break tests: http://45.33.8.238/linux/34907/step_7.txt Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92915/new/ https://reviews.llvm.org/D92915 ___ cfe-commits mailing li

[clang] 872bf68 - Default CodeGenOptions::LegacyPassManager to !LLVM_ENABLE_NEW_PASS_MANAGER

Author: Fangrui Song Date: 2020-12-09T17:10:17-08:00 New Revision: 872bf680011a71b73e9bd353449d9c42ebf6b8f6 URL: https://github.com/llvm/llvm-project/commit/872bf680011a71b73e9bd353449d9c42ebf6b8f6 DIFF: https://github.com/llvm/llvm-project/commit/872bf680011a71b73e9bd353449d9c42ebf6b8f6.diff

[clang-tools-extra] de4f551 - Revert "[clangd] Extract per-dir CDB cache to its own threadsafe class. NFC"

Author: Nico Weber Date: 2020-12-09T20:11:19-05:00 New Revision: de4f5519015cc97f28718d90cc6dac73c0a15161 URL: https://github.com/llvm/llvm-project/commit/de4f5519015cc97f28718d90cc6dac73c0a15161 DIFF: https://github.com/llvm/llvm-project/commit/de4f5519015cc97f28718d90cc6dac73c0a15161.diff LO

[PATCH] D92381: [clangd] Extract per-dir CDB cache to its own threadsafe class. NFC

thakis added a comment. Reverted in de4f5519015cc97f28718d90cc6dac73c0a15161 for now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92381/new/ https://reviews.llvm.org/D92381 _

[PATCH] D91979: [Clang][Attr] Introduce the `assume` function attribute

jdoerfert updated this revision to Diff 310724. jdoerfert added a comment. List known assumptions and warn if unknown. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91979/new/ https://reviews.llvm.org/D91979 Files: clang/docs/LanguageExtensions.

[PATCH] D92915: [Driver] Add -f[no-]legacy-pass-manager to supersede -f[no-]experimental-new-pass-manager

aeubanks added a comment. In D92915#2444287 , @thakis wrote: > Seems to break tests: http://45.33.8.238/linux/34907/step_7.txt that test fails when the NPM is turned on and lit isn't aware of it :) Comment at: clang/include/clang/Drive

[clang] 754d1d3 - [test] Fix Misc/time-passes.c

Author: Fangrui Song Date: 2020-12-09T17:17:28-08:00 New Revision: 754d1d3d52b7145acc9fd440e8ecc0c10d9e966d URL: https://github.com/llvm/llvm-project/commit/754d1d3d52b7145acc9fd440e8ecc0c10d9e966d DIFF: https://github.com/llvm/llvm-project/commit/754d1d3d52b7145acc9fd440e8ecc0c10d9e966d.diff

[PATCH] D92915: [Driver] Add -f[no-]legacy-pass-manager to supersede -f[no-]experimental-new-pass-manager

MaskRay marked an inline comment as done. MaskRay added inline comments. Comment at: clang/include/clang/Driver/Options.td:1354-1356 +defm legacy_pass_manager : BooleanMarshalledFFlag<"legacy-pass-manager", "CodeGenOpts.LegacyPassManager", + "static_cast(LLVM_ENABLE_NEW_PASS_MA

[PATCH] D91979: [Clang][Attr] Introduce the `assume` function attribute

jdoerfert added a comment. I added the warning and typo recognition as discussed in IRC. We list known assumption strings in the documentation and SemaDeclAttr. As we add new ones we should include a short description or link to their meaning. The ones I added so far are OpenMP specific (dubbed

[PATCH] D91979: [Clang][Attr] Introduce the `assume` function attribute

jdoerfert updated this revision to Diff 310727. jdoerfert added a comment. minor spelling improvements Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91979/new/ https://reviews.llvm.org/D91979 Files: clang/docs/LanguageExtensions.rst clang/incl

[clang] 880aa6a - [test] Fix test/Driver/ve-toolchain.cpp

Author: Fangrui Song Date: 2020-12-09T17:26:22-08:00 New Revision: 880aa6ac668b0c0aefb7c7b831e7127c3c54ee9b URL: https://github.com/llvm/llvm-project/commit/880aa6ac668b0c0aefb7c7b831e7127c3c54ee9b DIFF: https://github.com/llvm/llvm-project/commit/880aa6ac668b0c0aefb7c7b831e7127c3c54ee9b.diff

[PATCH] D92386: [VE] Add standard include path and library path for C++

MaskRay added inline comments. Comment at: clang/test/Driver/ve-toolchain.cpp:13 + +// RUN: %clangxx -### -target ve %s 2>&1 | FileCheck -check-prefix=DYNLINKER %s +// DYNLINKER: nld{{.*}} "-dynamic-linker" "/opt/nec/ve/lib/ld-linux-ve.so.1" Many linker options t

[PATCH] D78760: Check a class doesn't have a dependent type before iterating over its base classes

ahatanak updated this revision to Diff 310728. ahatanak added a comment. Rebase and ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78760/new/ https://reviews.llvm.org/D78760 Files: clang/lib/AST/DeclCXX.cpp clang/lib/Sema/SemaDeclCXX.cpp

[PATCH] D92986: [clangd][NFC] Remove unnecessary vector.

njames93 created this revision. njames93 added reviewers: kbobyrev, sammccall. Herald added subscribers: usaxena95, kadircet, arphaman. njames93 requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. As pointed out in D92788

[PATCH] D92386: [VE] Add standard include path and library path for C++

kaz7 added a comment. Thank you for suggestions. I'll submit patches to improve it. Comment at: clang/test/Driver/ve-toolchain.cpp:13 + +// RUN: %clangxx -### -target ve %s 2>&1 | FileCheck -check-prefix=DYNLINKER %s +// DYNLINKER: nld{{.*}} "-dynamic-linker" "/opt/nec/ve/lib/

[PATCH] D91442: [clang][Driver] Handle risvc in Baremetal.cpp.

MaskRay added a comment. This change has been failing on my machine for the past two weeks. `riscv32-toolchain-extra.c` and `riscv64-toolchain-extra.c` are not hermit. I have installed `/usr/lib/gcc-cross/riscv64-linux-gnu/10` (gcc-10-riscv64-linux-gnu and its dependencies) on my machine and th

[PATCH] D92006: Refactoring the attrubute plugin example to fit the new API

psionic12 marked 5 inline comments as done. psionic12 added inline comments. Comment at: clang/test/Frontend/plugin-attribute.cpp:1 -// RUN: %clang -fplugin=%llvmshlibdir/Attribute%pluginext -emit-llvm -S %s -o - 2>&1 | FileCheck %s --check-prefix=ATTRIBUTE -// RUN: not %clang -

<    1   2   3   >