kaz7 added a comment.
Thank you for suggestions. I'll submit patches to improve it.
================
Comment at: clang/test/Driver/ve-toolchain.cpp:13
+
+// RUN: %clangxx -### -target ve %s 2>&1 | FileCheck -check-prefix=DYNLINKER %s
+// DYNLINKER: nld{{.*}} "-dynamic-linker" "/opt/nec/ve/lib/ld-linux-ve.so.1"
----------------
MaskRay wrote:
> Many linker options tests should really be merged to save resources on
> developers.
>
> This test has been failing for me for the last few days so I committed
> 880aa6ac668b0c0aefb7c7b831e7127c3c54ee9b to fix it and merge the
> --dynamic-linker with the other options.
Thank you so much for fixing my problem.
================
Comment at: clang/test/Driver/ve-toolchain.cpp:90
+
+// RUN: %clangxx -### -target ve %s 2>&1 | FileCheck -check-prefix=DEFADDESIG
%s
+// DEFADDESIG: clang{{.*}} "-cc1"
----------------
MaskRay wrote:
> One %clangxx command is sufficient to test the default-ness of -faddrsig.
>
> The -fno-addrsig and -faddrsig have been tested by addrsig.c. Please don't
> duplicate.
I'll do that. Thank you for suggestion.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D92386/new/
https://reviews.llvm.org/D92386
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
