aaron.ballman added a comment.
Nothing is calling the new `parseConfigurationWithDiags()`, is that
intentional? Also, is there a way to add test coverage for the change?
================
Comment at: clang-tools-extra/clang-tidy/ClangTidyOptions.cpp:400
+ DiagCallback Handler) {
+ llvm::yaml::Input Input(Config, nullptr, Handler ? diagHandlerImpl : nullptr,
+ &Handler);
----------------
Would it make sense to require `Handler` to be nonnull with an assertion?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D92920/new/
https://reviews.llvm.org/D92920
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
