[PATCH] D91049: [clangd][remote] Check an index file correctly

ArcsinX created this revision. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman. Herald added a project: clang. ArcsinX requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. There is not reason to check `std::make_unique<...>(..)` return value, bu

[PATCH] D91051: [clangd] Improve clangd-indexer performance

ArcsinX created this revision. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman. Herald added a project: clang. ArcsinX requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. This is a try to improve clangd-indexer tool performance: - avoid proces

[PATCH] D91049: [clangd][remote] Check an index file correctly

kadircet accepted this revision. kadircet added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/index/remote/server/Server.cpp:365 } + auto Index = std::make_unique(std::move(SymIndex)); well actually w

[PATCH] D91049: [clangd][remote] Check an index file correctly

ArcsinX updated this revision to Diff 303766. ArcsinX added a comment. Do not use unique pointer for Index Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91049/new/ https://reviews.llvm.org/D91049 Files: clang-tools-extra/clangd/index/remote/serv

[PATCH] D91051: [clangd] Improve clangd-indexer performance

kadircet added inline comments. Comment at: clang-tools-extra/clangd/indexer/IndexerMain.cpp:46 Opts.CountReferences = true; +Opts.FileFilter = [&](const SourceManager &SM, FileID FID) { + const auto *F = SM.getFileEntryForID(FID); this changes the

[PATCH] D89790: [clangd] Add basic conflict detection for the rename.

hokein updated this revision to Diff 303768. hokein marked 3 inline comments as done. hokein added a comment. address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89790/new/ https://reviews.llvm.org/D89790 Files: clang-tools-ex

[PATCH] D91054: [LLVM][OpenMP] Frontend work for sections - D89671

AMDChirag created this revision. AMDChirag added reviewers: anchu-rajendran, fghanim, jdoerfert, kiranchandramohan, kiranktp, SouraVX, AlexisPerry, Meinersbur. Herald added subscribers: cfe-commits, guansong, yaxunl. Herald added a project: clang. AMDChirag requested review of this revision. Heral

[PATCH] D91047: Add a call super attribute plugin example

psionic12 updated this revision to Diff 303772. psionic12 added a comment. add final attribute checking Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91047/new/ https://reviews.llvm.org/D91047 Files: clang/docs/ClangPlugins.rst clang/examples/

[PATCH] D91029: [clangd] Implement clang-tidy options from config

njames93 updated this revision to Diff 303774. njames93 added a comment. - Fix compile error for gcc 5.3. - Add back logging configuration when creating CTContext. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91029/new/ https://reviews.llvm.org/D9

[PATCH] D91054: [Clang][OpenMP] Frontend work for sections - D89671

AMDChirag added a comment. The test case will also be added here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91054/new/ https://reviews.llvm.org/D91054 ___ cfe-commits mailing list cfe-commits@lists.l

[PATCH] D91047: Add a call super attribute plugin example

psionic12 added inline comments. Comment at: clang/test/Frontend/plugin-call-super.cpp:7 +struct Base2 { [[call_super]] virtual void Test() {} }; +struct Derive : public Base1, public Base2 { [[call_super]] virtual void Test() override final; }; +// CALLSUPER: warning: call_supe

[PATCH] D91055: [clang-tidy] Introduce misc No Integer To Pointer Cast check

lebedev.ri created this revision. lebedev.ri added reviewers: aaron.ballman, njames93, JonasToth. lebedev.ri added a project: LLVM. Herald added subscribers: cfe-commits, xazax.hun, mgorny. Herald added a project: clang. lebedev.ri requested review of this revision. While casting an (integral) poi

[PATCH] D90849: [dllexport] Avoid multiple codegen assert for explicitly defaulted methods in explicit instantiation definitions (PR47683)

hans marked 3 inline comments as done. hans added inline comments. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:5898 // encountered. } else if (!MD->isTrivial() || MD->isExplicitlyDefaulted() || MD->isCopyAssignmentOperator() || rn

[PATCH] D90849: [dllexport] Avoid multiple codegen assert for explicitly defaulted methods in explicit instantiation definitions (PR47683)

hans updated this revision to Diff 303778. hans marked an inline comment as done. hans added a comment. Addressing comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90849/new/ https://reviews.llvm.org/D90849 Files: clang/lib/Sema/SemaDeclCXX.cpp clang/test/CodeGenCXX/dllexpor

[PATCH] D90928: [OpenCL] Add assertions to extension lookup

erik2020 added a comment. In D90928#2379322 , @Anastasia wrote: > Ok, it would still segfault but perhaps it is acceptable as this is an > internal frontend only option for now. Would it be better if these functions returned `false` for unknown extension

[PATCH] D91055: [clang-tidy] Introduce misc No Integer To Pointer Cast check

nlopes added a comment. Nice! BTW, another popular idiom is to store data in the last few bits of the pointer (e.g., LLVM's own PointerIntPair). I guess that one can also be implement by casting the ptr to char* and doing operations over that. Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D91055: [clang-tidy] Introduce misc No Integer To Pointer Cast check

tschuett added a comment. Out of curiosity: why is this in clang-tidy and not in clang? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91055/new/ https://reviews.llvm.org/D91055 ___ cfe-commits mailing li

[PATCH] D91055: [clang-tidy] Introduce misc No Integer To Pointer Cast check

lebedev.ri added a comment. In D91055#2382112 , @nlopes wrote: > Nice! Why thank you. > BTW, another popular idiom is to store data in the last few bits of the > pointer (e.g., LLVM's own PointerIntPair). I guess that one can also be > implement by cas

[PATCH] D90949: [clang-format] avoid introducing multiline comments

krasimir updated this revision to Diff 303788. krasimir marked 3 inline comments as done. krasimir added a comment. - address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90949/new/ https://reviews.llvm.org/D90949 Files: clang/l

[PATCH] D90949: [clang-format] avoid introducing multiline comments

krasimir added inline comments. Comment at: clang/lib/Format/BreakableToken.cpp:109 +// after '\'. +if (Style.isCpp()) { + StringRef::size_type LastNonBlank = sammccall wrote: > Do we really want to predicate this on isCpp()? `//` comments are allowe

[PATCH] D60193: [OpenCL] Added addrspace_cast operator

mantognini added inline comments. Comment at: clang/include/clang-c/Index.h:2057 + */ + CXCursor_CXXAddrspaceCastExpr = 129, + hans wrote: > Anastasia wrote: > > hans wrote: > > > akyrtzi wrote: > > > > Hi Anastasia, apologies for not catching this earlier, bu

[PATCH] D90765: [ARM][AArch64] Adding Neoverse V1 CPU support

pratlucas updated this revision to Diff 303803. pratlucas added a comment. Removing extra includes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90765/new/ https://reviews.llvm.org/D90765 Files: clang/test/Driver/aarch64-cpus.c clang/test/Dri

[PATCH] D90555: [clangd] Handle duplicate enum constants in PopulateSwitch tweak

sammccall accepted this revision. sammccall added a comment. Fantastic, thanks! Still LG, comments optional. Comment at: clang-tools-extra/clangd/refactor/tweaks/PopulateSwitch.cpp:61 private: + class EnumAndCovered { + public: for this kind of purpose, we'

[PATCH] D90949: [clang-format] avoid introducing multiline comments

sammccall accepted this revision. sammccall added a comment. Still LG Comment at: clang/lib/Format/BreakableToken.cpp:109 +// after '\'. +if (Style.isCpp()) { + StringRef::size_type LastNonBlank = krasimir wrote: > sammccall wrote: > > Do we really

[PATCH] D90956: [clang][SVE] Additional macros implied by `-msve-vector-bits=`.

fpetrogalli updated this revision to Diff 303805. fpetrogalli added a comment. NFC: update tests to use `%clang_cc1` instead of `%clang` to prevent errors for missing includes: https://reviews.llvm.org/B77907 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D91055: [clang-tidy] Introduce misc No Integer To Pointer Cast check

arichardson added a comment. Nice! I wonder if this could be an off-by-default (maybe enabled by -Wpedantic) warning in clang instead? Diagnostics like this could be very useful for CHERI since our capabilities are in some way tracking provenance in hardware: we have bounds, permissions and a

[PATCH] D91055: [clang-tidy] Introduce misc No Integer To Pointer Cast check

lebedev.ri added a subscriber: rsmith. lebedev.ri added a comment. CC'ing @rsmith regarding the suggestion/question of also having a clang diagnostic for this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91055/new/ https://reviews.llvm.org/D9105

[PATCH] D90524: [Driver] Enable getOSLibDir() lib32 workaround for SPARC on Linux

glaubitz added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90524/new/ https://reviews.llvm.org/D90524 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D90549: [Driver] Switch CHECK-DEBIAN-SPARC tests to use debian_multiarch_tree

glaubitz added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90549/new/ https://reviews.llvm.org/D90549 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D87981: [X86] AMX programming model prototype.

LuoYuanke added inline comments. Comment at: clang/test/CodeGen/X86/amx_api.c:13 + //CHECK-LABEL: @test_api + //CHECK: call <256 x i32> @llvm.x86.tileloadd64.internal + //CHECK: call <256 x i32> @llvm.x86.tdpbssd.internal pengfei wrote: > Shoud it check for 3

[PATCH] D91067: [AArch64][SVE] Support implicit lax vector conversions for SVE types

joechrisellis created this revision. joechrisellis added reviewers: peterwaller-arm, fpetrogalli, DavidTruby. Herald added subscribers: cfe-commits, psnobl, kristof.beyls, tschuett. Herald added a reviewer: rengolin. Herald added a reviewer: efriedma. Herald added a project: clang. joechrisellis re

[PATCH] D91051: [clangd] Improve clangd-indexer performance

hokein added inline comments. Comment at: clang-tools-extra/clangd/indexer/IndexerMain.cpp:46 Opts.CountReferences = true; +Opts.FileFilter = [&](const SourceManager &SM, FileID FID) { + const auto *F = SM.getFileEntryForID(FID); kadircet wrote: > t

[PATCH] D91051: [clangd] Improve clangd-indexer performance

sammccall added a comment. This seems like an accuracy/latency tradeoff in an environment where... it's not clear why we care about latency very much. Do we? OTOH, how useful is it to have a static index that's more accurate if it's going to be shadowed by a dynamic index for the files you care

[PATCH] D90849: [dllexport] Avoid multiple codegen assert for explicitly defaulted methods in explicit instantiation definitions (PR47683)

thakis accepted this revision. thakis added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:5917 // There is no later point when we will see the definition of this // function, so pass it to the consum

[clang-tools-extra] 5918ef8 - [clangd] Handle duplicate enum constants in PopulateSwitch tweak

Author: Nathan James Date: 2020-11-09T12:14:53Z New Revision: 5918ef8b1aac00af2f8dd8b99f3de7b176463444 URL: https://github.com/llvm/llvm-project/commit/5918ef8b1aac00af2f8dd8b99f3de7b176463444 DIFF: https://github.com/llvm/llvm-project/commit/5918ef8b1aac00af2f8dd8b99f3de7b176463444.diff LOG:

[PATCH] D90555: [clangd] Handle duplicate enum constants in PopulateSwitch tweak

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5918ef8b1aac: [clangd] Handle duplicate enum constants in PopulateSwitch tweak (authored by njames93). Changed prior to commit: https://reviews.ll

[PATCH] D91067: [AArch64][SVE] Support implicit lax vector conversions for SVE types

peterwaller-arm added a comment. fixed_float64_t appears in the commit message but also is unused. Comment at: clang/test/Sema/aarch64-sve-lax-vector-conversions.cpp:15 +typedef svint32_t fixed_int32_t FIXED_ATTR; +typedef svint64_t fixed_int64_t FIXED_ATTR; +

[PATCH] D90956: [clang][SVE] Additional macros implied by `-msve-vector-bits=`.

peterwaller-arm added inline comments. Comment at: clang/test/CodeGen/aarch64-sve-acle-__ARM_FEATURE_SVE_VECTOR_OPERATORS-expected-error-on-address.c:6 + +// Examples taken from section 3.7.3.3 of the SVE ACLE (Version +// 00bet6) that can be found at Reposit

[PATCH] D82860: Port ObjCMTAction to new option parsing system

jansvoboda11 commandeered this revision. jansvoboda11 added a reviewer: dang. jansvoboda11 added a comment. Taking control of this revision, as Daniel is no longer involved. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82860/new/ https://reviews.l

[PATCH] D90956: [clang][SVE] Additional macros implied by `-msve-vector-bits=`.

peterwaller-arm added a comment. Suggestion: Where referencing sections you could include the title "3.7.3.3. Behavior specific to SVE vectors" instead of "3.7.3.3" for example. I think this makes it easier to spot misreferences and gives future souls a better chance to understand the context w

[PATCH] D90748: [clangd] Introduce config parsing for External blocks

kadircet updated this revision to Diff 303824. kadircet marked 6 inline comments as done. kadircet added a comment. - Update comments - Drop the warning for specifying server on non-grpc builds Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90748/new

[PATCH] D90849: [dllexport] Avoid multiple codegen assert for explicitly defaulted methods in explicit instantiation definitions (PR47683)

hans added inline comments. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:5917 // There is no later point when we will see the definition of this // function, so pass it to the consumer now. S.Consumer.HandleTopLevelDecl(DeclGroupRef(MD));

[PATCH] D82860: Port ObjCMTAction to new option parsing system

jansvoboda11 updated this revision to Diff 303828. jansvoboda11 added a comment. Rebase on top of D82756 . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82860/new/ https://reviews.llvm.org/D82860 Files: clang/include/clang/Driver/Options.td clang/li

[PATCH] D82860: Port ObjCMTAction to new option parsing system

jansvoboda11 requested review of this revision. jansvoboda11 added a comment. WDYT @Bigcheese? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82860/new/ https://reviews.llvm.org/D82860 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

[PATCH] D87981: [X86] AMX programming model prototype.

LuoYuanke updated this revision to Diff 303830. LuoYuanke added a comment. 1. Address Pengfei's comments. 2. Add tilerelease at the epilog. 3. Fix a bug of emitting instruction that use subregister. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D8798

[PATCH] D91051: [clangd] Improve clangd-indexer performance

ArcsinX added a comment. Thanks you all for your comments. I will try to describe my thoughts: - the more data `SymbolCollector` will collect, the greater the difference (`N` will increase in `this patch improves performance in N times`). E.g. collection call/contain relations will affect `cla

[PATCH] D87981: [X86] AMX programming model prototype.

LuoYuanke marked 5 inline comments as done. LuoYuanke added inline comments. Comment at: llvm/lib/Target/X86/X86TileConfig.cpp:101 + unsigned SubIdx = (BitSize == 8) ? X86::sub_8bit : X86::sub_16bit; + unsigned Opc = (BitSize == 8) ? X86::MOV8mr : X86::MOV16mr; + MachineInstr

[PATCH] D90957: Frontend: Skip namespace around createVFSFromCompilerInvocation definition, NFC

jansvoboda11 accepted this revision. jansvoboda11 added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90957/new/ https://reviews.llvm.org/D90957 ___ cfe-commits mailing list cfe

[PATCH] D87981: [X86] AMX programming model prototype.

LuoYuanke updated this revision to Diff 303833. LuoYuanke added a comment. Reformt the code with lint fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87981/new/ https://reviews.llvm.org/D87981 Files: clang/include/clang/Basic/BuiltinsX86_64.d

[PATCH] D90983: Change algorithms to return iterators

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90983/new/ https://reviews.llvm.org/D90983 __

[PATCH] D90765: [ARM][AArch64] Adding Neoverse V1 CPU support

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc2c2cc136013: [ARM][AArch64] Adding Neoverse V1 CPU support (authored by pratlucas). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[clang] c2c2cc1 - [ARM][AArch64] Adding Neoverse V1 CPU support

Author: Lucas Prates Date: 2020-11-09T13:15:40Z New Revision: c2c2cc13601374f987cb03dfc8ef841c64b14024 URL: https://github.com/llvm/llvm-project/commit/c2c2cc13601374f987cb03dfc8ef841c64b14024 DIFF: https://github.com/llvm/llvm-project/commit/c2c2cc13601374f987cb03dfc8ef841c64b14024.diff LOG:

[clang-tools-extra] f0922ef - [clang-tidy] Remove bad assert after 3b9b90a1

Author: Nathan James Date: 2020-11-09T13:21:55Z New Revision: f0922efddef49b7f9057f5c3d5b6b8968111aadf URL: https://github.com/llvm/llvm-project/commit/f0922efddef49b7f9057f5c3d5b6b8968111aadf DIFF: https://github.com/llvm/llvm-project/commit/f0922efddef49b7f9057f5c3d5b6b8968111aadf.diff LOG:

[PATCH] D91067: [AArch64][SVE] Support implicit lax vector conversions for SVE types

joechrisellis updated this revision to Diff 303838. joechrisellis marked an inline comment as done. joechrisellis added a comment. Address @peterwaller-arm's comment regarding unused types. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91067/new/ h

[PATCH] D91067: [AArch64][SVE] Support implicit lax vector conversions for SVE types

joechrisellis added inline comments. Comment at: clang/test/Sema/aarch64-sve-lax-vector-conversions.cpp:15 +typedef svint32_t fixed_int32_t FIXED_ATTR; +typedef svint64_t fixed_int64_t FIXED_ATTR; + peterwaller-arm wrote: > I can't see any uses of fixed_float64_t

[PATCH] D90524: [Driver] Enable getOSLibDir() lib32 workaround for SPARC on Linux

ro added a comment. As it happens, I'd arrived at exactly the same patch when I tried a build on a Debian/sparc64 system in the GCC compile farm (gcc202), submitted as D85582 . A couple of questions/caveats: - I wouldn't call this patch a workaround, as you do

[PATCH] D91000: [clang-tidy] CERT MSC24-C Obsolescent Functions check

steakhal added a comment. Quoting the revision summary: > This checker guards against using some vulnerable C functions which are > mentioned in MSC24-C in obsolescent functions table. Why don't we check the rest of the functions as well? `asctime`, `atof`, `atoi`, `atol`, `atoll`, `ctime`, `fo

[PATCH] D90549: [Driver] Switch CHECK-DEBIAN-SPARC tests to use debian_multiarch_tree

ro added a comment. As I'd mentioned in D90524 , I believe both patches should be merged into one. Otherwise, no matter in which order you commit them, the buildbots might show failures otherwise. Another point I'm not certain about is wether the checks for the

[PATCH] D90524: [Driver] Enable getOSLibDir() lib32 workaround for SPARC on Linux

glaubitz added a comment. Hi Rainer! Thanks for your review. In D90524#2382555 , @ro wrote: > As it happens, I'd arrived at exactly the same patch when I tried a build on > a Debian/sparc64 system in the GCC compile farm (gcc202), submitted as D85582 >

[PATCH] D90984: Update matchers to be traverse-aware

aaron.ballman added a comment. I think this change should come with a warning in the release notes because it silently changes the behavior of existing matchers in a way that may be surprising to users. I think the behavior is correct in that these constructs are all implicit nodes that aren't

[PATCH] D90524: [Driver] Enable getOSLibDir() lib32 workaround for SPARC on Linux

glaubitz updated this revision to Diff 303846. glaubitz edited the summary of this revision. glaubitz added a comment. Herald added subscribers: steven.zhang, jrtc27. Update as requested in previous review, also merge with D90549 . Repository: rG LLVM Github M

[PATCH] D90549: [Driver] Switch CHECK-DEBIAN-SPARC tests to use debian_multiarch_tree

glaubitz added a comment. Merged into D90524 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90549/new/ https://reviews.llvm.org/D90549 ___ cfe-commits mailing list cfe-c

[PATCH] D91035: [NFC, Refactor] Convert FunctionDefinitionKind from DeclSpech.h to a scoped enum

aaron.ballman added inline comments. Comment at: clang/include/clang/Sema/DeclSpec.h:1837 /// Actually a FunctionDefinitionKind. - unsigned FunctionDefinition : 2; + FunctionDefinitionKind FunctionDefinition : 2; I think we need to keep this as `unsigned`

[PATCH] D91011: [NFC, Refactor] Rename the (scoped) enum DeclaratorContext's enumerators to avoid redundancy

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91011/new/ https://reviews.llvm.org/D91011 __

[clang-tools-extra] 9ca6fc4 - Add a new altera kernel name restriction check to clang-tidy.

Author: Frank Derry Wanye Date: 2020-11-09T09:26:50-05:00 New Revision: 9ca6fc4e095f9aacd70e406e640472ad2d370553 URL: https://github.com/llvm/llvm-project/commit/9ca6fc4e095f9aacd70e406e640472ad2d370553 DIFF: https://github.com/llvm/llvm-project/commit/9ca6fc4e095f9aacd70e406e640472ad2d370553.d

[PATCH] D72218: [clang-tidy] new altera kernel name restriction check

aaron.ballman added a comment. In D72218#2381149 , @ffrankies wrote: > Moved test files `KERNEL.cl`, `VHDL.cl` and `vERILOG.cl` to the `uppercase` > subdirectory to prevent filename clashes in some environments. > > This is in response to the buildbot fai

[PATCH] D91075: [clang] Fix ForStmt mustprogress handling

atmnpatel created this revision. atmnpatel added reviewers: jdoerfert, aqjune, aaron.ballman. Herald added a project: clang. Herald added a subscriber: cfe-commits. atmnpatel requested review of this revision. D86841 had an error where for statements with no cond

[clang] 7b7170f - [clang-format] avoid introducing multiline comments

Author: Krasimir Georgiev Date: 2020-11-09T15:29:09+01:00 New Revision: 7b7170fa5791a8fcf28418e6daa1ab7dd2126a25 URL: https://github.com/llvm/llvm-project/commit/7b7170fa5791a8fcf28418e6daa1ab7dd2126a25 DIFF: https://github.com/llvm/llvm-project/commit/7b7170fa5791a8fcf28418e6daa1ab7dd2126a25.d

[PATCH] D90949: [clang-format] avoid introducing multiline comments

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7b7170fa5791: [clang-format] avoid introducing multiline comments (authored by krasimir). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D91055: [clang-tidy] Introduce misc No Integer To Pointer Cast check

tschuett added a comment. I did not consider false positives, but it provides better visibility. It is always on. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91055/new/ https://reviews.llvm.org/D91055 ___

[PATCH] D90121: clang-format: Add a consumer to diagnostics engine

thakis added a comment. Thanks for the test! I think moving TextDiagnosticsPrinter to Basic is much better than making Format depend on Frontend. If you just want to fix your crash and be done with it, then doing that (and adding your test) is fine. I think the best fix would be to change Basi

[PATCH] D90799: [PowerPC] Add paired vector load and store builtins and intrinsics

lei added inline comments. Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:2658 + return false; +} + There's alot of nested `if`s, would it be possible to refactor to have some early exits instead? Comment at: llvm/test/CodeGen/Power

[PATCH] D91078: [clang-format] do not break before @tags in JS comments

krasimir created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. krasimir requested review of this revision. In JavaScript breaking before a `@tag` in a comment puts it on a new line, and machinery that parses these comments will fail to understand such commen

[PATCH] D91075: [clang] Fix ForStmt mustprogress handling

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91075/new/ https://reviews.llvm.org/D91075 ___

[PATCH] D91015: [clang-tidy] Extend bugprone-string-constructor-check to std::string_view.

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/StringConstructorCheck.cpp:64 void StringConstructorCheck::registerMatchers(MatchFinder *Finder) { + const auto hasStringCtorName = + hasAnyNameStdString(removeNamespaces(StringNames));

[PATCH] D91078: [clang-format] do not break before @tags in JS comments

krasimir added inline comments. Comment at: clang/unittests/Format/FormatTestJS.cpp:194 -format("/** @returns {string} jsdoc line 12 */", - getGoogleJSStyleWithColumns(20))); EXPECT_EQ("/**\n" this actually demonstrates a bug fixe

[PATCH] D90670: Simplifying memory globalization from the front end to move optimizations to the middle end.

jdoerfert added a comment. Let's start by adding an updated test to this so we can see how the result looks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90670/new/ https://reviews.llvm.org/D90670 ___

[PATCH] D89959: UBSAN: emit distinctive traps in trapping mode

t.p.northover added inline comments. Comment at: llvm/include/llvm/IR/Intrinsics.td:1242 +def int_ubsantrap : Intrinsic<[], [llvm_i8_ty], + [IntrNoReturn, IntrCold, ImmArg>]>; jdoerfert wrote: > should this be readonly and inaccesib

[PATCH] D91051: [clangd] Improve clangd-indexer performance

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. Looks like everyone thinks that this sounds reasonable. So LGTM. Thanks for the patch! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91051/n

[clang] d093401 - [NFC] Remove string parameter of annotation attribute from AST childs.

Author: Tyker Date: 2020-11-09T16:39:59+01:00 New Revision: d093401a2617d3c46aaed9eeaecf877e3ae1a9f1 URL: https://github.com/llvm/llvm-project/commit/d093401a2617d3c46aaed9eeaecf877e3ae1a9f1 DIFF: https://github.com/llvm/llvm-project/commit/d093401a2617d3c46aaed9eeaecf877e3ae1a9f1.diff LOG: [N

[PATCH] D82756: Port some floating point options to new option marshalling infrastructure

jansvoboda11 added a comment. @dexonsmith, could you please commit this one for me? I don't have the rights to do so, as this is my first patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82756/new/ https://reviews.llvm.org/D82756 ___ cfe

[PATCH] D90221: Include more attribute details when dumping AST in JSON

aaron.ballman added a subscriber: Tyker. aaron.ballman added a comment. In D90221#2381325 , @aronsky wrote: > In D90221#2379793 , @aaron.ballman > wrote: > >> I think the issue is that ASTNodeTraverser is visiting

[PATCH] D90174: [HIP] Fix regressions due to fp contract change

yaxunl added a comment. How about fast-constrained, fast-limited, fast-restricted, or fast-restrained? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90174/new/ https://reviews.llvm.org/D90174 ___ cfe-commits mailing list cfe-commits@lists.llv

[PATCH] D91078: [clang-format] do not break before @tags in JS comments

mprobst added a comment. See my comment on the upstream bug, let's chat a bit about whether we need this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91078/new/ https://reviews.llvm.org/D91078 ___ cfe-

[PATCH] D91075: [clang] Fix ForStmt mustprogress handling

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfd3cad7a6016: [clang] Fix ForStmt mustprogress handling (authored by atmnpatel). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] fd3cad7 - [clang] Fix ForStmt mustprogress handling

Author: Atmn Patel Date: 2020-11-09T11:38:06-05:00 New Revision: fd3cad7a60168b49f7bc160354655d7605847d41 URL: https://github.com/llvm/llvm-project/commit/fd3cad7a60168b49f7bc160354655d7605847d41 DIFF: https://github.com/llvm/llvm-project/commit/fd3cad7a60168b49f7bc160354655d7605847d41.diff LO

[PATCH] D91011: [NFC, Refactor] Rename the (scoped) enum DeclaratorContext's enumerators to avoid redundancy

wchilders accepted this revision. wchilders added a comment. +1 Nice QOL change :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91011/new/ https://reviews.llvm.org/D91011 ___ cfe-commits mailing list cf

[PATCH] D82756: Port some floating point options to new option marshalling infrastructure

dexonsmith added a comment. In D82756#2382885 , @jansvoboda11 wrote: > @dexonsmith, could you please commit this one for me? I don't have the rights > to do so, as this is my first patch. Sure; what do you want for `GIT_AUTHOR_NAME` and `GIT_AUTHOR_EMAI

[PATCH] D91035: [NFC, Refactor] Convert FunctionDefinitionKind from DeclSpech.h to a scoped enum

wchilders added a comment. Generally agree with this direction; Are there plans for migrating https://github.com/llvm/llvm-project/blob/master/clang/include/clang/Basic/Specifiers.h in a similar fashion, for consistency? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[clang] e625f9c - -fbasic-block-sections=list=: Suppress output if failed to open the file

Author: Fangrui Song Date: 2020-11-09T09:26:37-08:00 New Revision: e625f9c5d1e2e69d18febae0e8d3f808df35c4c8 URL: https://github.com/llvm/llvm-project/commit/e625f9c5d1e2e69d18febae0e8d3f808df35c4c8 DIFF: https://github.com/llvm/llvm-project/commit/e625f9c5d1e2e69d18febae0e8d3f808df35c4c8.diff

[PATCH] D90815: -fbasic-block-sections=list=: Suppress output if failed to open the file

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe625f9c5d1e2: -fbasic-block-sections=list=: Suppress output if failed to open the file (authored by MaskRay). Repository: rG LLVM Github Monorepo

[PATCH] D91088: [CUDA][HIP] Fix capturing reference to host variable

yaxunl created this revision. yaxunl added reviewers: tra, rjmccall. yaxunl requested review of this revision. In C++ when a reference variable is captured by copy, the lambda is supposed to make a copy of the referenced variable in the captures and refer to the copy in the lambda. Therefore, it i

[PATCH] D90748: [clangd] Introduce config parsing for External blocks

kadircet added a comment. (sorry looks like i forgot to hit submit :( ) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90748/new/ https://reviews.llvm.org/D90748 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D90748: [clangd] Introduce config parsing for External blocks

kadircet added a comment. > (Meta-point: not sure how useful splitting this patch out from the compile > step is...) I wanted to keep them separate especially to ensure testing isn't mixed up. As these things tend to get big easily :/ Comment at: clang-tools-extra/clangd/Con

[PATCH] D91088: [CUDA][HIP] Fix capturing reference to host variable

yaxunl updated this revision to Diff 303905. yaxunl added a comment. remove debug code CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91088/new/ https://reviews.llvm.org/D91088 Files: clang/lib/CodeGen/CGExpr.cpp clang/lib/Sema/SemaExpr.cpp clang/test/CodeGenCUDA/lambda-reference-

[PATCH] D91047: Add a call super attribute plugin example

aaron.ballman added inline comments. Comment at: clang/docs/ClangPlugins.rst:117 +Defining CallSuperAttr +=== + The number of underlines here looks off -- can you verify it's correct? Comment at: clang/docs/ClangPlugins.rst:119

[PATCH] D90956: [clang][SVE] Additional macros implied by `-msve-vector-bits=`.

fpetrogalli updated this revision to Diff 303908. fpetrogalli marked an inline comment as done. fpetrogalli added a comment. I removed the enablement of __ARM_FEATURE_SVE_PREDICATE_OPERATORS as the codegen is incorrect. I have extended testing of the codegen for __ARM_FEATURE_SVE_VECTOR_OPERATOR

[PATCH] D90956: [clang][SVE] Activate macro `__ARM_FEATURE_SVE_VECTOR_OPERATORS`.

fpetrogalli updated this revision to Diff 303911. fpetrogalli edited the summary of this revision. fpetrogalli added a comment. In the last update I removed the tests for `__ARM_FEATURE_SVE_PREDICATE_OPERATORS`but forgot to remove the code that generates and tests the macro. Repository: rG L

[PATCH] D82756: Port some floating point options to new option marshalling infrastructure

jansvoboda11 added a comment. Thanks, `Jan Svoboda` and `jan_svob...@apple.com` is fine. Is it possible to add @dang as a co-author? `git log` says he uses `Daniel Grumberg` and `dany.grumb...@gmail.com`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82756/new/ https://reviews.llvm.or

[PATCH] D91088: [CUDA][HIP] Fix capturing reference to host variable

tra added a subscriber: rsmith. tra added a comment. The use case in the tests makes sense, but I'd like to have a second opinion on whether it may have unintended consequences. Lambdas tend to bring interesting corner cases. @rsmith Richard, do you see any issues with this approach? ===

  1   2   >