kadircet accepted this revision.
kadircet added inline comments.
This revision is now accepted and ready to land.


================
Comment at: clang-tools-extra/clangd/index/remote/server/Server.cpp:365
   }
+  auto Index = std::make_unique<clang::clangd::SwapIndex>(std::move(SymIndex));
 
----------------
well actually we don't need to make unique at all. why not just create a 
`SwapIndex Idx(std::move(SymIndex))` and pass it around ?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91049/new/

https://reviews.llvm.org/D91049

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to