mantognini added inline comments.
================ Comment at: clang/include/clang-c/Index.h:2057 + */ + CXCursor_CXXAddrspaceCastExpr = 129, + ---------------- hans wrote: > Anastasia wrote: > > hans wrote: > > > akyrtzi wrote: > > > > Hi Anastasia, apologies for not catching this earlier, but libclang is > > > > intended to keep a stable ABI and changing the enumerator values breaks > > > > libclang's ABI compatibility. > > > > > > > > Would you be able to make a follow-up commit and restore the enumerator > > > > values to their original values? I would suggest to add > > > > `CXCursor_CXXAddrspaceCastExpr` at the end and assign to it the next > > > > available value that is not already taken. > > > It also broke the Python bindings, as someone reported here: > > > https://stackoverflow.com/questions/64542827/there-appears-to-be-mismatch-in-clang-llvm-ver-11-0-0-python-bindings > > I guess it's too late to fix 11.0.0, does it make sense to fix 11.0.1? > That's @tstellar 's call. @tstellar, does this require any particular action from my side to be included in 11.0.1? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60193/new/ https://reviews.llvm.org/D60193 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
