[PATCH] D87187: [Driver] Perform Linux distribution detection just once

dmantipov updated this revision to Diff 292710. dmantipov added a comment. Updated (style adjustments). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87187/new/ https://reviews.llvm.org/D87187 Files: clang/include/clang/Driver/Distro.h clang/l

[clang] 8a86261 - [FPEnv] Use typed accessors in FPOptions

Author: Serge Pavlov Date: 2020-09-18T14:16:43+07:00 New Revision: 8a86261c511e09629aa48c13cb84172b9be26c0c URL: https://github.com/llvm/llvm-project/commit/8a86261c511e09629aa48c13cb84172b9be26c0c DIFF: https://github.com/llvm/llvm-project/commit/8a86261c511e09629aa48c13cb84172b9be26c0c.diff

[PATCH] D87812: [FPEnv] Use typed accessors in FPOptions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8a86261c511e: [FPEnv] Use typed accessors in FPOptions (authored by sepavloff). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[clang] 13e19d2 - Revert "[InstCombine] Canonicalize SPF_ABS to abs intrinc"

Author: Nikita Popov Date: 2020-09-18T09:38:26+02:00 New Revision: 13e19d2e7cdc2a54bb85da702df47c8a04a6d857 URL: https://github.com/llvm/llvm-project/commit/13e19d2e7cdc2a54bb85da702df47c8a04a6d857 DIFF: https://github.com/llvm/llvm-project/commit/13e19d2e7cdc2a54bb85da702df47c8a04a6d857.diff

[PATCH] D83814: [clangd] Add Random Forest runtime for code completion.

usaxena95 marked an inline comment as done. usaxena95 added inline comments. Comment at: clang-tools-extra/clangd/quality/CompletionModel.cmake:13 + + set(output_dir ${CMAKE_BINARY_DIR}/generated/decision_forest) + set(header_file ${output_dir}/${filename}.h)

[PATCH] D83814: [clangd] Add Random Forest runtime for code completion.

usaxena95 updated this revision to Diff 292717. usaxena95 marked 12 inline comments as done. usaxena95 added a comment. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83814/new/ https://reviews.llvm.org/D83814 Files: clang-too

[PATCH] D87775: [clangd] Add option for disabling AddUsing tweak on some namespaces.

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Thanks! Can we add a simple test to TweakTests (I should really split up that file) and to ConfigCompileTests? (BTW, do you think we should merge Config{Compile,YAML}Tests? =

[PATCH] D83814: [clangd] Add Random Forest runtime for code completion.

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. LG from my side! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83814/new/ https://reviews.llvm.org/D83814 ___

[PATCH] D78658: [clang][Frontend] Add missing error handling

andrewrk accepted this revision. andrewrk added a comment. This revision is now accepted and ready to land. ping? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78658/new/ https://reviews.llvm.org/D78658 ___ cfe-commits mailing list cfe-commit

[PATCH] D87350: [AST][RecoveryExpr] Fix a crash on undeduced type.

sammccall added inline comments. Comment at: clang/lib/Sema/SemaOverload.cpp:12880 return Result.getValueOr(QualType()); } Wouldn't we be better to handle undeduced type here rather than in the loop? Not sure if it practically matters, but given: `auto f()

[PATCH] D87888: [X86] Use inlineasm flag output for the _bittest* intrinsics.

craig.topper created this revision. craig.topper added reviewers: rnk, niravd. Herald added a project: clang. craig.topper requested review of this revision. Instead of expliciting emitting a setc in the inline asm instructions, we can use flag output. This allows the backend to use the flag direc

[PATCH] D86077: [clangd] Add a way for exporting memory usage metrics

sammccall added a comment. Just for the record, as I think Kadir and Adam are both aware... We discussed making this a bit richer and less reliant on static state. We'd build a tree-shaped profile by passing a tree-builder recursively into various components. Then the metrics would be exported a

[PATCH] D80109: [AST][RecoveryExpr] Preserve type for broken member call expr.

sammccall added a comment. @hokein Did this get landed at some point? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80109/new/ https://reviews.llvm.org/D80109 ___ cfe-commits mailing list cfe-commits@lis

[PATCH] D71586: [clangd] Add a test case that verifies -fimplicit-modules work in Clangd when building the AST

sammccall added a comment. We do now have tests in unittests/ModulesTests.cpp that likely covers at least part of this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71586/new/ https://reviews.llvm.org/D71586 _

[PATCH] D87831: [clang] Expose helper function to turn PP keywords spelling into PPKeywordKind

kbobyrev added inline comments. Comment at: clang/include/clang/Basic/TokenKinds.h:99 +PPKeywordKind getPPKeywordFromSpelling(const std::string &Name); + riccibruno wrote: > A string is expensive here and unneeded. Why not a `StringRef`? Yeah, this piece is unf

[PATCH] D77527: [AST] Adjust existing tests for recovery-exprs

sammccall resigned from this revision. sammccall added a comment. Herald added a subscriber: sstefan1. (This is obsolete now I believe, the flag has been flipped) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77527/new/ https://reviews.llvm.org/D77

[PATCH] D87891: [clangd] findNearbyIdentifier(): guaranteed to give up after 2^N lines

ArcsinX created this revision. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous. Herald added a project: clang. ArcsinX requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. As @kadircet mentions in D84912#2184144

[PATCH] D76831: [AST] Preserve the DeclRefExpr when it refers to an invalid decl.

sammccall added a comment. @hokein I think this patch is obsolete, right? Richard's last comment is basically what's currently implemented: if lookup doesn't yield any valid results, we create a recoveryexpr for the failed lookup. It doesn't have a pointer to the invalid decl (which would be ne

[PATCH] D82284: [AST][RecoveryAST] Preseve invalid return stmt, and suppress the diagnostics for missing return stmt in constexpr func.

sammccall added a comment. Any interest in chasing these diagnostic regressions (they seem like they might be tractable) or should we abandon this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82284/new/ https://reviews.llvm.org/D82284 _

[PATCH] D83296: [clang-format] Add a MacroExpander.

sammccall added a comment. Just checking this is waiting on you rather than me... If the multiple-expansion thing is blocking progress, I think we're much better off getting a limited version of this feature landed than losing momentum trying to solve it. Repository: rG LLVM Github Monorepo

[PATCH] D87629: Thread safety analysis: Improve documentation for ASSERT_CAPABILITY

vasild accepted this revision. vasild added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87629/new/ https://reviews.llvm.org/D87629 ___ c

[PATCH] D86765: [clang] Don't emit "no member" diagnostic if the lookup fails on an invalid record decl.

sammccall accepted this revision. sammccall added a comment. This seems like fixing a fairly specific case of a general problem: if the base class is invalid I would expect to see similar problems in other places (e.g. unqualified lookup from inside the class). But it fixes a diagnostic the libc

[PATCH] D87888: [X86] Use inlineasm flag output for the _bittest* intrinsics.

RKSimon added a comment. Do we have sufficient backend test coverage for this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87888/new/ https://reviews.llvm.org/D87888 ___ cfe-commits mailing list cfe-co

[PATCH] D87030: Adapt CastExpr::getSubExprAsWritten to ConstantExpr

sberg updated this revision to Diff 292728. sberg added a comment. ping (addressed the clang-tidy nitpick) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87030/new/ https://reviews.llvm.org/D87030 Files: clang/lib/AST/Expr.cpp clang/unittests/Tooling/CastExprTest.cpp Index: clang

[libunwind] 5831adb - Revert "[libunwind] Support for leaf function unwinding."

Author: Daniel Kiss Date: 2020-09-18T11:37:54+02:00 New Revision: 5831adb8c38f3fd1b17ff52984c514fc32e893f6 URL: https://github.com/llvm/llvm-project/commit/5831adb8c38f3fd1b17ff52984c514fc32e893f6 DIFF: https://github.com/llvm/llvm-project/commit/5831adb8c38f3fd1b17ff52984c514fc32e893f6.diff L

[PATCH] D87895: [SyntaxTree] Test for '\' inside token.

eduucaldas created this revision. eduucaldas added a reviewer: gribozavr2. Herald added a project: clang. Herald added a subscriber: cfe-commits. eduucaldas requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D87895 Files: clang/unittests/Tooling/S

[PATCH] D87896: [SyntaxTree][Synthesis] Improve testing `createLeaf`

eduucaldas created this revision. eduucaldas added a reviewer: gribozavr2. Herald added a project: clang. Herald added a subscriber: cfe-commits. eduucaldas requested review of this revision. The new test shows that `createLeaf` depends on the C++ version. Repository: rG LLVM Github Monorepo

[clang] 9d172c8 - Recommit "[DSE] Switch to MemorySSA-backed DSE by default."

Author: Florian Hahn Date: 2020-09-18T11:05:00+01:00 New Revision: 9d172c8e9c845a36b61dc12c27de8acdbef8b247 URL: https://github.com/llvm/llvm-project/commit/9d172c8e9c845a36b61dc12c27de8acdbef8b247 DIFF: https://github.com/llvm/llvm-project/commit/9d172c8e9c845a36b61dc12c27de8acdbef8b247.diff

[PATCH] D87891: [clangd] findNearbyIdentifier(): guaranteed to give up after 2^N lines

ArcsinX updated this revision to Diff 292739. ArcsinX added a comment. Fix format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87891/new/ https://reviews.llvm.org/D87891 Files: clang-tools-extra/clangd/XRefs.cpp Index: clang-tools-extra/clang

[PATCH] D87163: [DSE] Switch to MemorySSA-backed DSE by default.

fhahn added a comment. All reported problems should be fixed now and we also made the fix for the issue @dmajor reported more conservative to catch more problematic cases. I just enabled DSE + MemorySSA again in 9d172c8e9c84 .

[PATCH] D84226: [AST][RecoveryExpr] Part1: Support dependent binary operator in C for error recovery.

sammccall added inline comments. Comment at: clang/include/clang/Basic/LangOptions.def:153 COMPATIBLE_LANGOPT(RecoveryASTType, 1, 0, "Preserve the type in recovery expressions") +COMPATIBLE_LANGOPT(CDependence, 1, 0, "Build dependent AST nodes in C for better error recovery")

[PATCH] D84304: [AST][RecoveryExpr] Part 2: Build dependent callexpr in C for error-recovery.

sammccall added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:6437 + if (getLangOpts().CDependence && + (Fn->isTypeDependent() || Expr::hasAnyTypeDependentArguments(ArgExprs))) { why is CDependence a condition and not an assertion inside the i

[PATCH] D84226: [AST][RecoveryExpr] Part1: Support dependent binary operator in C for error recovery.

sammccall added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:14255 + if (Opc <= BO_Assign || Opc > BO_OrAssign) +return BinaryOperator::Create(Context, LHS, RHS, Opc, Context.DependentTy, + VK_RValue, OK_Ordinary, OpLoc, -

[PATCH] D84322: [AST][RecoveryExpr] Part3: Suppress spurious "typecheck_cond_expect_scalar" diagnostic

sammccall added inline comments. Comment at: clang/test/Sema/error-dependence.c:18 + // type is required" is not emitted. + ptr > f ? ptr : f; // expected-error {{invalid operands to binary expression}} +} nit: parens would help me understand here :-) I don't

[PATCH] D84387: [AST][RecoveryExpr] Part4: Suppress spurious "err_typecheck_expect_scalar_operand" diagnostic

sammccall added a comment. I'm not sure I love having the assertion for contains-errors every place that handles dependent code in C. We should certainly somehow document the reason dependence is possible, just as the possibility of overloads is documented. But the assertion seems pretty heavywe

[PATCH] D87080: [AST] Reduce the size of TemplateArgumentLocInfo.

sammccall added a comment. Looks good apart from a minor technical issue with the traits. Would it be possible to compile some big file in LLVM (probably doesn't matter much which, Sema something?) and observe if there's a significant change in overall ASTContext size? Comme

[PATCH] D87895: [SyntaxTree] Test for '\' inside token.

gribozavr2 accepted this revision. gribozavr2 added inline comments. This revision is now accepted and ready to land. Comment at: clang/unittests/Tooling/Syntax/BuildTreeTest.cpp:173 + R"cpp( +in/ +t a; That looks like the wrong slash to me (forward instead

[PATCH] D77792: [analyzer] Extend constraint manager to be able to compare simple SymSymExprs

baloghadamsoftware commandeered this revision. baloghadamsoftware edited reviewers, added: steakhal; removed: baloghadamsoftware. baloghadamsoftware added a comment. Herald added a subscriber: gamesh411. We found use cases which can be solved using this improvement. That is why I commandeer this

[PATCH] D77792: [analyzer] Extend constraint manager to be able to compare simple SymSymExprs

baloghadamsoftware updated this revision to Diff 292755. baloghadamsoftware added a comment. Crash fixed and new tests added. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77792/new/ https://reviews.llvm.org/D77792 Files: clang/include/clang/StaticAnalyzer/Core/PathSensitive/RangedC

[PATCH] D87163: [DSE] Switch to MemorySSA-backed DSE by default.

dmajor added a comment. Thanks for the heads up. I'll schedule a more intensive test run over the weekend while there's less demand for machines. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87163/new/ https://reviews.llvm.org/D87163 ___

[PATCH] D77792: [analyzer] Extend constraint manager to be able to compare simple SymSymExprs

baloghadamsoftware added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:814 +Optional RangeConstraintManager::tryAssumeSymSymOp( +ProgramStateRef State, BinaryOperator::Opcode Op, SymbolRef LHSSym, NoQ wrote: > I belie

[PATCH] D83004: [UpdateCCTestChecks] Include generated functions if asked

greened added a comment. In D83004#2278681 , @arichardson wrote: > Maybe add another test that checks for the @__cxx_global_var_init() > constructor function? > E.g. something like this: > > int init_func(int arg) { > return arg + 1; > } > >

[PATCH] D83004: [UpdateCCTestChecks] Include generated functions if asked

greened added inline comments. Comment at: llvm/utils/update_cc_test_checks.py:274-277 prefixes = p[0] for prefix in prefixes: func_dict.update({prefix: dict()}) +func_order.update({prefix: []}) arichardson wrote: > This should avoi

[PATCH] D83004: [UpdateCCTestChecks] Include generated functions if asked

arichardson added a comment. I think this approach seems fine, just a few very minor comments inlines. In D83004#2280363 , @greened wrote: > In D83004#2278681 , @arichardson > wrote: > >> Maybe add another test th

[PATCH] D82317: [Clang/Test]: Update tests where `noundef` attribute is necessary

eugenis added a comment. We really need to do something about this. How about a change that adds -fdisable-noundef-analysis to every RUN line with %clang? (-) We are not testing exactly the same mode that is used by the users - but that's already true for many other flags that clang driver passe

[libunwind] 22b615a - [libunwind] Support for leaf function unwinding.

Author: Daniel Kiss Date: 2020-09-18T15:09:42+02:00 New Revision: 22b615a96593f13109a27cabfd1764ec4f558c7a URL: https://github.com/llvm/llvm-project/commit/22b615a96593f13109a27cabfd1764ec4f558c7a DIFF: https://github.com/llvm/llvm-project/commit/22b615a96593f13109a27cabfd1764ec4f558c7a.diff L

[PATCH] D87901: [Driver] Filter out /gcc and /gcc-cross if they do not exists

dmantipov created this revision. dmantipov added reviewers: manojgupta, sthibaul, dlj. Herald added subscribers: cfe-commits, fedor.sergeev. Herald added a project: clang. dmantipov requested review of this revision. For the regular (system-wide) installation it's OK to assume that Clang is insta

[PATCH] D54222: [clang-tidy] Add a check to detect returning static locals in public headers

jranieri-grammatech added a comment. @JonasToth It looks like there are some outstanding review comments that need to be addressed. I've gotten some time allocated to work on this next week. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54222/new/

[PATCH] D84968: [PowerPC] Legalize v256i1 and v512i1 and implement load and store of these types

lei accepted this revision. lei added a comment. This revision is now accepted and ready to land. Just some minor comments. Please address them prior to commit. Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:10519 + // 2 or 4 vsx registers. + if (VT == MVT::v256i1 ||

[PATCH] D77792: [analyzer] Extend constraint manager to be able to compare simple SymSymExprs

baloghadamsoftware added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/RangedConstraintManager.h:103-110 + enum class CompareResult { +unknown, +identical, +less, +less_equal, +greater, +greater_equal

[PATCH] D87804: [PowerPC][Power10] Implement Vector signed/unsigned __int128 overloads for the comparison builtins

lei added a comment. please fix the clang format issues. Comment at: llvm/include/llvm/IR/IntrinsicsPowerPC.td:365 + def int_ppc_altivec_vcmpequq : GCCBuiltin<"__builtin_altivec_vcmpequq">, + Intrinsic<[llvm_v1i128_ty], [llvm_v1i128_ty, llvm_v1i128_ty], +

[PATCH] D83004: [UpdateCCTestChecks] Include generated functions if asked

thakis added inline comments. Comment at: llvm/utils/UpdateTestChecks/common.py:645 + added = set() + for prefixes, tool_args, *rest in prefix_list: +for prefix in prefixes: LLVM still supports Python 2.7. This breaks devs and bots still using 2.7. Please

[PATCH] D86137: Add ignore-unknown-options flag to clang-format.

fodinabor updated this revision to Diff 292781. fodinabor marked an inline comment as done. fodinabor added a comment. Fix the nit :) Anyone with access may commit this now (ideally ofc someone with a final opinion on the clang-format part). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D87904: [AIX][Clang][Driver] Add handling of nostartfiles option

daltenty created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. daltenty requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D87904 Files: clang/lib/Driver/ToolChains/AIX.cpp clang/test/Driver/aix-ld.c Ind

[PATCH] D87349: [clang] adapt c++17 behavior for dependent decltype-specifiers

hokein updated this revision to Diff 292784. hokein marked 2 inline comments as done. hokein added a comment. address comments: - don't break existing mangling tests - deduplicate instantiation-dependent-but-not-type-dependent DecltypeType node (for name mangling substitution) - fix the dependen

[PATCH] D87349: [clang] adapt c++17 behavior for dependent decltype-specifiers

hokein added inline comments. Comment at: clang/lib/AST/Type.cpp:3429 toTypeDependence(E->getDependence()) | - (E->isInstantiationDependent() ? TypeDependence::Dependent - : TypeDependence::None) | +

[PATCH] D86137: Add -Wno-error=unknown flag to clang-format.

MyDeveloperDay added a comment. IMHO I feel that given that these changes are more wide reaching than just clang-format that it might be more correct for your to request commit access yourself. You need to own these changes, because if the llvm/Support changes fail the build or unit tests the

[PATCH] D87775: [clangd] Add option for disabling AddUsing tweak on some namespaces.

adamcz updated this revision to Diff 292786. adamcz marked 2 inline comments as done. adamcz added a comment. addressed review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87775/new/ https://reviews.llvm.org/D87775 Files: clang-tools-e

[PATCH] D87775: [clangd] Add option for disabling AddUsing tweak on some namespaces.

adamcz added inline comments. Comment at: clang-tools-extra/clangd/Config.h:70 +// declarations, always spell out the whole name (with or without leading +// ::). All nested namespaces are affected as well. +std::vector FullyQualifiedNamespaces; sammc

[PATCH] D86137: Add -Wno-error=unknown flag to clang-format.

fodinabor added a comment. Okay, I requested commit access. So the patch is fine with you from a clang-format perspective? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86137/new/ https://reviews.llvm.org/D86137 ___

[PATCH] D85611: Improve dynamic AST matching diagnostics for conversion errors

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Sorry about the delay, good guess as to what was happening :-) Comment at: clang/lib/ASTMatchers/Dynamic/Marshallers.h:88 + static bool hasCorrectValue(const VariantVa

[PATCH] D87775: [clangd] Add option for disabling AddUsing tweak on some namespaces.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc894bfd1f580: [clangd] Add option for disabling AddUsing tweak on some namespaces. (authored by adamcz). Changed prior to commit: https://reviews.

[clang-tools-extra] c894bfd - [clangd] Add option for disabling AddUsing tweak on some namespaces.

Author: Adam Czachorowski Date: 2020-09-18T16:46:09+02:00 New Revision: c894bfd1f580e5807fc98cc353b0834e0c5ddc21 URL: https://github.com/llvm/llvm-project/commit/c894bfd1f580e5807fc98cc353b0834e0c5ddc21 DIFF: https://github.com/llvm/llvm-project/commit/c894bfd1f580e5807fc98cc353b0834e0c5ddc21.d

[PATCH] D87669: [clangd] Rainbow Semantic Highlighting

sammccall added a comment. This is cool! We've had a couple of looks at attributes, but haven't really gotten around to polishing it. (For a submittable version, I think we should avoid introducing more modifiers at the same time, just to avoid getting bogged down in exactly which ones) I like

[PATCH] D86790: [FE] Use preferred alignment instead of ABI alignment for complete object when applicable

jasonliu added inline comments. Comment at: clang/include/clang/AST/ASTContext.h:259 mutable TypeInfoMap MemoizedTypeInfo; + /// /// A cache from types to size and preferred alignment information. + mutable TypeInfoMap MemoizedPreferredTypeInfo; nit: Extra /

[PATCH] D87188: [InstCombine] Canonicalize SPF to abs intrinc

sanwou01 added a comment. I know this has already been reverted but just FYI that I've bisected a ~2% regression in SPEC2017 x264_r on AArch64 to this commit. Presumably this is due to the extra unrolling / cost modelling issue already mentioned? Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D87804: [PowerPC][Power10] Implement Vector signed/unsigned __int128 overloads for the comparison builtins

amyk added a comment. Please address clang-format issues and Lei's comments. Other than that, I think the patch LGTM. Comment at: llvm/test/CodeGen/PowerPC/vec_cmpq.ll:14 +; CHECK-LABEL: v1si128_cmp: +; CHECK: vcmpequq 2, 2, 3 +} lei wrote: > please add the ch

[PATCH] D87669: [clangd] Rainbow Semantic Highlighting

alexzielenski added a comment. Hey Sam, Thanks for checking this out! I really like your idea about encoding the variants with binary - as you say it removes the need for any assumption on the server's part for the limit of colors. However, I'd be wary of the fact that most users and theme crea

[PATCH] D87910: [PowerPC] Implement the 128-bit vec_[all|any]_[eq | ne | lt | gt | le | ge] builtins in Clang/LLVM

amyk created this revision. amyk added reviewers: power-llvm-team, PowerPC, nemanjai, saghir, Conanap. amyk added projects: LLVM, clang, PowerPC. Herald added subscribers: shchenz, hiraditya. amyk requested review of this revision. This patch implements the vec_[all|any]_[eq | ne | lt | gt | le |

[PATCH] D87534: Sema: introduce `__attribute__((__swift_name__))`

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, though you may want to get a second set of eyes on the swift name validation bits for a more thorough review of that part. Comment at: clang/include/clan

[PATCH] D83814: [clangd] Add Random Forest runtime for code completion.

usaxena95 updated this revision to Diff 292818. usaxena95 added a comment. Removed generated (for review) files. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83814/new/ https://reviews.llvm.org/D83814 Files: clang-tools-extra/clangd/CMakeLists.

[PATCH] D87188: [InstCombine] Canonicalize SPF to abs intrinc

spatel added a comment. In D87188#2281957 , @sanwou01 wrote: > I know this has already been reverted but just FYI that I've bisected a ~2% > regression in SPEC2017 x264_r on AArch64 to this commit. Presumably this is > due to the extra unrolling / cost m

[PATCH] D87914: [AIX][Clang][Driver] Add handling of shared option

daltenty created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. daltenty requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D87914 Files: clang/lib/Driver/ToolChains/AIX.cpp clang/test/Driver/aix-ld.c Ind

[clang] 51c5add - Extending Baremetal toolchain's support for the rtlib option.

Author: Jon Roelofs Date: 2020-09-18T09:19:37-07:00 New Revision: 51c5add8547a66caa5fbc9a19a91cd7976944229 URL: https://github.com/llvm/llvm-project/commit/51c5add8547a66caa5fbc9a19a91cd7976944229 DIFF: https://github.com/llvm/llvm-project/commit/51c5add8547a66caa5fbc9a19a91cd7976944229.diff L

[PATCH] D87164: Extending Baremetal toolchain's support for the rtlib option.

This revision was automatically updated to reflect the committed changes. Closed by commit rG51c5add8547a: Extending Baremetal toolchain's support for the rtlib option. (authored by jroelofs). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87164/new/

[PATCH] D87858: [hip] Add HIP scope atomic ops.

yaxunl added a comment. In D87858#2280429 , @jfb wrote: > Please provide documentation in this patch. opencl atomic builtins are documented as notes to `__c11_atomic builtins` part of https://clang.llvm.org/docs/LanguageExtensions.html#builtin-functions.

[PATCH] D83814: [clangd] Add Random Forest runtime for code completion.

usaxena95 updated this revision to Diff 292828. usaxena95 added a comment. Fixed output_dir cmake variable. Clean build succeeds now. Ready to land. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83814/new/ https://reviews.llvm.org/D83814 Files:

[PATCH] D77491: [Sema] Introduce BuiltinAttr, per-declaration builtin-ness

dmajor added a comment. This commit broke Firefox builds on Mac with an error in the SDK headers. Could you please revert if a fix is not readily available? Reproducer: struct objc_super {}; extern "C" id objc_msgSendSuper(struct objc_super *super, SEL op, ...); extern "C" void objc_msgSe

[PATCH] D87671: [PowerPC] Implement Vector String Isolate Builtins in Clang/LLVM

amyk updated this revision to Diff 292830. amyk added a comment. Address clang-format concerns. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87671/new/ https://reviews.llvm.org/D87671 Files: clang/include/clang/Basic/BuiltinsPPC.def clang/lib

[PATCH] D87804: [PowerPC][Power10] Implement Vector signed/unsigned __int128 overloads for the comparison builtins

amyk accepted this revision. amyk added a comment. This revision is now accepted and ready to land. Forgot to approve this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87804/new/ https://reviews.llvm.org/D87804

[PATCH] D87896: [SyntaxTree][Synthesis] Improve testing `createLeaf`

eduucaldas updated this revision to Diff 292831. eduucaldas added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87896/new/ https://reviews.llvm.org/D87896 Files: clang/unittests/Tooling/Syntax/SynthesisTest.cpp Index: clang/u

[PATCH] D87895: [SyntaxTree] Test for '\' inside token.

eduucaldas updated this revision to Diff 292832. eduucaldas added a comment. Fix typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87895/new/ https://reviews.llvm.org/D87895 Files: clang/unittests/Tooling/Syntax/BuildTreeTest.cpp Index: clang

[PATCH] D87858: [hip] Add HIP scope atomic ops.

jfb added a comment. In D87858#2282150 , @yaxunl wrote: > In D87858#2280429 , @jfb wrote: > >> Please provide documentation in this patch. > > opencl atomic builtins are documented as notes to `__c11_atomic builtins

[PATCH] D86790: [FE] Use preferred alignment instead of ABI alignment for complete object when applicable

jyknight added inline comments. Comment at: clang/include/clang/AST/ASTContext.h:256 - /// A cache from types to size and alignment information. using TypeInfoMap = llvm::DenseMap; + /// A cache from types to size and ABI-specified alignment information. P

[PATCH] D77491: [Sema] Introduce BuiltinAttr, per-declaration builtin-ness

tambre added a comment. In D77491#2282166 , @dmajor wrote: > This commit broke Firefox builds on Mac with an error in the SDK headers. > Could you please revert if a fix is not readily available? > > Reproducer: > > struct objc_super {}; > extern "C"

[PATCH] D87808: [DebugInfo] Fix bug in constructor homing where it would use ctor homing when a class only has copy/move constructors

rnk added a comment. In D87808#2280197 , @dblaikie wrote: > @rsmith What's the deal with these anonymous structs/unions? Why do they have > copy/move constructors (are those technically called from the enclosing > class's copy/move constructors?) but no

[PATCH] D78075: [WIP][Clang][OpenMP] Added support for nowait target in CodeGen

tianshilei1992 updated this revision to Diff 292835. tianshilei1992 added a comment. Fixed the test case `target_parallel_codegen.cpp` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78075/new/ https://reviews.llvm.org/D78075 Files: clang/lib/Code

[PATCH] D87917: [Sema] Handle objc_super special lookup when checking builtin compatibility

tambre created this revision. tambre added a reviewer: rsmith. Herald added a project: clang. Herald added a subscriber: cfe-commits. tambre requested review of this revision. objc_super is special and needs LookupPredefedObjCSuperType() called before performing builtin type comparisons. This fix

[PATCH] D77491: [Sema] Introduce BuiltinAttr, per-declaration builtin-ness

tambre added a comment. In D77491#2282219 , @tambre wrote: > In D77491#2282166 , @dmajor wrote: > >> This commit broke Firefox builds on Mac with an error in the SDK headers. >> Could you please revert if a fix is

[clang] 2e7add8 - [clang-format] Add a option for the position of Java static import

Author: mydeveloperday Date: 2020-09-18T18:12:21+01:00 New Revision: 2e7add812eb7bdd90bd0f0fc3b633515edd55f27 URL: https://github.com/llvm/llvm-project/commit/2e7add812eb7bdd90bd0f0fc3b633515edd55f27 DIFF: https://github.com/llvm/llvm-project/commit/2e7add812eb7bdd90bd0f0fc3b633515edd55f27.diff

[PATCH] D87201: [clang-format] Add a option for the position of Java static import

This revision was automatically updated to reflect the committed changes. Closed by commit rG2e7add812eb7: [clang-format] Add a option for the position of Java static import (authored by MyDeveloperDay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D87917: [Sema] Handle objc_super special lookup when checking builtin compatibility

tambre added a comment. I'll go ahead and commit this, as it's affecting an user and the fix is simple and obvious. Hopefully post-commit review is acceptable per my understanding of the rules. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87917/n

[clang] a16e4a6 - [clang-format] NFC ensure the clang-format tests remain clang-formatted

Author: mydeveloperday Date: 2020-09-18T18:16:02+01:00 New Revision: a16e4a63ae7c1933291577723324e412e087dc8e URL: https://github.com/llvm/llvm-project/commit/a16e4a63ae7c1933291577723324e412e087dc8e DIFF: https://github.com/llvm/llvm-project/commit/a16e4a63ae7c1933291577723324e412e087dc8e.diff

[clang-tools-extra] 9b6765e - [clangd] Add Random Forest runtime for code completion.

Author: Utkarsh Saxena Date: 2020-09-18T19:25:56+02:00 New Revision: 9b6765e784b39c88cb8cdb85ab083e6c95a997ed URL: https://github.com/llvm/llvm-project/commit/9b6765e784b39c88cb8cdb85ab083e6c95a997ed DIFF: https://github.com/llvm/llvm-project/commit/9b6765e784b39c88cb8cdb85ab083e6c95a997ed.diff

[PATCH] D83814: [clangd] Add Random Forest runtime for code completion.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9b6765e784b3: [clangd] Add Random Forest runtime for code completion. (authored by usaxena95). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D87822: [FPEnv] Evaluate constant expressions under non-default rounding modes

sepavloff updated this revision to Diff 292841. sepavloff added a comment. Updated patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87822/new/ https://reviews.llvm.org/D87822 Files: clang/include/clang/AST/Expr.h clang/lib/AST/Expr.cpp cl

[PATCH] D87917: [Sema] Handle objc_super special lookup when checking builtin compatibility

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rGa1aa330b202f: [Sema] Handle objc_super special lookup when checking builtin compatibility (authored by tambre). Repositor

[clang] a1aa330 - [Sema] Handle objc_super special lookup when checking builtin compatibility

Author: Raul Tambre Date: 2020-09-18T20:51:55+03:00 New Revision: a1aa330b202f97ecd243ea9ef0c7ac00a80ea653 URL: https://github.com/llvm/llvm-project/commit/a1aa330b202f97ecd243ea9ef0c7ac00a80ea653 DIFF: https://github.com/llvm/llvm-project/commit/a1aa330b202f97ecd243ea9ef0c7ac00a80ea653.diff L

[PATCH] D87822: [FPEnv] Evaluate constant expressions under non-default rounding modes

sepavloff marked an inline comment as done. sepavloff added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:2427 +FPOptions FPFeatures = Cast->getFPFeaturesInEffect(Info.Ctx.getLangOpts()); +RM = FPFeatures.getRoundingMode(); + } rjmccall wro

[PATCH] D87917: [Sema] Handle objc_super special lookup when checking builtin compatibility

dmajor added a comment. Thanks, this fixes the specific translation unit I was looking at today. It's going to take some time before I have full build results but I don't expect any problems. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87917/new

  1   2   >