sammccall added a comment.
I'm not sure I love having the assertion for contains-errors every place that
handles dependent code in C.
We should certainly somehow document the reason dependence is possible, just as
the possibility of overloads is documented.
But the assertion seems pretty heavyweight :-\
================
Comment at: clang/lib/Sema/SemaCast.cpp:2695
+ (DestType->isDependentType() || SrcExpr.get()->isTypeDependent() ||
+ SrcExpr.get()->isValueDependent())) {
+ assert((DestType->containsErrors() || SrcExpr.get()->containsErrors() ||
----------------
hokein wrote:
> This is similar to the way how C++ codepath handles dependent code,
> https://github.com/llvm/llvm-project/blob/master/clang/lib/Sema/SemaCast.cpp#L2527-L2532.
>
also copy the comment?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D84387/new/
https://reviews.llvm.org/D84387
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
