[PATCH] D86223: [analyzer][z3] Use more elaborate Z3 variable names

steakhal updated this revision to Diff 287303. steakhal retitled this revision from "[analyzer][z3] Use more elaborate z3 variable names in debug build" to "[analyzer][z3] Use more elaborate Z3 variable names". steakhal edited the summary of this revision. steakhal added a comment. In D86223#223

[PATCH] D85105: [doxygen] Fix bad doxygen results for BugReporterVisitors.h

vsavchenko accepted this revision. vsavchenko added a comment. This revision is now accepted and ready to land. Awesome! I will submit the patch! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85105/new/ https://reviews.llvm.org/D85105 ___ cfe

[PATCH] D86293: [analyzer] Add modeling of Eq operator in smart ptr

vsavchenko added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/SmartPtrModeling.cpp:351 +bool SmartPtrModeling::handleEqOp(const CallEvent &Call, + CheckerContext &C) const { xazax.hun wrote: > I'd prefer to cal

[PATCH] D86027: [analyzer] Add bool operator modeling for unque_ptr

vsavchenko added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/SmartPtrModeling.cpp:404 +void SmartPtrModeling::handleBoolOperation(const CallEvent &Call, + CheckerContext &C) const { I suggest `BoolCon

[PATCH] D81083: [Clang] Allow "vector_size" applied to Booleans

simoll added a comment. The Hexagon builtins explicitly require bool vectors to have 8-bit wide bool elements. That clashes with our new vector type because bool vectors in builtin functions and vector_size bool vectors have the same internal representation in Clang. However, AFAIK Hexagon is t

[PATCH] D85736: [Sema][AArch64] Support arm_sve_vector_bits attribute

c-rhodes added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85736/new/ https://reviews.llvm.org/D85736 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D86295: [analyzer] Reorder the layout of MemRegion and cache by hand for optimal size

martong added a comment. In D86295#2232005 , @steakhal wrote: > In D86295#2231760 , @NoQ wrote: > >> I mean, like, you can measure the entire process with `time` or something >> like that. I believe @vsavchenko's d

[PATCH] D86295: [analyzer] Reorder the layout of MemRegion and cache by hand for optimal size

martong added a comment. In D86295#2233068 , @martong wrote: > In D86295#2232005 , @steakhal wrote: > >> In D86295#2231760 , @NoQ wrote: >> >>> I mean, like, you can measure

[PATCH] D86295: [analyzer] Reorder the layout of MemRegion and cache by hand for optimal size

vsavchenko added a comment. In D86295#2231760 , @NoQ wrote: > I believe @vsavchenko's docker thingy already knows how to do that. Yep, it sure does! Additionally, there is a `benchmark` subcommand that can chart memory consumption for measured projects.

[PATCH] D83048: [LiveDebugValues] 3/4 Add Xclang and CodeGen options for using instr-ref variable locations

djtodoro accepted this revision. djtodoro added a comment. This revision is now accepted and ready to land. nit included, otherwise lgtm, thanks! Comment at: llvm/lib/CodeGen/LiveDebugValues/LiveDebugValues.cpp:45 + ~LiveDebugValues() + { +if (TheImpl) is

[PATCH] D86437: [SyntaxTree] Split array declarator tests

eduucaldas created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. eduucaldas requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D86437 Files: clang/unittests/Tooling/Syntax/BuildTreeTest.cpp Index: clang/uni

[clang] ada2e8e - Reland "Correctly emit dwoIDs after ASTFileSignature refactoring (D81347)"

Author: Raphael Isemann Date: 2020-08-24T11:51:32+02:00 New Revision: ada2e8ea67393aa8c44fe8e9d46be62df6d1c702 URL: https://github.com/llvm/llvm-project/commit/ada2e8ea67393aa8c44fe8e9d46be62df6d1c702 DIFF: https://github.com/llvm/llvm-project/commit/ada2e8ea67393aa8c44fe8e9d46be62df6d1c702.dif

[PATCH] D84013: Correctly emit dwoIDs after ASTFileSignature refactoring (D81347)

This revision was automatically updated to reflect the committed changes. Closed by commit rGada2e8ea6739: Reland "Correctly emit dwoIDs after ASTFileSignature refactoring (D81347)" (authored by teemperor). Changed prior to commit: https://reviews.llvm.org/D84013?vs=287017&id=287318#toc Reposi

[PATCH] D86439: [SyntaxTree] Use annotations to reduce noise on member function tests

eduucaldas created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. eduucaldas requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D86439 Files: clang/unittests/Tooling/Syntax/BuildTreeTest.cpp Index: clang/uni

[PATCH] D86295: [analyzer] Reorder the layout of MemRegion and cache by hand for optimal size

steakhal added a comment. In D86295#2233076 , @vsavchenko wrote: > In D86295#2231760 , @NoQ wrote: > >> I believe @vsavchenko's docker thingy already knows how to do that. > > Yep, it sure does! Additionally, there

[PATCH] D86440: [SyntaxTree] Split FreeStandingClass tests

eduucaldas created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. eduucaldas requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D86440 Files: clang/unittests/Tooling/Syntax/BuildTreeTest.cpp Index: clang/uni

[PATCH] D86441: [SyntaxTree] Split ExplicitTemplateInstantiation test

eduucaldas created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. eduucaldas requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D86441 Files: clang/unittests/Tooling/Syntax/BuildTreeTest.cpp Index: clang/uni

[PATCH] D86443: [SyntaxTree] Group tests related to `using`

eduucaldas created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. eduucaldas requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D86443 Files: clang/unittests/Tooling/Syntax/BuildTreeTest.cpp Index: clang/uni

[PATCH] D86441: [SyntaxTree] Split ExplicitTemplateInstantiation test

gribozavr2 accepted this revision. gribozavr2 added inline comments. This revision is now accepted and ready to land. Comment at: clang/unittests/Tooling/Syntax/BuildTreeTest.cpp:3054 -TEST_P(SyntaxTreeTest, ExplicitTemplateInstantations) { +TEST_P(SyntaxTreeTest, ExplicitTempl

[PATCH] D84013: Correctly emit dwoIDs after ASTFileSignature refactoring (D81347)

davezarzycki added a comment. I have an auto-bisecting cron job that has identified the "reland" as breaking the test suite on Fedora 32 (x86). Is there a quick fix or can we revert the reland? FAIL: Clang :: Modules/ModuleDebugInfoDwoId.cpp (12657 of 68968) TEST 'Clang

[PATCH] D86295: [analyzer] Reorder the layout of MemRegion and cache by hand for optimal size

vsavchenko added a comment. In D86295#2233157 , @steakhal wrote: > In D86295#2233076 , @vsavchenko > wrote: > >> In D86295#2231760 , @NoQ wrote: >> >>> I believe @vsavchenko

[clang] 2b3074c - Revert "Reland "Correctly emit dwoIDs after ASTFileSignature refactoring (D81347)""

Author: Raphael Isemann Date: 2020-08-24T12:54:25+02:00 New Revision: 2b3074c0d14cadbd9595346fc795d4a49a479a20 URL: https://github.com/llvm/llvm-project/commit/2b3074c0d14cadbd9595346fc795d4a49a479a20 DIFF: https://github.com/llvm/llvm-project/commit/2b3074c0d14cadbd9595346fc795d4a49a479a20.dif

[PATCH] D86295: [analyzer] Reorder the layout of MemRegion and cache by hand for optimal size

Szelethus added a comment. I really like the patch, but have nothing to add to what other reviewers already said. Nice! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86295/new/ https://reviews.llvm.org/D86295 _

[PATCH] D84013: Correctly emit dwoIDs after ASTFileSignature refactoring (D81347)

teemperor added a comment. In D84013#2233242 , @davezarzycki wrote: > I have an auto-bisecting cron job that has identified the "reland" as > breaking the test suite on Fedora 32 (x86). Is there a quick fix or can we > revert the reland? > > FAIL: Cla

[PATCH] D86445: [analyzer][RFC] Simplify MetadataSymbol representation and resolve a CStringChecker FIXME

steakhal created this revision. steakhal added reviewers: NoQ, vsavchenko, xazax.hun, martong, Szelethus. Herald added subscribers: cfe-commits, ASDenysPetrov, Charusso, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, whisperity. Herald added a project: clang

[PATCH] D85324: [SystemZ][z/OS] Add z/OS Target and define macros

abhina.sreeskantharajan updated this revision to Diff 287338. abhina.sreeskantharajan added a comment. Thanks Hubert, I fixed the comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85324/new/ https://reviews.llvm.org/D85324 Files: clang/lib/

[PATCH] D84013: Correctly emit dwoIDs after ASTFileSignature refactoring (D81347)

davezarzycki added a comment. Not fighting with how `lit`, `FileCheck`, and shell input/output work would help here: FAIL: Clang :: Modules/ModuleDebugInfoDwoId.cpp (1 of 1) TEST 'Clang :: Modules/ModuleDebugInfoDwoId.cpp' FAILED Script: -- :

[PATCH] D86447: [AST] Change return type of getTypeInfoInChars to a proper struct instead of std::pair.

ebevhan created this revision. ebevhan added a reviewer: efriedma. Herald added subscribers: bjope, martong, jfb. Herald added a project: clang. ebevhan requested review of this revision. Followup to D85191 . This changes getTypeInfoInChars to return a TypeInfoCha

[PATCH] D84316: [analyzer][NFC] Split CStringChecker to modeling and reporting

Szelethus added a comment. Do I sense correctly that the only information `CSrtingLengthModeling.cpp` requires from the actual `CStringChecker` is a checker tag? Because if so, I think we should just separate them even more cleanly -- we could just make a `CStringLengthModeling` checker impleme

[clang] 09e7fe9 - [AST][RecoveryAST] Preserve the type by default for recovery expression.

Author: Haojian Wu Date: 2020-08-24T14:28:28+02:00 New Revision: 09e7fe9859b4efeeb35697c095c9676e993fc03c URL: https://github.com/llvm/llvm-project/commit/09e7fe9859b4efeeb35697c095c9676e993fc03c DIFF: https://github.com/llvm/llvm-project/commit/09e7fe9859b4efeeb35697c095c9676e993fc03c.diff LO

[PATCH] D82657: [AST][RecoveryAST] Preserve the type by default for recovery expression.

This revision was automatically updated to reflect the committed changes. Closed by commit rG09e7fe9859b4: [AST][RecoveryAST] Preserve the type by default for recovery expression. (authored by hokein). Herald added a subscriber: dang. Changed prior to commit: https://reviews.llvm.org/D82657?vs=

[PATCH] D85031: [builtins] Unify the softfloat division implementation

atrosinenko updated this revision to Diff 287351. atrosinenko added a comment. Addressed the review comments mostly by clarifying the explanations. I expect this code to have no **unresolved** review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[clang] 577f8b1 - [Fixed Point] Add codegen for fixed-point shifts.

Author: Bevin Hansson Date: 2020-08-24T14:37:16+02:00 New Revision: 577f8b157a03055821341146ed0617e3b103fdaf URL: https://github.com/llvm/llvm-project/commit/577f8b157a03055821341146ed0617e3b103fdaf DIFF: https://github.com/llvm/llvm-project/commit/577f8b157a03055821341146ed0617e3b103fdaf.diff

[PATCH] D86282: [Fixed Point] Use FixedPointBuilder to codegen fixed-point IR.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG808ac5464521: [Fixed Point] Use FixedPointBuilder to codegen fixed-point IR. (authored by ebevhan). Repository: rG LLVM Github Monorepo CHANGES S

[clang] 808ac54 - [Fixed Point] Use FixedPointBuilder to codegen fixed-point IR.

Author: Bevin Hansson Date: 2020-08-24T14:37:07+02:00 New Revision: 808ac54645212ddc9aba150cdc97454e36fb9521 URL: https://github.com/llvm/llvm-project/commit/808ac54645212ddc9aba150cdc97454e36fb9521 DIFF: https://github.com/llvm/llvm-project/commit/808ac54645212ddc9aba150cdc97454e36fb9521.diff

[PATCH] D83294: [Fixed Point] Add codegen for fixed-point shifts.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG577f8b157a03: [Fixed Point] Add codegen for fixed-point shifts. (authored by ebevhan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[PATCH] D85032: [builtins] Make divXf3 handle denormal results

atrosinenko updated this revision to Diff 287354. atrosinenko added a comment. Re-upload after parent commits were changed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85032/new/ https://reviews.llvm.org/D85032 Files: compiler-rt/lib/builtins/

[PATCH] D86295: [analyzer] Reorder the layout of MemRegion and cache by hand for optimal size

steakhal added a comment. In D86295#2233244 , @vsavchenko wrote: > Here is a short summary how to do regression testing (check that all warnings > are the same): Oh thanks for the detailed guide, I will make the experiment. However the `./SATest.py dock

[PATCH] D86295: [analyzer] Reorder the layout of MemRegion and cache by hand for optimal size

vsavchenko added a comment. In D86295#2233398 , @steakhal wrote: > In D86295#2233244 , @vsavchenko > wrote: > >> Here is a short summary how to do regression testing (check that all >> warnings are the same): > >

[PATCH] D86299: [compiler-rt][builtins] Factor out some common bit manipulations

atrosinenko updated this revision to Diff 287355. atrosinenko added a comment. Reupload. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86299/new/ https://reviews.llvm.org/D86299 Files: compiler-rt/lib/builtins/fixdfdi.c compiler-rt/lib/builtin

[clang] 105151c - Reland "Correctly emit dwoIDs after ASTFileSignature refactoring (D81347)"

Author: Raphael Isemann Date: 2020-08-24T14:52:53+02:00 New Revision: 105151ca5669a0536fb5bb1bc02bd3279cdbbfda URL: https://github.com/llvm/llvm-project/commit/105151ca5669a0536fb5bb1bc02bd3279cdbbfda DIFF: https://github.com/llvm/llvm-project/commit/105151ca5669a0536fb5bb1bc02bd3279cdbbfda.dif

[PATCH] D86414: [compiler-rt][builtins] Fix some other cases of UB

atrosinenko updated this revision to Diff 287359. atrosinenko added a comment. Re-upload with properly set parent review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86414/new/ https://reviews.llvm.org/D86414 Files: compiler-rt/lib/builtins/ab

[PATCH] D84013: Correctly emit dwoIDs after ASTFileSignature refactoring (D81347)

This revision was automatically updated to reflect the committed changes. Closed by commit rG105151ca5669: Reland "Correctly emit dwoIDs after ASTFileSignature refactoring (D81347)" (authored by teemperor). Changed prior to commit: https://reviews.llvm.org/D84013?vs=287318&id=287358#toc Reposi

[PATCH] D82317: [Clang/Test]: Update tests where `noundef` attribute is necessary

guiand added a comment. Herald added a subscriber: wenlei. @rjmccall We've discussed several different possibilities here. Does any of them strike you as a good step forward here? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82317/new/ https://re

[clang] aec12c1 - [analyzer][tests] Add a notion of project sizes

Author: Valeriy Savchenko Date: 2020-08-24T16:13:00+03:00 New Revision: aec12c1264ac17877d5cb19750eaa322fe57342d URL: https://github.com/llvm/llvm-project/commit/aec12c1264ac17877d5cb19750eaa322fe57342d DIFF: https://github.com/llvm/llvm-project/commit/aec12c1264ac17877d5cb19750eaa322fe57342d.d

[PATCH] D83942: [analyzer][tests] Add a notion of project sizes

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGaec12c1264ac: [analyzer][tests] Add a notion of project sizes (authored by vsavchenko). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[PATCH] D86445: [analyzer][RFC] Simplify MetadataSymbol representation and resolve a CStringChecker FIXME

martong added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/SymbolManager.h:198 /// SymbolMetadata - Represents path-dependent metadata about a specific region. /// Metadata symbols remain live as long as they are marked as in use before

[PATCH] D86445: [analyzer][RFC] Simplify MetadataSymbol representation and resolve a CStringChecker FIXME

steakhal added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/SymbolManager.h:441 + const SymbolMetadata *getMetadataSymbol(const MemRegion *R, QualType T, const void *SymbolTag = nullptr); ---

[PATCH] D86445: [analyzer][RFC] Simplify MetadataSymbol representation and resolve a CStringChecker FIXME

steakhal added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/SymbolManager.h:198 /// SymbolMetadata - Represents path-dependent metadata about a specific region. /// Metadata symbols remain live as long as they are marked as in use before

[PATCH] D84316: [analyzer][NFC] Split CStringChecker to modeling and reporting

steakhal added a comment. In D84316#2233368 , @Szelethus wrote: > Do I sense correctly that the only information `CSrtingLengthModeling.cpp` > requires from the actual `CStringChecker` is a checker tag? AFAIK yes. > [...] it seems like we're legalizing

[PATCH] D86459: [SyntaxTree] Split `ParametersAndQualifiers` tests

eduucaldas created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. eduucaldas requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D86459 Files: clang/unittests/Tooling/Syntax/BuildTreeTest.cpp Index: clang/uni

[PATCH] D86135: [analyzer][MacroExpansion] Fix a crash where multiple parameters resolved to __VA_ARGS__

martong added a comment. I can feel your pain. > The fundamental problem is, we simply can't ask Preprocessor what a macro > expands into without hacking really hard. Can you summarize what is the exact problem (or give a link to a discussion, etc)? Is it an architectural problem in Clang itse

[PATCH] D86424: [clang] Do not consider the template arguments of bases to be bases themselves

hokein added inline comments. Comment at: clang/lib/Index/IndexTypeSourceInfo.cpp:167 +if (!TraverseTemplateName(TL.getTypePtr()->getTemplateName())) + return false; + nit: this could be simplified by calling the `base::TraverseTemplateSpecializationTyp

[PATCH] D86441: [SyntaxTree] Split ExplicitTemplateInstantiation test

eduucaldas updated this revision to Diff 287378. eduucaldas marked 4 inline comments as done. eduucaldas added a comment. Template -> ClassTemplate Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86441/new/ https://reviews.llvm.org/D86441 Files: c

[PATCH] D86239: [OPENMP]Fix PR47158, case 3: allow devic_typein nested declare target region.

This revision was automatically updated to reflect the committed changes. Closed by commit rGbedc841a5098: [OPENMP]Fix PR47158, case 3: allow devic_typein nested declare target region. (authored by ABataev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[clang] bedc841 - [OPENMP]Fix PR47158, case 3: allow devic_typein nested declare target region.

Author: Alexey Bataev Date: 2020-08-24T09:58:37-04:00 New Revision: bedc841a5098bc0a90bbc66328d7aab4b2c23c4a URL: https://github.com/llvm/llvm-project/commit/bedc841a5098bc0a90bbc66328d7aab4b2c23c4a DIFF: https://github.com/llvm/llvm-project/commit/bedc841a5098bc0a90bbc66328d7aab4b2c23c4a.diff

[PATCH] D86295: [analyzer] Reorder the layout of MemRegion and cache by hand for optimal size

steakhal added a comment. In D86295#2233401 , @vsavchenko wrote: > Yep, I guess that is the cause. I'll take a look. Did you try it with this > fast fix? I tried, but it lacks further fixes. Currently, I have this: diff --git a/clang/utils/analyzer

[PATCH] D86440: [SyntaxTree] Split FreeStandingClass tests

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb4093d663f83: [SyntaxTree] Split FreeStandingClass tests (authored by eduucaldas). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D86439: [SyntaxTree] Use annotations to reduce noise on member function tests

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGed83095254a3: [SyntaxTree] Use annotations to reduce noise on member function tests (authored by eduucaldas). Repository: rG LLVM Github Monorepo

[PATCH] D86437: [SyntaxTree] Split array declarator tests

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4e8dd506e666: [SyntaxTree] Split array declarator tests (authored by eduucaldas). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 235f9f7 - [SyntaxTree] Split `DynamicExceptionSpecification` test

Author: Eduardo Caldas Date: 2020-08-24T14:31:46Z New Revision: 235f9f7fe94488904a60a8a1f5430183b0504945 URL: https://github.com/llvm/llvm-project/commit/235f9f7fe94488904a60a8a1f5430183b0504945 DIFF: https://github.com/llvm/llvm-project/commit/235f9f7fe94488904a60a8a1f5430183b0504945.diff LOG

[PATCH] D86441: [SyntaxTree] Split ExplicitTemplateInstantiation test

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa722d6a197c7: [SyntaxTree] Split ExplicitTemplateInstantiation test (authored by eduucaldas). Repository: rG LLVM Github Monorepo CHANGES SINCE L

[clang] ed83095 - [SyntaxTree] Use annotations to reduce noise on member function tests

Author: Eduardo Caldas Date: 2020-08-24T14:31:45Z New Revision: ed83095254a3e212d14b293a6a0e6c85d1f3331c URL: https://github.com/llvm/llvm-project/commit/ed83095254a3e212d14b293a6a0e6c85d1f3331c DIFF: https://github.com/llvm/llvm-project/commit/ed83095254a3e212d14b293a6a0e6c85d1f3331c.diff LOG

[clang] 90f85df - [SyntaxTree] Group tests related to `using`

Author: Eduardo Caldas Date: 2020-08-24T14:31:46Z New Revision: 90f85dfc14bc6020486eb2d2c6399f8207ef3625 URL: https://github.com/llvm/llvm-project/commit/90f85dfc14bc6020486eb2d2c6399f8207ef3625 DIFF: https://github.com/llvm/llvm-project/commit/90f85dfc14bc6020486eb2d2c6399f8207ef3625.diff LOG

[clang] 4baa163 - [SyntaxTree] Split `ParametersAndQualifiers` tests

Author: Eduardo Caldas Date: 2020-08-24T14:31:46Z New Revision: 4baa163c74237b30c5094c1fafd7ed355575bcfa URL: https://github.com/llvm/llvm-project/commit/4baa163c74237b30c5094c1fafd7ed355575bcfa DIFF: https://github.com/llvm/llvm-project/commit/4baa163c74237b30c5094c1fafd7ed355575bcfa.diff LOG

[clang] a722d6a - [SyntaxTree] Split ExplicitTemplateInstantiation test

Author: Eduardo Caldas Date: 2020-08-24T14:31:45Z New Revision: a722d6a197c7a4f7a1afb72b4732b8ebe8272628 URL: https://github.com/llvm/llvm-project/commit/a722d6a197c7a4f7a1afb72b4732b8ebe8272628 DIFF: https://github.com/llvm/llvm-project/commit/a722d6a197c7a4f7a1afb72b4732b8ebe8272628.diff LOG

[clang] 4e8dd50 - [SyntaxTree] Split array declarator tests

Author: Eduardo Caldas Date: 2020-08-24T14:31:45Z New Revision: 4e8dd506e66642329dcd530524f43b0d2b528521 URL: https://github.com/llvm/llvm-project/commit/4e8dd506e66642329dcd530524f43b0d2b528521 DIFF: https://github.com/llvm/llvm-project/commit/4e8dd506e66642329dcd530524f43b0d2b528521.diff LOG

[clang] b4093d6 - [SyntaxTree] Split FreeStandingClass tests

Author: Eduardo Caldas Date: 2020-08-24T14:31:45Z New Revision: b4093d663f8377b3ca3746ff104c83c9c5510c0a URL: https://github.com/llvm/llvm-project/commit/b4093d663f8377b3ca3746ff104c83c9c5510c0a DIFF: https://github.com/llvm/llvm-project/commit/b4093d663f8377b3ca3746ff104c83c9c5510c0a.diff LOG

[PATCH] D86459: [SyntaxTree] Split `ParametersAndQualifiers` tests

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4baa163c7423: [SyntaxTree] Split `ParametersAndQualifiers` tests (authored by eduucaldas). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D86443: [SyntaxTree] Group tests related to `using`

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG90f85dfc14bc: [SyntaxTree] Group tests related to `using` (authored by eduucaldas). Changed prior to commit: https://reviews.llvm.org/D86443?vs=28

[PATCH] D86135: [analyzer][MacroExpansion] Fix a crash where multiple parameters resolved to __VA_ARGS__

xazax.hun added a comment. Is this related to https://bugs.llvm.org/show_bug.cgi?id=44493? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86135/new/ https://reviews.llvm.org/D86135 ___ cfe-commits mailing

[PATCH] D86295: [analyzer] Reorder the layout of MemRegion and cache by hand for optimal size

vsavchenko added a comment. In D86295#2233666 , @steakhal wrote: > In D86295#2233401 , @vsavchenko > wrote: > >> Yep, I guess that is the cause. I'll take a look. Did you try it with this >> fast fix? > > I trie

[clang] 512e256 - [PowerPC] Add clang options to control MMA support

Author: Baptiste Saleil Date: 2020-08-24T09:35:55-05:00 New Revision: 512e256c0d8c0fed5b4603ed5ed74b6ad503f368 URL: https://github.com/llvm/llvm-project/commit/512e256c0d8c0fed5b4603ed5ed74b6ad503f368 DIFF: https://github.com/llvm/llvm-project/commit/512e256c0d8c0fed5b4603ed5ed74b6ad503f368.dif

[PATCH] D81442: [PowerPC] Add clang options to control MMA support

This revision was automatically updated to reflect the committed changes. Closed by commit rG512e256c0d8c: [PowerPC] Add clang options to control MMA support (authored by bsaleil). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81442/new/ https://rev

[PATCH] D84887: [OPENMP]Fix codegen for is_device_ptr component, captured by reference.

ABataev updated this revision to Diff 287396. ABataev added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84887/new/ https://reviews.llvm.org/D84887 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp clang/test/OpenMP/target_is_dev

[PATCH] D86295: [analyzer] Reorder the layout of MemRegion and cache by hand for optimal size

steakhal added a comment. In D86295#2233694 , @vsavchenko wrote: > And what is the error right now? F12760388: error.txt BTW this sort of ping-pong should be done on a different forum, eg. on the Static Analyzer Disc

[clang] c9b45ce - [clang][NFC] Fix a GCC warning in ASTImporterTest.cpp

Author: Raphael Isemann Date: 2020-08-24T17:10:55+02:00 New Revision: c9b45ce1fd97531c228e092bedee719b971f82a3 URL: https://github.com/llvm/llvm-project/commit/c9b45ce1fd97531c228e092bedee719b971f82a3 DIFF: https://github.com/llvm/llvm-project/commit/c9b45ce1fd97531c228e092bedee719b971f82a3.dif

[PATCH] D85635: [clangd] Compute the inactive code range for semantic highlighting.

hokein updated this revision to Diff 287405. hokein marked an inline comment as done. hokein added a comment. Herald added a subscriber: mgrang. address comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85635/new/ https://reviews.llvm.org/D856

[PATCH] D86424: [clang] Do not consider the template arguments of bases to be bases themselves

nridge added inline comments. Comment at: clang/lib/Index/IndexTypeSourceInfo.cpp:167 +if (!TraverseTemplateName(TL.getTypePtr()->getTemplateName())) + return false; + hokein wrote: > nit: this could be simplified by calling the > `base::TraverseTemplat

[PATCH] D85762: [OPENMP]Do not allow threadprivates as base for array-like reduction.

ABataev updated this revision to Diff 287406. ABataev added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85762/new/ https://reviews.llvm.org/D85762 Files: clang/lib/Sema/SemaOpenMP.cpp clang/test/OpenMP/parallel_reduction_me

[PATCH] D86465: [analyzer][solver] Redesign constraint ranges data structure

vsavchenko created this revision. vsavchenko added reviewers: NoQ, dcoughlin, xazax.hun, Szelethus, ASDenysPetrov, steakhal. Herald added subscribers: cfe-commits, martong, Charusso, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, mgrang, rnkovacs, szepet, baloghadamsoftware. Herald added a proje

[PATCH] D84415: [analyzer][StdLibraryFunctionsChecker] Add POSIX pthread handling functions

martong updated this revision to Diff 287409. martong marked 4 inline comments as done. martong added a comment. - Remove private ctor of Signature - Assert a valid signature in Signature::matces Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84415/n

[PATCH] D84415: [analyzer][StdLibraryFunctionsChecker] Add POSIX pthread handling functions

martong added a comment. Thanks @balazske for your comments, you always make an assiduous review! Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:350 + } else { +*this = Signature(Args, *RetTy); } balazske wrote:

[PATCH] D82663: [CodeGen] Have CodeGen for fixed-point unsigned with padding emit signed operations.

ebevhan abandoned this revision. ebevhan added a comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82663/new/ https://reviews.llvm.org/D82663 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D86467: [SyntaxTree] Split `MemberPointer` tests with annotations

eduucaldas created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. eduucaldas requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D86467 Files: clang/unittests/Tooling/Syntax/BuildTreeTest.cpp Index: clang/uni

[PATCH] D84415: [analyzer][StdLibraryFunctionsChecker] Add POSIX pthread handling functions

martong planned changes to this revision. martong added a comment. Planning to rebase this on a dependent patch that uses an API with Optionals. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84415/new/ https://reviews.llvm.org/D84415 _

[PATCH] D86308: [CMake][compiler-rt][libunwind] Compile assembly files as ASM not C, unify workarounds

teemperor added a comment. In D86308#2229936 , @tambre wrote: > In D86308#2229901 , @teemperor wrote: > >> Sorry, just got around to check this out. With the new workaround this seems >> to work on macOS (the initi

[PATCH] D85960: [AST][FPEnv] Keep FP options in trailing storage of CastExpr

sepavloff added a comment. In D85960#2218798 , @kpn wrote: > You mentioned in D85920 a need to merge > this review with that review. I don't think that's needed. This code here is > farther along. It does everything that

[PATCH] D86308: [CMake][compiler-rt][libunwind] Compile assembly files as ASM not C, unify workarounds

tambre updated this revision to Diff 287421. tambre added a comment. Gate Apple workaround behind CMake version 3.19 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86308/new/ https://reviews.llvm.org/D86308 Files: clang/runtime/CMakeLists.txt c

[PATCH] D86308: [CMake][compiler-rt][libunwind] Compile assembly files as ASM not C, unify workarounds

tambre added a comment. In D86308#2233934 , @teemperor wrote: > In D86308#2229936 , @tambre wrote: > >> In D86308#2229901 , @teemperor >> wrote: >> >>> Sorry, just got aroun

[PATCH] D86465: [analyzer][solver] Redesign constraint ranges data structure

grandinj added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/RangedConstraintManager.h:88 + // structure is preferred. + using ImplType = llvm::SmallVector; + Just curious - if they mostly contain 1 or 2 elements, why i

[PATCH] D86469: [SyntaxTree] Split ConstVolatileQualifiers tests

eduucaldas created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. eduucaldas requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D86469 Files: clang/unittests/Tooling/Syntax/BuildTreeTest.cpp Index: clang/un

[PATCH] D86470: [SyntaxTree] Use annotations on ClassTemplate_MemberClassDefinition test

eduucaldas created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. eduucaldas requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D86470 Files: clang/unittests/Tooling/Syntax/BuildTreeTest.cpp Index: clang/un

[PATCH] D85998: Add clang-cl "vctoolsdir" option to specify the location of the msvc toolchain

zahen updated this revision to Diff 287425. zahen edited reviewers, added: aganea; removed: thakis. zahen added a comment. Updates as requested CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85998/new/ https://reviews.llvm.org/D85998 Files: clang/include/clang/Driver/Options.td clan

[PATCH] D86465: [analyzer][solver] Redesign constraint ranges data structure

vsavchenko added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/RangedConstraintManager.h:88 + // structure is preferred. + using ImplType = llvm::SmallVector; + grandinj wrote: > Just curious - if they mostly contain 1

[PATCH] D85998: Add clang-cl "vctoolsdir" option to specify the location of the msvc toolchain

aganea added a comment. Thanks, one more minor thing and it should be good to go. Comment at: clang/lib/Driver/ToolChains/MSVC.cpp:764 // Check the environment first, since that's probably the user telling us // what they want to use. Please update thes

[PATCH] D85330: [SyntaxTree] Extend the syntax tree dump

eduucaldas updated this revision to Diff 287430. eduucaldas marked an inline comment as done. eduucaldas added a comment. Update tests to dump role Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85330/new/ https://reviews.llvm.org/D85330 Files: c

[PATCH] D81347: Make ASTFileSignature an array of 20 uint8_t instead of 5 uint32_t

dblaikie added a comment. In D81347#2080217 , @aprantl wrote: > I was going to ask why make this change, but looking at the patch, it's > pretty obvious :-) Might be worth writing it down for everyone else - isn't exactly obvious to me (though not a par

[PATCH] D85330: [SyntaxTree] Extend the syntax tree dump

eduucaldas updated this revision to Diff 287431. eduucaldas marked 4 inline comments as done. eduucaldas added a comment. - Nits Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85330/new/ https://reviews.llvm.org/D85330 Files: clang/include/clang/

Re: [clang] c9b45ce - [clang][NFC] Fix a GCC warning in ASTImporterTest.cpp

Usually this would be addressed with a "using Base::Function" - makes it clear you aren't intending to override any base behavior, just want to continue to expose the full overload set On Mon, Aug 24, 2020 at 8:11 AM Raphael Isemann via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > Author:

  1   2   >