hokein added inline comments.
================
Comment at: clang/lib/Index/IndexTypeSourceInfo.cpp:167
+ if (!TraverseTemplateName(TL.getTypePtr()->getTemplateName()))
+ return false;
+
----------------
nit: this could be simplified by calling the
`base::TraverseTemplateSpecializationTypeLoc`
================
Comment at: clang/unittests/Index/IndexTests.cpp:337
+TEST(IndexTest, RelationBaseOf) {
+ std::string Code = R"cpp(
----------------
nit: I think we need a test in clang, `clang/test/Index/Core/index-source.cpp`.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D86424/new/
https://reviews.llvm.org/D86424
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
