[PATCH] D85401: [clang-tidy] Fix bugprone-bad-signal-to-kill-thread crash when `SIGTERM` was undefined after definition.

hokein accepted this revision. hokein added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/test/clang-tidy/checkers/bugprone-bad-signal-to-kill-thread-undef-sigterm.cpp:1 +// RUN: clang-tidy %s --checks="-*,bugprone-bad-signal-to-

[PATCH] D85398: [clang-tidy] Fix bugprone-bad-signal-to-kill-thread crash when `SIGTERM` is not a literal.

hokein accepted this revision. hokein added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/test/clang-tidy/checkers/bugprone-bad-signal-to-kill-thread-sigterm-not-a-literal.cpp:1 +// RUN: clang-tidy %s --checks="-*,bugprone-bad-si

[PATCH] D85097: [Sema] add warning for comparisons like 'x<=y<=z'

njames93 added a comment. Also with a name like compare op parenthesis. It sounds like this would consider `==` and `!=` Comment at: clang/lib/Sema/SemaExpr.cpp:14034 + << FixItHint::CreateInsertion(LHSExpr->getEndLoc(), ") && ") + << FixItHint::CreateInsertion(LHSBO

[PATCH] D85401: [clang-tidy] Fix bugprone-bad-signal-to-kill-thread crash when `SIGTERM` was undefined after definition.

ArcsinX updated this revision to Diff 283503. ArcsinX added a comment. Fix test according to review comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85401/new/ https://reviews.llvm.org/D85401 Files: clang-tools-extra/clang-tidy/bugprone/Bad

[PATCH] D85401: [clang-tidy] Fix bugprone-bad-signal-to-kill-thread crash when `SIGTERM` was undefined after definition.

ArcsinX added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/bugprone-bad-signal-to-kill-thread-undef-sigterm.cpp:1 +// RUN: clang-tidy %s --checks="-*,bugprone-bad-signal-to-kill-thread" + hokein wrote: > nit: `// RUN: clang-tidy %s -ch

[PATCH] D85330: [SyntaxTree] Extend the syntax tree dump

eduucaldas updated this revision to Diff 283506. eduucaldas added a comment. Answer comment. Please suggest more descriptive markers. Options I thought of: `I` -> `unmodifiable` `M` -> `not backed by source code` / `synthesized` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 504a197 - [X86] Rename X86::getImpliedFeatures to X86::updateImpliedFeatures and pass clang's StringMap directly to it.

Author: Craig Topper Date: 2020-08-06T00:20:46-07:00 New Revision: 504a197fe54de83be791ea0aa2ed290f6b9285b0 URL: https://github.com/llvm/llvm-project/commit/504a197fe54de83be791ea0aa2ed290f6b9285b0 DIFF: https://github.com/llvm/llvm-project/commit/504a197fe54de83be791ea0aa2ed290f6b9285b0.diff

[PATCH] D85398: [clang-tidy] Fix bugprone-bad-signal-to-kill-thread crash when `SIGTERM` is not a literal.

ArcsinX updated this revision to Diff 283509. ArcsinX added a comment. Fix test according to review comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85398/new/ https://reviews.llvm.org/D85398 Files: clang-tools-extra/clang-tidy/bugprone/Bad

[PATCH] D85398: [clang-tidy] Fix bugprone-bad-signal-to-kill-thread crash when `SIGTERM` is not a literal.

ArcsinX added a comment. Thank you for review! Comment at: clang-tools-extra/test/clang-tidy/checkers/bugprone-bad-signal-to-kill-thread-sigterm-not-a-literal.cpp:1 +// RUN: clang-tidy %s --checks="-*,bugprone-bad-signal-to-kill-thread" + hokein wrote: > the s

[PATCH] D85401: [clang-tidy] Fix bugprone-bad-signal-to-kill-thread crash when `SIGTERM` was undefined after definition.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG86711668330c: [clang-tidy] Fix bugprone-bad-signal-to-kill-thread crash when `SIGTERM` was… (authored by ArcsinX). Repository: rG LLVM Github Mon

[clang-tools-extra] 8671166 - [clang-tidy] Fix bugprone-bad-signal-to-kill-thread crash when `SIGTERM` was undefined after definition.

Author: Aleksandr Platonov Date: 2020-08-06T10:28:20+03:00 New Revision: 86711668330cf48325a5e960f30d33f6a7364db2 URL: https://github.com/llvm/llvm-project/commit/86711668330cf48325a5e960f30d33f6a7364db2 DIFF: https://github.com/llvm/llvm-project/commit/86711668330cf48325a5e960f30d33f6a7364db2.

[PATCH] D85316: [SyntaxTree] Proposition of new tree dump

eduucaldas updated this revision to Diff 283513. eduucaldas added a comment. Reflect comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85316/new/ https://reviews.llvm.org/D85316 Files: clang/unittests/Tooling/Syntax/TreeTest.cpp Index: cl

[PATCH] D85316: [SyntaxTree] Proposition of new tree dump

eduucaldas added inline comments. Comment at: clang/unittests/Tooling/Syntax/TreeTest.cpp:3363 +| |-'if' IntroducerKeyword I +| |-'(' I +| |-BinaryOperatorExpression I Some points to make a decision. What should be the order of these extra informatio

[PATCH] D85398: [clang-tidy] Fix bugprone-bad-signal-to-kill-thread crash when `SIGTERM` is not a literal.

This revision was automatically updated to reflect the committed changes. Closed by commit rG216ad2da74f0: [clang-tidy] Fix bugprone-bad-signal-to-kill-thread crash when `SIGTERM` is not… (authored by ArcsinX). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[clang-tools-extra] 216ad2d - [clang-tidy] Fix bugprone-bad-signal-to-kill-thread crash when `SIGTERM` is not a literal.

Author: Aleksandr Platonov Date: 2020-08-06T10:32:03+03:00 New Revision: 216ad2da74f0e952af8f1c8ac84e19146d739ff2 URL: https://github.com/llvm/llvm-project/commit/216ad2da74f0e952af8f1c8ac84e19146d739ff2 DIFF: https://github.com/llvm/llvm-project/commit/216ad2da74f0e952af8f1c8ac84e19146d739ff2.

[PATCH] D85115: [update_cc_test_checks.py] Add test for D84511

This revision was automatically updated to reflect the committed changes. Closed by commit rGe150d2cab868: [update_cc_test_checks.py] Add test for D84511 (authored by arichardson). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85115/new/ https://rev

[clang] e150d2c - [update_cc_test_checks.py] Add test for D84511

Author: Alex Richardson Date: 2020-08-06T09:15:56+01:00 New Revision: e150d2cab8688a2b3b7d395bfbbc152b08df9033 URL: https://github.com/llvm/llvm-project/commit/e150d2cab8688a2b3b7d395bfbbc152b08df9033 DIFF: https://github.com/llvm/llvm-project/commit/e150d2cab8688a2b3b7d395bfbbc152b08df9033.dif

[clang] 7109494 - [clang][Driver] Don't hardcode --as-needed/--no-as-needed on Illumos

Author: Rainer Orth Date: 2020-08-06T10:47:16+02:00 New Revision: 710949482edb96a329104317164909979f2387aa URL: https://github.com/llvm/llvm-project/commit/710949482edb96a329104317164909979f2387aa DIFF: https://github.com/llvm/llvm-project/commit/710949482edb96a329104317164909979f2387aa.diff L

[PATCH] D84412: [clang][Driver] Don't hardcode --as-needed/--no-as-needed on Illumos

This revision was automatically updated to reflect the committed changes. ro marked 3 inline comments as done. Closed by commit rG710949482edb: [clang][Driver] Don't hardcode --as-needed/--no-as-needed on Illumos (authored by ro). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D67422: [analyzer] NFC: Move path diagnostic consumer implementations to libAnalysis.

vsavchenko added inline comments. Comment at: clang/lib/Analysis/TextPathDiagnosticConsumer.cpp:1 //===--- TextDiagnostics.cpp - Text Diagnostics for Paths ---*- C++ -*-===// // TextPathDiagnosticConsumer.cpp? Comment at: clang/lib/Analy

[PATCH] D85309: [WIP][clang][Driver] Support GNU ld on Solaris

ro added a comment. In D85309#2198505 , @MaskRay wrote: > Please find a suitable test file (clang/test/Driver/solaris-*.c) and add some > tests there (for example, solaris-ld.c) > The challenge is that CLANG_ENABLE_GLD is not a default configuration, so

[PATCH] D85295: [SyntaxTree] Implement the List construct.

eduucaldas added inline comments. Comment at: clang/include/clang/Tooling/Syntax/Tree.h:197 + MaybeTerminated, + Separated, +}; gribozavr2 wrote: > Add a "WithoutDelimiters" case as well? I think we might want to treat non-delimited-list in another way. as many

[PATCH] D85295: [SyntaxTree] Implement the List construct.

eduucaldas updated this revision to Diff 283536. eduucaldas marked 9 inline comments as done. eduucaldas added a comment. Answer comments non-delimited-lists need further discussion Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85295/new/ https://

[PATCH] D85009: [Sema][BFloat] Forbid arithmetic on vectors of bfloat.

simon_tatham added a comment. This discussion seems to have wound down. I'll land this patch tomorrow on the strength of @LukeGeeson's review, unless you have strong objections, @jfb? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85009/new/ https:

[PATCH] D85097: [Sema] add warning for comparisons like 'x<=y<=z'

vabridgers added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:14034 + << FixItHint::CreateInsertion(LHSExpr->getEndLoc(), ") && ") + << FixItHint::CreateInsertion(LHSBO->getRHS()->getBeginLoc(), "(y ") + << FixItHint::CreateInsertion(RHSExpr->getEndLoc(

[PATCH] D85311: [analyzer][tests] Understand when diagnostics change between builds

This revision was automatically updated to reflect the committed changes. Closed by commit rG6ddef9247458: [analyzer][tests] Understand when diagnostics change between builds (authored by vsavchenko). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D853

[clang] 6ddef92 - [analyzer][tests] Understand when diagnostics change between builds

Author: Valeriy Savchenko Date: 2020-08-06T12:53:20+03:00 New Revision: 6ddef92474583ef3c183da9bdc8c8e81ec578fd8 URL: https://github.com/llvm/llvm-project/commit/6ddef92474583ef3c183da9bdc8c8e81ec578fd8 DIFF: https://github.com/llvm/llvm-project/commit/6ddef92474583ef3c183da9bdc8c8e81ec578fd8.d

[PATCH] D83942: [analyzer][tests] Add a notion of project sizes

vsavchenko updated this revision to Diff 283548. vsavchenko added a comment. Herald added a subscriber: steakhal. Keep SATest.py Python2 compatible Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83942/new/ https://reviews.llvm.org/D83942 Files: c

[PATCH] D85417: [clangd] Fix crash in bugprone-bad-signal-to-kill-thread clang-tidy check.

ArcsinX created this revision. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, dexonsmith, steven_wu, jkorous, hiraditya. Herald added a project: clang. ArcsinX requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Inside clangd, clang-tidy che

[PATCH] D72705: [analyzer] Added new checker 'alpha.unix.ErrorReturn'.

balazske added a comment. Herald added a subscriber: whisperity. Test results for tmux are available here

[PATCH] D85256: Add -Wtautological-value-range-compare warning.

rtrieu accepted this revision. rtrieu added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85256/new/ https://reviews.llvm.org/D85256 ___ c

[PATCH] D85337: [AMDGPU] gfx1031 target

jhenderson added inline comments. Comment at: llvm/tools/llvm-readobj/ELFDumper.cpp:1844 LLVM_READOBJ_ENUM_ENT(ELF, EF_AMDGPU_MACH_AMDGCN_GFX1030), + LLVM_READOBJ_ENUM_ENT(ELF, EF_AMDGPU_MACH_AMDGCN_GFX1031), LLVM_READOBJ_ENUM_ENT(ELF, EF_AMDGPU_XNACK), Wh

[PATCH] D79219: [CMake] Simplify CMake handling for zlib

phosek updated this revision to Diff 283398. phosek marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79219/new/ https://reviews.llvm.org/D79219 Files: clang/test/CMakeLists.txt clang/test/lit.site.cfg.py.in compiler-rt/test/lit.common.configured.in

[PATCH] D79219: [CMake] Simplify CMake handling for zlib

This revision was automatically updated to reflect the committed changes. Closed by commit rG1adc494bce44: [CMake] Simplify CMake handling for zlib (authored by phosek). Changed prior to commit: https://reviews.llvm.org/D79219?vs=283398&id=283434#toc Repository: rG LLVM Github Monorepo CHAN

[PATCH] D79219: [CMake] Simplify CMake handling for zlib

phosek reopened this revision. phosek added a comment. This revision is now accepted and ready to land. Sorry about the breakage, that was an unintentional change. I have updated the patch and restored the original behavior on Windows. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79219

[PATCH] D85337: [AMDGPU] gfx1031 target

This revision was automatically updated to reflect the committed changes. Closed by commit rGea7d0e2996ec: [AMDGPU] gfx1031 target (authored by rampitec). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[PATCH] D62574: Initial draft of target-configurable address spaces.

ebevhan added a comment. In D62574#2183294 , @Anastasia wrote: > In D62574#2136423 , @ebevhan wrote: > >> It seems that D70605 attempted to >> ameliorate the issues that I observed

[PATCH] D85390: [Clang] Add note for bad conversion error when expression is of forward-declared type

hans added a comment. Thanks! This looks promising. In addition to updating existing tests, it would be good to add a test aimed explicitly at this. Maybe you can reduce something from the example in the bug report. Maybe looking at git blame for emitBadConversionNotes() will provide hints for

[PATCH] D85423: [AST][RecoveryExpr] Fix the missing type when rebuilding RecoveryExpr in TreeTransform.

hokein created this revision. hokein added a reviewer: sammccall. Herald added a project: clang. hokein requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D85423 Files: clang/lib/Sema/TreeTransform.h clang/test/SemaTemplate/recovery-tree-transfo

[PATCH] D79219: [CMake] Simplify CMake handling for zlib

hans added inline comments. Comment at: llvm/cmake/config-ix.cmake:178 -if (LLVM_ENABLE_ZLIB STREQUAL "FORCE_ON" AND NOT HAVE_LIBZ) - message(FATAL_ERROR "Failed to configure zlib") Could this check be put back? E.g. for now it seems building with -DLLVM_USE_

[PATCH] D85424: [Analyzer] Crash fix for alpha.cplusplus.IteratorRange

baloghadamsoftware created this revision. baloghadamsoftware added reviewers: NoQ, Szelethus, gamesh411. baloghadamsoftware added a project: clang. Herald added subscribers: ASDenysPetrov, martong, steakhal, Charusso, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, xazax.hun, whi

[PATCH] D85287: Extend -Wtautological-bitwise-compare "bitwise or with non-zero value" warnings

rtrieu added a subscriber: AndersRonnholm. rtrieu added a comment. I looked back on the commits and while I did commit, I did it on the behalf of Anders Rönnholm, who did not have commit access at the time. I haven't seen activity from Anders in a while, but added to subscribers just in case.

[PATCH] D85424: [Analyzer] Crash fix for alpha.cplusplus.IteratorRange

baloghadamsoftware added a comment. Unfortunately, I could not create test for it. It is extremely rare that the //Analyzer// creates an `UndefinedVal`. I had the following output: 1. parser at end of file 2.While analyzing stack: #0 Calling llvm::object::BindRebaseSegInfo::

[PATCH] D85287: Extend -Wtautological-bitwise-compare "bitwise or with non-zero value" warnings

sberg added a comment. In D85287#2199463 , @rtrieu wrote: > Are you planning to allow this change to other warnings that use the same > helper functions? No, I didn't plan to work on this further. Just scratching that itch of why Clang didn't emit that

[PATCH] D85426: [clangd] Implement FileFilter for the indexer

kbobyrev created this revision. kbobyrev added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous. Herald added a project: clang. kbobyrev requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Tests failing so far: Ba

[PATCH] D80514: [clang-tidy] modernize-use-trailing-return-type support for C++20 concepts and decltype

bernhardmgruber added a comment. Ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80514/new/ https://reviews.llvm.org/D80514 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit

[PATCH] D85426: [clangd] Implement FileFilter for the indexer

kbobyrev planned changes to this revision. kbobyrev added a comment. @sammccall This is the change I was talking about during the standup: the code looks legit, but `BackgroundIndexTests.IndexTwoFiles` fails because with the following code path in `Background.cpp`'s `FileFilter`: const auto *

[PATCH] D85427: [SyntaxTree][NFC] remove redundant namespace-specifiers

eduucaldas created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. eduucaldas requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D85427 Files: clang/include/clang/Tooling/Syntax/Nodes.h clang/include/clang/T

[PATCH] D84811: [clangd] Add an option to exclude symbols outside of project root from index

kbobyrev requested review of this revision. kbobyrev added a comment. Even despite `FileFilter` not being fully implemented yet (an issue for a separate patch) I think this change should still be correct and is probably OK to land, WDYT @hokein? Repository: rG LLVM Github Monorepo CHANGES S

[PATCH] D85113: [ABI][NFC] Fix the confusion of ByVal and ByRef argument names

This revision was automatically updated to reflect the committed changes. Closed by commit rG5a07490d7611: [ABI][NFC] Fix the confusion of ByVal and ByRef argument names (authored by atrosinenko). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85113/n

[clang] 5a07490 - [ABI][NFC] Fix the confusion of ByVal and ByRef argument names

Author: Anatoly Trosinenko Date: 2020-08-06T15:20:18+03:00 New Revision: 5a07490d7611088277dca4c1c06c2002403b7039 URL: https://github.com/llvm/llvm-project/commit/5a07490d7611088277dca4c1c06c2002403b7039 DIFF: https://github.com/llvm/llvm-project/commit/5a07490d7611088277dca4c1c06c2002403b7039.

[PATCH] D85113: [ABI][NFC] Fix the confusion of ByVal and ByRef argument names

atrosinenko added a comment. @rjmccall Uploaded, thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85113/new/ https://reviews.llvm.org/D85113 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[PATCH] D85324: [z/OS] Add z/OS Target and define macros

abhina.sreeskantharajan added inline comments. Comment at: clang/lib/Basic/Targets/OSTargets.h:780 +public: + ZOSTargetInfo(const llvm::Triple &Triple, const TargetOptions &Opts) + : OSTargetInfo(Triple, Opts) {} tatyana-krasnukha wrote: > It is possible to

[clang] 839d974 - [DOCS] Add more detail to stack protector documentation

Author: Peter Smith Date: 2020-08-06T13:47:21+01:00 New Revision: 839d974ee0e45f09b9665b4eed734ca1ba174d25 URL: https://github.com/llvm/llvm-project/commit/839d974ee0e45f09b9665b4eed734ca1ba174d25 DIFF: https://github.com/llvm/llvm-project/commit/839d974ee0e45f09b9665b4eed734ca1ba174d25.diff L

[PATCH] D85239: [DOCS] Add more detail to stack protector documentation

This revision was automatically updated to reflect the committed changes. psmith marked an inline comment as done. Closed by commit rG839d974ee0e4: [DOCS] Add more detail to stack protector documentation (authored by psmith). Herald added a project: clang. Repository: rG LLVM Github Monorepo C

[PATCH] D85191: [AST] Get field size in chars rather than bits in RecordLayoutBuilder.

ebevhan added a comment. In D85191#2197550 , @bjope wrote: > In D85191#2196863 , @rsmith wrote: > >> In D85191#2195923 , @ebevhan wrote: >> >>> In D85191#2193645

[PATCH] D85429: [OpenCL] Allow for variadic macros in C++ for OpenCL

olestrohm created this revision. olestrohm added a reviewer: Anastasia. olestrohm added a project: clang. Herald added subscribers: cfe-commits, yaxunl. olestrohm requested review of this revision. C++ for OpenCL intends to support variadic macros, a decision motivated by OpenCL 3.0. This patch s

[PATCH] D85295: [SyntaxTree] Implement the List construct.

gribozavr2 added inline comments. Comment at: clang/include/clang/Tooling/Syntax/Tree.h:197 + MaybeTerminated, + Separated, +}; eduucaldas wrote: > gribozavr2 wrote: > > Add a "WithoutDelimiters" case as well? > I think we might want to treat non-delimited-list

[PATCH] D85191: [AST] Get field size in chars rather than bits in RecordLayoutBuilder.

tschuett added a comment. I don't know whether the name of your downstream target is a secret. Wouldn't it help you to add a fake 16bit per char target and add units tests to prevent regressions? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85191

[PATCH] D85424: [Analyzer] Crash fix for alpha.cplusplus.IteratorRange

Szelethus added a comment. Yeah, this looks straightforward, but how come you didn't manage to get a small test case? creduce gave up? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85424/new/ https://reviews.llvm.org/D85424 __

[PATCH] D85431: [analyzer] Implement a new checker ThreadPrimitivesChecker

ASDenysPetrov created this revision. ASDenysPetrov added reviewers: NoQ, vsavchenko, xazax.hun, steakhal, baloghadamsoftware, dcoughlin, Szelethus. ASDenysPetrov added a project: clang. Herald added subscribers: cfe-commits, martong, Charusso, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkov

[PATCH] D85276: [PGO][CUDA][HIP] Skip generating profile on the device stub and wrong-side functions.

yaxunl added a comment. Do we need to disable pgo and coverage mapping for device compilation? Or it is already disabled? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85276/new/ https://reviews.llvm.org/D85276 ___

[PATCH] D67253: clang-misexpect: a standalone tool for verifying the use of __builtin_expect with PGO data

lebedev.ri requested changes to this revision. lebedev.ri added a comment. This revision now requires changes to proceed. Abandon this? D66324 landed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67253/new/ https:

[PATCH] D85417: [clangd] Fix crash in bugprone-bad-signal-to-kill-thread clang-tidy check.

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. Thanks, this is a nice catch. Looks like NotNullTerminatedResultCheck.cpp also has this pattern, we may want to fix that as well. Comment at: clang-tools-extra/clangd/unitt

[PATCH] D85431: [analyzer] Implement a new checker ThreadPrimitivesChecker

vsavchenko added a comment. It is an interesting checker, but it seems that this kind of checker is extremely hard in single TU/top-down analysis. It feels like it's going to produce hell a lot of false positives in the wild. Also `mutex` is usually a global variable - the nemesis of any static

[PATCH] D84932: [builtins] Add more test cases for __div[sdt]f3 LibCalls

atrosinenko added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84932/new/ https://reviews.llvm.org/D84932 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[PATCH] D85417: [clangd] Fix crash in bugprone-bad-signal-to-kill-thread clang-tidy check.

ArcsinX updated this revision to Diff 283600. ArcsinX added a comment. Test rename: ClangTidyBadSignalToKillThread => ClangTidyNoLiteralDataInMacroToken Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85417/new/ https://reviews.llvm.org/D85417 File

[PATCH] D85417: [clangd] Fix crash in bugprone-bad-signal-to-kill-thread clang-tidy check.

ArcsinX added inline comments. Comment at: clang-tools-extra/clangd/unittests/DiagnosticsTests.cpp:441 +TEST(DiagnosticTest, ClangTidyBadSignalToKillThread) { + Annotations Main(R"cpp( hokein wrote: > ClangTidyBadSignalToKillThread doesn't seen ti provide much

[PATCH] D84534: [AIX] Static init frontend recovery and backend support

jasonliu added inline comments. Comment at: llvm/include/llvm/CodeGen/AsmPrinter.h:391 + /// @param[out] Structors Sorted Structor structs by Priority. + /// @return false if List is not an array of '{ i32, void ()*, i8* }' structs. + bool preprocessXXStructorList(const DataL

[PATCH] D84600: [Analyzer] Support note tags for smart ptr checker

vrnithinkumar updated this revision to Diff 283602. vrnithinkumar marked 13 inline comments as done. vrnithinkumar added a comment. - Changes from review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84600/new/ https://reviews.llvm.org/D

[PATCH] D84600: [Analyzer] Support note tags for smart ptr checker

vrnithinkumar added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/CheckerContext.h:312 + const NoteTag *getNoteTag( + std::function Cb, + bool IsPrunable = false) { xazax.hun wrote: > The callback is taken is an r

[PATCH] D85315: [AIX][Clang][Driver] Generate reference to the C++ library on the link step

ShuhongL updated this revision to Diff 283607. ShuhongL added a comment. Added testcases for lc and lc++ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85315/new/ https://reviews.llvm.org/D85315 Files: clang/lib/Driver/ToolChains/AIX.cpp clang/

[PATCH] D84811: [clangd] Add an option to exclude symbols outside of project root from index

hokein added a comment. In D84811#2199510 , @kbobyrev wrote: > Even despite `FileFilter` not being fully implemented yet (an issue for a > separate patch) I think this change should still be correct and is probably > OK to land, WDYT @hokein? Yes, perso

[PATCH] D84811: [clangd] Add an option to exclude symbols outside of project root from index

kbobyrev added a comment. In D84811#2199820 , @hokein wrote: > In D84811#2199510 , @kbobyrev wrote: > >> Even despite `FileFilter` not being fully implemented yet (an issue for a >> separate patch) I think this cha

[PATCH] D85426: [clangd] Implement FileFilter for the indexer

hokein added inline comments. Comment at: clang-tools-extra/clangd/index/SymbolCollector.cpp:643 assert(Loc.isValid() && "Invalid source location for NamedDecl"); - // FIXME: use the result to filter out symbols. - shouldIndexFile(SM.getFileID(Loc)); + if (!shouldIndexFile(

[PATCH] D85417: [clangd] Fix crash in bugprone-bad-signal-to-kill-thread clang-tidy check.

ArcsinX added a comment. In D85417#2199694 , @hokein wrote: > Looks like NotNullTerminatedResultCheck.cpp also has this pattern, we may > want to fix that as well. Yes, you are right. I will fix this in the next patch. Repository: rG LLVM Github Mono

[PATCH] D85285: [clangd] WIP experimentation with finding static grpc++ libraries

kbobyrev planned changes to this revision. kbobyrev added a comment. WIP, nothing important here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85285/new/ https://reviews.llvm.org/D85285 ___ cfe-commits

[PATCH] D85426: [clangd] Implement FileFilter for the indexer

kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/index/SymbolCollector.cpp:643 assert(Loc.isValid() && "Invalid source location for NamedDecl"); - // FIXME: use the result to filter out symbols. - shouldIndexFile(SM.getFileID(Loc)); + if (!shouldIndexFil

[PATCH] D82502: [PowerPC] Implement Load VSX Vector and Sign Extend and Zero Extend

amyk accepted this revision. amyk added inline comments. This revision is now accepted and ready to land. Comment at: clang/test/CodeGen/builtins-ppc-p10vector.c:703 +vector signed __int128 test_vec_xl_sext_i8(void) { + // CHECK: load i8 + // CHECK: sext i8 It

[PATCH] D85429: [OpenCL] Allow for variadic macros in C++ for OpenCL

Anastasia added a comment. Can you extend test test/Preprocessor/macro_variadic.cl to cover C++ for OpenCL mode, otherwise LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85429/new/ https://reviews.llvm.org/D85429

[PATCH] D84811: [clangd] Add an option to exclude symbols outside of project root from index

hokein added a comment. In D84811#2199829 , @kbobyrev wrote: > In D84811#2199820 , @hokein wrote: > >> In D84811#2199510 , @kbobyrev wrote: >> >>> Even despite `FileFilter` n

[PATCH] D84348: WIP: Add complete id-expression support to syntax trees

eduucaldas updated this revision to Diff 283622. eduucaldas added a comment. - Update comments to reflect change in API. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84348/new/ https://reviews.llvm.org/D84348 Files: clang/include/clang/Tooling/

[PATCH] D84811: [clangd] Add an option to exclude symbols outside of project root from index

kbobyrev planned changes to this revision. kbobyrev added a comment. In D84811#2199891 , @hokein wrote: > In D84811#2199829 , @kbobyrev wrote: > >> In D84811#2199820 , @hokei

[PATCH] D84781: Use PointerUnion instead of inheritance for alternative clauses in NNS

eduucaldas updated this revision to Diff 283627. eduucaldas added a comment. - [SyntaxTree] Fix crash on name specifier. This diff revision is based on https://reviews.llvm.org/D84348 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84781/new/ https:

[PATCH] D85439: [SyntaxTree] Expand support for `NestedNameSpecifier`

eduucaldas created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. eduucaldas requested review of this revision. We want NestedNameSpecifier syntax nodes to be generally supported, not only for `DeclRefExpr` and `DependentScopedDeclRefExpr`. To achieve this w

[PATCH] D85440: [SyntaxTree] Implement `NNS` using the `List` base API

eduucaldas created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. eduucaldas requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D85440 Files: clang/include/clang/Tooling/Syntax/Nodes.h clang/include/clang/T

[PATCH] D81083: [Clang] Allow "vector_size" applied to Booleans

simoll updated this revision to Diff 283632. simoll added a comment. Fixed debug info representation for bool vectors. Interpret 8*N with the N in vector_size(N) as the bool numbers of bits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81083/new/

[PATCH] D81083: [Clang] Allow "vector_size" applied to Booleans

simoll updated this revision to Diff 283636. simoll added a comment. NFC. Cleanup. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81083/new/ https://reviews.llvm.org/D81083 Files: clang/docs/LanguageExtensions.rst clang/include/clang/AST/Type.h

[PATCH] D85439: [SyntaxTree] Expand support for `NestedNameSpecifier`

eduucaldas added a reviewer: gribozavr2. eduucaldas added inline comments. Comment at: clang/lib/Tooling/Syntax/BuildTree.cpp:227-254 +namespace llvm { +template <> struct DenseMapInfo { + using FirstInfo = DenseMapInfo; + using SecondInfo = DenseMapInfo; + + static inline Nes

[PATCH] D85276: [PGO][CUDA][HIP] Skip generating profile on the device stub and wrong-side functions.

tra added a comment. In D85276#2199655 , @yaxunl wrote: > Do we need to disable pgo and coverage mapping for device compilation? Or it > is already disabled? We already disable profiling during device compilation for NVIDIA and AMD GPUs: https://github.c

[PATCH] D85440: [SyntaxTree] Implement `NNS` using the `List` base API

eduucaldas updated this revision to Diff 283638. eduucaldas added a comment. Clean List specific code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85440/new/ https://reviews.llvm.org/D85440 Files: clang/include/clang/Tooling/Syntax/Nodes.h cl

[PATCH] D85440: [SyntaxTree] Implement `NNS` using the `List` base API

eduucaldas updated this revision to Diff 283643. eduucaldas added a comment. . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85440/new/ https://reviews.llvm.org/D85440 Files: clang/include/clang/Tooling/Syntax/Nodes.h clang/lib/Tooling/Syntax/

[clang] 8d072a4 - [OPENMP]Fix for Windows buildbots, NFC.

Author: Alexey Bataev Date: 2020-08-06T12:36:52-04:00 New Revision: 8d072a4405213623a1b13dbac2e451df81457343 URL: https://github.com/llvm/llvm-project/commit/8d072a4405213623a1b13dbac2e451df81457343 DIFF: https://github.com/llvm/llvm-project/commit/8d072a4405213623a1b13dbac2e451df81457343.diff

[PATCH] D85337: [AMDGPU] gfx1031 target

rampitec added inline comments. Comment at: llvm/tools/llvm-readobj/ELFDumper.cpp:1844 LLVM_READOBJ_ENUM_ENT(ELF, EF_AMDGPU_MACH_AMDGCN_GFX1030), + LLVM_READOBJ_ENUM_ENT(ELF, EF_AMDGPU_MACH_AMDGCN_GFX1031), LLVM_READOBJ_ENUM_ENT(ELF, EF_AMDGPU_XNACK), jhen

[PATCH] D85276: [PGO][CUDA][HIP] Skip generating profile on the device stub and wrong-side functions.

hliao added a comment. In D85276#2200108 , @tra wrote: > In D85276#2199655 , @yaxunl wrote: > >> Do we need to disable pgo and coverage mapping for device compilation? Or it >> is already disabled? > > We already d

[PATCH] D85295: [SyntaxTree] Implement the List construct.

gribozavr2 added inline comments. Comment at: clang/include/clang/Tooling/Syntax/Tree.h:247 + + TerminationKind getTerminationKind(); + I just realized that the rest of the syntax tree API does not use the `get~` prefix. However, most of Clang does, as far as I

[PATCH] D85440: [SyntaxTree] Implement `NNS` using the `List` base API

gribozavr2 added a comment. Please also add appropriate handling to `syntax::List::getDelimiterTokenKind`, `getTerminationKind`, and `canBeEmpty`. Comment at: clang/lib/Tooling/Syntax/Nodes.cpp:240 return Children; -} +}; Repository: rG LLVM Github M

[PATCH] D85440: [SyntaxTree] Implement `NNS` using the `List` base API

gribozavr2 added a comment. Could you add unit tests for methods in List and NNS? OK if they are in a separate patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85440/new/ https://reviews.llvm.org/D85440 ___

[PATCH] D84602: [MSP430] Expose msp430_builtin calling convention to C code

atrosinenko added a comment. I suspect there might be some terminology clash, so clarifying a bit just in case. It was probably better to refer to these functions as //LibCalls// - functions from the compiler support library (such as `libgcc`) such as `__adddf3`. While there are `__popcount[sd

[PATCH] D85276: [PGO][CUDA][HIP] Skip generating profile on the device stub and wrong-side functions.

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85276/new/ https://reviews.llvm.org/D85276 _

  1   2   >