hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land.
Thanks, this is a nice catch. Looks like NotNullTerminatedResultCheck.cpp also has this pattern, we may want to fix that as well. ================ Comment at: clang-tools-extra/clangd/unittests/DiagnosticsTests.cpp:441 +TEST(DiagnosticTest, ClangTidyBadSignalToKillThread) { + Annotations Main(R"cpp( ---------------- ClangTidyBadSignalToKillThread doesn't seen ti provide much information about what is testcase testing. Maybe `NoLiteralDataInMacroToken`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85417/new/ https://reviews.llvm.org/D85417 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits