[PATCH] D83025: [clang] Include type specifiers in typo correction when checking isCXXDeclarationSpecifiers.

hokein created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D83025 Files: clang/lib/Parse/ParseTentative.cpp clang/test/SemaCXX/typo-correction.cpp Index: clang/test/SemaCXX/typo-correct

[PATCH] D82845: [Analyzer][StreamChecker] Report every leak, clean up state.

balazske marked an inline comment as done. balazske added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StreamChecker.cpp:969 + // Do not warn for non-closed stream at program exit. + if (Pred && Pred->getCFGBlock() && Pred->getCFGBlock()->hasNoReturnElement())

[PATCH] D79431: [analyzer] StdLibraryFunctionsChecker: Add better diagnostics

balazske added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:323 +std::string("Function argument constraint is not satisfied, ") + +VC->getName().data() + ", ArgN: " + std::to_string(VC->getArgNo()); if (!BT_Inv

[clang-tools-extra] d3bf1f3 - Revert "[clang-tidy] For `run-clang-tidy.py` escape the paths that are used for analysis."

Author: Nathan James Date: 2020-07-02T08:54:55+01:00 New Revision: d3bf1f3af2f26a7c100c3aa6b8ae93feb7034cb8 URL: https://github.com/llvm/llvm-project/commit/d3bf1f3af2f26a7c100c3aa6b8ae93feb7034cb8 DIFF: https://github.com/llvm/llvm-project/commit/d3bf1f3af2f26a7c100c3aa6b8ae93feb7034cb8.diff

[PATCH] D82629: [libclang] Fix crash when visiting a captured VLA.

ckandeler added a comment. I suppose it boils down to whether the visit() function is supposed to except null arguments or not. Since I don't know the answer to that, I added the check at the caller. From the description of the linked patch, it appears that other places are also calling the fun

[PATCH] D81917: [clang-tidy] For `run-clang-tidy.py` escape the paths that are used for analysis.

njames93 added a comment. Based on https://bugs.llvm.org/show_bug.cgi?id=46536 I've reverted this as it renders the core feature of the script as unusable (using `.*` to run over entire database) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81917

[PATCH] D71199: [clang-tidy] New check cppcoreguidelines-prefer-member-initializer

baloghadamsoftware marked an inline comment as done. baloghadamsoftware added a comment. In D71199#2125602 , @njames93 wrote: > Just my 2 cents, but would it not be wise to introduce a test case that runs > the 2 aforementioned checks together demonstrati

[PATCH] D82948: [Driver][ARM] Disable unsupported features when nofp arch extension is used

chill added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/ARM.cpp:292-297 + auto checkFPDisabledInArchName = [](const StringRef &ArchName) { +SmallVector Split; +ArchName.split(Split, '+', -1, false); +return llvm::any_of( +Split, [](const Str

[clang] 9e6f19f - Fix missing build dependency on omp_gen.

Author: Simon Tatham Date: 2020-07-02T09:16:15+01:00 New Revision: 9e6f19fd8390d39a0351941da1582f888d18c369 URL: https://github.com/llvm/llvm-project/commit/9e6f19fd8390d39a0351941da1582f888d18c369 DIFF: https://github.com/llvm/llvm-project/commit/9e6f19fd8390d39a0351941da1582f888d18c369.diff

[clang] aa4fd7d - [NFC] Fix typo in triples from unkown to unknown

Author: Qiu Chaofan Date: 2020-07-02T16:21:54+08:00 New Revision: aa4fd7d848d78611b4e6b6768edc6ab9d2b1efa5 URL: https://github.com/llvm/llvm-project/commit/aa4fd7d848d78611b4e6b6768edc6ab9d2b1efa5 DIFF: https://github.com/llvm/llvm-project/commit/aa4fd7d848d78611b4e6b6768edc6ab9d2b1efa5.diff L

[PATCH] D79279: Add overloaded versions of builtin mem* functions

gchatelet added inline comments. Comment at: clang/include/clang/Basic/Builtins.def:489 BUILTIN(__builtin_memcpy_inline, "vv*vC*Iz", "nt") +BUILTIN(__builtin_overloaded_memcpy, "v*v*vC*z", "nt") BUILTIN(__builtin_memmove, "v*v*vC*z", "nF") `overloaded` doesn't

[PATCH] D82659: Fix missing build dependency on omp_gen.

This revision was automatically updated to reflect the committed changes. Closed by commit rG9e6f19fd8390: Fix missing build dependency on omp_gen. (authored by simon_tatham). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82659/new/ https://reviews.

[PATCH] D82948: [Driver][ARM] Disable unsupported features when nofp arch extension is used

DavidSpickett added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/ARM.cpp:296 +return llvm::any_of( +Split, [](const StringRef &Extension) { return Extension == "nofp"; }); + }; I would check what this does: $ ./bin/clang -target arm-

[PATCH] D82938: [clangd] Implement path and URI translation for remote index

sammccall added a comment. Generally I think this is missing high-level documentation describing the translation that happens at each level - I had to refer back to the notes from our meeting to understand what the scheme was. I think Marshalling.h is probably a good place to document how this w

[clang] f255656 - [SVE] ACLE: Fix builtins for svdup_lane_bf16 and svcvtnt_bf16_f32_x

Author: Sander de Smalen Date: 2020-07-02T09:57:34+01:00 New Revision: f255656a97f7c83f7e049fd916278bbf7446651e URL: https://github.com/llvm/llvm-project/commit/f255656a97f7c83f7e049fd916278bbf7446651e DIFF: https://github.com/llvm/llvm-project/commit/f255656a97f7c83f7e049fd916278bbf7446651e.di

[PATCH] D82908: [SVE] ACLE: Fix builtins for svdup_lane_bf16 and svcvtnt_bf16_f32_x

This revision was automatically updated to reflect the committed changes. Closed by commit rGf255656a97f7: [SVE] ACLE: Fix builtins for svdup_lane_bf16 and svcvtnt_bf16_f32_x (authored by sdesmalen). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D8290

[PATCH] D82948: [Driver][ARM] Disable unsupported features when nofp arch extension is used

vhscampos marked 2 inline comments as done. vhscampos added a comment. I will merge the two patches into one. Please also see my inline responses. Comment at: clang/lib/Driver/ToolChains/Arch/ARM.cpp:288 +static void appendNoFPUnsupportedFeatures(const arm::FloatABI ABI, +

[PATCH] D83009: [clang][Serialization] Don't duplicate the body of LambdaExpr during deserialization

martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. In D83009#2127106 , @vabridgers wrote: > I cherry picked this change and retried the case that was failing. This > change addresses the issue I was s

[PATCH] D82940: [ASTReader][ASTWriter][PCH][Modules] Fix (de)serialization of SwitchCases

martong abandoned this revision. martong added a comment. Abandoning for a better fix in D83009 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82940/new/ https://reviews.llvm.org/D82940 __

[PATCH] D81917: [clang-tidy] For `run-clang-tidy.py` escape the paths that are used for analysis.

Abpostelnicu added a comment. @njames93 wdyt if we add another parameter to distinguish if we want to use regex or not, and if not we escape the paths? Also thank you so much for catching this up! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81917

[PATCH] D82964: [clangd] Config: loading and caching config from disk.

kadircet added a comment. thanks looks really cool! Comment at: clang-tools-extra/clangd/ConfigProvider.cpp:39 +std::vector &Out) { +assert(llvm::sys::path::is_absolute(Path)); +auto FS = TFS.view(/*CWD=*/llvm::None); I believe this function

[PATCH] D82738: [clang] Fix a null-NSS-access crash in DependentNameType.

hokein updated this revision to Diff 275027. hokein marked 2 inline comments as done. hokein added a comment. refine the fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82738/new/ https://reviews.llvm.org/D82738 Files: clang/lib/Sema/SemaTemp

[clang] 804d968 - [VE] Rename VE toolchain source files

Author: Kazushi (Jam) Marukawa Date: 2020-07-02T18:45:16+09:00 New Revision: 804d9687443e1132157a9bb3696cb5327ae0558c URL: https://github.com/llvm/llvm-project/commit/804d9687443e1132157a9bb3696cb5327ae0558c DIFF: https://github.com/llvm/llvm-project/commit/804d9687443e1132157a9bb3696cb5327ae05

[PATCH] D76291: [Support] Fix formatted_raw_ostream for UTF-8

ostannard updated this revision to Diff 275029. ostannard marked 5 inline comments as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76291/new/ https://reviews.llvm.org/D76291 Files: clang/test/Analysis/checker-plugins.c llvm/include/llvm/S

[PATCH] D83025: [clang] Include type specifiers in typo correction when checking isCXXDeclarationSpecifiers.

hokein updated this revision to Diff 275032. hokein added a comment. update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83025/new/ https://reviews.llvm.org/D83025 Files: clang/lib/Parse/ParseTentative.cpp clang/test/SemaCXX/typo-correction.c

[PATCH] D82738: [clang] Fix a null-NSS-access crash in DependentNameType.

hokein added inline comments. Comment at: clang/lib/Sema/SemaTemplate.cpp:4869 LookupResult::NotFoundInCurrentInstantiation) { +if (SS.isEmpty()) + // bail out if we don't have a NNS, this could be happened during sammccall wrote:

[PATCH] D82968: [VE] Rename VE toolchain source files

This revision was automatically updated to reflect the committed changes. Closed by commit rG804d9687443e: [VE] Rename VE toolchain source files (authored by kaz7). Changed prior to commit: https://reviews.llvm.org/D82968?vs=274815&id=275036#toc Repository: rG LLVM Github Monorepo CHANGES S

[clang] d4cf4c6 - Fix some typos (unkown -> unknown); NFC

Author: Aaron Ballman Date: 2020-07-02T06:41:05-04:00 New Revision: d4cf4c66b5b75393fd68e3aee8ab6c788bb628e3 URL: https://github.com/llvm/llvm-project/commit/d4cf4c66b5b75393fd68e3aee8ab6c788bb628e3 DIFF: https://github.com/llvm/llvm-project/commit/d4cf4c66b5b75393fd68e3aee8ab6c788bb628e3.diff

[PATCH] D80911: AArch64+ARM: make LLVM consider system registers volatile to prevent unsound optimizations.

t.p.northover added a comment. Herald added a reviewer: jdoerfert. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80911/new/ https://reviews.llvm.org/D80911 ___ cfe-commits mailing list cfe-commit

[PATCH] D83009: [clang][Serialization] Don't duplicate the body of LambdaExpr during deserialization

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83009/new/ https://reviews.llvm.org/D83009 ___ cfe-commits mailing list cfe-commi

[PATCH] D81456: [clangd] Get rid of WantDiagnostics::Yes

kadircet planned changes to this revision. kadircet marked an inline comment as done. kadircet added inline comments. Comment at: clang-tools-extra/clangd/ClangdLSPServer.cpp:670 auto Version = DraftMgr.addDraft(File, Params.textDocument.version, Contents); - Server->addDocu

[PATCH] D82880: Fix PR35677: UB on __int128_t or __uint128_t template parameters.

aaron.ballman added inline comments. Comment at: clang/lib/AST/StmtPrinter.cpp:1159 + case BuiltinType::UInt128: +OS << "Ui128"; +break; riccibruno wrote: > riccibruno wrote: > > davidstone wrote: > > > riccibruno wrote: > > > > `i128` and `Ui128` are no

[PATCH] D77062: [analyzer] Improved zero assumption in CStringChecke::assumeZero

ASDenysPetrov added a comment. @NoQ , just one another ping, since it is near to be closed. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77062/new/ https://reviews.llvm.org/D77062 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[PATCH] D80911: AArch64+ARM: make LLVM consider system registers volatile to prevent unsound optimizations.

fhahn added reviewers: fhahn, efriedma, hfinkel. fhahn added a comment. This seems similar to the problem described in https://bugs.llvm.org/show_bug.cgi?id=46210 : for intrinsics that are marked as reading memory, we do not account for the fact that the memory could be modified outside of the

[PATCH] D81917: [clang-tidy] For `run-clang-tidy.py` escape the paths that are used for analysis.

njames93 added a comment. In D81917#2127477 , @Abpostelnicu wrote: > @njames93 wdyt if we add another parameter to distinguish if we want to use > regex or not, and if not we escape the paths? > Also thank you so much for catching this up! As the argu

[PATCH] D82436: [clangd] Implement textDocument/foldingRange

sammccall added a comment. I think this looks reasonable, but I'd like to make sure we have a plan going forward otherwise the behavior/assumptions tend to calcify. I think RAV and adding other region types are clear, but maybe we should discuss lines/filtering behavior offline a bit. ===

[PATCH] D82930: [HIP] Fix rocm detection

yaxunl marked an inline comment as done. yaxunl added inline comments. Comment at: clang/lib/Driver/ToolChains/AMDGPU.cpp:167 +llvm::ErrorOr> VersionFile = +FS.getBufferForFile(BinPath + "/.hipVersion"); +if (!VersionFile) arsenm wrote: > arsenm w

[PATCH] D81456: [clangd] Get rid of WantDiagnostics::Yes

sammccall added inline comments. Comment at: clang-tools-extra/clangd/ClangdLSPServer.cpp:670 auto Version = DraftMgr.addDraft(File, Params.textDocument.version, Contents); - Server->addDocument(File, Contents, encodeVersion(Version), - WantDiagnostics::

[PATCH] D82921: Removed a RecursiveASTVisitor feature to visit operator kinds with different methods

gribozavr updated this revision to Diff 275064. gribozavr added a comment. Added release notes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82921/new/ https://reviews.llvm.org/D82921 Files: clang-tools-extra/clang-tidy/modernize/LoopConvertUti

[clang] 4cf24cb - [NFC][clang] Add missing VALIDATE_DIAG_SIZE()

Author: Whisperity Date: 2020-07-02T14:14:57+02:00 New Revision: 4cf24cb868b9fe9e65d2e4b27b8ec5fd5d5fb599 URL: https://github.com/llvm/llvm-project/commit/4cf24cb868b9fe9e65d2e4b27b8ec5fd5d5fb599 DIFF: https://github.com/llvm/llvm-project/commit/4cf24cb868b9fe9e65d2e4b27b8ec5fd5d5fb599.diff LO

[PATCH] D82944: [clangd] Switch FindSymbolsTests to use TestTU

kadircet updated this revision to Diff 275069. kadircet marked an inline comment as done. kadircet added a comment. - Get rid of the fixtures Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82944/new/ https://reviews.llvm.org/D82944 Files: clang-t

[PATCH] D82706: [ASTMatchers] Enhanced support for matchers taking Regex arguments

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82706/new/ https://reviews.llvm.org/D82706

[PATCH] D81917: [clang-tidy] For `run-clang-tidy.py` escape the paths that are used for analysis.

Abpostelnicu added a comment. In D81917#2127690 , @njames93 wrote: > In D81917#2127477 , @Abpostelnicu > wrote: > > > @njames93 wdyt if we add another parameter to distinguish if we want to use > > regex or not, a

[PATCH] D82738: [clang] Fix a null-NSS-access crash in DependentNameType.

sammccall accepted this revision. sammccall added a subscriber: rsmith. sammccall added a comment. This revision is now accepted and ready to land. Yeah, I think you're right, and this small version of the patch seems good. > if the arg is a DeclRefExpr (no typo correction), we'll never into this

[PATCH] D71199: [clang-tidy] New check cppcoreguidelines-prefer-member-initializer

aaron.ballman added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines-prefer-member-initializer-assignment.cpp:29 +public: + Simple2() : n (0) { +x = 0.0; baloghadamsoftware wrote: > aaron.ballman wrote: > > baloghada

[clang-tools-extra] 37cc3ee - [clangd] Switch FindSymbolsTests to use TestTU

Author: Kadir Cetinkaya Date: 2020-07-02T14:25:45+02:00 New Revision: 37cc3ee8c5553ec02c133e80e9ac98f5ffa525d1 URL: https://github.com/llvm/llvm-project/commit/37cc3ee8c5553ec02c133e80e9ac98f5ffa525d1 DIFF: https://github.com/llvm/llvm-project/commit/37cc3ee8c5553ec02c133e80e9ac98f5ffa525d1.dif

[clang] db4d5f7 - [analyzer][StdLibraryFunctionsChecker] Add POSIX file handling functions

Author: Gabor Marton Date: 2020-07-02T14:28:05+02:00 New Revision: db4d5f7048a26a7708821e46095742aecfd8ba46 URL: https://github.com/llvm/llvm-project/commit/db4d5f7048a26a7708821e46095742aecfd8ba46 DIFF: https://github.com/llvm/llvm-project/commit/db4d5f7048a26a7708821e46095742aecfd8ba46.diff

[PATCH] D81169: [clangd] Improve hover on arguments to function call

adamcz updated this revision to Diff 275073. adamcz added a comment. Final review comment + rebase on top of HEAD Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81169/new/ https://reviews.llvm.org/D81169 Files: clang-tools-extra/clangd/Hover.cpp

[PATCH] D81315: [analyzer] Warning for default constructed unique pointer dereferences

vrnithinkumar updated this revision to Diff 275076. vrnithinkumar marked 14 inline comments as done. vrnithinkumar added a comment. Herald added a subscriber: mgorny. - Created a new checker for smart point derference diagnostic - Moved checking part to this checker - Kept all the modeling in `Sma

[PATCH] D81315: [analyzer] Warning for default constructed unique pointer dereferences

vrnithinkumar marked 2 inline comments as done. vrnithinkumar added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Checkers/Checkers.td:574 -def SmartPtrModeling: Checker<"SmartPtr">, +def SmartPtrModeling: Checker<"SmartPtrModeling">, HelpText<"Model behavi

[PATCH] D82288: [analyzer][StdLibraryFunctionsChecker] Add POSIX file handling functions

This revision was automatically updated to reflect the committed changes. Closed by commit rGdb4d5f7048a2: [analyzer][StdLibraryFunctionsChecker] Add POSIX file handling functions (authored by martong). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D8

[PATCH] D81315: [analyzer] Warning for default constructed unique pointer dereferences

vrnithinkumar added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Checkers/Checkers.td:577-583 + CheckerOptions<[ +CmdLineOption, + ]>, Szelethus wrote: > NoQ wrote: > > Szelethus wrote: > > > This goes against D81750 -- Sorry for not brin

[PATCH] D82944: [clangd] Switch FindSymbolsTests to use TestTU

This revision was automatically updated to reflect the committed changes. Closed by commit rG37cc3ee8c555: [clangd] Switch FindSymbolsTests to use TestTU (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82944/new/ https://review

[clang] 8c5133f - [clang] Fix a null-NSS-access crash in DependentNameType.

Author: Haojian Wu Date: 2020-07-02T14:58:32+02:00 New Revision: 8c5133f1855767a16a6045777bed4652bd114d84 URL: https://github.com/llvm/llvm-project/commit/8c5133f1855767a16a6045777bed4652bd114d84 DIFF: https://github.com/llvm/llvm-project/commit/8c5133f1855767a16a6045777bed4652bd114d84.diff LO

[clang] e4d178a - [clang][Serialization] Don't duplicate the body of LambdaExpr during deserialization

Author: Bruno Ricci Date: 2020-07-02T14:13:35+01:00 New Revision: e4d178a75253f0ab8d2b9085087208aa8296 URL: https://github.com/llvm/llvm-project/commit/e4d178a75253f0ab8d2b9085087208aa8296 DIFF: https://github.com/llvm/llvm-project/commit/e4d178a75253f0ab8d2b9085087208aa8296.diff L

[PATCH] D83006: [ASTImporter] Add unittest case for friend decl import

martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. Thanks, looks good! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83006/new/ https://reviews.llvm.org/D83006 __

[PATCH] D82738: [clang] Fix a null-NSS-access crash in DependentNameType.

This revision was automatically updated to reflect the committed changes. hokein marked an inline comment as done. Closed by commit rG8c5133f18557: [clang] Fix a null-NSS-access crash in DependentNameType. (authored by hokein). Changed prior to commit: https://reviews.llvm.org/D82738?vs=275027&

[PATCH] D79279: Add overloaded versions of builtin mem* functions

erichkeane added a comment. I just took a look at SemaChecking, the rest I'm not sure I get the intent of the patch sufficiently to understand. Comment at: clang/lib/Sema/SemaChecking.cpp:1442 + enum class MemCheckType { Full, Basic }; + Oh boy... all these

[PATCH] D83009: [clang][Serialization] Don't duplicate the body of LambdaExpr during deserialization

This revision was automatically updated to reflect the committed changes. Closed by commit rGe4d178a75244: [clang][Serialization] Don't duplicate the body of LambdaExpr during… (authored by riccibruno). Changed prior to commit: https://reviews.llvm.org/D83009?vs=274951&id=275093#toc Repository

[clang] f51a319 - [ASTMatchers] Enhanced support for matchers taking Regex arguments

Author: Nathan James Date: 2020-07-02T14:52:25+01:00 New Revision: f51a319cacd44819b4fb9fa9f005c2445bcee984 URL: https://github.com/llvm/llvm-project/commit/f51a319cacd44819b4fb9fa9f005c2445bcee984 DIFF: https://github.com/llvm/llvm-project/commit/f51a319cacd44819b4fb9fa9f005c2445bcee984.diff

[PATCH] D82948: [Driver][ARM] Disable unsupported features when nofp arch extension is used

vhscampos marked 2 inline comments as done. vhscampos added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/ARM.cpp:292-297 + auto checkFPDisabledInArchName = [](const StringRef &ArchName) { +SmallVector Split; +ArchName.split(Split, '+', -1, false); +r

[PATCH] D81315: [analyzer] Warning for default constructed unique pointer dereferences

Szelethus added a comment. I only looked at the checker naming issue, and that seems to have been resolved perfectly, thanks! :) Comment at: clang/include/clang/StaticAnalyzer/Checkers/Checkers.td:582 + "false", + InAlpha>, + ]>,

[PATCH] D82706: [ASTMatchers] Enhanced support for matchers taking Regex arguments

This revision was automatically updated to reflect the committed changes. njames93 marked an inline comment as done. Closed by commit rGf51a319cacd4: [ASTMatchers] Enhanced support for matchers taking Regex arguments (authored by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D81678: Introduce noundef attribute at call sites for stricter poison analysis

guiand updated this revision to Diff 274895. guiand added a comment. Addressed comments, added test for indirect calls Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81678/new/ https://reviews.llvm.org/D81678 Files: clang/include/clang/Basic/Code

[clang] 59f1bf4 - [ASTImporter] Add unittest case for friend decl import

Author: Vince Bridgers Date: 2020-07-02T09:26:34-05:00 New Revision: 59f1bf46f8c258b9c784ff921b89fb6cb7a06612 URL: https://github.com/llvm/llvm-project/commit/59f1bf46f8c258b9c784ff921b89fb6cb7a06612 DIFF: https://github.com/llvm/llvm-project/commit/59f1bf46f8c258b9c784ff921b89fb6cb7a06612.diff

[PATCH] D81169: [clangd] Improve hover on arguments to function call

adamcz updated this revision to Diff 275104. adamcz marked an inline comment as done. adamcz added a comment. removed some more {} Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81169/new/ https://reviews.llvm.org/D81169 Files: clang-tools-extra/

[PATCH] D80911: AArch64+ARM: make LLVM consider system registers volatile to prevent unsound optimizations.

jdoerfert added a comment. As an alternative, and necessary regardless, we need to teach AA that "no-`nosync`" operations can experience the effects of external things. As long as `llvm.read_register` is not marked `nosync` that should prevent hoisting. Should, because AA doesn't know this yet.

[PATCH] D83048: [LiveDebugValues] 3/4 Add Xclang and CodeGen options for using instr-ref variable locations

jmorse created this revision. jmorse added reviewers: aprantl, vsk, probinson, Orlando, StephenTozer, TWeaver, djtodoro. Herald added subscribers: llvm-commits, cfe-commits, hiraditya. Herald added projects: clang, LLVM. jmorse added a parent revision: D83047: [LiveDebugValues] 2/4 Add instructio

[PATCH] D80525: [clangd] Fix crash-bug in preamble indexing when using modules.

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/unittests/SymbolCollectorTests.cpp:1509 +TEST_F(SymbolCollectorTest, UndefOfModuleMacro) { + auto TU = TestTU::withCode(R"cpp(

[PATCH] D82677: [Clang] Handle AIX Include management in the driver

ShuhongL updated this revision to Diff 275111. ShuhongL marked 2 inline comments as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82677/new/ https://reviews.llvm.org/D82677 Files: clang/lib/Driver/ToolChains/AIX.cpp clang/lib/Driver/ToolCh

[PATCH] D83006: [ASTImporter] Add unittest case for friend decl import

This revision was automatically updated to reflect the committed changes. Closed by commit rG59f1bf46f8c2: [ASTImporter] Add unittest case for friend decl import (authored by vabridgers, committed by einvbri ). Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D82502: [PowerPC][Power10] Implement Load VSX Vector and Sign Extend and Zero Extend

Conanap marked 2 inline comments as done. Conanap added a comment. Addressed Anil's comments with regards to the test cases Comment at: llvm/test/CodeGen/PowerPC/p10-vsx-builtins.ll:56 + +; CHECK: lxvrdx +; Function Attrs: norecurse nounwind readonly anil9 wrot

[PATCH] D83053: [clang-tidy] OptionsView::store specialized on bool

njames93 created this revision. njames93 added reviewers: aaron.ballman, alexfh, gribozavr2. Herald added subscribers: cfe-commits, arphaman, kbarton, xazax.hun, nemanjai. Herald added a project: clang. njames93 marked an inline comment as done. njames93 added inline comments. Herald added a subscr

[PATCH] D83048: [LiveDebugValues] 3/4 Add Xclang and CodeGen options for using instr-ref variable locations

djtodoro added a comment. Please add a test case for the Driver option (you can take a look into existing ones within `clang/test/Driver/`). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83048/new/ https://reviews.llvm.org/D83048 __

[PATCH] D83053: [clang-tidy] OptionsView::store specialized on bool

njames93 marked an inline comment as done. njames93 added inline comments. Herald added a subscriber: wuzish. Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/ProBoundsConstantArrayIndexCheck.cpp:31 Options.store(Opts, "GslHeader", GslHeader); - Options.store(Opts,

[PATCH] D82085: [TRE] allow TRE for non-capturing calls.

avl updated this revision to Diff 275123. avl added a comment. rebased. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82085/new/ https://reviews.llvm.org/D82085 Files: llvm/lib/Transforms/Scalar/TailRecursionElimination.cpp llvm/test/Transform

[PATCH] D82502: [PowerPC][Power10] Implement Load VSX Vector and Sign Extend and Zero Extend

Conanap added a comment. Addressed Lei's comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82502/new/ https://reviews.llvm.org/D82502 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:

[PATCH] D79719: [AIX] Implement AIX special alignment rule about double/long double

Xiangling_L marked an inline comment as done. Xiangling_L added inline comments. Comment at: clang/test/Layout/aix-double-struct-member.cpp:1 +// RUN: %clang_cc1 -emit-llvm-only -triple powerpc-ibm-aix-xcoff \ +// RUN: -fdump-record-layouts -fsyntax-only %s 2>/dev/null | \ --

[PATCH] D82502: [PowerPC][Power10] Implement Load VSX Vector and Sign Extend and Zero Extend

Conanap updated this revision to Diff 275124. Conanap marked 4 inline comments as done. Conanap added a comment. Fixed some formatting stuff. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82502/new/ https://reviews.llvm.org/D82502 Files: clang/l

[PATCH] D82677: [Clang] Handle AIX Include management in the driver

daltenty accepted this revision. daltenty added a comment. This revision is now accepted and ready to land. LGTM other than minor nit Comment at: clang/test/Driver/aix-toolchain-include.cpp:13 + +// Check powerpc-ibm-aix, 64-bit. +// RUN: %clangxx -### -no-canonical-prefixes %s

[PATCH] D82948: [Driver][ARM] Disable unsupported features when nofp arch extension is used

chill added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/ARM.cpp:292-297 + auto checkFPDisabledInArchName = [](const StringRef &ArchName) { +SmallVector Split; +ArchName.split(Split, '+', -1, false); +return llvm::any_of( +Split, [](const Str

[PATCH] D83055: [clang][Driver] Fix tool path priority test failure

DavidSpickett created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This test can fail when the path of the build includes the strings we're checking for. E.g "/gcc" is found in ".../gcc_7.3.0/..." To correct this look for '"' on the end of all matches. So

[PATCH] D83055: [clang][Driver] Fix tool path priority test failure

DavidSpickett updated this revision to Diff 275138. DavidSpickett added a comment. - Added check for alternate gcc names in the first test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83055/new/ https://reviews.llvm.org/D83055 Files: clang/tes

[PATCH] D82677: [Clang] Handle AIX Include management in the driver

hubert.reinterpretcast added inline comments. Comment at: clang/lib/Driver/ToolChains/AIX.cpp:179 + } + addSystemInclude(DriverArgs, CC1Args, "/usr/include"); +} This does not observe `--sysroot`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D82677: [Clang] Handle AIX Include management in the driver

hubert.reinterpretcast added inline comments. Comment at: clang/lib/Driver/ToolChains/AIX.cpp:172 +return; + + const Driver &D = getDriver(); Please investigate the handling of `OPT_nostdlibinc`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[PATCH] D82964: [clangd] Config: loading and caching config from disk.

sammccall marked 15 inline comments as done. sammccall added inline comments. Comment at: clang-tools-extra/clangd/ConfigProvider.cpp:39 +std::vector &Out) { +assert(llvm::sys::path::is_absolute(Path)); +auto FS = TFS.view(/*CWD=*/llvm::None);

[PATCH] D82964: [clangd] Config: loading and caching config from disk.

sammccall updated this revision to Diff 275146. sammccall marked 5 inline comments as done. sammccall added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82964/new/ https://reviews.llvm.org/D82964 Files: clang-tools-e

[PATCH] D78478: [UpdateTestChecks] Add UTC_ARGS support for update_{llc,cc}_test_checks.py

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. Nice cleanup again! I think eventually we need to teach the common logic to recognize top-level entities, e.g., functions, and with these changes it will be accessible w/o duplication i

[PATCH] D82659: Fix missing build dependency on omp_gen.

jdoerfert added a comment. Thank you both for figuring this out! *Much* appreciated! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82659/new/ https://reviews.llvm.org/D82659 ___ cfe-commits mailing li

[PATCH] D83057: [OpenMP][NFC] Remove hard-coded line numbers from more tests

jdenny created this revision. jdenny added reviewers: ABataev, jdoerfert, hfinkel, grokos, sfantao, Hahnfeld. Herald added subscribers: cfe-commits, sstefan1, guansong, yaxunl. Herald added a project: clang. This is a continuation of D82224 . Repository: rG LLV

[PATCH] D50229: [ARM][AArch64] Add feature +fp16fml

SjoerdMeijer marked an inline comment as done. SjoerdMeijer added inline comments. Comment at: test/Driver/aarch64-cpus.c:518 +// RUN: %clang -target aarch64 -march=armv8.4-a -### -c %s 2>&1 | FileCheck -check-prefix=GENERICV84A-NO-FP16FML %s +// GENERICV84A-NO-FP16FML-NOT: "-ta

[PATCH] D82502: [PowerPC][Power10] Implement Load VSX Vector and Sign Extend and Zero Extend

lei added inline comments. Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.h:487 +/// Allows utilization of the Load VSX Vector Rightmost Instructions. +LXVRZX + missing `,`? Comment at: llvm/lib/Target/PowerPC/PPCInstrPrefix.td:220

[PATCH] D75740: [ASTImporter] Corrected import of repeated friend declarations.

martong added a comment. Ping :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75740/new/ https://reviews.llvm.org/D75740 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[PATCH] D78478: [UpdateTestChecks] Add UTC_ARGS support for update_{llc,cc}_test_checks.py

MaskRay added subscribers: xbolva00, greened, spatel, lebedev.ri. MaskRay added a comment. The idea look good to me, but I want some opinions on the name `UTC_ARGS` (I can't help associating it with Coordinated Universal Time). Adding some folks who may have opinions: @greened @lebedev.ri @RKSi

[PATCH] D83061: [OpenMP] Implement TR8 `present` map type modifier in Clang (1/2)

jdenny created this revision. jdenny added reviewers: ABataev, jdoerfert, hfinkel, Meinersbur, kkwli0, grokos, sfantao, gtbercea. Herald added subscribers: cfe-commits, sstefan1, guansong, yaxunl. Herald added a project: clang. jdenny added a parent revision: D83057: [OpenMP][NFC] Remove hard-code

[PATCH] D78478: [UpdateTestChecks] Add UTC_ARGS support for update_{llc,cc}_test_checks.py

xbolva00 added a comment. >> UTC_ARGS (I can't help associating it with Coordinated Universal Time). Me too. Any suggestions for new name? TCU_ARGS? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78478/new/ https://reviews.llvm.org/D78478 __

[PATCH] D79719: [AIX] Implement AIX special alignment rule about double/long double

hubert.reinterpretcast added inline comments. Comment at: clang/test/Layout/aix-double-struct-member.cpp:1 +// RUN: %clang_cc1 -emit-llvm-only -triple powerpc-ibm-aix-xcoff \ +// RUN: -fdump-record-layouts -fsyntax-only %s 2>/dev/null | \ Xiangling_L wrote: >

[PATCH] D82999: [CodeGen] Check the cleanup flag before destructing temporaries created in conditional expressions

rjmccall added a comment. Please adjust the commit message to be clear that this is about lifetime-extended temporaries; it's not like we got this wrong for all temporaries. Do we need to do anything to ensure that the after-full-expression cleanup is configured conditionally? Repository:

[PATCH] D83013: [LPM] Port CGProfilePass from NPM to LPM

zequanwu updated this revision to Diff 275160. zequanwu marked 7 inline comments as done. zequanwu added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D83013: [LPM] Port CGProfilePass from NPM to LPM

zequanwu updated this revision to Diff 275161. zequanwu added a comment. update. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83013/new/ https://reviews.llvm.org/D83013 Files: clang/lib/CodeGen/BackendUtil.cpp llvm/include/llvm/InitializePass

  1   2   >