chill added inline comments.
================
Comment at: clang/lib/Driver/ToolChains/Arch/ARM.cpp:292-297
+ auto checkFPDisabledInArchName = [](const StringRef &ArchName) {
+ SmallVector<StringRef, 8> Split;
+ ArchName.split(Split, '+', -1, false);
+ return llvm::any_of(
+ Split, [](const StringRef &Extension) { return Extension == "nofp"; });
+ };
----------------
chill wrote:
> Wouldn't just looking for the substring do the job?
>
> Also need to handle `-mcpu=...+nofp`.
>
> We already "parse" the arguments to `-march=` and `-mcpu=` (and `-mfpu=`)
> earlier, it seems to me we
> could note the `+nofp` and `+nofp.dp` earlier. (TBH, it isn't immediately
> obvious to me how to untangle this mess).
>
Hmm, actually, `+nofp.dp` should not disable the FPU, I think.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D82948/new/
https://reviews.llvm.org/D82948
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
