[PATCH] D81912: [AST] Dump containsErrors bit for the Type.

hokein created this revision. hokein added a reviewer: sammccall. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D81912 Files: clang/lib/AST/JSONNodeDumper.cpp clang/lib/AST/TextNodeDumper.cpp Index: clang/lib/AST/TextNodeDumper.cpp ==

[PATCH] D81913: [AST][RecoveryExpr] Fix a crash on a field decl with invalid type.

hokein created this revision. hokein added a reviewer: sammccall. Herald added a project: clang. The field decl (in the testcase) was still valid, which results in a valid RecordDecl, it led to crash when performing struct layout, and computing struct size etc. Repository: rG LLVM Github Monor

[clang] e00dcf6 - NFC: cleanup the "(void)" case trick since the assertion is wrapped in NDEBUG.

Author: Haojian Wu Date: 2020-06-16T09:46:29+02:00 New Revision: e00dcf61a2f4397c0525db7133503b80d8ecf5ac URL: https://github.com/llvm/llvm-project/commit/e00dcf61a2f4397c0525db7133503b80d8ecf5ac DIFF: https://github.com/llvm/llvm-project/commit/e00dcf61a2f4397c0525db7133503b80d8ecf5ac.diff LO

[PATCH] D81785: [clangd] Fix readability-else-after-return 'Adding a note without main diagnostic' crash

hokein accepted this revision. hokein added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clang-tidy/readability/ElseAfterReturnCheck.cpp:191 // scope, we can pull the decl out of the if statement. - DiagnosticBuilder

[PATCH] D81407: [Analyzer][StreamChecker] Add note tags for file opening.

balazske updated this revision to Diff 270974. balazske added a comment. - Rebase - Added check for checker in NoteTag function. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81407/new/ https://reviews.llvm.org/D81407 Files: clang/lib/StaticAnal

[PATCH] D75453: [Driver][ARM] parse version of arm/thumb architecture correctly

danielkiss accepted this revision. danielkiss added a comment. Sorry for the delay, it is okay to say "ping" after a while :) LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75453/new/ https://reviews.llvm.org/D75453 ___ cfe-commits mai

[PATCH] D80279: [libclang] Extend clang_Cursor_Evaluate().

ckandeler added a comment. A kind reminder that I need someone with commit rights to merge this for me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80279/new/ https://reviews.llvm.org/D80279 ___ cfe-

[PATCH] D81304: [llvm][SveEmitter] Emit the bfloat version of `svld1ro`.

sdesmalen added inline comments. Comment at: clang/test/CodeGen/aarch64-sve-intrinsics/acle_sve_ld1ro-bfloat.c:1 +// RUN: %clang_cc1 -D__ARM_FEATURE_SVE_MATMUL_FP64 -D__ARM_FEATURE_BF16_SCALAR_ARITHMETIC -D__ARM_FEATURE_SVE -triple aarch64-none-linux-gnu -target-feature +sve -t

[PATCH] D81912: [AST] Dump containsErrors bit for the Type.

sammccall added a comment. Can we add a test at least for the text dump? Comment at: clang/lib/AST/TextNodeDumper.cpp:205 + if (T->containsErrors()) +OS << " contains-errors"; IIRC in the expr case we used a color, does that make sense here? Repository

[PATCH] D81304: [llvm][SveEmitter] Emit the bfloat version of `svld1ro`.

sdesmalen accepted this revision. sdesmalen added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/include/clang/Basic/AArch64SVEACLETypes.def:44 #define SVE_VECTOR_TYPE(Name, MangledName, Id, SingletonId, NumEls, ElBits, \ -

[clang-tools-extra] 3725142 - [clangd] Make sure working directory is set during preamble validation

Author: Kadir Cetinkaya Date: 2020-06-16T11:06:41+02:00 New Revision: 3725142449af1b061b81cbacf81f64aaa5428250 URL: https://github.com/llvm/llvm-project/commit/3725142449af1b061b81cbacf81f64aaa5428250 DIFF: https://github.com/llvm/llvm-project/commit/3725142449af1b061b81cbacf81f64aaa5428250.dif

[PATCH] D81737: docker images for mlir-nvidia

kuhnel added inline comments. Comment at: buildbot/google/docker/build_deploy.sh:36 + +docker build -t ${IMAGE_NAME}:latest -t ${IMAGE_NAME}:${VERSION} . + tra wrote: > What if I happen to run it in a tree I haven't updated for a while? We > probably don't want

[PATCH] D81737: docker images for mlir-nvidia

kuhnel updated this revision to Diff 270985. kuhnel added a comment. fixed last patch Repository: rZORG LLVM Github Zorg CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81737/new/ https://reviews.llvm.org/D81737 Files: buildbot/google/README.md buildbot/google/docker/README.md b

[PATCH] D81737: docker images for mlir-nvidia

kuhnel updated this revision to Diff 270984. kuhnel marked 3 inline comments as done. kuhnel added a comment. Herald added subscribers: cfe-commits, martong. Herald added a project: clang. improved tagging of images Repository: rZORG LLVM Github Zorg CHANGES SINCE LAST ACTION https://review

[clang-tools-extra] 068fa35 - [clang-tidy] For `run-clang-tidy.py` escape the paths that are used for analysis.

Author: Andi-Bogdan Postelnicu Date: 2020-06-16T12:21:18+03:00 New Revision: 068fa35746637fde29355a43d17d554a92b32cdf URL: https://github.com/llvm/llvm-project/commit/068fa35746637fde29355a43d17d554a92b32cdf DIFF: https://github.com/llvm/llvm-project/commit/068fa35746637fde29355a43d17d554a92b32

[PATCH] D81718: [Analyzer][NFC] Add methods `getReturnObject()` and `getArgObject()` to `CallEvent`

NoQ added a comment. > Let me explain! An iterator may be implemented by multiple ways. It can be a > simple pointer... Let's cover this with tests then, for once. Hint: they don't work, for the exact reason i described above, and your last update to this patch is insufficient to fix that. `/

[PATCH] D81916: [analyzer] Fix StdLibraryFunctionsChecker crash on macOS

vsavchenko created this revision. vsavchenko added reviewers: NoQ, xazax.hun, Szelethus. Herald added subscribers: cfe-commits, ASDenysPetrov, martong, Charusso, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware. Herald added a project: clang. vsavchenko added a

[PATCH] D81917: [clang-tidy] For `run-clang-tidy.py` escape the paths that are used for analysis.

Abpostelnicu created this revision. Abpostelnicu added a reviewer: sylvestre.ledru. Herald added subscribers: cfe-commits, xazax.hun. Herald added a project: clang. Abpostelnicu edited reviewers, added: JonasToth; removed: sylvestre.ledru. Some paths can have special chars like `file++c.cpp` in th

[PATCH] D81917: [clang-tidy] For `run-clang-tidy.py` escape the paths that are used for analysis.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG068fa3574663: [clang-tidy] For `run-clang-tidy.py` escape the paths that are used for… (authored by Andi-Bogdan Postelnicu

[PATCH] D81916: [analyzer] Fix StdLibraryFunctionsChecker crash on macOS

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Thanks! @martong, thoughts on this? :) Also i guess in this test we're unable to obtain the value for `EOF`, what would be a good fixme-test to demonstrate that? Comment at: cla

[clang] 28923dc - [AST][RecoveryExpr] Fix a crash on a field decl with invalid type.

Author: Haojian Wu Date: 2020-06-16T12:12:10+02:00 New Revision: 28923dc2dda46610e5b6ee73bf046d2bb78a1a77 URL: https://github.com/llvm/llvm-project/commit/28923dc2dda46610e5b6ee73bf046d2bb78a1a77 DIFF: https://github.com/llvm/llvm-project/commit/28923dc2dda46610e5b6ee73bf046d2bb78a1a77.diff LO

[PATCH] D81916: [analyzer] Fix StdLibraryFunctionsChecker crash on macOS

NoQ added inline comments. Comment at: clang/test/Analysis/pch_crash.cpp:21 + // we need a function call here to initiate erroneous routine + return foo(); +} NoQ wrote: > Let's add sone comment like `// no-crash` so that to indicate what is it that > we're te

[PATCH] D80025: [ASTMatcher] Correct memoization bug ignoring direction (descendants or ancestors)

klimek accepted this revision. klimek added a comment. This revision is now accepted and ready to land. LG. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80025/new/ https://reviews.llvm.org/D80025 ___ cfe-commits mailing list cfe-co

[PATCH] D81916: [analyzer] Fix StdLibraryFunctionsChecker crash on macOS

vsavchenko updated this revision to Diff 271005. vsavchenko added a comment. Fix review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81916/new/ https://reviews.llvm.org/D81916 Files: clang/lib/StaticAnalyzer/Core/CheckerHelpers.cpp c

[PATCH] D81407: [Analyzer][StreamChecker] Add note tags for file opening.

balazske updated this revision to Diff 271007. balazske marked an inline comment as done. balazske added a comment. - Re-added the location uniqueing feature. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81407/new/ https://reviews.llvm.org/D81407

[PATCH] D72705: [analyzer] Added new checker 'alpha.unix.ErrorReturn'.

NoQ added a comment. Sounds like we have a feature request! https://bugs.llvm.org/show_bug.cgi?id=46346 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72705/new/ https://reviews.llvm.org/D72705 ___ cfe

[PATCH] D81916: [analyzer] Fix StdLibraryFunctionsChecker crash on macOS

vsavchenko marked 5 inline comments as done. vsavchenko added inline comments. Comment at: clang/test/Analysis/pch_crash.cpp:1 +// RUN: %clang_cc1 -triple x86_64-apple-macosx10.15.0 -emit-pch -o %t %s +// RUN: %clang_analyze_cc1 -triple x86_64-apple-macosx10.15.0 -include-pch %t

[PATCH] D81642: [analyzer] CmpRuns.py: Fix error due to statistics differences

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Aha, that probably broke when i added timers for visitors! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81642/new/ https://reviews.llvm.org/D81642

[PATCH] D80517: [analyzer] CmpRuns.py: Refactor and add type annotations

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Thanks! Please mark as "NFC:" ("no functional change intended "). In D80517#2068336 , @NoQ wrot

[PATCH] D79796: Sketch support for generating CC1 command line from CompilerInvocation

dang updated this revision to Diff 271006. dang marked 5 inline comments as done and an inline comment as not done. dang added a comment. Implement suffix merging to avoid allocations for option spelling when generating the command line. This update also removes unnecessary allocation for `std::

[PATCH] D81569: [analyzer] SATest: Add option to specify projects to test

vsavchenko updated this revision to Diff 271010. vsavchenko added a comment. Fix typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81569/new/ https://reviews.llvm.org/D81569 Files: clang/utils/analyzer/ProjectMap.py clang/utils/analyzer/SATes

[PATCH] D80517: [analyzer] CmpRuns.py: Refactor and add type annotations

vsavchenko updated this revision to Diff 271012. vsavchenko added a comment. Mark as NFC Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80517/new/ https://reviews.llvm.org/D80517 Files: clang/utils/analyzer/CmpRuns.py clang/utils/analyzer/SATes

[PATCH] D81913: [AST][RecoveryExpr] Fix a crash on a field decl with invalid type.

This revision was automatically updated to reflect the committed changes. Closed by commit rG28923dc2dda4: [AST][RecoveryExpr] Fix a crash on a field decl with invalid type. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81913/ne

[clang] 4a606e0 - [analyzer] CmpRuns.py: Fix error due to statistics differences

Author: Valeriy Savchenko Date: 2020-06-16T13:30:00+03:00 New Revision: 4a606e0a8c8f196832049c9a6c297589dacedb04 URL: https://github.com/llvm/llvm-project/commit/4a606e0a8c8f196832049c9a6c297589dacedb04 DIFF: https://github.com/llvm/llvm-project/commit/4a606e0a8c8f196832049c9a6c297589dacedb04.d

[clang] fb4b565 - [analyzer] SATest: Move from csv to json project maps

Author: Valeriy Savchenko Date: 2020-06-16T13:30:00+03:00 New Revision: fb4b565212b0158e2b41ffec71a7c4282907cda9 URL: https://github.com/llvm/llvm-project/commit/fb4b565212b0158e2b41ffec71a7c4282907cda9 DIFF: https://github.com/llvm/llvm-project/commit/fb4b565212b0158e2b41ffec71a7c4282907cda9.d

[clang] bbb8f17 - [analyzer] SATest: Add posibility to download source from git and zip

Author: Valeriy Savchenko Date: 2020-06-16T13:30:00+03:00 New Revision: bbb8f171364b78c6290fcdbf48b214a870dd1caf URL: https://github.com/llvm/llvm-project/commit/bbb8f171364b78c6290fcdbf48b214a870dd1caf DIFF: https://github.com/llvm/llvm-project/commit/bbb8f171364b78c6290fcdbf48b214a870dd1caf.d

[clang] d9944da - [analyzer] SATest: Introduce a single entrypoint for regression scripts

Author: Valeriy Savchenko Date: 2020-06-16T13:30:01+03:00 New Revision: d9944da273c42846947b028c02b7a59880ca50ed URL: https://github.com/llvm/llvm-project/commit/d9944da273c42846947b028c02b7a59880ca50ed DIFF: https://github.com/llvm/llvm-project/commit/d9944da273c42846947b028c02b7a59880ca50ed.d

[clang] dc8a77d - [analyzer] ProjectMap: Do not serialize fields with default values

Author: Valeriy Savchenko Date: 2020-06-16T13:30:01+03:00 New Revision: dc8a77de7db71dc52b0c75b3bb5437d9ae0ccc8c URL: https://github.com/llvm/llvm-project/commit/dc8a77de7db71dc52b0c75b3bb5437d9ae0ccc8c DIFF: https://github.com/llvm/llvm-project/commit/dc8a77de7db71dc52b0c75b3bb5437d9ae0ccc8c.d

[clang] 38b455e - [analyzer] SATest: Add option to specify projects to test

Author: Valeriy Savchenko Date: 2020-06-16T13:30:01+03:00 New Revision: 38b455e91a63cc20c24b19ab4f469f7c6c60db44 URL: https://github.com/llvm/llvm-project/commit/38b455e91a63cc20c24b19ab4f469f7c6c60db44 DIFF: https://github.com/llvm/llvm-project/commit/38b455e91a63cc20c24b19ab4f469f7c6c60db44.d

[clang] 98f737f - [analyzer] CmpRuns.py: Refactor and add type annotations. NFC.

Author: Valeriy Savchenko Date: 2020-06-16T13:29:46+03:00 New Revision: 98f737f4bfc79acac31d899886ad6b5d44396bde URL: https://github.com/llvm/llvm-project/commit/98f737f4bfc79acac31d899886ad6b5d44396bde DIFF: https://github.com/llvm/llvm-project/commit/98f737f4bfc79acac31d899886ad6b5d44396bde.d

[clang] 35dd014 - [analyzer] CmpRuns.py: Decouple main functionality from argparse

Author: Valeriy Savchenko Date: 2020-06-16T13:30:01+03:00 New Revision: 35dd0147cdd0b8a145592d895d0a64eedb397917 URL: https://github.com/llvm/llvm-project/commit/35dd0147cdd0b8a145592d895d0a64eedb397917 DIFF: https://github.com/llvm/llvm-project/commit/35dd0147cdd0b8a145592d895d0a64eedb397917.d

[clang] 4a7b3d4 - [analyzer] SATestAdd.py: Parse arguments with argparse

Author: Valeriy Savchenko Date: 2020-06-16T13:30:00+03:00 New Revision: 4a7b3d406f1eca8c9bb8091f92da55ff2c72ab44 URL: https://github.com/llvm/llvm-project/commit/4a7b3d406f1eca8c9bb8091f92da55ff2c72ab44 DIFF: https://github.com/llvm/llvm-project/commit/4a7b3d406f1eca8c9bb8091f92da55ff2c72ab44.d

[PATCH] D81920: [clangd] Change FSProvider::getFileSystem to take CurrentWorkingDirectory

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. We've faced a couple of problems when the returned FS didn't have the proper working directory. New sig

[PATCH] D81564: [analyzer] SATest: Add posibility to download source from git and zip

This revision was automatically updated to reflect the committed changes. Closed by commit rGbbb8f171364b: [analyzer] SATest: Add posibility to download source from git and zip (authored by vsavchenko). Changed prior to commit: https://reviews.llvm.org/D81564?vs=269814&id=271027#toc Repository

[PATCH] D80517: [analyzer] CmpRuns.py: Refactor and add type annotations

This revision was automatically updated to reflect the committed changes. Closed by commit rG98f737f4bfc7: [analyzer] CmpRuns.py: Refactor and add type annotations. NFC. (authored by vsavchenko). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80517/ne

[PATCH] D81565: [analyzer] SATestAdd.py: Parse arguments with argparse

This revision was automatically updated to reflect the committed changes. Closed by commit rG4a7b3d406f1e: [analyzer] SATestAdd.py: Parse arguments with argparse (authored by vsavchenko). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81565/new/ http

[PATCH] D81567: [analyzer] SATest: Introduce a single entrypoint for regression scripts

This revision was automatically updated to reflect the committed changes. Closed by commit rGd9944da273c4: [analyzer] SATest: Introduce a single entrypoint for regression scripts (authored by vsavchenko). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D81642: [analyzer] CmpRuns.py: Fix error due to statistics differences

This revision was automatically updated to reflect the committed changes. Closed by commit rG4a606e0a8c8f: [analyzer] CmpRuns.py: Fix error due to statistics differences (authored by vsavchenko). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81642/ne

[PATCH] D81569: [analyzer] SATest: Add option to specify projects to test

This revision was automatically updated to reflect the committed changes. Closed by commit rG38b455e91a63: [analyzer] SATest: Add option to specify projects to test (authored by vsavchenko). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81569/new/ h

[PATCH] D81563: [analyzer] SATest: Move from csv to json project maps

This revision was automatically updated to reflect the committed changes. Closed by commit rGfb4b565212b0: [analyzer] SATest: Move from csv to json project maps (authored by vsavchenko). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81563/new/ https

[PATCH] D81568: [analyzer] ProjectMap: Do not serialize fields with default values

This revision was automatically updated to reflect the committed changes. Closed by commit rGdc8a77de7db7: [analyzer] ProjectMap: Do not serialize fields with default values (authored by vsavchenko). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D8156

[PATCH] D81566: [analyzer] CmpRuns.py: Decouple main functionality from argparse

This revision was automatically updated to reflect the committed changes. Closed by commit rG35dd0147cdd0: [analyzer] CmpRuns.py: Decouple main functionality from argparse (authored by vsavchenko). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81566/

[clang-tools-extra] 740575d - [clangd] Fix readability-else-after-return 'Adding a note without main diagnostic' crash

Author: njames93 Date: 2020-06-16T12:01:56+01:00 New Revision: 740575dc232b25de0a4bedb41e825ee2e5a056ea URL: https://github.com/llvm/llvm-project/commit/740575dc232b25de0a4bedb41e825ee2e5a056ea DIFF: https://github.com/llvm/llvm-project/commit/740575dc232b25de0a4bedb41e825ee2e5a056ea.diff LOG:

Re: [clang] e4b3fc1 - Get rid of -Wunused warnings in release build, NFC.

On Mon, 15 Jun 2020 at 18:29, David Blaikie wrote: > I don't think the comment's adding value here - it should be fairly > clear from the context that the whole loop only exists for some > assertions. > > Also: Could you remove the "(void)" casts now that the whole thing's > wrapped in NDEBUG? >

[PATCH] D81422: Change filecheck default to dump input on failure

aeubanks added a comment. FWIW I didn't see this change initially but was pleasantly surprised with the extra output when debugging a newly added (relatively small) test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81422/new/ https://reviews.llv

[PATCH] D81422: Change filecheck default to dump input on failure

mehdi_amini added a comment. In D81422#2093360 , @arsenm wrote: > The amount of context printed previously was good enough for development use. > If I ever can't figure it out from the diff, I want to look at the output > completely separate from the ter

[PATCH] D81422: Change filecheck default to dump input on failure

jdenny added a comment. Perhaps llvm-dev is the right place to discuss the default behavior. Regardless of that default, perhaps there should be an option that limits the dump to N lines that always encloses the first error. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[PATCH] D80961: Ignore template instantiations if not in AsIs mode

klimek added a comment. In D80961#2090216 , @steveire wrote: > In D80961#2079419 , @aaron.ballman > wrote: > > > In D80961#2079044 , @klimek wrote: > > > > > In D80961#20762

[PATCH] D81923: [clang-tidy] Add modernize-use-ranges check.

njames93 created this revision. njames93 added reviewers: aaron.ballman, alexfh, gribozavr2. Herald added subscribers: cfe-commits, mgrang, xazax.hun, mgorny. Herald added a project: clang. Flags and replaces calls to standard library algorithms that could be converted to use the `std::ranges` al

[PATCH] D80712: [SVE] Add checks for no warnings in SVE tests

david-arm added a comment. Hi @sdesmalen @efriedma , hopefully I've addressed your review comments with my latest patch! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80712/new/ https://reviews.llvm.org/D80712 ___ cfe-commits mailing list

[PATCH] D81785: [clangd] Fix readability-else-after-return 'Adding a note without main diagnostic' crash

This revision was automatically updated to reflect the committed changes. Closed by commit rG740575dc232b: [clangd] Fix readability-else-after-return 'Adding a note without main… (authored by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D8

[clang] ccd8b7b - [LSan] Enable for SystemZ

Author: Ilya Leoshkevich Date: 2020-06-16T13:45:29+02:00 New Revision: ccd8b7b103470beb79140ecf9d6ccfaddf7fbc11 URL: https://github.com/llvm/llvm-project/commit/ccd8b7b103470beb79140ecf9d6ccfaddf7fbc11 DIFF: https://github.com/llvm/llvm-project/commit/ccd8b7b103470beb79140ecf9d6ccfaddf7fbc11.di

[PATCH] D81923: [clang-tidy] Add modernize-use-ranges check.

JonasToth added a comment. great to see such a check! Comment at: clang-tools-extra/clang-tidy/modernize/UseRangesCheck.cpp:77 + MatchCallTo((ID + "Begin").str(), namedDecl().bind(Range), + hasAnyName("::std::begin", "::std::cbegin"

[PATCH] D81912: [AST] Dump containsErrors bit for the Type.

hokein updated this revision to Diff 271045. hokein marked an inline comment as done. hokein added a comment. add tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81912/new/ https://reviews.llvm.org/D81912 Files: clang/lib/AST/JSONNodeDumper

[PATCH] D81912: [AST] Dump containsErrors bit for the Type.

hokein added inline comments. Comment at: clang/lib/AST/TextNodeDumper.cpp:205 + if (T->containsErrors()) +OS << " contains-errors"; sammccall wrote: > IIRC in the expr case we used a color, does that make sense here? yeah, in the expr we use a color, but

[PATCH] D81718: [Analyzer][NFC] Add methods `getReturnObject()` and `getArgObject()` to `CallEvent`

baloghadamsoftware added a comment. In D81718#2095043 , @NoQ wrote: > So it still thinks that the iterator is an object, whereas it should be > tracking the iterator as symbol instead. As expected, because your code fails > to discriminate between these

[PATCH] D81336: [clang-tidy] simplify-bool-expr ignores template instantiations

njames93 updated this revision to Diff 271047. njames93 added a comment. Removed `isExpansionInMainFile` check as per original authors comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81336/new/ https://reviews.llvm.org/D81336 Files: clang-

[PATCH] D78644: [LSan] Enable for SystemZ

This revision was automatically updated to reflect the committed changes. Closed by commit rGccd8b7b10347: [LSan] Enable for SystemZ (authored by iii). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78644/new/ https://reviews.llvm.org/D78644 Files:

[PATCH] D81336: [clang-tidy] simplify-bool-expr ignores template instantiations

lebedev.ri accepted this revision. lebedev.ri added a comment. This revision is now accepted and ready to land. LG, unless @aaron.ballman has concerns. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81336/new/ https://reviews.llvm.org/D81336

[PATCH] D81336: [clang-tidy] simplify-bool-expr ignores template instantiations

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81336/new/ https://reviews.llvm.org/D81336 ___ cfe-commits mailing list cfe-comm

[PATCH] D81543: [CodeGen][TLS] Set TLS Model for __tls_guard as well.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81543/new/ https://reviews.llvm.org/D81543 ___ cfe-commits mai

[PATCH] D81930: [AArch64] Add -mbti flag.

danielkiss created this revision. danielkiss added reviewers: nsz, tamas.petz, pbarrio, ostannard, chill. Herald added subscribers: llvm-commits, cfe-commits, hiraditya, kristof.beyls. Herald added projects: clang, LLVM. Writing the .note.gnu.property manually is error prone and hard to maintain i

[PATCH] D81552: [ASTMatchers] Added hasDirectBase and hasClass Matchers

aaron.ballman added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:3553 +/// \endcode +AST_MATCHER_P(CXXBaseSpecifier, hasClass, internal::Matcher, + InnerMatcher) { sammccall wrote: > aaron.ballman wrote: > > jkorous wrot

[clang-tools-extra] e1ba724 - [clang-tidy] simplify-bool-expr ignores template instantiations

Author: Nathan James Date: 2020-06-16T13:54:48+01:00 New Revision: e1ba7241c3efc3a36439a6f80a7367c26cc193b1 URL: https://github.com/llvm/llvm-project/commit/e1ba7241c3efc3a36439a6f80a7367c26cc193b1 DIFF: https://github.com/llvm/llvm-project/commit/e1ba7241c3efc3a36439a6f80a7367c26cc193b1.diff

[PATCH] D81881: [OPENMP]Fix overflow during counting the number of iterations.

ABataev added a comment. In D81881#2094062 , @jdoerfert wrote: > So the idea is to do the trip count computation with defined overflow > behavior, e.g., without `nsw/nuw` in IR, right? Not quite. If we can predict that there is no overflow, everything r

[PATCH] D81932: [clang-tidy] Improved accuracy of check list updater script

njames93 created this revision. njames93 added reviewers: aaron.ballman, gribozavr2, Eugene.Zelenko. Herald added subscribers: cfe-commits, xazax.hun. Herald added a project: clang. - Added a file `FixItHint` comments to Check files to for the script to mark those checks as offering fix-its when

[PATCH] D81923: [clang-tidy] Add modernize-use-ranges check.

njames93 marked an inline comment as done. njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/UseRangesCheck.cpp:77 + MatchCallTo((ID + "Begin").str(), namedDecl().bind(Range), + hasAnyName("::std::begi

[PATCH] D79972: [OpenMP5.0] map item can be non-contiguous for target update

ABataev added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:7834 +llvm::APInt Size = CAT->getSize(); +SizeV = llvm::ConstantInt::get(CGF.SizeTy, Size); + } else if (VAT) { cchen wrote: > ABataev wrote: > > cch

[PATCH] D81916: [analyzer] Fix StdLibraryFunctionsChecker crash on macOS

martong added a comment. In D81916#2095106 , @NoQ wrote: > Thanks! > > @martong, thoughts on this? :) > > Also i guess in this test we're unable to obtain the value for `EOF`, what > would be a good fixme-test to demonstrate that? I accept this as a ver

[PATCH] D81336: [clang-tidy] simplify-bool-expr ignores template instantiations

This revision was automatically updated to reflect the committed changes. Closed by commit rGe1ba7241c3ef: [clang-tidy] simplify-bool-expr ignores template instantiations (authored by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81336/new

[clang] 14b947f - [analyzer] Fix StdLibraryFunctionsChecker crash on macOS

Author: Valeriy Savchenko Date: 2020-06-16T16:10:07+03:00 New Revision: 14b947f306ac7bc2e4eb55ac1e4255fd762b217b URL: https://github.com/llvm/llvm-project/commit/14b947f306ac7bc2e4eb55ac1e4255fd762b217b DIFF: https://github.com/llvm/llvm-project/commit/14b947f306ac7bc2e4eb55ac1e4255fd762b217b.d

[PATCH] D81916: [analyzer] Fix StdLibraryFunctionsChecker crash on macOS

vsavchenko marked 2 inline comments as done. vsavchenko added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/CheckerHelpers.cpp:131 const Token &T = FilteredTokens.back(); - if (!T.isLiteral()) + if (!T.isLiteral() || !T.getLiteralData()) return llvm::None;

[PATCH] D81932: [clang-tidy] Improved accuracy of check list updater script

Eugene.Zelenko added a comment. Looks OK for me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81932/new/ https://reviews.llvm.org/D81932 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:/

[PATCH] D80944: Add begin source location for the attributed statement created from PragmaLoopHint decorated loop

erichkeane added a comment. Note that this causes a regression (reported here) https://bugs.llvm.org/show_bug.cgi?id=46336 The assert added here breaks in the case where a pragma loop attribute is combined with a C++ attribute. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D81916: [analyzer] Fix StdLibraryFunctionsChecker crash on macOS

vsavchenko updated this revision to Diff 271073. vsavchenko added a comment. Add FIXME comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81916/new/ https://reviews.llvm.org/D81916 Files: clang/lib/StaticAnalyzer/Core/CheckerHelpers.cpp cla

[PATCH] D81923: [clang-tidy] Add modernize-use-ranges check.

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:149 + Converts calls to std library algorithms that take a pair of iterators to use + the equivalent function in std::ranges. + Please highlight std::ranges with double ba

[PATCH] D81916: [analyzer] Fix StdLibraryFunctionsChecker crash on macOS

This revision was automatically updated to reflect the committed changes. Closed by commit rG14b947f306ac: [analyzer] Fix StdLibraryFunctionsChecker crash on macOS (authored by vsavchenko). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81916/new/ ht

[PATCH] D79945: [Sema] Comparison of pointers to complete and incomplete types

pestctrl marked 5 inline comments as done. pestctrl added a comment. @rsmith @efriedma Any more comments? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79945/new/ https://reviews.llvm.org/D79945 ___ cf

[PATCH] D81719: [clangd] Drop usage of PreambleStatCache in scanPreamble

kadircet updated this revision to Diff 271083. kadircet marked 2 inline comments as done. kadircet added a comment. - Drop VFS usage in scanPreamble completely to avoid IO. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81719/new/ https://reviews.ll

[PATCH] D81719: [clangd] Drop usage of PreambleStatCache in scanPreamble

kadircet added a comment. In D81719#2092589 , @sammccall wrote: > Thanks for all this investigation! > > > 80.710.002330 5 394 374 openat > > I'm curious what the 400 attempts and 20 successes are (I've seen this before > but d

[clang] e830fa2 - [clang][amdgpu] Prefer not using `fp16` conversion intrinsics.

Author: Michael Liao Date: 2020-06-16T10:21:56-04:00 New Revision: e830fa260da9d3bbe99c4176b4ddb6aa5e6229dd URL: https://github.com/llvm/llvm-project/commit/e830fa260da9d3bbe99c4176b4ddb6aa5e6229dd DIFF: https://github.com/llvm/llvm-project/commit/e830fa260da9d3bbe99c4176b4ddb6aa5e6229dd.diff

cfe-commits@lists.llvm.org

Author: Luke Geeson Date: 2020-06-16T15:23:30+01:00 New Revision: 10b6567f49778f49ea81ff36269fc0fbc033d7ad URL: https://github.com/llvm/llvm-project/commit/10b6567f49778f49ea81ff36269fc0fbc033d7ad DIFF: https://github.com/llvm/llvm-project/commit/10b6567f49778f49ea81ff36269fc0fbc033d7ad.diff L

[PATCH] D81938: [SROA] Teach SROA to perform no-op pointer conversion.[InferAddressSpaces] Handle the pair of `ptrtoint`/`inttoptr`.

hliao created this revision. hliao added reviewers: arsenm, chandlerc. Herald added subscribers: llvm-commits, cfe-commits, kerbowa, hiraditya, nhaehnle, wdng, jvesely. Herald added projects: clang, LLVM. - When promoting a pointer from memory to register, SROA skips pointers from different addr

[PATCH] D81849: [clang][amdgpu] Prefer not using `fp16` conversion intrinsics.

This revision was automatically updated to reflect the committed changes. Closed by commit rGe830fa260da9: [clang][amdgpu] Prefer not using `fp16` conversion intrinsics. (authored by hliao). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81849/new/ h

cfe-commits@lists.llvm.org

This revision was automatically updated to reflect the committed changes. Closed by commit rG10b6567f4977: [AArch64]: BFloat MatMul Intrinsics&CodeGen (authored by LukeGeeson). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80752/new/ https://reviews

[PATCH] D81938: [SROA] Teach SROA to perform no-op pointer conversion.[InferAddressSpaces] Handle the pair of `ptrtoint`/`inttoptr`.

lebedev.ri added a comment. This should be two separate patches - inferaddressspace and SROA. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81938/new/ https://reviews.llvm.org/D81938 ___ cfe-commits ma

[PATCH] D81938: [SROA] Teach SROA to perform no-op pointer conversion.[InferAddressSpaces] Handle the pair of `ptrtoint`/`inttoptr`.

arsenm added a comment. Should be separate patches for each pass Comment at: llvm/test/Transforms/InferAddressSpaces/noop-ptrint-pair.ll:17 + ret void +} This is missing a number of test cases I would like to see. First, I would like to make sure if the inter

[PATCH] D81745: [analyzer][MallocChecker] PR46253: Correctly recognize standard realloc

martong added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/MallocChecker.cpp:1071-1072 bool ShouldFreeOnFail) const { + // HACK: CallDescription currently recognizes non-standard realloc functions + // as standard because it d

[PATCH] D81658: [OPENMP50]Codegen for scan directive in for simd regions.

ABataev updated this revision to Diff 271098. ABataev added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81658/new/ https://reviews.llvm.org/D81658 Files: clang/lib/CodeGen/CGStmtOpenMP.cpp clang/test/OpenMP/for_simd_scan_co

[PATCH] D81847: [ARM] Improve diagnostics message when Neon is unsupported

LukeGeeson accepted this revision. LukeGeeson added a comment. This revision is now accepted and ready to land. Very simple change, looks good to me. Please wait a week or so before submitting, so that non-arm folks have time to raise issues Repository: rG LLVM Github Monorepo CHANGES SINCE

  1   2   3   >