arsenm added a comment.

Should be separate patches for each pass



================
Comment at: llvm/test/Transforms/InferAddressSpaces/noop-ptrint-pair.ll:17
+  ret void
+}
----------------
This is missing a number of test cases I would like to see. First, I would like 
to make sure if the intermediate size is larger or smaller than the pointer 
size, this isn't done. I also want to stress the full combination of cases in a 
constant expression, not just instructions.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81938/new/

https://reviews.llvm.org/D81938



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to