NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land.
Thanks! @martong, thoughts on this? :) Also i guess in this test we're unable to obtain the value for `EOF`, what would be a good fixme-test to demonstrate that? ================ Comment at: clang/test/Analysis/pch_crash.cpp:1 +// RUN: %clang_cc1 -triple x86_64-apple-macosx10.15.0 -emit-pch -o %t %s +// RUN: %clang_analyze_cc1 -triple x86_64-apple-macosx10.15.0 -include-pch %t \ ---------------- Just curious - did you double-check that only macos triples are affected? Maybe we should add a pair of run-lines without the triple, so that to automatically get coverage from buildbots on all platforms on which we have buildbots. Because the test should obviously pass on all platforms. ================ Comment at: clang/test/Analysis/pch_crash.cpp:3 +// RUN: %clang_analyze_cc1 -triple x86_64-apple-macosx10.15.0 -include-pch %t \ +// RUN: -analyzer-checker=apiModeling -verify %s + ---------------- Can we enable `core` as well? Because we keep telling everybody that running without `core` is unsupported, so we tend to enable it on tests in order to demonstrate that. ================ Comment at: clang/test/Analysis/pch_crash.cpp:21 + // we need a function call here to initiate erroneous routine + return foo(); +} ---------------- Let's add sone comment like `// no-crash` so that to indicate what is it that we're testing for. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81916/new/ https://reviews.llvm.org/D81916 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
