[clang] 020815f - [analyzer] On-demand parsing capability for CTU

Author: Endre Fülöp Date: 2020-06-10T08:59:04+02:00 New Revision: 020815fafd15ddac0f2b5539e7766107d7b25ddc URL: https://github.com/llvm/llvm-project/commit/020815fafd15ddac0f2b5539e7766107d7b25ddc DIFF: https://github.com/llvm/llvm-project/commit/020815fafd15ddac0f2b5539e7766107d7b25ddc.diff L

[clang] a8fbbf8 - [SveEmitter] NFC: Add missing ACLE tests

Author: Sander de Smalen Date: 2020-06-10T08:29:34+01:00 New Revision: a8fbbf8fe251652847bd98a5800a27375e13b1f9 URL: https://github.com/llvm/llvm-project/commit/a8fbbf8fe251652847bd98a5800a27375e13b1f9 DIFF: https://github.com/llvm/llvm-project/commit/a8fbbf8fe251652847bd98a5800a27375e13b1f9.di

[PATCH] D75665: [analyzer] On-demand parsing capability for CTU

This revision was automatically updated to reflect the committed changes. Closed by commit rG020815fafd15: [analyzer] On-demand parsing capability for CTU (authored by gamesh411). Changed prior to commit: https://reviews.llvm.org/D75665?vs=269677&id=269749#toc Repository: rG LLVM Github Mono

[PATCH] D81538: [clangd] Disable new errs()-tie behavior, it's racy.

sammccall created this revision. sammccall added a reviewer: hokein. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D81538 Files: clang-tools-e

[PATCH] D81390: [KernelAddressSanitizer] Make globals constructors compatible with kernel [v2]

melver updated this revision to Diff 269751. melver added a comment. Fix typos. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81390/new/ https://reviews.llvm.org/D81390 Files: clang/test/CodeGen/asan-globals.cpp llvm/include/llvm/Transforms/Ut

[PATCH] D77062: [analyzer] Added check for unacceptable equality operation between Loc and NonLoc types

ASDenysPetrov added a comment. @NoQ, what do you think about my explanation? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77062/new/ https://reviews.llvm.org/D77062 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm

[clang] c640779 - Revert "[analyzer] On-demand parsing capability for CTU"

Author: Endre Fülöp Date: 2020-06-10T10:30:10+02:00 New Revision: c64077949448f70c017939aea9490aee3851321c URL: https://github.com/llvm/llvm-project/commit/c64077949448f70c017939aea9490aee3851321c DIFF: https://github.com/llvm/llvm-project/commit/c64077949448f70c017939aea9490aee3851321c.diff L

[PATCH] D81396: [clang-tidy] New util `Aliasing` factored out from `bugprone-infinite-loop`

njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/utils/Aliasing.cpp:17 + +/// Return whether `S` is a reference to the declaration of `Var`. +static bool isAccessForVar(const Stmt *S, const VarDecl *Var) { Ditto `\p `. C

[PATCH] D81530: [clangd] Log rather than assert on bad UTF-8.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. LGTM, thanks! (i bet you rushed it already for the cherry-pick, but just wanted to remind again that we should :D) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[PATCH] D81543: [CodeGen][TLS] Set TLS Model for __tls_guard as well.

junparser created this revision. junparser added reviewers: chh, rnk, aaron.ballman, rjmccall. Herald added a project: clang. Herald added a subscriber: cfe-commits. junparser edited the summary of this revision. For now we do not set tls model for tls_guard with/without option -ftls-model which

[clang-tools-extra] f2c8f6e - [clangd] Log rather than assert on bad UTF-8.

Author: Sam McCall Date: 2020-06-10T11:40:23+02:00 New Revision: f2c8f6e16d25ca356f58995109292735b222b1b7 URL: https://github.com/llvm/llvm-project/commit/f2c8f6e16d25ca356f58995109292735b222b1b7 DIFF: https://github.com/llvm/llvm-project/commit/f2c8f6e16d25ca356f58995109292735b222b1b7.diff LO

[PATCH] D80360: [PCH] Support writing BuiltinBitCastExprs to PCHs

hyd-dev added a comment. If this is OK, please commit it with `--author "hyd-dev "`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80360/new/ https://reviews.llvm.org/D80360 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://l

[PATCH] D80360: [PCH] Support writing BuiltinBitCastExprs to PCHs

hyd-dev updated this revision to Diff 269765. hyd-dev marked an inline comment as done. hyd-dev added a comment. Address the comment: remove `PathSize` from `BuiltinBitCastExpr`'s constructor and `assert()` it `== 0`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80360/new/ https://rev

[PATCH] D81272: [clang-tidy] New check `misc-redundant-condition`

baloghadamsoftware updated this revision to Diff 269769. baloghadamsoftware added a comment. Thank you for your help, @njames93! I updated the patch according to your comments. (And of course, also thank you, @Eugene.Zelenko, I also incorporated the changes you suggested.) CHANGES SINCE LAST A

[PATCH] D81428: [ARM] Moving CMSE handling of half arguments and return to the backend

ostannard added a comment. Is this expected to work for the soft-float calling convention, or is clang still passing half-precision values as integer types for that? If the former, then this needs some tests for that case. Comment at: llvm/lib/Target/ARM/ARMISelLowering.cpp:2

[PATCH] D81451: [ARM][Clang] Removing lowering of half-precision FP arguments and returns from Clang's CodeGen

ostannard accepted this revision. ostannard added a comment. This revision is now accepted and ready to land. LGTM, thanks for working on this patch series, this looks much clearer than doing it in clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D81530: [clangd] Log rather than assert on bad UTF-8.

This revision was automatically updated to reflect the committed changes. Closed by commit rGf2c8f6e16d25: [clangd] Log rather than assert on bad UTF-8. (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81530/new/ https://review

[PATCH] D81315: [analyzer][Draft] [Prototype] warning for default constructed unique pointer dereferences

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/SmartPtrModeling.cpp:233 +return false; + if (MethodDec->getDeclName().isIdentifier()) { +return ResetMethods.count(MethodDec->getName().lower()); vsavchenko wrote: > I'm not sure a

[PATCH] D81462: [SveEmitter] Add builtins for svtbl2

c-rhodes accepted this revision. c-rhodes added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81462/new/ https://reviews.llvm.org/D81462 ___

[PATCH] D76996: [analyzer] Improve PlacementNewChecker

NoQ added a comment. https://bugs.llvm.org/show_bug.cgi?id=46266! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76996/new/ https://reviews.llvm.org/D76996 ___ cfe-commits mailing list cfe-commits@lists

[PATCH] D81390: [KernelAddressSanitizer] Make globals constructors compatible with kernel [v2]

melver updated this revision to Diff 269780. melver added a comment. Fix test on windows. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81390/new/ https://reviews.llvm.org/D81390 Files: clang/test/CodeGen/asan-globals.cpp llvm/include/llvm/Tra

[PATCH] D81396: [clang-tidy] New util `Aliasing` factored out from `bugprone-infinite-loop`

baloghadamsoftware updated this revision to Diff 269779. baloghadamsoftware added a comment. Parameters in comments changed to `\p `. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81396/new/ https://reviews.llvm.org/D81396 Files: clang-tools-extra/clang-tidy/bugprone/InfiniteLoopChec

[PATCH] D81422: Change filecheck default to dump input on failure

This revision was automatically updated to reflect the committed changes. Closed by commit rGd31c9e5a46ee: Change filecheck default to dump input on failure (authored by mehdi_amini). Changed prior to commit: https://reviews.llvm.org/D81422?vs=269581&id=269631#toc Repository: rG LLVM Github

[PATCH] D81422: Change filecheck default to dump input on failure

arsenm added a comment. I think this is a worse default for development for large tests. For some generated check lines, I'm seeing many thousand of line dumps on failure, which just makes it harder to see the point it actually failed at. Can we move this default into the buildbot defaults or s

[PATCH] D81422: Change filecheck default to dump input on failure

arsenm added a comment. In D81422#2083808 , @mehdi_amini wrote: > In D81422#2083761 , @arsenm wrote: > > > I think this is a worse default for development for large tests. > > > Maybe the issue is with large tests t

[PATCH] D81422: Change filecheck default to dump input on failure

mehdi_amini added a comment. In D81422#2083882 , @arsenm wrote: > In D81422#2083808 , @mehdi_amini > wrote: > > > In D81422#2083761 , @arsenm wrote: > > > > > I think this i

[PATCH] D81422: Change filecheck default to dump input on failure

jdenny added a comment. In D81422#2083882 , @arsenm wrote: > The environment variable was removed though? I would also at least expect > this to be an option I can set at cmake time and never have to think about > again Could you set `FILECHECK_OPTS=-d

[PATCH] D81422: Change filecheck default to dump input on failure

mehdi_amini added a comment. In D81422#2083761 , @arsenm wrote: > I think this is a worse default for development for large tests. Maybe the issue is with large tests that needs to be broken up? To me this is a general improvement during development at m

[PATCH] D81390: [KernelAddressSanitizer] Make globals constructors compatible with kernel [v2]

glider accepted this revision. glider added a comment. This revision is now accepted and ready to land. LGTM assuming allyesconfig builds. Comment at: llvm/lib/Transforms/Instrumentation/AddressSanitizer.cpp:759 // do globals-gc. -UseCtorComdat(UseGlobalsGC &&

[PATCH] D76283: [IRBuilder] Use preferred target type for len argument of memory intrinsic functions

kschwarz updated this revision to Diff 269789. kschwarz added a comment. Herald added a project: LLVM. Brining this up again Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76283/new/ https://reviews.llvm.org/D76283 Files: clang/test/CodeGen/c11at

[PATCH] D76283: [IRBuilder] Use preferred target type for len argument of memory intrinsic functions

kschwarz added a comment. I brought this to the mailing list (http://lists.llvm.org/pipermail/llvm-dev/2020-March/140032.html) but didn't get an answer there. @arsenm, have you any comments regarding @rjmccall's last comment regarding the sizes of pointers in different address spaces? Reposi

[clang] 97e07d0 - [analyzer] On-demand parsing capability for CTU

Author: Endre Fülöp Date: 2020-06-10T13:43:51+02:00 New Revision: 97e07d0c352ca469eb07a0cb3162c2807ff1099d URL: https://github.com/llvm/llvm-project/commit/97e07d0c352ca469eb07a0cb3162c2807ff1099d DIFF: https://github.com/llvm/llvm-project/commit/97e07d0c352ca469eb07a0cb3162c2807ff1099d.diff L

[PATCH] D80712: [SVE] Add checks for no warnings in SVE tests

sdesmalen added inline comments. Comment at: clang/test/CodeGen/aarch64-sve-intrinsics/acle_sve_abd.c:6 +// ASM-NOT: warning #include Just thinking out loud here; we don't need to test for the specific warnings, because LLVM doesn't emit any other warnings a

[PATCH] D76283: [IRBuilder] Use preferred target type for len argument of memory intrinsic functions

gchatelet added a comment. I would harden the verifier and declare the i64 versions of mem intrinsics illegal on 32 bits architectures. Also the intrinsic sections of LangRef should be updated accordingly. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D81552: [ASTMatchers] Added hasDirectBase and hasClass Matchers

njames93 created this revision. njames93 added reviewers: klimek, aaron.ballman, jkorous. Herald added subscribers: cfe-commits, dexonsmith. Herald added a project: clang. Adds a matcher called `hasDirectBase` for matching the `CXXBaseSpecifier` of a class that directly derives from another class

[PATCH] D80153: [AST] Mangle LambdaContextDecl for top level decl

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. lgtm CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80153/new/ https://reviews.llvm.org/D80153 ___ cfe-commits mailing list cfe-commits@lists

[PATCH] D76283: [IRBuilder] Use preferred target type for len argument of memory intrinsic functions

arsenm added a comment. In D76283#2084627 , @kschwarz wrote: > I brought this to the mailing list > (http://lists.llvm.org/pipermail/llvm-dev/2020-March/140032.html) but didn't > get an answer there. > > @arsenm, have you any comments regarding @rjmccall

[PATCH] D81396: [clang-tidy] New util `Aliasing` factored out from `bugprone-infinite-loop`

njames93 accepted this revision. njames93 added a comment. LGTM, but with one more nit Comment at: clang-tools-extra/clang-tidy/bugprone/InfiniteLoopCheck.cpp:16 using namespace clang::ast_matchers; +using clang::tidy::utils::hasPtrOrReferenceInFunc; This fu

[PATCH] D80743: (PR46111) Properly handle elaborated types in an implicit deduction guide

erichkeane added a comment. Ping @rsmith I've done as you suggested, though I'm not sure its necessary for you to do a thorough review since you approve of the approach. Would it be alright for someone like @rjmccall or others to do the final pedantic checks? CHANGES SINCE LAST ACTION http

[clang] ae45145 - Create a warning flag for 'warn_conv_*_not_used'

Author: Ronald Wampler Date: 2020-06-10T09:09:48-04:00 New Revision: ae451454e32db48793afc76e0c5f2bcbda878995 URL: https://github.com/llvm/llvm-project/commit/ae451454e32db48793afc76e0c5f2bcbda878995 DIFF: https://github.com/llvm/llvm-project/commit/ae451454e32db48793afc76e0c5f2bcbda878995.diff

[clang] d3f8931 - [KernelAddressSanitizer] Make globals constructors compatible with kernel [v2]

Author: Marco Elver Date: 2020-06-10T15:08:42+02:00 New Revision: d3f89314ff20ce1612bd5e09f9f90ff5dd5205a7 URL: https://github.com/llvm/llvm-project/commit/d3f89314ff20ce1612bd5e09f9f90ff5dd5205a7 DIFF: https://github.com/llvm/llvm-project/commit/d3f89314ff20ce1612bd5e09f9f90ff5dd5205a7.diff L

[PATCH] D81420: Fix size for _ExtInt types with builtins

erichkeane added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:330 + + // Disallow ExtIntType args larger than 128 bits to mul function until we + // improve backend support. Disallow _signed_ ... Comment at: clang/lib/Sema/Sem

[PATCH] D81565: [analyzer] SATestAdd.py: Parse arguments with argparse

vsavchenko created this revision. vsavchenko added reviewers: NoQ, dcoughlin. Herald added subscribers: cfe-commits, ASDenysPetrov, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a project: clang. Repository: rG LLVM Git

[PATCH] D81564: [analyzer] SATest: Add posibility to download source from git and zip

vsavchenko created this revision. vsavchenko added reviewers: NoQ, dcoughlin. Herald added subscribers: cfe-commits, ASDenysPetrov, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a project: clang. Repository: rG LLVM Git

[PATCH] D81563: [analyzer] SATest: Move from csv to json project maps

vsavchenko created this revision. vsavchenko added reviewers: NoQ, dcoughlin. Herald added subscribers: cfe-commits, ASDenysPetrov, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a project: clang. JSON format is a bit more

[PATCH] D75665: [analyzer] On-demand parsing capability for CTU

thakis added a comment. This breaks check-clang on mac: http://45.33.8.238/mac/15258/step_7.txt Please take a look, and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75665/new/ https://reviews.llvm.org/D7

[PATCH] D81566: [analyzer] CmpRuns.py: Decouple main functionality from argparse

vsavchenko created this revision. vsavchenko added reviewers: NoQ, dcoughlin. Herald added subscribers: cfe-commits, ASDenysPetrov, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a project: clang. It makes it much harder t

[PATCH] D81569: [analyzer] SATest: Add option to specify projects to test

vsavchenko created this revision. vsavchenko added reviewers: NoQ, dcoughlin. Herald added subscribers: cfe-commits, ASDenysPetrov, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a project: clang. Repository: rG LLVM Git

[PATCH] D81568: [analyzer] ProjectMap: Do not serialize fields with default values

vsavchenko created this revision. vsavchenko added reviewers: NoQ, dcoughlin. Herald added subscribers: cfe-commits, ASDenysPetrov, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a project: clang. Repository: rG LLVM Git

[PATCH] D81567: [analyzer] SATest: Introduce a single entrypoint for regression scripts

vsavchenko created this revision. vsavchenko added reviewers: NoQ, dcoughlin. Herald added subscribers: cfe-commits, ASDenysPetrov, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a project: clang. Repository: rG LLVM Git

[PATCH] D81571: [analyzer] SATest: Add initial docker infrastructure

vsavchenko created this revision. vsavchenko added reviewers: NoQ, dcoughlin. Herald added subscribers: cfe-commits, ASDenysPetrov, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a project: clang. Static analysis is very s

[PATCH] D81572: [analyzer] SATest: Add convenience 'docker' command

vsavchenko created this revision. vsavchenko added reviewers: NoQ, dcoughlin. Herald added subscribers: cfe-commits, ASDenysPetrov, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a project: clang. It provides a simpler int

[PATCH] D79945: [Sema] Comparison of pointers to complete and incomplete types

pestctrl updated this revision to Diff 269824. pestctrl added a comment. Don't diagnose outside of C99 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79945/new/ https://reviews.llvm.org/D79945 Files: clang/include/clang/Basic/DiagnosticSemaKinds.

[PATCH] D78442: Create a warning flag for 'warn_conv_*_not_used'

This revision was automatically updated to reflect the committed changes. Closed by commit rGae451454e32d: Create a warning flag for 'warn_conv_*_not_used' (authored by rdwampler). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78442/new/ https://rev

[PATCH] D81390: [KernelAddressSanitizer] Make globals constructors compatible with kernel [v2]

This revision was automatically updated to reflect the committed changes. Closed by commit rGd3f89314ff20: [KernelAddressSanitizer] Make globals constructors compatible with kernel [v2] (authored by melver). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

cfe-commits@lists.llvm.org

LukeGeeson updated this revision to Diff 269833. LukeGeeson added a comment. addressed review comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80752/new/ https://reviews.llvm.org/D80752 Files: clang/include/clang/Basic/arm_neon.td clang/lib/CodeGen/CGBuiltin.cpp clang/test/

cfe-commits@lists.llvm.org

arsenm added inline comments. Comment at: llvm/test/CodeGen/AArch64/aarch64-bf16-ldst-intrinsics.ll:264 +; Function Attrs: argmemonly nounwind readonly +declare { <8 x bfloat>, <8 x bfloat> } @llvm.aarch64.neon.ld2lane.v8bf16.p0i8(<8 x bfloat>, <8 x bfloat>, i64, i8*) #3 + -

cfe-commits@lists.llvm.org

LukeGeeson marked 2 inline comments as done. LukeGeeson added inline comments. Comment at: llvm/test/CodeGen/AArch64/aarch64-bf16-ldst-intrinsics.ll:264 +; Function Attrs: argmemonly nounwind readonly +declare { <8 x bfloat>, <8 x bfloat> } @llvm.aarch64.neon.ld2lane.v8bf16.p0i8

[clang-tools-extra] 4e3a44d - [clangd] Disable new errs()-tie behavior, it's racy.

Author: Sam McCall Date: 2020-06-10T16:08:37+02:00 New Revision: 4e3a44d42eace1924c9cba3b7c1ea9cdbbd6cb48 URL: https://github.com/llvm/llvm-project/commit/4e3a44d42eace1924c9cba3b7c1ea9cdbbd6cb48 DIFF: https://github.com/llvm/llvm-project/commit/4e3a44d42eace1924c9cba3b7c1ea9cdbbd6cb48.diff LO

[clang] 63489c3 - Fix version of c-general.profdata.v5 test case

Author: serge-sans-paille Date: 2020-06-10T16:20:20+02:00 New Revision: 63489c39deeffb24a085b3766c5d5ff76a52fa2f URL: https://github.com/llvm/llvm-project/commit/63489c39deeffb24a085b3766c5d5ff76a52fa2f DIFF: https://github.com/llvm/llvm-project/commit/63489c39deeffb24a085b3766c5d5ff76a52fa2f.d

[PATCH] D79961: [PGO] Fix computation of fuction Hash

serge-sans-paille added a comment. In D79961#2065605 , @alanphipps wrote: > It looks like clang/test/Profile/Inputs/c-general.profdata.v5 is being read > as v6 rather than v5. Can you double check? Thanks for spotting the issue. Should be fixed by 634

[PATCH] D81538: [clangd] Disable new errs()-tie behavior, it's racy.

This revision was automatically updated to reflect the committed changes. Closed by commit rG4e3a44d42eac: [clangd] Disable new errs()-tie behavior, it's racy. (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81538/new/ https:/

[PATCH] D81552: [ASTMatchers] Added hasDirectBase and hasClass Matchers

aaron.ballman added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:2888-2890 +/// class Foo; +/// class Bar : Foo {}; +/// class Baz : Bar {}; It seems like these aren't really part of the example? Comment at:

[clang] 6ef08c3 - Fix the -Wsign-compare warning.

Author: Haojian Wu Date: 2020-06-10T16:51:54+02:00 New Revision: 6ef08c3a700761eaedc49edadc6d1dbadbc85670 URL: https://github.com/llvm/llvm-project/commit/6ef08c3a700761eaedc49edadc6d1dbadbc85670 DIFF: https://github.com/llvm/llvm-project/commit/6ef08c3a700761eaedc49edadc6d1dbadbc85670.diff LO

[PATCH] D81347: Make ASTFileSignature an array of 20 uint8_t instead of 5 uint32_t

dang updated this revision to Diff 269845. dang added a comment. Missed a case where an ASTFileSignature was created using an explicit `std::copy` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81347/new/ https://reviews.llvm.org/D81347 Files: c

[PATCH] D80383: Add AST_SIGNATURE record to unhashed control block of PCM files

dang updated this revision to Diff 269854. dang marked an inline comment as done. dang added a comment. Address @dexonsmith feedback about making the relative offsets in the AST block relative to the nearest relevant subblock. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[PATCH] D80383: Add AST_SIGNATURE record to unhashed control block of PCM files

dang added inline comments. Comment at: clang/include/clang/Serialization/ASTBitCodes.h:396-400 /// Record code for the signature that identifiers this AST file. SIGNATURE = 1, + /// Record code for the signature of the AST block. + AST_SIGNATURE, --

[PATCH] D81552: [ASTMatchers] Added hasDirectBase and hasClass Matchers

njames93 marked 2 inline comments as done. njames93 added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:2888-2890 +/// class Foo; +/// class Bar : Foo {}; +/// class Baz : Bar {}; aaron.ballman wrote: > It seems like these aren'

[PATCH] D74166: [AIX][Frontend] Static init implementation for AIX considering no priority

jasonliu added inline comments. Comment at: clang/lib/CodeGen/CGDeclCXX.cpp:305 + if (llvm::Function *unatexitFn = + dyn_cast(unatexit.getCallee())) +unatexitFn->setDoesNotThrow(); Is there a valid case that unatexit.getCallee() returns a type which

[PATCH] D80917: [OpenMP][AMDGCN] Support OpenMP offloading for AMDGCN architecture - Part 2

saiislam added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80917/new/ https://reviews.llvm.org/D80917 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[PATCH] D79945: [Sema] Comparison of pointers to complete and incomplete types

pestctrl marked 2 inline comments as done. pestctrl added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:11571 + Diag(Loc, + getLangOpts().C11 + ? diag::ext_typecheck_compare_complete_incomplete_pointers efriedma

cfe-commits@lists.llvm.org

SjoerdMeijer added inline comments. Comment at: llvm/test/CodeGen/AArch64/aarch64-bf16-ldst-intrinsics.ll:264 +; Function Attrs: argmemonly nounwind readonly +declare { <8 x bfloat>, <8 x bfloat> } @llvm.aarch64.neon.ld2lane.v8bf16.p0i8(<8 x bfloat>, <8 x bfloat>, i64, i8*) #3 +

[PATCH] D78350: [AST] Build recovery expressions by default for C++.

hokein updated this revision to Diff 269859. hokein marked 2 inline comments as done. hokein added a comment. rebase to master and address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78350/new/ https://reviews.llvm.org/D78350 Files:

cfe-commits@lists.llvm.org

LukeGeeson marked 2 inline comments as done. LukeGeeson added inline comments. Comment at: llvm/test/CodeGen/AArch64/aarch64-bf16-ldst-intrinsics.ll:264 +; Function Attrs: argmemonly nounwind readonly +declare { <8 x bfloat>, <8 x bfloat> } @llvm.aarch64.neon.ld2lane.v8bf16.p0i8

cfe-commits@lists.llvm.org

chill added inline comments. Comment at: llvm/test/CodeGen/AArch64/aarch64-bf16-ldst-intrinsics.ll:264 +; Function Attrs: argmemonly nounwind readonly +declare { <8 x bfloat>, <8 x bfloat> } @llvm.aarch64.neon.ld2lane.v8bf16.p0i8(<8 x bfloat>, <8 x bfloat>, i64, i8*) #3 + --

[clang] 435b458 - Revert "[analyzer] On-demand parsing capability for CTU"

Author: Endre Fülöp Date: 2020-06-10T17:55:37+02:00 New Revision: 435b458ad0a4630e6126246a6865748104ccad06 URL: https://github.com/llvm/llvm-project/commit/435b458ad0a4630e6126246a6865748104ccad06 DIFF: https://github.com/llvm/llvm-project/commit/435b458ad0a4630e6126246a6865748104ccad06.diff L

[PATCH] D79972: [OpenMP5.0] map item can be non-contiguous for target update

ABataev added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:7046-7049 +/// Signal that the runtime library should use args as an array of +/// descriptor_dim pointers and use args_size as dims. Used when we have +/// non-contiguous list items in t

[PATCH] D81045: [LLVM] Change isa<> to a variadic function template

jurahul updated this revision to Diff 269870. jurahul added a comment. Split isa<> changes into its own change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81045/new/ https://reviews.llvm.org/D81045 Files: clang/include/clang/AST/DeclBase.h l

[PATCH] D81583: Update SystemZ ABI to handle C++20 [[no_unique_address]] attribute

uweigand created this revision. uweigand added reviewers: craig.topper, erichkeane, jasonliu, kbarton, rnk, asl, sunfish, t.p.northover, arsenm, asb. Herald added subscribers: cfe-commits, wdng. Herald added a project: clang. The SystemZ ABI has special cases to handle structs containing just a s

cfe-commits@lists.llvm.org

SjoerdMeijer added inline comments. Comment at: llvm/test/CodeGen/AArch64/aarch64-bf16-ldst-intrinsics.ll:264 +; Function Attrs: argmemonly nounwind readonly +declare { <8 x bfloat>, <8 x bfloat> } @llvm.aarch64.neon.ld2lane.v8bf16.p0i8(<8 x bfloat>, <8 x bfloat>, i64, i8*) #3 +

[clang] e408cba - [AST] Mangle LambdaContextDecl for top level decl

Author: Zequan Wu Date: 2020-06-10T09:44:09-07:00 New Revision: e408cba84f8a9471bb26deca8d9aac049a924847 URL: https://github.com/llvm/llvm-project/commit/e408cba84f8a9471bb26deca8d9aac049a924847 DIFF: https://github.com/llvm/llvm-project/commit/e408cba84f8a9471bb26deca8d9aac049a924847.diff LOG

cfe-commits@lists.llvm.org

chill added inline comments. Comment at: llvm/test/CodeGen/AArch64/aarch64-bf16-ldst-intrinsics.ll:264 +; Function Attrs: argmemonly nounwind readonly +declare { <8 x bfloat>, <8 x bfloat> } @llvm.aarch64.neon.ld2lane.v8bf16.p0i8(<8 x bfloat>, <8 x bfloat>, i64, i8*) #3 + --

[PATCH] D74166: [AIX][Frontend] Static init implementation for AIX considering no priority

jasonliu added a comment. -fregister_global_dtors_with_atexit does not seem to work properly in current implementation. We should consider somehow disabling/report_fatal_error it instead of letting it generate invalid code on AIX. Comment at: clang/lib/CodeGen/CGDeclCXX.cpp:

[PATCH] D80970: [PowerPC][Power10] Implement centrifuge, vector gather every nth bit, vector evaluate Builtins in LLVM/Clang

amyk added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80970/new/ https://reviews.llvm.org/D80970 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-b

[PATCH] D80935: [PowerPC][Power10] Implement Parallel Bits Deposit/Extract Builtins in LLVM/Clang

amyk added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80935/new/ https://reviews.llvm.org/D80935 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-b

[PATCH] D81390: [KernelAddressSanitizer] Make globals constructors compatible with kernel [v2]

thakis added a comment. This breaks mac again: http://45.33.8.238/mac/15259/step_7.txt Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81390/new/ https://reviews.llvm.org/D81390 ___ cfe-commits mailing l

[PATCH] D80153: [AST] Mangle LambdaContextDecl for top level decl

zequanwu updated this revision to Diff 269882. zequanwu added a comment. rebase CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80153/new/ https://reviews.llvm.org/D80153 Files: clang/lib/AST/MicrosoftMangle.cpp clang/test/CodeGenCXX/mangle-ms-cxx17.cpp Index: clang/test/CodeGenCXX

[PATCH] D80917: [OpenMP][AMDGCN] Support OpenMP offloading for AMDGCN architecture - Part 2

jdoerfert added a comment. I am fine with this. @arsenm feel free to accept. --- --- In D80917#2085138 , @saiislam wrote: > Ping. Afaik, pings should be reserved to ~1 week of inactivity. I know this can be frustrating, but we also need to consider no

[PATCH] D80153: [AST] Mangle LambdaContextDecl for top level decl

This revision was automatically updated to reflect the committed changes. Closed by commit rGe408cba84f8a: [AST] Mangle LambdaContextDecl for top level decl (authored by zequanwu). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80153/new/ https://rev

[PATCH] D81563: [analyzer] SATest: Move from csv to json project maps

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Sounds like a nice abstraction :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81563/new/ https://reviews.llvm.org/D81563

[PATCH] D81565: [analyzer] SATestAdd.py: Parse arguments with argparse

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Absolutely worth it! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81565/new/ https://reviews.llvm.org/D81565 _

[PATCH] D81552: [ASTMatchers] Added hasDirectBase and hasClass Matchers

aaron.ballman added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:2888-2890 +/// class Foo; +/// class Bar : Foo {}; +/// class Baz : Bar {}; njames93 wrote: > aaron.ballman wrote: > > It seems like these aren't really part of t

[PATCH] D81564: [analyzer] SATest: Add posibility to download source from git and zip

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. *keeps ranting that there are no lit tests so it's much harder to figure out what the code is even supposed to do as there are no examples* Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D81569: [analyzer] SATest: Add option to specify projects to test

NoQ accepted this revision. NoQ added inline comments. This revision is now accepted and ready to land. Comment at: clang/utils/analyzer/SATest.py:137 +build_parser.add_argument("--projects", action="store", default="", + help="Comma-separated lis

[PATCH] D81566: [analyzer] CmpRuns.py: Decouple main functionality from argparse

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Yes, definitely. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81566/new/ https://reviews.llvm.org/D81566 _

[PATCH] D81591: [ASan][Test] Split out global alias test

melver created this revision. melver added a reviewer: thakis. Herald added subscribers: cfe-commits, aaron.ballman. Herald added a project: clang. Some platforms do not support aliases. Split the test, and pass explicit triple to avoid test failure. Repository: rG LLVM Github Monorepo https:

[PATCH] D81592: [analyzer] SATest: Add a set of initial projects for testing

vsavchenko created this revision. vsavchenko added reviewers: NoQ, dcoughlin. Herald added subscribers: cfe-commits, ASDenysPetrov, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a project: clang. Repository: rG LLVM Git

[PATCH] D81567: [analyzer] SATest: Introduce a single entrypoint for regression scripts

NoQ accepted this revision. NoQ added inline comments. This revision is now accepted and ready to land. Comment at: clang/utils/analyzer/CmpRuns.py:526-529 +if __name__ == "__main__": +print("CmpRuns.py should not be used on its own.") +print("Please use 'SATest.py compar

[PATCH] D81591: [ASan][Test] Split out global alias test

melver updated this revision to Diff 269898. melver added a comment. Comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81591/new/ https://reviews.llvm.org/D81591 Files: clang/test/CodeGen/asan-globals-alias.c clang/test/CodeGen/asan-globa

[PATCH] D81567: [analyzer] SATest: Introduce a single entrypoint for regression scripts

vsavchenko marked an inline comment as done. vsavchenko added inline comments. Comment at: clang/utils/analyzer/CmpRuns.py:526-529 +if __name__ == "__main__": +print("CmpRuns.py should not be used on its own.") +print("Please use 'SATest.py compare' instead") +sys.exi

  1   2   3   >