sdesmalen added inline comments.
================ Comment at: clang/test/CodeGen/aarch64-sve-intrinsics/acle_sve_abd.c:6 +// ASM-NOT: warning #include <arm_sve.h> ---------------- Just thinking out loud here; we don't need to test for the specific warnings, because LLVM doesn't emit any other warnings and any Clang's warnings are otherwise caught by `-Werror`. ================ Comment at: clang/test/CodeGen/aarch64-sve-intrinsics/acle_sve_abd.c:6 +// ASM-NOT: warning #include <arm_sve.h> ---------------- sdesmalen wrote: > Just thinking out loud here; we don't need to test for the specific warnings, > because LLVM doesn't emit any other warnings and any Clang's warnings are > otherwise caught by `-Werror`. Can you add a comment to these checks, so that if someone breaks it (because their code causes a new warning), they know where to look? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80712/new/ https://reviews.llvm.org/D80712 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
