[PATCH] D80055: Diagnose union tail padding

jfb added a comment. In D80055#2042630 , @rsmith wrote: > I'm not convinced that this is an especially useful diagnostic (much like > with `-Wpadded`), but I'm also not opposed if you are aware of cases where it > would be used. I wrote it to help with

[PATCH] D80547: [clang-format] Fix an ObjC regression introduced with new [[likely]][[unlikely]] support in if/else clauses

MyDeveloperDay updated this revision to Diff 266248. MyDeveloperDay marked an inline comment as done. MyDeveloperDay added a comment. Address nits CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80547/new/ https://reviews.llvm.org/D80547 Files: clang/lib/Format/UnwrappedLineParser.cpp

[PATCH] D77148: [analyzer] ApiModeling: Add buffer size arg constraint with multiplier involved

xazax.hun added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:1013 +addToFunctionSummaryMap( +"__buf_size_arg_constraint_mul", +Summary(ArgTypes{ConstVoidPtrTy, SizeTy, SizeTy}, RetType{IntTy},

[PATCH] D80531: [clang-tidy]: Added modernize-replace-disallow-copy-and-assign-macro

kwk updated this revision to Diff 266251. kwk marked 11 inline comments as done. kwk added a comment. - Avoid constructing string - CamelCase for vars - more readable snippets for documentation - Added empty line after header in documentation - Remove sentence from doc - Remove unimportant tests

[PATCH] D80531: [clang-tidy]: Added modernize-replace-disallow-copy-and-assign-macro

kwk added a comment. Thanks @njames93 and @Eugene.Zelenko for your review. Most of it, I addressed but for some I have comments. See inline. Comment at: clang-tools-extra/clang-tidy/modernize/ReplaceDisallowCopyAndAssignMacroCheck.cpp:36 +// be the class name. +const

[PATCH] D80531: [clang-tidy]: Added modernize-replace-disallow-copy-and-assign-macro

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/modernize-replace-disallow-copy-and-assign-macro.rst:31 +* Notice that the migration example above leaves the ``private`` access + specification untouched. This opens room for improvement

[PATCH] D77148: [analyzer] ApiModeling: Add buffer size arg constraint with multiplier involved

martong marked 3 inline comments as done. martong added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:1013 +addToFunctionSummaryMap( +"__buf_size_arg_constraint_mul", +Summary(ArgTypes{ConstVoidPtrTy, SizeTy, Si

[PATCH] D80409: [MS ABI] Add mangled type for auto template parameter whose argument kind is Integeral

zequanwu marked an inline comment as done. zequanwu added inline comments. Comment at: clang/test/CodeGenCXX/mangle-ms-auto-templates.cpp:17 + AutoParmTemplate<0> auto_int; + // CHECK: call {{.*}} @"??0?$AutoParmTemplate@$H0A@@@QAE@XZ" + AutoParmTemplate auto_bool; ---

[PATCH] D77148: [analyzer] ApiModeling: Add buffer size arg constraint with multiplier involved

xazax.hun added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:1013 +addToFunctionSummaryMap( +"__buf_size_arg_constraint_mul", +Summary(ArgTypes{ConstVoidPtrTy, SizeTy, SizeTy}, RetType{IntTy},

[PATCH] D50078: clang-format: support aligned nested conditionals formatting

srj added a comment. > And I also think it should be on by default instead of modifying many > .clang-format files. So IMHO if we add an option, it should be opt-out. I can live with it being opt-out. My big concern is that (as it currently stands) our project gets different 'canonical' clang-f

[PATCH] D80574: [ExtVector] Support ExtVectorType conditional operator

myhsu created this revision. myhsu added reviewers: Anastasia, bader, hfinkel, erichkeane. Herald added a project: clang. Herald added a subscriber: cfe-commits. Extension vectors now can be used in element-wise conditional selector. For example: R[i] = C[i]? A[i] : B[i] This feature was previ

[PATCH] D80531: [clang-tidy]: Added modernize-replace-disallow-copy-and-assign-macro

kwk added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/modernize-replace-disallow-copy-and-assign-macro.rst:31 +* Notice that the migration example above leaves the ``private`` access + specification untouched. This opens room for improvement, yes I kno

[PATCH] D80531: [clang-tidy]: Added modernize-replace-disallow-copy-and-assign-macro

kwk updated this revision to Diff 266257. kwk marked 2 inline comments as done. kwk added a comment. - Refer to modernize-use-equals-delete for warning about deleted functions in private sections Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80531/

[PATCH] D71726: Let clang atomic builtins fetch add/sub support floating point types

tra added inline comments. Comment at: clang/include/clang/Basic/TargetInfo.h:1418 + /// Whether floating point atomic fetch add/sub is supported. + virtual bool isFPAtomicFetchAddSubSupported() const { return false; } + yaxunl wrote: > tra wrote: > > I think i

[PATCH] D80366: [Analyzer] Add `getReturnValueUnderConstruction()` to `CallEvent`

baloghadamsoftware marked an inline comment as done. baloghadamsoftware added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/ExprEngineCXX.cpp:112 +Optional ExprEngine::retrieveFromConstructionContext( +ProgramStateRef State, const LocationContext *LCtx, ---

[PATCH] D80020: [PowerPC] Add support for -mcpu=pwr10 in both clang and llvm

amyk accepted this revision. amyk added a comment. I think this looks good aside from the comments I had. Comment at: llvm/lib/Target/PowerPC/PPCSubtarget.h:142 bool IsISA3_0; + bool IsISA3_1; bool UseLongCalls; Missing `IsISA3_1 = false;` in PPCSubtarge

[PATCH] D80547: [clang-format] Fix an ObjC regression introduced with new [[likely]][[unlikely]] support in if/else clauses

krasimir accepted this revision. krasimir added a comment. This revision is now accepted and ready to land. This is nice! Thank you! Ran this through a mix of C++ and Objective-C sources and didn't spot any regressions from pre-D80144. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D8054

[PATCH] D80222: Replace Clang's createRuntimeFunction with the definitions in OMPKinds.def

jdoerfert added a comment. In D80222#2055149 , @jhuber6 wrote: > This passes all checks except the libomp ones. Those still seg-fault, I'm not > entirely sure why. Cuda failure is again because I don't have it configured > on my machine. > > Failing Test

[PATCH] D80531: [clang-tidy]: Added modernize-replace-disallow-copy-and-assign-macro

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/modernize-replace-disallow-copy-and-assign-macro.rst:41 + specification untouched. You might want to run the check + `modernize-use-equals-delete `_ to get + warnings for deleted functi

[PATCH] D80532: [NFC] Fix formatting for the 'aix-ld.c' test case.

stevewan updated this revision to Diff 266263. stevewan added a comment. Add the two-space indent before continuations on a pipeine. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80532/new/ https://reviews.llvm.org/D80532 Files: clang/test/Drive

[PATCH] D80531: [clang-tidy]: Added modernize-replace-disallow-copy-and-assign-macro

kwk marked 2 inline comments as done. kwk added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/modernize-replace-disallow-copy-and-assign-macro.rst:41 + specification untouched. You might want to run the check + `modernize-use-equals-delete `_ to get +

[PATCH] D79754: [OpenMP][AMDGCN] Support OpenMP offloading for AMDGCN architecture - Part 1

saiislam marked an inline comment as done. saiislam added inline comments. Comment at: clang/test/OpenMP/amdgcn_device_function_call.cpp:27 + } +} jdoerfert wrote: > Not for this patch: > FWIW, we will need to make math functions work inside target regions. The

[PATCH] D80531: [clang-tidy]: Added modernize-replace-disallow-copy-and-assign-macro

kwk updated this revision to Diff 266268. kwk added a comment. - Adjust link to documentation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80531/new/ https://reviews.llvm.org/D80531 Files: clang-tools-extra/clang-tidy/modernize/CMakeLists.txt

[PATCH] D80531: [clang-tidy]: Added modernize-replace-disallow-copy-and-assign-macro

kwk marked an inline comment as done. kwk added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/modernize-replace-disallow-copy-and-assign-macro.rst:41 + specification untouched. You might want to run the check + `modernize-use-equals-delete `_ to get +

[clang] 8f1156a - [clang-format] Fix an ObjC regression introduced with new [[likely]][[unlikely]] support in if/else clauses

Author: mydeveloperday Date: 2020-05-26T18:48:49+01:00 New Revision: 8f1156a7d004d97e9f75484a00dc4278698fd8ea URL: https://github.com/llvm/llvm-project/commit/8f1156a7d004d97e9f75484a00dc4278698fd8ea DIFF: https://github.com/llvm/llvm-project/commit/8f1156a7d004d97e9f75484a00dc4278698fd8ea.diff

[PATCH] D80547: [clang-format] Fix an ObjC regression introduced with new [[likely]][[unlikely]] support in if/else clauses

This revision was automatically updated to reflect the committed changes. Closed by commit rG8f1156a7d004: [clang-format] Fix an ObjC regression introduced with new [[likely]]… (authored by MyDeveloperDay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D80531: [clang-tidy]: Added modernize-replace-disallow-copy-and-assign-macro

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/modernize-replace-disallow-copy-and-assign-macro.rst:41 + specification untouched. You might want to run the check :doc:`modernize-use-equals-delete + ` to get warnings for deleted + f

[clang] d70ec36 - [Analyzer][NFC] Remove the SubEngine interface

Author: Adam Balogh Date: 2020-05-26T19:56:55+02:00 New Revision: d70ec366c91b2a5fc6334e6f6ca9c4d9a6785c5e URL: https://github.com/llvm/llvm-project/commit/d70ec366c91b2a5fc6334e6f6ca9c4d9a6785c5e DIFF: https://github.com/llvm/llvm-project/commit/d70ec366c91b2a5fc6334e6f6ca9c4d9a6785c5e.diff L

[PATCH] D80554: [DebugInfo] Use SplitTemplateClosers (foo >) in DWARF too

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Looks good - thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80554/new/ https://reviews.llvm.org/D80554 ___

[PATCH] D71199: [clang-tidy] New check cppcoreguidelines-prefer-member-initializer

baloghadamsoftware updated this revision to Diff 266277. baloghadamsoftware added a comment. Code reformatted. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71199/new/ https://reviews.llvm.org/D71199 Files: clang-tools-extra/clang-tidy/cppcoreguidelines/CMakeLists.txt clang-tools-e

[PATCH] D80464: [CUDA] Missing __syncthreads intrinsic in __clang_cuda_device_functions.h

tra added a comment. `__syncthreads` is clang's built-in and as such should not be in any header file: https://github.com/llvm/llvm-project/blob/master/clang/include/clang/Basic/BuiltinsNVPTX.def#L406 My guess is that the root cause of this problem is that source parsing is done using C++, not

[PATCH] D80548: [Analyzer][NFC] Remove the SubEngine interface

This revision was automatically updated to reflect the committed changes. Closed by commit rGd70ec366c91b: [Analyzer][NFC] Remove the SubEngine interface (authored by baloghadamsoftware). Changed prior to commit: https://reviews.llvm.org/D80548?vs=266168&id=266281#toc Repository: rG LLVM Git

[PATCH] D80548: [Analyzer][NFC] Remove the SubEngine interface

MyDeveloperDay added a comment. I think the buildbot might be failing http://lab.llvm.org:8011/builders/clang-ppc64le-rhel/builds/3664 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80548/new/ https://reviews.llvm.org/D80548

[PATCH] D80450: [CUDA][HIP] Fix implicit HD function resolution

tra added a comment. Is this patch supposed to be used with D79526 or instead of it? Comment at: clang/test/SemaCUDA/function-overload.cu:551 + struct a { +__attribute__((device)) a(short); +__attribute__((device)) operator unsigned()

[clang] a94e08d - [StaticAnalyzer] Fix non-virtual destructor warning

Author: Jonas Devlieghere Date: 2020-05-26T11:32:02-07:00 New Revision: a94e08d2e840a0e7ce032f59e9344bc49b5a54a1 URL: https://github.com/llvm/llvm-project/commit/a94e08d2e840a0e7ce032f59e9344bc49b5a54a1 DIFF: https://github.com/llvm/llvm-project/commit/a94e08d2e840a0e7ce032f59e9344bc49b5a54a1.d

[clang] 12dbdc2 - [Analyzer] Fix buildbot failure of commit rGd70ec366c91b

Author: Adam Balogh Date: 2020-05-26T20:43:37+02:00 New Revision: 12dbdc2a6b68162f7370e9754bdb0e1edd65bf3c URL: https://github.com/llvm/llvm-project/commit/12dbdc2a6b68162f7370e9754bdb0e1edd65bf3c DIFF: https://github.com/llvm/llvm-project/commit/12dbdc2a6b68162f7370e9754bdb0e1edd65bf3c.diff L

[clang] 7eb666b - [PowerPC] Add support for -mcpu=pwr10 in both clang and llvm

Author: Lei Huang Date: 2020-05-26T13:48:22-05:00 New Revision: 7eb666b1556b86503f2f386bf921186cdbb2d22a URL: https://github.com/llvm/llvm-project/commit/7eb666b1556b86503f2f386bf921186cdbb2d22a DIFF: https://github.com/llvm/llvm-project/commit/7eb666b1556b86503f2f386bf921186cdbb2d22a.diff LOG

[PATCH] D79995: [clang] [MinGW] Fix libunwind extension

mstorsjo added a comment. In D79995#2054298 , @mati865 wrote: > @mstorsjo @rnk will be away since June Yeah, I've noticed - but was waiting to see if he'd comment on it before that. Btw, would it be possible to add some test for this? (Sorry for not men

[PATCH] D80020: [PowerPC] Add support for -mcpu=pwr10 in both clang and llvm

lei updated this revision to Diff 266283. lei added a comment. update as per reviewers comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80020/new/ https://reviews.llvm.org/D80020 Files: clang/lib/Basic/Targets/PPC.cpp clang/lib/Basic/Tar

[PATCH] D80554: [DebugInfo] Use SplitTemplateClosers (foo >) in DWARF too

amccarth added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:242 +// SplitTemplateClosers yields better interop with GCC and GDB (PR46052). +PP.SplitTemplateClosers = true; } So, in other words, we'll always set `PP.SplitTemplateCloser

[PATCH] D80536: [clang-tidy][modernize-loop-convert] Make loop var type human readable

njames93 added a comment. I'm having trouble with the reproduction of this - https://godbolt.org/z/tsMfcj. Aside from that this needs some test cases to demonstrate the patch is indeed working Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80536/new

[PATCH] D80548: [Analyzer][NFC] Remove the SubEngine interface

baloghadamsoftware added a comment. In D80548#2055446 , @MyDeveloperDay wrote: > I think the buildbot might be failing > http://lab.llvm.org:8011/builders/clang-ppc64le-rhel/builds/3664 Fixed now. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D80412: Summary: [Lexer] Fix invalid suffix diagnostic for fixed-point literals

leonardchan accepted this revision. leonardchan added a comment. This revision is now accepted and ready to land. LGTM. Thanks for fixing this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80412/new/ https://reviews.llvm.org/D80412

[PATCH] D79830: Add support of __builtin_expect_with_probability

LukeZhuang marked 3 inline comments as done. LukeZhuang added a comment. Fixed in latest update as well as adding test. Thank you! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79830/new/ https://reviews.llvm.org/D79830 ___ cfe-commits mail

[PATCH] D79830: Add support of __builtin_expect_with_probability

LukeZhuang updated this revision to Diff 266285. LukeZhuang added a comment. **updated: 05/26/2020** (1) add Sema test (2) improve assert (3) format change CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79830/new/ https://reviews.llvm.org/D79830 Files: clang/include/clang/Basic/Builti

[PATCH] D77066: [analyzer] ApiModeling: Add buffer size arg constraint

martong updated this revision to Diff 266287. martong marked 4 inline comments as done. martong added a comment. - Add assert - Create the BufferSize arg constraints in a more readable way Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77066/new/ ht

[PATCH] D80020: [PowerPC] Add support for -mcpu=pwr10 in both clang and llvm

This revision was automatically updated to reflect the committed changes. Closed by commit rG7eb666b1556b: [PowerPC] Add support for -mcpu=pwr10 in both clang and llvm (authored by lei). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80020/new/ https

[PATCH] D77066: [analyzer] ApiModeling: Add buffer size arg constraint

martong added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:249-250 + // cannot apply the constraint. Actually, other checkers like + // CallAndMessage should catch this situation earlier, because we call a + // func

[PATCH] D79945: [Sema] Comparison of pointers to complete and incomplete types

efriedma added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:6446 + "ordered comparison of complete and incomplete pointers (%0 and %1)">, + InGroup; +def warn_typecheck_compare_complete_incomplete_pointers : ExtWarn< ext_typeche

[PATCH] D79830: Add support of __builtin_expect_with_probability

erichkeane added a comment. 1 more nit that I saw (don't use an 'else' after an 'if' branch that returns), but otherwise I think this is good from the CFE perspective. Someone better understanding of LLVM needs to look at the rest though. Comment at: clang/lib/Sema/SemaCheck

[PATCH] D80374: [Clang] Enable KF and KC mode for [_Complex] __float128

rjmccall added inline comments. Comment at: clang/lib/Sema/SemaDeclAttr.cpp:3970 + DestWidth = 128; + break; case 'T': rjmccall wrote: > Are there interactions with the other mode specifiers? For example, should > this be allowed with integer mod

[PATCH] D80533: [Clang] Enable _Complex __float

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80533/new/ https://reviews.llvm.org/D80533 __

[PATCH] D80548: [Analyzer][NFC] Remove the SubEngine interface

Szelethus added a comment. - claps in excitement * Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80548/new/ https://reviews.llvm.org/D80548 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https

[PATCH] D80532: [NFC] Fix formatting for the 'aix-ld.c' test case.

hubert.reinterpretcast accepted this revision. hubert.reinterpretcast added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80532/new/ https://reviews.llvm.org/D80532 __

[PATCH] D80018: [Analyzer][StreamChecker] Added check for "indeterminate file position".

Szelethus added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StreamChecker.cpp:857-868 +// FEof and other states are possible. +// The path with FEof is the one that can continue. +// For this reason a non-fatal error is generated to continue the ana

[PATCH] D80374: [Clang] Enable KF and KC mode for [_Complex] __float128

rjmccall added inline comments. Comment at: clang/lib/Sema/SemaDeclAttr.cpp:3970 + DestWidth = 128; + break; case 'T': Are there interactions with the other mode specifiers? For example, should this be allowed with integer modes? If so, I think

[PATCH] D80554: [DebugInfo] Use SplitTemplateClosers (foo >) in DWARF too

sammccall marked an inline comment as done. sammccall added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:242 +// SplitTemplateClosers yields better interop with GCC and GDB (PR46052). +PP.SplitTemplateClosers = true; } amccarth wrote:

[PATCH] D68049: Propeller: Clang options for basic block sections

tmsriram added a comment. Ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68049/new/ https://reviews.llvm.org/D68049 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D69764: [clang-format] Add East/West Const fixer capability

steveire added a comment. @MyDeveloperDay Thanks for the update. I pinged you on slack about this, but I guess you're not using it at the moment. I asked if you have a git branch somewhere with this change. Downloading patches from phab is such a pain I have no idea why we use it. If you can l

Re: [clang-tools-extra] 61559d0 - [clangd] Squash GCC error with StringRef + gtest MatchesRegex()

Might be handy to link to a buildbot and/or quote the specific error message in the commit message for changes like this so it's clear what's being addressed by the change. On Tue, May 19, 2020 at 4:58 AM Sam McCall via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > Author: Sam McCall > Dat

[PATCH] D80522: [Analyzer] [NFC] Parameter Regions -- Alternative Approach

baloghadamsoftware updated this revision to Diff 266296. baloghadamsoftware added a comment. Herald added subscribers: llvm-commits, MaskRay, hiraditya, arichardson, nemanjai, emaste. Herald added a reviewer: espindola. Herald added a reviewer: MaskRay. Herald added a project: LLVM. Updated accor

[PATCH] D80522: [Analyzer] [NFC] Parameter Regions -- Alternative Approach

baloghadamsoftware updated this revision to Diff 266298. baloghadamsoftware added a comment. Herald added a subscriber: wuzish. Wrong diff uploaded previously, now fixed. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80522/new/ https://reviews.llvm.org/D80522 Files: clang/include/cla

[PATCH] D80522: [Analyzer] [NFC] Parameter Regions -- Alternative Approach

baloghadamsoftware marked 4 inline comments as done. baloghadamsoftware added a comment. In D80522#2055040 , @NoQ wrote: > Nice, looks like you managed to reuse most of the code. I still feel like we > should ditch `DeclRegion` entirely (forcing its ~5 cu

[PATCH] D76793: [Matrix] Implement + and - operators for MatrixType.

fhahn updated this revision to Diff 266303. fhahn marked an inline comment as done. fhahn added a comment. Add support for user-defined conversion function, use PrepareScalarCast and add overloads for matrix +/- operators. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[PATCH] D69764: [clang-format] Add East/West Const fixer capability

MyDeveloperDay marked an inline comment as done. MyDeveloperDay added inline comments. Comment at: clang/lib/Format/Format.cpp:2547 + if (Style.isCpp() || Style.Language == FormatStyle::LK_ObjC) { +if (Style.ConstStyle != FormatStyle::CS_Leave) aaron.ballm

[PATCH] D50078: clang-format: support aligned nested conditionals formatting

Typz added a comment. In D50078#2055227 , @srj wrote: > > And I also think it should be on by default instead of modifying many > > .clang-format files. So IMHO if we add an option, it should be opt-out. > > I can live with it being opt-out. My big concer

[PATCH] D76793: [Matrix] Implement + and - operators for MatrixType.

fhahn added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:11989 + else +return false; + rjmccall wrote: > I would suggest checking some preconditions and then just calling > `PrepareScalarCast`. > > You should allow implicit conversions from cla

[PATCH] D80409: [MS ABI] Add mangled type for auto template parameter whose argument kind is Integeral

thakis added inline comments. Comment at: clang/test/CodeGenCXX/mangle-ms-auto-templates.cpp:17 + AutoParmTemplate<0> auto_int; + // CHECK: call {{.*}} @"??0?$AutoParmTemplate@$H0A@@@QAE@XZ" + AutoParmTemplate auto_bool; zequanwu wrote: > thakis wrote: > > Are

[PATCH] D69764: [clang-format] Add East/West Const fixer capability

MyDeveloperDay added a comment. I really do appreciate the reviews and the comments especially regarding east/west/left/right/wrong ;-), I know there won't be 100% agreement, but I think most people who even consider clone the LLVM repo know what we mean by East/West. as such I'm going to leave

[clang] 14de6e2 - [Clang][Driver] Add Bounds and Thread to SupportsCoverage list

Author: Marco Elver Date: 2020-05-26T13:36:21-07:00 New Revision: 14de6e29b1315e9abe61d71e3e13f75bff80e1be URL: https://github.com/llvm/llvm-project/commit/14de6e29b1315e9abe61d71e3e13f75bff80e1be DIFF: https://github.com/llvm/llvm-project/commit/14de6e29b1315e9abe61d71e3e13f75bff80e1be.diff L

[PATCH] D78442: Create a warning flag for 'warn_conv_*_not_used'

rdwampler added a comment. Ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78442/new/ https://reviews.llvm.org/D78442 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D60620: [HIP] Support target id by --offload-arch

yaxunl updated this revision to Diff 266315. yaxunl marked an inline comment as done. yaxunl added a comment. Herald added subscribers: kerbowa, nhaehnle, jvesely. Fixed passing target id to clang -cc1. Added predefined macros for target id. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D69764: [clang-format] Add East/West Const fixer capability

steveire added a comment. > if I put any declarations inside the preprocess clauses they actually don't > get converted. Sorry, I'm not certain what this means. Does it mean that if you have #if 0 Foo> P; #else Foo> P; #endif that neither of them get converted? Can you point me to

[PATCH] D79628: [Clang][Driver] Add Bounds and Thread to SupportsCoverage list

vitalybuka updated this revision to Diff 266316. vitalybuka added a comment. simplify some tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79628/new/ https://reviews.llvm.org/D79628 Files: clang/lib/Driver/SanitizerArgs.cpp clang/test/Code

[PATCH] D80472: [clangd] Add access specifier information to hover contents

danielmartin updated this revision to Diff 266322. danielmartin marked 2 inline comments as done. danielmartin added a comment. Address feedback Rename getAccess to getAccessSpelling. Replace more parts of the codebase that were using their own version of getAccessSpelling. Use StringRef's str()

[PATCH] D79628: [Clang][Driver] Add Bounds and Thread to SupportsCoverage list

This revision was automatically updated to reflect the committed changes. Closed by commit rG14de6e29b131: [Clang][Driver] Add Bounds and Thread to SupportsCoverage list (authored by melver, committed by vitalybuka). Changed prior to commit: https://reviews.llvm.org/D79628?vs=266316&id=266324#t

[PATCH] D80020: [PowerPC] Add support for -mcpu=pwr10 in both clang and llvm

lei updated this revision to Diff 266321. lei added a comment. change how we generate p10 feature list. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80020/new/ https://reviews.llvm.org/D80020 Files: clang/lib/Basic/Targets/PPC.cpp clang/lib/B

[PATCH] D80222: Replace Clang's createRuntimeFunction with the definitions in OMPKinds.def

jhuber6 marked 2 inline comments as done. jhuber6 added inline comments. Comment at: llvm/include/llvm/Frontend/OpenMP/OMPKinds.def:245 +__OMP_PTR_TYPE(Int8PtrPtr, Int8Ptr) +__OMP_PTR_TYPE(Int8PtrPtrPtr, Int8PtrPtr) + I added these types as @fghanim suggested.

[PATCH] D80409: [MS ABI] Add mangled type for auto template parameter whose argument kind is Integeral

zequanwu marked an inline comment as done. zequanwu added inline comments. Comment at: clang/test/CodeGenCXX/mangle-ms-auto-templates.cpp:17 + AutoParmTemplate<0> auto_int; + // CHECK: call {{.*}} @"??0?$AutoParmTemplate@$H0A@@@QAE@XZ" + AutoParmTemplate auto_bool; ---

[PATCH] D69764: [clang-format] Add East/West Const fixer capability

aaron.ballman added a comment. In D69764#2055716 , @MyDeveloperDay wrote: > I really do appreciate the reviews and the comments especially regarding > east/west/left/right/wrong ;-), I know there won't be 100% agreement, but I > think most people who ev

[PATCH] D69764: [clang-format] Add East/West Const fixer capability

steveire added inline comments. Comment at: clang/lib/Format/EastWestConstFixer.cpp:22 + +#define DEBUG_TYPE "using-declarations-sorter" + Should this be removed? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69764/new/ https://reviews.llvm.org/D69764

[clang] 1e06b16 - [clang][docs] Document additional bits of libc that -ffreestanding envs must provide

Author: Jon Roelofs Date: 2020-05-26T15:42:32-06:00 New Revision: 1e06b169be3e59799b8dcaf16d1d03bd4c12da42 URL: https://github.com/llvm/llvm-project/commit/1e06b169be3e59799b8dcaf16d1d03bd4c12da42 DIFF: https://github.com/llvm/llvm-project/commit/1e06b169be3e59799b8dcaf16d1d03bd4c12da42.diff L

[PATCH] D80046: [StackSafety] Make full LTO to attach metadata if MTE is enabled

vitalybuka planned changes to this revision. vitalybuka added a comment. I'll probably abandon this. I've converted the pass into pure analysis and I need to upstream that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80046/new/ https://reviews.l

[PATCH] D80237: [hip] Ensure pointer in struct argument has proper `addrspacecast`.

arsenm added a comment. In D80237#2051933 , @rjmccall wrote: > Okay. Can you explain why we need to coerce in the first place, though? > Especially if the representation is the same, why is your target-lowering > requiring parameters to be coerced to i

[PATCH] D80222: Replace Clang's createRuntimeFunction with the definitions in OMPKinds.def

jhuber6 marked 3 inline comments as done. jhuber6 added inline comments. Comment at: llvm/include/llvm/Frontend/OpenMP/OMPKinds.def:250 +__OMP_SIZE_TYPE(SizeTy) +#undef __OMP_SIZE_TYPE + jdoerfert wrote: > Why the indirection via `__OMP_SIZE_TYPE`? Wouldn't `OMP_

[PATCH] D80222: Replace Clang's createRuntimeFunction with the definitions in OMPKinds.def

jdoerfert added inline comments. Comment at: llvm/include/llvm/Frontend/OpenMP/OMPKinds.def:250 +__OMP_SIZE_TYPE(SizeTy) +#undef __OMP_SIZE_TYPE + Why the indirection via `__OMP_SIZE_TYPE`? Wouldn't `OMP_TYPE(SizeTy, M.getDataLayout().getIntPtrType(Ctx))` suffic

[PATCH] D80472: [clangd] Add access specifier information to hover contents

danielmartin added a comment. Thanks for the review! I don't have commit access so I'd need someone to land this patch for me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80472/new/ https://reviews.llvm.org/D80472

[PATCH] D80436: [clang][docs] Document additional bits of libc that -ffreestanding envs must provide

jroelofs closed this revision. jroelofs added a comment. 1e06b169be3e59799b8dcaf16d1d03bd4c12da42 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80436/new/ https://reviews.llvm.o

[clang] efd1a8e - [analyzer][MallocChecker] Make NewDeleteLeaks depend on DynamicMemoryModeling rather than NewDelete

Author: Kristóf Umann Date: 2020-05-27T00:03:53+02:00 New Revision: efd1a8e66eaa13afff709ebf16ff6280caa82ead URL: https://github.com/llvm/llvm-project/commit/efd1a8e66eaa13afff709ebf16ff6280caa82ead DIFF: https://github.com/llvm/llvm-project/commit/efd1a8e66eaa13afff709ebf16ff6280caa82ead.diff

[clang] a924dac - [NFC] Fix formatting for the 'aix-ld.c' test case.

Author: stevewan Date: 2020-05-26T18:11:49-04:00 New Revision: a924dac44f31ffa19508165fc61a9f10cd1d4836 URL: https://github.com/llvm/llvm-project/commit/a924dac44f31ffa19508165fc61a9f10cd1d4836 DIFF: https://github.com/llvm/llvm-project/commit/a924dac44f31ffa19508165fc61a9f10cd1d4836.diff LOG:

[PATCH] D80020: [PowerPC] Add support for -mcpu=pwr10 in both clang and llvm

stefanp accepted this revision. stefanp added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80020/new/ https://reviews.llvm.org/D80020 ___ cfe-commits mailing list cfe-commits@lists.llv

[PATCH] D80590: [WIP][OPENMP] Fix assertion error for using alignas with OpenMP directive

cchen created this revision. Herald added subscribers: cfe-commits, sstefan1, guansong, yaxunl. Herald added a reviewer: jdoerfert. Herald added a project: clang. cchen added a comment. cchen added a reviewer: ABataev. cchen added subscribers: dreachem, sandoval. Haven't added test yet since I'm n

[PATCH] D80590: [WIP][OPENMP] Fix assertion error for using alignas with OpenMP directive

cchen added a comment. Haven't added test yet since I'm not sure in which file should I add the test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80590/new/ https://reviews.llvm.org/D80590 ___ cfe-co

[PATCH] D80409: [MS ABI] Add mangled type for auto template parameter whose argument kind is Integeral

zequanwu updated this revision to Diff 266339. zequanwu added a comment. Add `19.20` version. Only add mangled type for version 19. 20 or later to be abi-compatible with https://godbolt.org/z/Bhc__A CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80409/new/ https://reviews.llvm.org/D8040

[PATCH] D79721: [Clang][AArch64] Capturing proper pointer alignment for Neon vld1 intrinsicts

efriedma added a comment. This caused https://bugs.llvm.org/show_bug.cgi?id=46084 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79721/new/ https://reviews.llvm.org/D79721 ___ cfe-commits mailing list c

[PATCH] D79721: [Clang][AArch64] Capturing proper pointer alignment for Neon vld1 intrinsicts

efriedma added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:10331 +auto Alignment = CGM.getNaturalPointeeTypeAlignment( +E->getArg(0)->IgnoreParenCasts()->getType()); Ops[0] = Builder.CreateBitCast(Ops[0], llvm::PointerType::getUnqual(VTy)); -

[PATCH] D79895: Add a new warning to warn when passing uninitialized variables as const reference parameters to a function

zequanwu added a comment. @rsmith Are you okay with this patch? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79895/new/ https://reviews.llvm.org/D79895 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/

[PATCH] D80532: [NFC] Fix formatting for the 'aix-ld.c' test case.

This revision was automatically updated to reflect the committed changes. Closed by commit rGa924dac44f31: [NFC] Fix formatting for the 'aix-ld.c' test case. (authored by stevewan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80532/new/ https://re

[PATCH] D80055: Diagnose union tail padding

rsmith added a comment. In D80055#2055151 , @jfb wrote: > I was wondering if any of the tests were surprising to you, or if the > behavior described was as expected? I've highlighted one case where the test expectation doesn't match the standard rules.

[PATCH] D80020: [PowerPC] Add support for -mcpu=pwr10 in both clang and llvm

amyk accepted this revision. amyk added a comment. This LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80020/new/ https://reviews.llvm.org/D80020 ___ cfe-commits mailing list cfe-commits@lists.llv

<    1   2   3   >