steveire added a comment. @MyDeveloperDay Thanks for the update. I pinged you on slack about this, but I guess you're not using it at the moment. I asked if you have a git branch somewhere with this change. Downloading patches from phab is such a pain I have no idea why we use it.
If you can link me to a branch somehow, I can re-test this. Regarding #if 0 #else #endif blocks causing multiple re-parses, presumably this is because clang-format formats code in the "other" preprocessor branch? At least I think it reformats comments in that case. Maybe the problem can be worked around with that in mind. ================ Comment at: clang/docs/ClangFormatStyleOptions.rst:1378 +**ConstStyle** (``ConstAlignmentStyle``) + Different ways to arrange const. ---------------- klimek wrote: > MyDeveloperDay wrote: > > aaron.ballman wrote: > > > MyDeveloperDay wrote: > > > > klimek wrote: > > > > > Personally, I'm somewhat against having 3 different aliases for the > > > > > options. I'd chose one, even though it doesn't make everybody happy, > > > > > and move on. I'm fine with East/West as long as the documentation > > > > > makes it clear what it is. > > > > If I have to drop the other options, I think I'd want to go with > > > > East/West const as I feel it has more momentum, just letting people > > > > know before I change the code back (to my original patch ;-) ) > > > > > > > > https://www.youtube.com/watch?v=gRmI_gsNqcI > > > > > > > > {F10954065} > > > > > > > @klimek I requested that we do not go with East/West the options and I'm > > > still pretty insistent on it. East/West is a kitschy way to phrase it > > > that I think is somewhat US-centric (where we make a pretty big > > > distinction between the east and west coasts). I do not want to have to > > > mentally map left/right to the less-clear east/west in the config file. > > > Would you be fine if we only had Left/Right instead of East/West? I would > > > be fine with that option, but figured enough people like the cute > > > East/West designation that we might as well support it. > > Just for a reference, I'm not from the US and I think east/west still > > translates pretty well. I was happy to support the others. > I'd be fine with only having left/right; my personal feeling is also that > west-const / east-const has kinda become a term of art, though, so I really > don't know which one is "right" :) > > Generally, I think this is one of the cases where, given good docs, we're > quickly spending more engineering hours discussing the right solution than > it'll cost aggregated over all future users, under the assumption that people > do not write new configs very often, and the few who will, will quickly > remember. > > I'd be fine with only having left/right; my personal feeling is also that > west-const / east-const has kinda become a term of art, though, so I really > don't know which one is "right" :) This reminds me of the joke that Americans drive on the "Right" side of the road, and English drive on the "Correct" side. Sort of gives a different meaning to `ConstStyle : Right` and that the alternative is `Wrong` :). Maybe that language ambiguity is why `East`/`West` caught on. > people do not write new configs very often Agreed. It seems a small number of strong views might influence this enough to make `East`/`West` not be used. What a pity. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69764/new/ https://reviews.llvm.org/D69764 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
