[PATCH] D79155: [CodeGen] Increase applicability of ffine-grained-bitfield-accesses for targets with limited native integer widths

asb created this revision. asb added reviewers: wmi, hfinkel, efriedma. Herald added subscribers: cfe-commits, luismarques, sameer.abuasal, s.egerton, lenary, PkmX, simoncook. Herald added a project: clang. asb added a subscriber: apazos. As pointed out in PR45708

[clang-tools-extra] 97c407d - [clangd] Make use of URIs in FileShardedIndex

Author: Kadir Cetinkaya Date: 2020-04-30T09:47:59+02:00 New Revision: 97c407db772521cd69a86433672f981a13c0abb2 URL: https://github.com/llvm/llvm-project/commit/97c407db772521cd69a86433672f981a13c0abb2 DIFF: https://github.com/llvm/llvm-project/commit/97c407db772521cd69a86433672f981a13c0abb2.dif

[PATCH] D79155: [CodeGen] Increase applicability of ffine-grained-bitfield-accesses for targets with limited native integer widths

asb updated this revision to Diff 261138. asb added a comment. Updated patch to include full context. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79155/new/ https://reviews.llvm.org/D79155 Files: clang/lib/CodeGen/CGRecordLayoutBuilder.cpp clang/test/CodeGenCXX/finegrain-bitfield

[PATCH] D77940: [AArch64] Add NVIDIA Carmel support

tambre added a comment. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. sdesmalen: ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77940/new/ https://reviews.llvm.org/D77940 _

[PATCH] D77491: [Sema] Fix incompatible builtin redeclarations in non-global scope

tambre added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77491/new/ https://reviews.llvm.org/D77491 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-

[PATCH] D46317: [clang-tidy] New check bugprone-map-subscript-operator-lookup

khuttun updated this revision to Diff 261141. khuttun added a comment. Fixed @Eugene.Zelenko's comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D46317/new/ https://reviews.llvm.org/D46317 Files: clang-tools-extra/clang-tidy/bugprone/BugproneTidyModule.cpp clang-tools-extra/cla

[PATCH] D79079: [clangd] Make use of URIs in FileShardedIndex

This revision was automatically updated to reflect the committed changes. kadircet marked an inline comment as done. Closed by commit rG97c407db7725: [clangd] Make use of URIs in FileShardedIndex (authored by kadircet). Changed prior to commit: https://reviews.llvm.org/D79079?vs=261061&id=26114

[PATCH] D46317: [clang-tidy] New check bugprone-map-subscript-operator-lookup

khuttun updated this revision to Diff 261142. khuttun added a comment. Accidentally removed the options documentation in the previous patch... Now added it back. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D46317/new/ https://reviews.llvm.org/D46317 Files: clang-tools-extra/clang-t

[PATCH] D79156: [analyzer] Merge implementations of SymInt, IntSym, and SymSym exprs

vsavchenko created this revision. vsavchenko added reviewers: NoQ, dcoughlin. Herald added subscribers: cfe-commits, ASDenysPetrov, martong, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a project: clang. SymIntExpr, IntS

[clang-tools-extra] 0dedb43 - [clangd] Fix windows build bots without rvalue refs

Author: Kadir Cetinkaya Date: 2020-04-30T10:25:22+02:00 New Revision: 0dedb43153e67b19ddaade384b0ccb1028a6f4ad URL: https://github.com/llvm/llvm-project/commit/0dedb43153e67b19ddaade384b0ccb1028a6f4ad DIFF: https://github.com/llvm/llvm-project/commit/0dedb43153e67b19ddaade384b0ccb1028a6f4ad.dif

[PATCH] D79095: [clang-format] NFC Correct clang-format headers file so documentation can be once again autogenerated

krasimir added a comment. In D79095#2010271 , @MyDeveloperDay wrote: > In D79095#2010250 , @krasimir wrote: > > > Awesome! Thank you! > > Now that we've got "clang/phabricator/lint/git" robots that leave comments

[PATCH] D76066: [ARM][MachineOutliner] Add Machine Outliner support for ARM

samparker added inline comments. Comment at: llvm/lib/Target/ARM/ARMBaseInstrInfo.cpp:5606 + // candidates. + auto CantGuaranteeValueAcrossCall = [&TRI](outliner::Candidate &C) { +// If the unsafe registers in this block are all dead, then we don't need yro

[PATCH] D79157: [clangd] Render code complete documentation as plaintext/markdown.

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Structure is parsed from the raw comment using the existing heuristics used for hover. Repository:

[PATCH] D77940: [AArch64] Add NVIDIA Carmel support

sdesmalen accepted this revision. sdesmalen added a comment. This revision is now accepted and ready to land. LGTM! Comment at: llvm/unittests/Support/TargetParserTest.cpp:1134 AArch64::ArchKind::INVALID, "sve2")); + EXPECT_TRUE( + test

[PATCH] D71124: [RISCV] support clang driver to select cpu

kito-cheng added a comment. Another proposal for -mcpu and -mtune: Decoupling the -mcpu and -mtune option, -mcpu only accept concrete CPU, and -mtune for micro-arch/pipeline model, they accept different option set. e.g. -mcpu=sifive-e24 # Imply -march=rv32imafc -mtune=sifive-2-series -mtune=sif

[PATCH] D77940: [AArch64] Add NVIDIA Carmel support

tambre added a comment. In D77940#2012092 , @sdesmalen wrote: > LGTM! Please land this for me as I lack commit privileges. :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77940/new/ https://reviews.llvm.

[PATCH] D78429: [clangd] Metric tracking through Tracer

kadircet marked 8 inline comments as done. kadircet added inline comments. Comment at: clang-tools-extra/clangd/Trace.h:35 +/// itself to active tracer on destruction. +struct Metric { + enum Type { sammccall wrote: > Conceptually there's a difference between a

[PATCH] D78429: [clangd] Metric tracking through Tracer

kadircet updated this revision to Diff 261156. kadircet marked an inline comment as done. kadircet added a comment. - Separate concept of a metric and measurement - Tie latency tracking to trace::Spans. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D79160: [AST] Preserve the type in RecoveryExprs for broken function calls.

hokein created this revision. Herald added subscribers: cfe-commits, arphaman. Herald added a project: clang. RecoveryExprs was modeled as dependent type to prevent bogus diagnostics and crashes in clang. This patch allows to preseve the type for broken calls when the RecoveryEprs have a known ty

[PATCH] D79157: [clangd] Render code complete documentation as plaintext/markdown.

kadircet marked an inline comment as done. kadircet added a comment. thanks, mostly LG apart from dropping of white-space only comments. Comment at: clang-tools-extra/clangd/CodeComplete.cpp:377 + auto SetDoc = [&](llvm::StringRef Doc) { +if (!Doc.trim().empty()) {

[PATCH] D76066: [ARM][MachineOutliner] Add Machine Outliner support for ARM

yroux added inline comments. Comment at: llvm/lib/Target/ARM/ARMBaseInstrInfo.cpp:5606 + // candidates. + auto CantGuaranteeValueAcrossCall = [&TRI](outliner::Candidate &C) { +// If the unsafe registers in this block are all dead, then we don't need sampark

[clang] 0fa7e4a - [clang-format] NFC Correct clang-format headers file so documentation can be once again autogenerated

Author: mydeveloperday Date: 2020-04-30T10:50:29+01:00 New Revision: 0fa7e4adcafb35126f87fb3a45f6f668c994c3e7 URL: https://github.com/llvm/llvm-project/commit/0fa7e4adcafb35126f87fb3a45f6f668c994c3e7 DIFF: https://github.com/llvm/llvm-project/commit/0fa7e4adcafb35126f87fb3a45f6f668c994c3e7.diff

[clang] b01dca5 - [clang-format] [PR45357] Fix issue found with operator spacing

Author: mydeveloperday Date: 2020-04-30T10:55:59+01:00 New Revision: b01dca50085768f1f1a5ad21a685906d48c38816 URL: https://github.com/llvm/llvm-project/commit/b01dca50085768f1f1a5ad21a685906d48c38816 DIFF: https://github.com/llvm/llvm-project/commit/b01dca50085768f1f1a5ad21a685906d48c38816.diff

[PATCH] D71124: [RISCV] support clang driver to select cpu

khchen updated this revision to Diff 261165. khchen marked 9 inline comments as done. khchen added a comment. address @lenary's review feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71124/new/ https://reviews.llvm.org/D71124 Files: clang

[PATCH] D79142: [clangd] Render doc-comment code spans with `backticks` in plaintext mode

kadircet added inline comments. Comment at: clang-tools-extra/clangd/FormattedString.cpp:365 +llvm::StringRef Marker = ""; +if (C.Preserve && C.Kind == Chunk::InlineCode) + Marker = "`"; should we rather use `renderInlineBlock` here ? because in pres

[PATCH] D79160: [AST] Preserve the type in RecoveryExprs for broken function calls.

hokein updated this revision to Diff 261167. hokein marked 3 inline comments as done. hokein added a comment. update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79160/new/ https://reviews.llvm.org/D79160 Files: clang/include/clang/AST/Expr.h

[PATCH] D78643: [OpenMP] Fix false error report of array subscription for templated indexes.

h-joo marked an inline comment as done. h-joo added a comment. Sorry, I feel like I'm holding back the fix for this bug since I'm stuck on how to proceed with the build failure, @ABataev would you like to proceed with the other revision that you were working on?

[PATCH] D79160: [AST] Preserve the type in RecoveryExprs for broken function calls.

hokein added inline comments. Comment at: clang/lib/Sema/SemaOverload.cpp:12779 +// Guess at what the return type for an unresolvable overload should be. +static QualType chooseRecoveryType(OverloadCandidateSet &CS, I steal this function from D61722.

[PATCH] D71124: [RISCV] support clang driver to select cpu

khchen added a comment. In D71124#2010759 , @lenary wrote: > This is looking good. > > I remember we discussed this on the LLVM call a few weeks ago - there was a > discussion as to whether we should be prioritising `-march` or `-mcpu` - do > you recall

[PATCH] D76066: [ARM][MachineOutliner] Add Machine Outliner support for ARM

samparker added inline comments. Comment at: llvm/lib/Target/ARM/ARMBaseInstrInfo.cpp:5606 + // candidates. + auto CantGuaranteeValueAcrossCall = [&TRI](outliner::Candidate &C) { +// If the unsafe registers in this block are all dead, then we don't need yro

[PATCH] D73951: [Clang] [Driver]Add logic to search for flang frontend

CarolineConcatto added a comment. @awarzynski If we don't foresee a use for this flag beside the problem I've faced, then I am fine to remove and only replace by flang-tmp. But as we discuss this flag enables flang driver to call another driver, basically cross-compilation. That could be a usef

[PATCH] D78350: [AST] Build recovery expressions by default for C++.

hokein marked an inline comment as done. hokein added a comment. In D78350#2009345 , @hubert.reinterpretcast wrote: > In D78350#2007065 , @hokein wrote: > > > In D78350#2006469

[PATCH] D78879: [clang-format] [PR45357] Fix issue found with operator spacing

This revision was automatically updated to reflect the committed changes. Closed by commit rGb01dca500857: [clang-format] [PR45357] Fix issue found with operator spacing (authored by MyDeveloperDay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D7887

[clang] 14198cc - [clang-format] Fix lambda with ellipsis in return type

Author: mydeveloperday Date: 2020-04-30T11:02:42+01:00 New Revision: 14198ccfb3837a2972d39ac446454ca5f175838c URL: https://github.com/llvm/llvm-project/commit/14198ccfb3837a2972d39ac446454ca5f175838c DIFF: https://github.com/llvm/llvm-project/commit/14198ccfb3837a2972d39ac446454ca5f175838c.diff

[PATCH] D79095: [clang-format] NFC Correct clang-format headers file so documentation can be once again autogenerated

This revision was automatically updated to reflect the committed changes. Closed by commit rG0fa7e4adcafb: [clang-format] NFC Correct clang-format headers file so documentation can be… (authored by MyDeveloperDay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews

[PATCH] D78694: [clang-format] Fix lambda with ellipsis in return type

This revision was automatically updated to reflect the committed changes. Closed by commit rG14198ccfb383: [clang-format] Fix lambda with ellipsis in return type (authored by MyDeveloperDay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78694/new/

[clang] 5733226 - [clang-format] Correct the AfterControlStatement configuration option output style

Author: mydeveloperday Date: 2020-04-30T11:05:02+01:00 New Revision: 573322694ad332c1cf3e7b27afe002fd46f561f7 URL: https://github.com/llvm/llvm-project/commit/573322694ad332c1cf3e7b27afe002fd46f561f7 DIFF: https://github.com/llvm/llvm-project/commit/573322694ad332c1cf3e7b27afe002fd46f561f7.diff

[clang] a8b8bd0 - [clang-format] Fix a bug causing BeforeLambdaBody to affect brace initialiser formatting

Author: mydeveloperday Date: 2020-04-30T11:11:34+01:00 New Revision: a8b8bd0f8d55856858236b36c508eb1d1f4bb6f1 URL: https://github.com/llvm/llvm-project/commit/a8b8bd0f8d55856858236b36c508eb1d1f4bb6f1 DIFF: https://github.com/llvm/llvm-project/commit/a8b8bd0f8d55856858236b36c508eb1d1f4bb6f1.diff

[clang-tools-extra] 7a3be97 - [clangd][Hover] Get rid of unused private field in Paragraph

Author: Kadir Cetinkaya Date: 2020-04-30T12:13:18+02:00 New Revision: 7a3be975b92fece93e07bfc6451e9a39eb6f5142 URL: https://github.com/llvm/llvm-project/commit/7a3be975b92fece93e07bfc6451e9a39eb6f5142 DIFF: https://github.com/llvm/llvm-project/commit/7a3be975b92fece93e07bfc6451e9a39eb6f5142.dif

[PATCH] D73951: [Clang] [Driver]Add logic to search for flang frontend

richard.barton.arm added a comment. So, coming back to this after a few weeks break. I agree with the point @awarzynski makes on this option being powerful and I think your alternative suggestion of using a different hard-coded name could work well at this stage of the project. I think the usec

[PATCH] D78982: [clang-format] Fix Microsoft style for enums

MyDeveloperDay added a comment. You will need to rebase as the non related rst changes have been handled by D79095: [clang-format] NFC Correct clang-format headers file so documentation can be once again autogenerated CHANGES SINCE LAST ACTION https://review

[PATCH] D71124: [RISCV] support clang driver to select cpu

khchen added a comment. In D71124#2012090 , @kito-cheng wrote: > Another proposal for -mcpu and -mtune: > > Decoupling the -mcpu and -mtune option, -mcpu only accept concrete CPU, and > -mtune for micro-arch/pipeline model, they accept different option se

[PATCH] D79022: [clang-format] Fix a bug causing BeforeLambdaBody to affect brace initialiser formatting

This revision was automatically updated to reflect the committed changes. Closed by commit rGa8b8bd0f8d55: [clang-format] Fix a bug causing BeforeLambdaBody to affect brace initialiser… (authored by MyDeveloperDay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[PATCH] D79020: [clang-format] Correct the AfterControlStatement configuration option output style

This revision was automatically updated to reflect the committed changes. Closed by commit rG573322694ad3: [clang-format] Correct the AfterControlStatement configuration option output… (authored by MyDeveloperDay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews

[PATCH] D78429: [clangd] Metric tracking through Tracer

sammccall added a comment. I like this a lot! Comment at: clang-tools-extra/clangd/ClangdLSPServer.cpp:46 +// Tracks end-to-end latency of high level lsp calls. +constexpr trace::Metric LSPLatencies("lsp_latencies", comment should mention the label schema if

[PATCH] D78350: [AST] Build recovery expressions by default for C++.

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Code LG, let's chat before landing though - want to understand the state of the internal testing. Comment at: clang/include/clang/Basic/LangOptions.def:151 -COMPATIB

[PATCH] D79139: [clangd] Fix whitespace between chunks in markdown paragraphs.

kadircet marked an inline comment as done. kadircet added inline comments. Comment at: clang-tools-extra/clangd/FormattedString.cpp:419 C.Contents = std::move(Norm); C.Kind = Chunk::InlineCode; return *this; i think we always want a space before code chu

[PATCH] D79142: [clangd] Render doc-comment code spans with `backticks` in plaintext mode

sammccall marked an inline comment as done. sammccall added inline comments. Comment at: clang-tools-extra/clangd/FormattedString.cpp:365 +llvm::StringRef Marker = ""; +if (C.Preserve && C.Kind == Chunk::InlineCode) + Marker = "`"; kadircet wrote: >

[PATCH] D79142: [clangd] Render doc-comment code spans with `backticks` in plaintext mode

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. LGTM thanks! Comment at: clang-tools-extra/clangd/FormattedString.cpp:365 +llvm::StringRef Marker = ""; +if (C.Preserve && C.Kind == Chunk::InlineCode) + Mar

[PATCH] D79157: [clangd] Render code complete documentation as plaintext/markdown.

sammccall marked 6 inline comments as done. sammccall added inline comments. Comment at: clang-tools-extra/clangd/CodeComplete.cpp:377 + auto SetDoc = [&](llvm::StringRef Doc) { +if (!Doc.trim().empty()) { + Completion.Documentation.emplace(); --

[PATCH] D79157: [clangd] Render code complete documentation as plaintext/markdown.

sammccall updated this revision to Diff 261185. sammccall marked an inline comment as done. sammccall added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79157/new/ https://reviews.llvm.org/D79157 Files: clang-tools-e

[PATCH] D72326: [clang-format] Rebased on master: Add option to specify explicit config file

MyDeveloperDay added a comment. These tests still fail running the following in the build directory (if your build directory is side-by-side with the llvm-project directory): c:/Python37/python ./bin/llvm-lit.py -v ./tools/clang/test/Format $ ./run_format_lit_tests.sh llvm-lit.py: C:\cygw

Re: [clang-tools-extra] 97c407d - [clangd] Make use of URIs in FileShardedIndex

Hi Kadir, I'm seeing a couple of windows buildbots failing to build FileIndexTests.cpp, even after the follow up in 0dedb43153e6: http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/32109 http://lab.llvm.org:8011/builders/clang-x64-windows-msvc/builds/15

[clang-tools-extra] 932a2b8 - [clangd] Fix VS2019 build bots too

Author: Kadir Cetinkaya Date: 2020-04-30T14:01:09+02:00 New Revision: 932a2b82641393df9b18eac3337491fdc64fe328 URL: https://github.com/llvm/llvm-project/commit/932a2b82641393df9b18eac3337491fdc64fe328 DIFF: https://github.com/llvm/llvm-project/commit/932a2b82641393df9b18eac3337491fdc64fe328.dif

[PATCH] D79156: [analyzer] Merge implementations of SymInt, IntSym, and SymSym exprs

xazax.hun accepted this revision. xazax.hun added a comment. This revision is now accepted and ready to land. Herald added a subscriber: rnkovacs. Nice catch, LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79156/new/ https://reviews.llvm.org/D

[PATCH] D79106: [clangd] Move inserted include from detail -> documentation.

hokein accepted this revision. hokein added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/CodeComplete.cpp:1834 if (InsertInclude) -LSP.detail += "\n" + InsertInclude->Header; - LSP.documentation = Documentation; +

[PATCH] D72326: [clang-format] Rebased on master: Add option to specify explicit config file

MyDeveloperDay requested changes to this revision. MyDeveloperDay added inline comments. This revision now requires changes to proceed. Comment at: clang/lib/Format/Format.cpp:2693 + llvm::vfs::FileSystem *FS, +

[clang] e0c3565 - [NFC][clang] Replace raw new/delete with unique_ptr to store ABIInfo in TargetCodeGenInfo

Author: jasonliu Date: 2020-04-30T12:31:50Z New Revision: e0c356582d2fc32ac3f70580b07bcf809d46a0b8 URL: https://github.com/llvm/llvm-project/commit/e0c356582d2fc32ac3f70580b07bcf809d46a0b8 DIFF: https://github.com/llvm/llvm-project/commit/e0c356582d2fc32ac3f70580b07bcf809d46a0b8.diff LOG: [NFC

[PATCH] D79160: [AST] Preserve the type in RecoveryExprs for broken function calls.

sammccall marked an inline comment as done. sammccall added inline comments. Comment at: clang/include/clang/AST/Expr.h:6042 /// /// For now, RecoveryExpr is type-, value- and instantiation-dependent to take /// advantage of existing machinery to deal with dependent code in C+

[PATCH] D78643: [OpenMP] Fix false error report of array subscription for templated indexes.

jdoerfert added a comment. In D78643#2012212 , @h-joo wrote: > Sorry, I feel like I'm holding back the fix for this bug since I'm stuck on > how to proceed with the build failure, @ABataev would you like to proceed > with the other revision

[PATCH] D79033: [NFC][clang] Replace raw new/delete with unique_ptr to store ABIInfo in TargetCodeGenInfo

This revision was automatically updated to reflect the committed changes. Closed by commit rGe0c356582d2f: [NFC][clang] Replace raw new/delete with unique_ptr to store ABIInfo in… (authored by jasonliu). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D78738: [OPENMP50]Support 'task' modifier in reduction clauses.

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. I'm assuming we do not have to check that no one uses `task, inscan: + : m`, right? If so, LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D78862: [IR] Convert null-pointer-is-valid into an enum attribute

jdoerfert added a comment. I think this is an improvement over the status quo and it looks fine to me. @arsenm I agree that we should tie this to the data layout (or at least should try) but I guess there are open questions to answer and code to write. I propose to accept this and work on the DL

[PATCH] D79156: [analyzer] Merge implementations of SymInt, IntSym, and SymSym exprs

NoQ accepted this revision. NoQ added a comment. That's... pretty neat. I wouldn't have thought of that. Looking forward to those `SymLocAsIntegerExpr`s. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79156/new/ https://reviews.llvm.org/D79156 _

[PATCH] D79167: [SVE][CodeGen] Legalise scalable vector types for vsetcc & vselect

kmclaughlin created this revision. kmclaughlin added reviewers: sdesmalen, efriedma, dancgr. Herald added subscribers: psnobl, rkruppe, hiraditya, tschuett. Herald added a project: LLVM. kmclaughlin added a parent revision: D79087: [SVE][Codegen] Lower legal min & max operations. The visitSelect

[PATCH] D79087: [SVE][Codegen] Lower legal min & max operations

kmclaughlin marked an inline comment as done. kmclaughlin added inline comments. Comment at: llvm/lib/Target/AArch64/SVEInstrFormats.td:3851 + def : SVE_1_Op_Imm_Arith_Pred_Pat(NAME # _S)>; + def : SVE_1_Op_Imm_Arith_Pred_Pat(NAME # _D)>; } efriedma wrote: > I

[PATCH] D78643: [OpenMP] Fix false error report of array subscription for templated indexes.

h-joo added a comment. In D78643#2012511 , @jdoerfert wrote: > In D78643#2012212 , @h-joo wrote: > > > Sorry, I feel like I'm holding back the fix for this bug since I'm stuck on > > how to proceed with the build f

[PATCH] D78969: [clang][OpenMP] Fix getNDSWDS for aarch64.

jdoerfert added a comment. Is the NDS and WDS number never visible in the IR, e.g., as part of the name? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78969/new/ https://reviews.llvm.org/D78969 ___ cfe

[PATCH] D78429: [clangd] Metric tracking through Tracer

kadircet updated this revision to Diff 261208. kadircet marked 23 inline comments as done. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78429/new/ https://reviews.llvm.org/D78429 Files: clang-tools-e

[PATCH] D79170: Fix minor errors

CarolineConcatto created this revision. Herald added subscribers: cfe-commits, kristof.beyls. Herald added a reviewer: DavidTruby. Herald added a reviewer: sscalpone. Herald added a project: clang. Signed-off-by: Caroline Concatto Repository: rG LLVM Github Monorepo https://reviews.llvm.org/

[PATCH] D78965: [clang][OpenMP] Fix mangling of linear parameters.

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. Code LGTM. I trust you know about mangling. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:11402 + .getTypeSizeInChars(P->getPoin

[PATCH] D78941: [OPENMP]Allow cancellation constructs in target parallel regions.

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78941/new/ https://reviews.llvm.org/D78941

[PATCH] D78429: [clangd] Metric tracking through Tracer

kadircet added inline comments. Comment at: clang-tools-extra/clangd/ClangdLSPServer.cpp:46 +// Tracks end-to-end latency of high level lsp calls. +constexpr trace::Metric LSPLatencies("lsp_latencies", sammccall wrote: > sammccall wrote: > > comment should ment

[clang-tools-extra] 594be17 - [clangd] Second attempt at fixing VS2019 build bots

Author: Kadir Cetinkaya Date: 2020-04-30T15:37:33+02:00 New Revision: 594be179c960af2cbc4f68dff4a30cc70179a83e URL: https://github.com/llvm/llvm-project/commit/594be179c960af2cbc4f68dff4a30cc70179a83e DIFF: https://github.com/llvm/llvm-project/commit/594be179c960af2cbc4f68dff4a30cc70179a83e.dif

Re: [clang-tools-extra] 97c407d - [clangd] Make use of URIs in FileShardedIndex

Thanks for bringing this up Jeremy, for some reason(I suppose due to the existing breakage in the bot) I haven't received any mails regarding this breakage. Sent out 2 patches, first one seemed to fix something, but wasn't enough. The bots have a really slow turnaround though, so it takes a while

[PATCH] D79172: [clang-format] [PR45626] SpacesInAngles does not insert or preserve leading space before :: operator

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: krasimir, mitchell-stellar. MyDeveloperDay added projects: clang, clang-format. See https://bugs.llvm.org/show_bug.cgi?id=45626 void f() { (void)static_cast<::std::uint32_t>(1); (void)static_cast< ::std::uint32_t >(1); }

[PATCH] D79170: Fix minor errors

CarolineConcatto abandoned this revision. CarolineConcatto added a comment. This patch has landed here by mistake. This is should be an update on: https://reviews.llvm.org/D73951 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79170/new/ https://r

[PATCH] D73951: [Clang] [Driver]Add logic to search for flang frontend

awarzynski added a comment. @richard.barton.arm @CarolineConcatto thank you both for clarification! @CarolineConcatto , if you prefer to go ahead with this approach - could you please address all the outstanding comments? I've left a few comments that I'd like addressed first, but nothing majo

[PATCH] D79157: [clangd] Render code complete documentation as plaintext/markdown.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. LGTM thanks! Comment at: clang-tools-extra/clangd/CodeComplete.cpp:377 + auto SetDoc = [&](llvm::StringRef Doc) { +if (!Doc.trim().empty()) { + Comp

[PATCH] D79087: [SVE][Codegen] Lower legal min & max operations

efriedma added inline comments. Comment at: llvm/lib/Target/AArch64/SVEInstrFormats.td:3851 + def : SVE_1_Op_Imm_Arith_Pred_Pat(NAME # _S)>; + def : SVE_1_Op_Imm_Arith_Pred_Pat(NAME # _D)>; } kmclaughlin wrote: > efriedma wrote: > > I don't see any test for th

[PATCH] D77229: [Analyzer][WIP] Avoid handling of LazyCompundVals in IteratorModeling

baloghadamsoftware updated this revision to Diff 261218. baloghadamsoftware added a comment. Bug reporter visitors updated, failing tests reduced from 19 to 6. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77229/new/ https://reviews.llvm.org/D77229 Files: clang/include/clang/StaticAn

[PATCH] D76932: [AIX] emit .extern and .weak directive linkage

This revision was automatically updated to reflect the committed changes. Closed by commit rGa2c8cd18128d: [AIX] emit .extern and .weak directive linkage (authored by DiggerLin). Changed prior to commit: https://reviews.llvm.org/D76932?vs=261004&id=261219#toc Repository: rG LLVM Github Monor

[clang-tools-extra] ad2da05 - [clangd] Get rid of move semantics to unbreak windows build bots

Author: Kadir Cetinkaya Date: 2020-04-30T16:43:50+02:00 New Revision: ad2da0521a66281be36a9adf54a8ea4293fe27cb URL: https://github.com/llvm/llvm-project/commit/ad2da0521a66281be36a9adf54a8ea4293fe27cb DIFF: https://github.com/llvm/llvm-project/commit/ad2da0521a66281be36a9adf54a8ea4293fe27cb.dif

[PATCH] D78969: [clang][OpenMP] Fix getNDSWDS for aarch64.

fpetrogalli added a comment. In D78969#2012591 , @jdoerfert wrote: > Is the NDS and WDS number never visible in the IR, e.g., as part of the name? Hang on, thanks for asking the question, maybe I can work something out here! :) They won't be visible in

[PATCH] D78965: [clang][OpenMP] Fix mangling of linear parameters.

fpetrogalli updated this revision to Diff 261225. fpetrogalli added a comment. Address review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78965/new/ https://reviews.llvm.org/D78965 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp clang/test/Ope

[PATCH] D79172: [clang-format] [PR45626] SpacesInAngles does not insert or preserve leading space before :: operator

krasimir accepted this revision. krasimir added a comment. This revision is now accepted and ready to land. Thank you! Comment at: clang/unittests/Format/FormatTest.cpp:8486 + FormatStyle SpaceBetweenBraces = getLLVMStyle(); nit: I suppose this newline was

[PATCH] D72841: Add support for pragma float_control, to control precision and exception behavior at the source level

mibintc marked an inline comment as done. mibintc added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:870 +def err_pragma_fenv_requires_precise : Error< + "'#pragma STDC FENV_ACCESS ON' is illegal when precise is disabled">; def warn_cxx_ms_struc

[PATCH] D76287: [analysis][analyzer] Introduce the skeleton of a reaching definitions calculator

martong added inline comments. Comment at: clang/lib/Analysis/ReachingDefinitions.cpp:269 + for (const CFGBlock *Succ : N->succs()) +Worklist.push_back(Succ); +} I understand that this is the worklist algorithm uplifted from Wikipedia. But how d

[PATCH] D71124: [RISCV] support clang driver to select cpu

kito-cheng added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/RISCV.cpp:478 // 1. Explicit choices using `--with-abi=` - // 2. A default based on `--with-arch=`, if provided - // 3. A default based on the target triple's arch + // 2. A default based on arch

[PATCH] D77621: ADT: SmallVector size/capacity use word-size integers when elements are small

dblaikie added inline comments. Comment at: llvm/include/llvm/ADT/SmallVector.h:52 + // The maximum size depends on size_type used. + static constexpr size_t SizeMax() { +return std::numeric_limits::max(); smeenai wrote: > browneee wrote: > > dexonsmith wro

[PATCH] D74166: [AIX][Frontend] Static init implementation for AIX considering no priority

daltenty added inline comments. Comment at: clang/lib/CodeGen/CGDeclCXX.cpp:583 + if (UseSinitAndSterm) +GlobalUniqueModuleId = getUniqueModuleId(&getModule()).substr(1); + if `getUniqueModuleId()` returns an empy string, which it does for modules which don

[PATCH] D72841: Add support for pragma float_control, to control precision and exception behavior at the source level

erichkeane added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:870 +def err_pragma_fenv_requires_precise : Error< + "'#pragma STDC FENV_ACCESS ON' is illegal when precise is disabled">; def warn_cxx_ms_struct : mibintc wrote: > e

[PATCH] D78429: [clangd] Metric tracking through Tracer

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Awesome, ship it! ... though, how do you feel about testing the actual metrics we export? Suggest a slightly generalized TestTracer that installs itself (RAII), and has a // Returns r

[PATCH] D78982: [clang-format] Fix Microsoft style for enums

asmith updated this revision to Diff 261239. asmith marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78982/new/ https://reviews.llvm.org/D78982 Files: clang/docs/ClangFormatStyleOptions.rst clang/include/clang/Format/Format.h clang/lib/Format/Format.c

[PATCH] D76066: [ARM][MachineOutliner] Add Machine Outliner support for ARM

yroux updated this revision to Diff 261237. yroux added a comment. This update avoids outlining MVE instructions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76066/new/ https://reviews.llvm.org/D76066 Files: clang/lib/Driver/ToolChains/Clang.c

[PATCH] D78982: [clang-format] Fix Microsoft style for enums

asmith updated this revision to Diff 261246. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78982/new/ https://reviews.llvm.org/D78982 Files: clang/docs/ClangFormatStyleOptions.rst clang/include/clang/Format/Format.h clang/lib/Format/Format.cpp clang/lib/Format/UnwrappedLineParser

[PATCH] D78982: [clang-format] Fix Microsoft style for enums

asmith updated this revision to Diff 261247. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78982/new/ https://reviews.llvm.org/D78982 Files: clang/docs/ClangFormatStyleOptions.rst clang/include/clang/Format/Format.h clang/lib/Format/Format.cpp clang/lib/Format/UnwrappedLineParser

[clang] 292058a - [clang-format] Fix Microsoft style for enums

Author: Aaron Smith Date: 2020-04-30T09:11:54-07:00 New Revision: 292058a5d6d708ec7d285a452d4350b33ba080dc URL: https://github.com/llvm/llvm-project/commit/292058a5d6d708ec7d285a452d4350b33ba080dc DIFF: https://github.com/llvm/llvm-project/commit/292058a5d6d708ec7d285a452d4350b33ba080dc.diff L

[PATCH] D78982: [clang-format] Fix Microsoft style for enums

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78982/new/ https://reviews.llvm.org/D78982 ___ cfe-commits mailing li

[PATCH] D78982: [clang-format] Fix Microsoft style for enums

asmith added a comment. In D78982#2012992 , @MyDeveloperDay wrote: > LGTM Thanks for the help! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78982/new/ https://reviews.llvm.org/D78982 ___ cfe-com

  1   2   3   >