kito-cheng added inline comments.
================ Comment at: clang/lib/Driver/ToolChains/Arch/RISCV.cpp:478 // 1. Explicit choices using `--with-abi=` - // 2. A default based on `--with-arch=`, if provided - // 3. A default based on the target triple's arch + // 2. A default based on arch // ---------------- I think it worth to keep this comment untouched, since it describing GCC's behavior. ================ Comment at: clang/lib/Driver/ToolChains/Arch/RISCV.cpp:531 + // 3. A default based on `--with-abi=`, if provided + // 4. A default based on the target triple's arch // ---------------- This part seems like is describing about GCC's behavior, so it should not change unless GCC changed? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71124/new/ https://reviews.llvm.org/D71124 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
