[PATCH] D78129: Add Marvell ThunderX3T110 support

chill added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64InstrInfo.td:849-857 +// These pointer authentication instructions require armv8.3a +let Predicates = [HasV8_3a, HasPA] in { let Uses = [LR], Defs = [LR] in { def PACIAZ : SystemNoOperands<0b000, "hint\

[PATCH] D78129: Add Marvell ThunderX3T110 support

DavidSpickett added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/AArch64.cpp:89 CPU = llvm::sys::getHostCPUName(); - if (CPU == "generic") { Remove stray change. Comment at: llvm/include/llvm/Support/AArch64TargetParser

[PATCH] D78129: Add Marvell ThunderX3T110 support

DavidSpickett added inline comments. Comment at: llvm/include/llvm/Support/AArch64TargetParser.def:168 + (AArch64::AEK_CRC | AEK_CRYPTO | AEK_FP | AEK_SIMD | AEK_LSE | AEK_RAND)) +AARCH64_CPU_NAME("thunderx3t110", ARMV8_3A, FK_CRYPTO_NEON_FP_ARMV8, false, +

[PATCH] D79072: [Analyzer][VLASizeChecker] Check VLA size in typedef and sizeof.

balazske created this revision. Herald added subscribers: cfe-commits, ASDenysPetrov, martong, Charusso, gamesh411, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a reviewer: Szelethus. Herald added a project: clang. The check of VL

[PATCH] D79076: [clang] [MinGW] Add the compiler rt libdirs to the search path

mstorsjo created this revision. mstorsjo added reviewers: rnk, hans. Herald added a project: clang. This matches what is done for MSVC in b8000c0ce84541c5b5535419234fb65ce77d6756 . Since that commit, compiler rt sanitizer libra

[PATCH] D78990: [analyzer] Allow bindings of the CompoundLiteralRegion

NoQ added a comment. Yay unit tests! Let's squash those mutually cancelling bugs. Comment at: clang/unittests/StaticAnalyzer/StoreTest.cpp:22-32 + struct TestContext { +StoreManager &SManager; +SValBuilder &Builder; +MemRegionManager &MRManager; +ASTContext &AS

[PATCH] D78286: [analyzer] Track runtime types represented by Obj-C Class objects

NoQ added a comment. Perfect! Please get yourself some commit access already -__- Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78286/new/ https://reviews.llvm.org/D78286 ___ cfe-commits mailing list c

[PATCH] D78374: [Analyzer][StreamChecker] Added evaluation of fread and fwrite.

balazske marked 3 inline comments as done. balazske added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StreamChecker.cpp:207-210 + {{"fread", 4}, + {&StreamChecker::preFread, +std::bind(&StreamChecker::evalFreadFwrite, _1, _2, _3, _4, +

[PATCH] D78129: Add Marvell ThunderX3T110 support

SjoerdMeijer added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64.td:849 + HasV8_1aOps, + HasV8_3aOps]>; + `HasV8_3aOps` implies `HasV8_2aOps`, which implies `HasV8_1a

[clang] 239c53b - [analyzer] Track runtime types represented by Obj-C Class objects

Author: Valeriy Savchenko Date: 2020-04-29T13:35:53+03:00 New Revision: 239c53b72b18d6fd6c5ad9a6d27cd09b950dc97a URL: https://github.com/llvm/llvm-project/commit/239c53b72b18d6fd6c5ad9a6d27cd09b950dc97a DIFF: https://github.com/llvm/llvm-project/commit/239c53b72b18d6fd6c5ad9a6d27cd09b950dc97a.d

[PATCH] D79079: [clangd] Make use of URIs in FileShardedIndex

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. This makes FileShardedIndex more robust and gets rid of the need for a URIToFileCache, as it is done by

[PATCH] D79000: [clang-format] C# property formatting can be controlled by config options

jbcoe added a comment. public int Style2 { get; set } appears in MS examples https://docs.microsoft.com/en-us/dotnet/csharp/programming-guide/classes-and-structs/properties public int Style2 { get; set } is the style we use in our code (where the formatter will be put to immediate use).

[PATCH] D78286: [analyzer] Track runtime types represented by Obj-C Class objects

This revision was automatically updated to reflect the committed changes. Closed by commit rG239c53b72b18: [analyzer] Track runtime types represented by Obj-C Class objects (authored by vsavchenko). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78286

[PATCH] D78118: [analyzer] StdLibraryFunctionsChecker: Add option to display loaded summaries

balazske added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:651 +// Get the declaration of a function proto as written in the source file. +StringRef ToString(const FunctionDecl *FD) { + const auto &SM = ACtx.getSource

[clang] 42a56bf - [SveEmitter] Add builtins for gather prefetches

Author: Sander de Smalen Date: 2020-04-29T11:52:49+01:00 New Revision: 42a56bf63f699a620a57c34474510d9937ebf715 URL: https://github.com/llvm/llvm-project/commit/42a56bf63f699a620a57c34474510d9937ebf715 DIFF: https://github.com/llvm/llvm-project/commit/42a56bf63f699a620a57c34474510d9937ebf715.di

[PATCH] D79079: [clangd] Make use of URIs in FileShardedIndex

kadircet updated this revision to Diff 260878. kadircet added a comment. - Return None and change PathRef to auto since it is URI now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79079/new/ https://reviews.llvm.org/D79079 Files: clang-tools-ex

[PATCH] D78677: [SveEmitter] Add builtins for gather prefetches

sdesmalen marked an inline comment as done. sdesmalen added a comment. Thanks for reviewing! Comment at: clang/lib/CodeGen/CGBuiltin.cpp:7739 + +// Index needs to be passed as scaled offset. +llvm::Type *MemEltTy = SVEBuiltinMemEltTy(TypeFlags); efriedm

[PATCH] D78677: [SveEmitter] Add builtins for gather prefetches

This revision was automatically updated to reflect the committed changes. Closed by commit rG42a56bf63f69: [SveEmitter] Add builtins for gather prefetches (authored by sdesmalen). Changed prior to commit: https://reviews.llvm.org/D78677?vs=259589&id=260879#toc Repository: rG LLVM Github Mono

[clang] db97a12 - Fix Wparentheses gcc warning. NFC.

Author: Simon Pilgrim Date: 2020-04-29T12:21:05+01:00 New Revision: db97a12454a95556dd7cd812105088c7e8852d92 URL: https://github.com/llvm/llvm-project/commit/db97a12454a95556dd7cd812105088c7e8852d92 DIFF: https://github.com/llvm/llvm-project/commit/db97a12454a95556dd7cd812105088c7e8852d92.diff

[PATCH] D78982: [clang-format] Fix Microsoft style for C++ enums

MyDeveloperDay added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:721 - -**InsertTrailingCommas** (``TrailingCommaStyle``) can be set to ``TCS_Wrapped`` - to insert trailing commas in container literals (arrays and objects) that wrap ? ar

[PATCH] D78874: [clang] Add vendor identity for Hygon Dhyana processor

fanjinke added a comment. Hi Craig， I can't commit the patch myself because I don't have access. Could you please help me？ Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78874/new/ https://reviews.llvm.org/D78874 ___

[PATCH] D79079: [clangd] Make use of URIs in FileShardedIndex

sammccall added a comment. LG but I think we can skip one lot of conversion, let me know what you think. Comment at: clang-tools-extra/clangd/index/Background.cpp:183 const auto &IGN = IndexIt.getValue(); // Note that sources do not contain any information regarding m

[clang] 23f4edf - [analyzer] Fix build error. NFC.

Author: Valeriy Savchenko Date: 2020-04-29T15:24:10+03:00 New Revision: 23f4edf1fe38b8d4c6dbc7fc8e197f1f1f8c6710 URL: https://github.com/llvm/llvm-project/commit/23f4edf1fe38b8d4c6dbc7fc8e197f1f1f8c6710 DIFF: https://github.com/llvm/llvm-project/commit/23f4edf1fe38b8d4c6dbc7fc8e197f1f1f8c6710.d

[clang] a4dac6d - [SveEmitter] Add builtins for svmov_b and svnot_b.

Author: Sander de Smalen Date: 2020-04-29T13:33:18+01:00 New Revision: a4dac6d4e0eae47eaa51bac72c048b1e3cd89c8b URL: https://github.com/llvm/llvm-project/commit/a4dac6d4e0eae47eaa51bac72c048b1e3cd89c8b DIFF: https://github.com/llvm/llvm-project/commit/a4dac6d4e0eae47eaa51bac72c048b1e3cd89c8b.di

[PATCH] D79039: [SveEmitter] Add builtins for svmov_b and svnot_b.

This revision was automatically updated to reflect the committed changes. Closed by commit rGa4dac6d4e0ea: [SveEmitter] Add builtins for svmov_b and svnot_b. (authored by sdesmalen). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[clang] 209ab6d - Revert 6654719 "[CMake] Fix logic error: NOT LIBCLANG_BUILD_STATIC does not imply PIC"

Author: Hans Wennborg Date: 2020-04-29T15:12:43+02:00 New Revision: 209ab6d8835cd88320ceb814893759cfbda91d15 URL: https://github.com/llvm/llvm-project/commit/209ab6d8835cd88320ceb814893759cfbda91d15 DIFF: https://github.com/llvm/llvm-project/commit/209ab6d8835cd88320ceb814893759cfbda91d15.diff

Re: [clang] 6654719 - [CMake] Fix logic error: NOT LIBCLANG_BUILD_STATIC does not imply PIC

On Sun, Apr 26, 2020 at 1:17 PM David Zarzycki via cfe-commits wrote: > > > Author: David Zarzycki > Date: 2020-04-26T07:16:42-04:00 > New Revision: 665471907a5c072c6653a38c35f35e5d54cef220 > > URL: > https://github.com/llvm/llvm-project/commit/665471907a5c072c6653a38c35f35e5d54cef220 > DIFF: >

[PATCH] D78785: Fix x86/x86_64 calling convention for _ExtInt

erichkeane added a comment. @craig.topper Did this look OK/ Is there anything else you want from this? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78785/new/ https://reviews.llvm.org/D78785 ___ cfe-commits mailing list cfe-commits@lists.

[PATCH] D78756: [SveEmitter] Add builtins for svreinterpret

sdesmalen marked an inline comment as done. sdesmalen added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:7880 +return Builder.CreateBitCast(Val, Ty); + } + efriedma wrote: > I'm vaguely suspicious this might be wrong for big-endian targets.

[PATCH] D79085: [clangd] Add CMake dependencies for Protobuf-generated files

kbobyrev created this revision. kbobyrev added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov, mgorny. Herald added a project: clang. kbobyrev added a comment. Otherwise sources including `Index.pb.h` or `Index.grpc.pb.

[PATCH] D79014: [clangd] Move non-clang base pieces into separate support/ lib.

kbobyrev accepted this revision. kbobyrev added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79014/new/ https://reviews.llvm.org/D79014 __

[PATCH] D78442: Create a warning flag for 'warn_conv_*_not_used'

rdwampler added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78442/new/ https://reviews.llvm.org/D78442 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[PATCH] D79085: [clangd] Add CMake dependencies for Protobuf-generated files

kbobyrev added a comment. Otherwise sources including `Index.pb.h` or `Index.grpc.pb.h` can be compiled before the those headers are generated. https://github.com/kirillbobyrev/indexing-tools/runs/629305684 (disregard the mess in the repo) Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D79085: [clangd] Add CMake dependencies for Protobuf-generated files

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Haha, CMake :-( Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79085/new/ https://reviews.llvm.org/D79085 __

[PATCH] D79087: [SVE][Codegen] Lower legal min & max operations

kmclaughlin created this revision. kmclaughlin added reviewers: sdesmalen, efriedma, dancgr. Herald added subscribers: psnobl, rkruppe, hiraditya, kristof.beyls, tschuett. Herald added a reviewer: rengolin. Herald added a project: LLVM. This patch adds AArch64ISD nodes for [S|U]MIN_PRED and [S|U]M

[PATCH] D79085: [clangd] Add CMake dependencies for Protobuf-generated files

sammccall added inline comments. Comment at: clang-tools-extra/clangd/index/remote/CMakeLists.txt:22 ) + add_dependencies(clangdRemoteIndex RemoteIndexProtos) is this equivalent to `DEPENDS RemoteIndexProtos` in the library? Slightly clearer probably. R

Re: [clang] 6654719 - [CMake] Fix logic error: NOT LIBCLANG_BUILD_STATIC does not imply PIC

Hans, Non-Windows non-PIC setups were working just fine until four days ago when D75068 landed. I tried to narrowly unbreak non-Windows non-PIC systems but apparently that broke Windows. For that, I'm sorry. That being said, non-Windows systems are broken again and this breakable was foreseeabl

[clang-tools-extra] ad97ccf - [clangd] Move non-clang base pieces into separate support/ lib. NFCI

Author: Sam McCall Date: 2020-04-29T15:57:12+02:00 New Revision: ad97ccf6b26a29262c9cbf5b3e7f6e84c6dcf55f URL: https://github.com/llvm/llvm-project/commit/ad97ccf6b26a29262c9cbf5b3e7f6e84c6dcf55f DIFF: https://github.com/llvm/llvm-project/commit/ad97ccf6b26a29262c9cbf5b3e7f6e84c6dcf55f.diff LO

Re: [clang] 6654719 - [CMake] Fix logic error: NOT LIBCLANG_BUILD_STATIC does not imply PIC

Your suggestion of > if(LLVM_ENABLE_PIC OR (WIN32 AND NOT LIBCLANG_BUILD_STATIC)) sounds good to me. I don't know what the non-Windows non-PIC problem was exactly (your commit didn't mention it), so maybe it's best if you land that to verify it fixes the issue? Thanks, Hans On Wed, Apr 29, 2020

[PATCH] D73951: [Clang] [Driver]Add logic to search for flang frontend

awarzynski added a comment. The suggested flag, `-fortran-fe`, feels quite powerful and I wonder whether it's required this early into the development of the Flang driver? IIUC, this flag would be used to workaround the fact that currently `flang` is a bash script and hence can't be used when t

[PATCH] D79085: [clangd] Add CMake dependencies for Protobuf-generated files

kbobyrev updated this revision to Diff 260906. kbobyrev marked 2 inline comments as done. kbobyrev added a comment. Use DEPENDS instead of add_dependencies. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79085/new/ https://reviews.llvm.org/D79085 F

[PATCH] D79014: [clangd] Move non-clang base pieces into separate support/ lib.

sammccall updated this revision to Diff 260905. sammccall added a comment. Update CMakeLists for non-default configurations, optimistically. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79014/new/ https://reviews.llvm.org/D79014 Files: clang-to

[PATCH] D79076: [clang] [MinGW] Add the compiler rt libdirs to the search path

rnk accepted this revision. rnk added a comment. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79076/new/ https://reviews.llvm.org/D79076 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

[PATCH] D78903: [Driver] Add option -fproc-stat-report

aganea added inline comments. Comment at: clang/docs/UsersManual.rst:786 + + $ clang -fproc-stat-report=- foo.c + clang-11: output=/tmp/foo-123456.o, total=84000, user=76000, mem=87496 MaskRay wrote: > aganea wrote: > > Why not just `-fproc-stat-report` in th

[PATCH] D79014: [clangd] Move non-clang base pieces into separate support/ lib.

This revision was automatically updated to reflect the committed changes. Closed by commit rGad97ccf6b26a: [clangd] Move non-clang base pieces into separate support/ lib. NFCI (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D790

[PATCH] D78982: [clang-format] Fix Microsoft style for C++ enums

asmith marked 6 inline comments as done. asmith added a comment. The is done unless there are other comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:721 - -**InsertTrailingCommas** (``TrailingCommaStyle``) can be set to ``TCS_Wrapped`` - to insert trailing commas i

[clang] e00071d - Fixing typo (singed -> signed); NFC

Author: Aaron Ballman Date: 2020-04-29T10:33:21-04:00 New Revision: e00071db0854ae9030e3b80a1f82c7cd66d57930 URL: https://github.com/llvm/llvm-project/commit/e00071db0854ae9030e3b80a1f82c7cd66d57930 DIFF: https://github.com/llvm/llvm-project/commit/e00071db0854ae9030e3b80a1f82c7cd66d57930.diff

Re: [clang] 6654719 - [CMake] Fix logic error: NOT LIBCLANG_BUILD_STATIC does not imply PIC

Okay, sounds good. For whatever it may be worth, I pasted the build failure to D75068 shortly after it landed with the hope that the original author(s) would commit a quick fix, but that didn't happen. On Wed, Apr 29, 2020, at 10:23 AM, Hans Wennborg wrote: > Your suggestion of > > > if(LLVM_E

RE: [clang] 6654719 - [CMake] Fix logic error: NOT LIBCLANG_BUILD_STATIC does not imply PIC

Hi, Thank you David for not reverting my 3rd attempt to get libclang to build statically on Windows. In my defense the commit landed on a Saturday, and while I usually hack on weekends, but now I'm involved in moving to a new home and I wasn't able to reply to your message. I'm sorry for the

[PATCH] D78982: [clang-format] Fix Microsoft style for C++ enums

MyDeveloperDay added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:721 - -**InsertTrailingCommas** (``TrailingCommaStyle``) can be set to ``TCS_Wrapped`` - to insert trailing commas in container literals (arrays and objects) that wrap asmi

[PATCH] D79085: [clangd] Add CMake dependencies for Protobuf-generated files

kbobyrev added a comment. In D79085#2010025 , @sammccall wrote: > Haha, CMake :-( Now that I know this it kind of makes sense (I guess it's faster to just build everything and then link when all deps are ready), just something I didn't think about :)

[PATCH] D73768: clang-format: [JS] document InsertTrailingCommas.

MyDeveloperDay added a comment. I'm trying to prevent this from getting deleted in D78982: [clang-format] Fix Microsoft style for C++ enums @mprobst When you added this documentation did you add it to Format.h and regenerate the rst text. ClangFormatStyleOptio

[PATCH] D75453: [Driver][ARM] parse version of arm/thumb architecture correctly

j0le updated this revision to Diff 260912. j0le retitled this revision from "[Driver][ARM] fix undefined behaviour when checking architecture version" to "[Driver][ARM] parse version of arm/thumb architecture correctly". j0le edited the summary of this revision. j0le added a comment. Changed tit

[PATCH] D76066: [ARM][MachineOutliner] Add Machine Outliner support for ARM

yroux updated this revision to Diff 260916. yroux edited the summary of this revision. yroux added a comment. Here is a new update of the patch. I remove the logic to disable LowOverheadLoops pass since Eli has added the live-ins infos inside outlined functions in D78605

[clang-tools-extra] 4645ef1 - [clangd] Add CMake dependencies for Protobuf-generated files

Author: Kirill Bobyrev Date: 2020-04-29T17:01:03+02:00 New Revision: 4645ef17ff1aa30e1890b7c8230b590ef830081b URL: https://github.com/llvm/llvm-project/commit/4645ef17ff1aa30e1890b7c8230b590ef830081b DIFF: https://github.com/llvm/llvm-project/commit/4645ef17ff1aa30e1890b7c8230b590ef830081b.diff

[PATCH] D79072: [Analyzer][VLASizeChecker] Check VLA size in typedef and sizeof.

xazax.hun added a comment. Overall the changes look good to me here. I had a small nit inline. But I wonder if we actually should add more code in the analyzer core to better model the sizes of memory regions corresponding to the VLAs. Comment at: clang/lib/StaticAnalyzer/Cor

[PATCH] D73354: clang-format: insert trailing commas into containers.

MyDeveloperDay added inline comments. Comment at: clang/include/clang/Format/Format.h:563 + }; + + TrailingCommaStyle InsertTrailingCommas; I think we need to add some text in here to ensure it gets documented automatically in ClangFormatStyleOptions.rst rathe

[PATCH] D79085: [clangd] Add CMake dependencies for Protobuf-generated files

This revision was automatically updated to reflect the committed changes. Closed by commit rG4645ef17ff1a: [clangd] Add CMake dependencies for Protobuf-generated files (authored by kbobyrev). Changed prior to commit: https://reviews.llvm.org/D79085?vs=260906&id=260920#toc Repository: rG LLVM

[PATCH] D76066: [ARM][MachineOutliner] Add Machine Outliner support for ARM

yroux updated this revision to Diff 260921. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76066/new/ https://reviews.llvm.org/D76066 Files: clang/lib/Driver/ToolChains/Clang.cpp llvm/lib/Target/ARM/ARMBaseInstrInfo.cpp llvm/lib/Target/ARM/ARMB

Re: [clang] 6654719 - [CMake] Fix logic error: NOT LIBCLANG_BUILD_STATIC does not imply PIC

Hi Cristian, That's alright. No worries. Good luck with the move (especially during the pandemic). My three stage test of LLVM+clang+lld+libcxx+libcxxabi is almost done, and I'll commit your suggested fix soon. Dave On Wed, Apr 29, 2020, at 10:53 AM, Cristian Adam wrote: > Hi, > > Thank you

[clang] e717e87 - [libclang] Shared libraries require PIC unless WIN32

Author: David Zarzycki Date: 2020-04-29T11:25:45-04:00 New Revision: e717e8744d374e16603157e5135005727bf17901 URL: https://github.com/llvm/llvm-project/commit/e717e8744d374e16603157e5135005727bf17901 DIFF: https://github.com/llvm/llvm-project/commit/e717e8744d374e16603157e5135005727bf17901.diff

[PATCH] D79094: [SemaObjC] Warn on visibility attributes on an @implementation

erik.pilkington created this revision. erik.pilkington added reviewers: rjmccall, aaron.ballman. Herald added subscribers: ributzka, dexonsmith, jkorous. D60542 added support for attributes on `@implementation`s, but CodeGen always looks for visibility attributes

[PATCH] D78982: [clang-format] Fix Microsoft style for C++ enums

asmith added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:721 - -**InsertTrailingCommas** (``TrailingCommaStyle``) can be set to ``TCS_Wrapped`` - to insert trailing commas in container literals (arrays and objects) that wrap MyDeveloperD

[PATCH] D78982: [clang-format] Fix Microsoft style for C++ enums

MyDeveloperDay added a comment. see D79095: [clang-format] NFC Correct clang-format headers file so documentation can be once again autogenerated this should be handled separately. Comment at: clang/docs/ClangFormatStyleOptions.rst:721 - -**I

[PATCH] D79095: [clang-format] NFC Correct clang-format headers file so documentation can be once again autogenerated

MyDeveloperDay marked an inline comment as done. MyDeveloperDay added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:1752 LngFunctionDeclaration(); +**InsertTrailingCommas** (``TrailingCommaStyle``) NOT

[PATCH] D79095: [clang-format] NFC Correct clang-format headers file so documentation can be once again autogenerated

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: mprobst, krasimir, mitchell-stellar, asmith. MyDeveloperDay added projects: clang, clang-format. MyDeveloperDay edited the summary of this revision. MyDeveloperDay marked an inline comment as done. MyDeveloperDay added inline com

[PATCH] D76066: [ARM][MachineOutliner] Add Machine Outliner support for ARM

yroux added inline comments. Comment at: llvm/lib/Target/ARM/ARMBaseInstrInfo.cpp:5606 + // candidates. + auto CantGuaranteeValueAcrossCall = [&TRI](outliner::Candidate &C) { +// If the unsafe registers in this block are all dead, then we don't need yroux w

[PATCH] D78118: [analyzer] StdLibraryFunctionsChecker: Add option to display loaded summaries

martong marked 4 inline comments as done. martong added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:651 +// Get the declaration of a function proto as written in the source file. +StringRef ToString(const FunctionDecl *FD)

[PATCH] D79095: [clang-format] NFC Correct clang-format headers file so documentation can be once again autogenerated

MyDeveloperDay added a comment. In D79095#2010250 , @krasimir wrote: > Awesome! Thank you! > Now that we've got "clang/phabricator/lint/git" robots that leave comments > on patches, we may want to think about a way to have this automatically > enforced

[PATCH] D78118: [analyzer] StdLibraryFunctionsChecker: Add option to display loaded summaries

martong updated this revision to Diff 260930. martong marked 2 inline comments as done. martong added a comment. - Use Decl::print and 'for: ' Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78118/new/ https://reviews.llvm.org/D78118 Files: clang/

[PATCH] D79095: [clang-format] NFC Correct clang-format headers file so documentation can be once again autogenerated

krasimir added a comment. Awesome! Thank you! Now that we've got "clang/phabricator/lint/git" robots that leave comments on patches, we may want to think about a way to have this automatically enforced in the future. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[PATCH] D78982: [clang-format] Fix Microsoft style for enums

asmith updated this revision to Diff 260932. asmith retitled this revision from "[clang-format] Fix Microsoft style for C++ enums" to "[clang-format] Fix Microsoft style for enums". asmith edited the summary of this revision. asmith added a comment. Enable for C# CHANGES SINCE LAST ACTION htt

[PATCH] D78982: [clang-format] Fix Microsoft style for enums

asmith marked 2 inline comments as done. asmith added inline comments. Comment at: clang/lib/Format/Format.cpp:1143 Style.PenaltyReturnTypeOnItsOwnLine = 1000; + Style.AllowShortEnumsOnASingleLine = (Language != FormatStyle::LK_Cpp); Style.AllowShortFunctionsOnASingleLine

[PATCH] D78903: [Driver] Add option -fproc-stat-report

sepavloff marked 3 inline comments as done. sepavloff added inline comments. Comment at: clang/docs/UsersManual.rst:770 + $ cat abc + clang-11,"/tmp/foo-123456.o",92000,84000,87536 + ld,"a.out",900,8000,53568 aganea wrote: > Please add a header to the outpu

[PATCH] D78785: Fix x86/x86_64 calling convention for _ExtInt

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78785/new/ https://reviews.llvm.org/D78785 ___ cfe-commits mailing list c

[PATCH] D77229: [Analyzer][WIP] Avoid handling of LazyCompundVals in IteratorModeling

baloghadamsoftware updated this revision to Diff 260944. baloghadamsoftware added a comment. Now I made some good progress, thank you @NoQ for your suggestions. Not all of them are implemented yet (currently the +-1 with the indices seem to be working, thus I will fix that part later), but now I

[PATCH] D78979: OpenCL: Include builtin header by default

svenvh added a comment. In D78979#2007643 , @Anastasia wrote: > > Would it not become confusing since the builtins are going to be included > > by default? Should we rename the flag at least? Also ideally it should be > > documented in https://clang.llvm

[PATCH] D78785: Fix x86/x86_64 calling convention for _ExtInt

rjmccall added a comment. Could you answer my question up-thread about whether ExtInt is currently target-limited? If it isn't, we need to more broadly audit targets. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78785/new/ https://reviews.llvm.org/D78785 __

[PATCH] D78903: [Driver] Add option -fproc-stat-report

aganea added inline comments. Comment at: clang/docs/UsersManual.rst:770 + $ cat abc + clang-11,"/tmp/foo-123456.o",92000,84000,87536 + ld,"a.out",900,8000,53568 sepavloff wrote: > aganea wrote: > > Please add a header to the output .CSV, specifying the uni

[clang] a0e53de - [clang] [MinGW] Add the compiler rt libdirs to the search path

Author: Martin Storsjö Date: 2020-04-29T20:35:50+03:00 New Revision: a0e53de472c5b9538884f23eb8f47c3bc734b345 URL: https://github.com/llvm/llvm-project/commit/a0e53de472c5b9538884f23eb8f47c3bc734b345 DIFF: https://github.com/llvm/llvm-project/commit/a0e53de472c5b9538884f23eb8f47c3bc734b345.diff

[clang] 5a1d9c0 - Fix x86/x86_64 calling convention for _ExtInt

Author: Erich Keane Date: 2020-04-29T11:04:25-07:00 New Revision: 5a1d9c0f5ac85b486a539b1d9558205821f17b33 URL: https://github.com/llvm/llvm-project/commit/5a1d9c0f5ac85b486a539b1d9558205821f17b33 DIFF: https://github.com/llvm/llvm-project/commit/5a1d9c0f5ac85b486a539b1d9558205821f17b33.diff L

[PATCH] D78785: Fix x86/x86_64 calling convention for _ExtInt

erichkeane added a comment. In D78785#2010546 , @rjmccall wrote: > Could you answer my question up-thread about whether ExtInt is currently > target-limited? If it isn't, we need to more broadly audit targets. Yikes! I missed that question, I'm sorry

[PATCH] D72841: Add support for pragma float_control, to control precision and exception behavior at the source level

mibintc marked an inline comment as done. mibintc added inline comments. Comment at: clang/include/clang/AST/Expr.h:2701 + FPOptions FPFeatures; + mibintc wrote: > erichkeane wrote: > > This type already has trailing-storage type stuff. I think in the past >

[PATCH] D79106: [clangd] Move inserted include from detail -> documentation.

sammccall created this revision. sammccall added a reviewer: hokein. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Many clients try to display all the detail inline, with poor results. Repository: rG LLVM

[PATCH] D78756: [SveEmitter] Add builtins for svreinterpret

efriedma added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:7880 +return Builder.CreateBitCast(Val, Ty); + } + sdesmalen wrote: > efriedma wrote: > > I'm vaguely suspicious this might be wrong for big-endian targets. I mean, > > this isn't

[PATCH] D79076: [clang] [MinGW] Add the compiler rt libdirs to the search path

This revision was automatically updated to reflect the committed changes. Closed by commit rGa0e53de472c5: [clang] [MinGW] Add the compiler rt libdirs to the search path (authored by mstorsjo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79076/new/

[PATCH] D78785: Fix x86/x86_64 calling convention for _ExtInt

This revision was automatically updated to reflect the committed changes. Closed by commit rG5a1d9c0f5ac8: Fix x86/x86_64 calling convention for _ExtInt (authored by erichkeane). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D78785: Fix x86/x86_64 calling convention for _ExtInt

rjmccall added a comment. Every target does something similar, they just all do it in different ways because they're mostly written by different people. We should restrict this feature to targets where we've adequately audited the ABI. It's not a feature until the ABI work is done. Repositor

[PATCH] D79087: [SVE][Codegen] Lower legal min & max operations

efriedma added a subscriber: huihuiz. efriedma added inline comments. Comment at: llvm/lib/Target/AArch64/SVEInstrFormats.td:3851 + def : SVE_1_Op_Imm_Arith_Pred_Pat(NAME # _S)>; + def : SVE_1_Op_Imm_Arith_Pred_Pat(NAME # _D)>; } I don't see any test for this

[PATCH] D72841: Add support for pragma float_control, to control precision and exception behavior at the source level

erichkeane added a comment. 2 small things, @rjmccall and @sepavloff , anything else? Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:870 +def err_pragma_fenv_requires_precise : Error< + "'#pragma STDC FENV_ACCESS ON' is illegal when precise is disabled">; def w

[clang] b5a4dee - [NFC] Split ext-int calling convention tests into their own file.

Author: Erich Keane Date: 2020-04-29T12:20:21-07:00 New Revision: b5a4deec6a70da8a1024a2227be66f88e9276b08 URL: https://github.com/llvm/llvm-project/commit/b5a4deec6a70da8a1024a2227be66f88e9276b08 DIFF: https://github.com/llvm/llvm-project/commit/b5a4deec6a70da8a1024a2227be66f88e9276b08.diff L

[PATCH] D78979: OpenCL: Include builtin header by default

Anastasia added a comment. In D78979#2007760 , @yaxunl wrote: > In D78979#2007643 , @Anastasia wrote: > > > ah I guess if we leave it under `-cc1 ` we will have the command line > > interface as follows: > > > > -

[PATCH] D78979: OpenCL: Include builtin header by default

Anastasia added a comment. In D78979#2010527 , @svenvh wrote: > In D78979#2007643 , @Anastasia wrote: > > > > Would it not become confusing since the builtins are going to be included > > > by default? Should we re

[PATCH] D74813: [RFC] Add hash of block contents to function block names

alexbdv added a comment. @erik.pilkington would the hash-based numbering be OK for now ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74813/new/ https://reviews.llvm.org/D74813 ___ cfe-commits mailing

[PATCH] D78785: Fix x86/x86_64 calling convention for _ExtInt

erichkeane added a comment. In D78785#2010654 , @rjmccall wrote: > Every target does something similar, they just all do it in different ways > because they're mostly written by different people. > > We should restrict this feature to targets where we've

[PATCH] D79014: [clangd] Move non-clang base pieces into separate support/ lib.

jsji added a comment. Herald added a subscriber: wuzish. Looks like this is causing buildbot failure when built with `-DBUILD_SHARED_LIBS=ON`. http://lab.llvm.org:8011/builders/clang-ppc64le-rhel/builds/3077/steps/build%20stage%201/logs/stdio FAILED: lib/libclangDaemon.so.11git : && /home/b

[PATCH] D79113: Revert "Remove false positive in AvoidNonConstGlobalVariables."

vingeldal created this revision. Herald added subscribers: cfe-commits, kbarton, nemanjai. Herald added a project: clang. vingeldal added reviewers: aaron.ballman, lebedev.ri, JonasToth, gribozavr2. Herald added a subscriber: wuzish. There was concernes about a false positive in clang-tidy check A

[PATCH] D71124: [RISCV] support clang driver to select cpu

lenary added a comment. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. This is looking good. I remember we discussed this on the LLVM call a few weeks ago - there was a discussion as to whether we should be prioritising `-march` or `-mcpu` - do you recall the outcome of

[clang-tools-extra] bc029fa - [clangd] Still need pthreads in clangDaemon.

Author: Sam McCall Date: 2020-04-29T21:41:12+02:00 New Revision: bc029fa6c5cdc28fa2087f721e5ffe27d9b24ecd URL: https://github.com/llvm/llvm-project/commit/bc029fa6c5cdc28fa2087f721e5ffe27d9b24ecd DIFF: https://github.com/llvm/llvm-project/commit/bc029fa6c5cdc28fa2087f721e5ffe27d9b24ecd.diff LO

[PATCH] D79117: [clang] [Darwin] Add reverse mappings for aarch64/aarch64_32 to darwin arch names

mstorsjo created this revision. mstorsjo added a reviewer: t.p.northover. Herald added subscribers: danielkiss, kristof.beyls. Herald added a project: clang. These are mapped in MachO::getMachOArchName already, but were missing in ToolChain::getDefaultUniversalArchName. Having these reverse mapp

  1   2   >