Author: Hans Wennborg Date: 2020-04-29T15:12:43+02:00 New Revision: 209ab6d8835cd88320ceb814893759cfbda91d15
URL: https://github.com/llvm/llvm-project/commit/209ab6d8835cd88320ceb814893759cfbda91d15 DIFF: https://github.com/llvm/llvm-project/commit/209ab6d8835cd88320ceb814893759cfbda91d15.diff LOG: Revert 6654719 "[CMake] Fix logic error: NOT LIBCLANG_BUILD_STATIC does not imply PIC" It broke building libclang.dll in Windows builds configured with LLVM_ENABLE_PIC=OFF. See discussion on the cfe-commits thread. Added: Modified: clang/tools/libclang/CMakeLists.txt Removed: ################################################################################ diff --git a/clang/tools/libclang/CMakeLists.txt b/clang/tools/libclang/CMakeLists.txt index 9368501592a9..bb2b14cc8e27 100644 --- a/clang/tools/libclang/CMakeLists.txt +++ b/clang/tools/libclang/CMakeLists.txt @@ -77,7 +77,7 @@ if(MSVC) set(LLVM_EXPORTED_SYMBOL_FILE) endif() -if(LLVM_ENABLE_PIC) +if(LLVM_ENABLE_PIC OR NOT LIBCLANG_BUILD_STATIC) set(ENABLE_SHARED SHARED) endif() _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
