[clang] 9490808 - [CodeGen] fix inline builtin-related breakage from D78162

Author: George Burgess IV Date: 2020-04-16T11:54:10-07:00 New Revision: 94908088a831141cfbdd15fc5837dccf30cfeeb6 URL: https://github.com/llvm/llvm-project/commit/94908088a831141cfbdd15fc5837dccf30cfeeb6 DIFF: https://github.com/llvm/llvm-project/commit/94908088a831141cfbdd15fc5837dccf30cfeeb6.d

[clang] 86478d3 - [MC][ELF] Put explicit section name symbols into entry size compatible sections

Author: bd1976llvm Date: 2020-04-16T19:12:49Z New Revision: 86478d3de91a81978c2c310fda13f04541cd3b23 URL: https://github.com/llvm/llvm-project/commit/86478d3de91a81978c2c310fda13f04541cd3b23 DIFF: https://github.com/llvm/llvm-project/commit/86478d3de91a81978c2c310fda13f04541cd3b23.diff LOG: [M

[PATCH] D78308: [NFC][PowerPC] Refactor ppcUserFeaturesCheck()

lei updated this revision to Diff 258119. lei added a comment. Fix mistake in code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78308/new/ https://reviews.llvm.org/D78308 Files: clang/lib/Basic/Targets/PPC.cpp Index: clang/lib/Basic/Targets/P

[PATCH] D75153: [ThinLTO] Allow usage of all SMT threads in the system

phosek added a comment. Herald added a reviewer: MaskRay. We've started seeing `llvm-cov` on our Linux bots with this error: terminating with uncaught exception of type std::__2::system_error: thread constructor failed: Resource temporarily unavailable Specifically, we're running `llvm export

[PATCH] D78308: [NFC][PowerPC] Refactor ppcUserFeaturesCheck()

lei updated this revision to Diff 258121. lei added a comment. update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78308/new/ https://reviews.llvm.org/D78308 Files: clang/lib/Basic/Targets/PPC.cpp Index: clang/lib/Basic/Targets/PPC.cpp ==

[PATCH] D76932: [AIX] emit .extern and .weak directive linkage

jasonliu accepted this revision. jasonliu added a comment. This revision is now accepted and ready to land. LGTM. Please wait a day or two to see if @hubert.reinterpretcast have further comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76932/

[PATCH] D72194: [MC][ELF] Ensure that mergeable globals with an explicit section are assigned to SHF_MERGE sections with compatible entsizes

This revision was automatically updated to reflect the committed changes. Closed by commit rG86478d3de91a: [MC][ELF] Put explicit section name symbols into entry size compatible sections (authored by bd1976llvm). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository:

[PATCH] D75153: [ThinLTO] Allow usage of all SMT threads in the system

phosek added a comment. In D75153#1987272 , @phosek wrote: > We've started seeing `llvm-cov` on our Linux bots with this error: > > terminating with uncaught exception of type std::__2::system_error: thread > constructor failed: Resource temporarily una

[PATCH] D78273: [clang-tools-extra] reimplement PreprocessorTracker in terms of StringSet.

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Comment at: clang-tools-extra/modularize/PreprocessorTracker.cpp:466 -bool operator<(const StringHandle &H1, const StringHandle &H2) { - const char *S1 = (H1 ? *H1 : ""); -

[clang-tools-extra] 39c9c12 - [clang-tools-extra] reimplement PreprocessorTracker in terms of StringSet.

Author: Chris Lattner Date: 2020-04-16T12:57:43-07:00 New Revision: 39c9c12b76da27bd52ca1b82c3d39d9c9b59ad0f URL: https://github.com/llvm/llvm-project/commit/39c9c12b76da27bd52ca1b82c3d39d9c9b59ad0f DIFF: https://github.com/llvm/llvm-project/commit/39c9c12b76da27bd52ca1b82c3d39d9c9b59ad0f.diff

[PATCH] D75153: [ThinLTO] Allow usage of all SMT threads in the system

aganea added a comment. In D75153#1987320 , @phosek wrote: > In D75153#1987272 , @phosek wrote: > > > We've started seeing `llvm-cov` on our Linux bots with this error: > > > > terminating with uncaught exception

[PATCH] D78323: [clang] Fix invalid comparator in tablegen

EricWF created this revision. EricWF added reviewers: fowles, bkramer, sdesmalen. Herald added a project: clang. The current version of the comparator does not introduce a strict weak ordering. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D78323 Files: clang/utils/TableGen/

[PATCH] D78273: [clang-tools-extra] reimplement PreprocessorTracker in terms of StringSet.

lattner added a comment. Thank you for the review Reid! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78273/new/ https://reviews.llvm.org/D78273 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D75153: [ThinLTO] Allow usage of all SMT threads in the system

MaskRay added a comment. In D75153#1942336 , @aganea wrote: > In D75153#1906580 , @MaskRay wrote: > > > Does `taskset -c 0-3 lld -flavor ...` restrict the number of cores? > > > > cpu_set_t cpu; > > sched_getaff

[PATCH] D76452: Use LLD by default for Android.

danalbert added a comment. @MaskRay Any other ideas, or should I submit this? Reviewing all our options: 1. Installing LLD as simply "ld" Rejected: Causes LLD to act in mach-o mode for Darwin 2. `-DCLANG_DEFAULT_LINKER=lld` Rejected: Our host Darwin toolchain still uses the system's linker, no

[PATCH] D78273: [clang-tools-extra] reimplement PreprocessorTracker in terms of StringSet.

This revision was automatically updated to reflect the committed changes. Closed by commit rG39c9c12b76da: [clang-tools-extra] reimplement PreprocessorTracker in terms of StringSet. (authored by lattner). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D75153: [ThinLTO] Allow usage of all SMT threads in the system

aganea added a comment. In D75153#1987538 , @MaskRay wrote: > I remember I saw a related bugs.llvm.org report yesterday but I can't find it > now... This? https://bugs.llvm.org/show_bug.cgi?id=45556 Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D78239: [SveEmitter] Add builtins for FP conversions

sdesmalen added a comment. In D78239#1985102 , @efriedma wrote: > > as the LLVM IR intrinsics use the as the predicate. > > Why are the fp conversion intrinsics special here? Should we fix the LLVM > intrinsic definitions? I questioned that as well, b

[PATCH] D76452: Use LLD by default for Android.

MaskRay accepted this revision. MaskRay added a comment. LGTM. But hope @ruiu or @int3 can clarify that we can't get rid of the `__APPLE__` special case in: // lld/tools/lld/lld.cpp static Flavor parseProgname(StringRef progname) { #if __APPLE__ // Use Darwin driver for "ld" on Darwin

[PATCH] D77597: [SveEmitter] Add ExpandOp1SVALL and builtin for svptrue

sdesmalen marked an inline comment as done. sdesmalen added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:7683 +if (TypeFlags.isExpandOp1SVALL()) { + if (Ops.size() <= 1) +Ops.push_back(Builder.getInt32(31)); efriedma wrote: > The

[PATCH] D78323: [clang] Fix invalid comparator in tablegen

sdesmalen accepted this revision. sdesmalen added a comment. This revision is now accepted and ready to land. LGTM, did this comparison introduce any non-determinism? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78323/new/ https://reviews.llvm.org

[PATCH] D76594: [clang][AST] Support AST files larger than 512M

sammccall accepted this revision. sammccall added a comment. A little sad it's not possible to just 64-bit align the typeoffsets array, but 32 seems to be the magic number. Comment at: clang/include/clang/Serialization/ASTBitCodes.h:225 + /// Offset in the AST file. Split

[PATCH] D76038: PR45000: Use Sema::SetParamDefaultArgument in TransformLambdaExpr

rsmith added inline comments. Comment at: clang/lib/Sema/TreeTransform.h:12162 for (unsigned I = 0, NumParams = NewCallOperator->getNumParams(); I != NumParams; ++I) { This logic shouldn't even be here in the first place.. this should all be handled

[PATCH] D76452: Use LLD by default for Android.

danalbert added a comment. Option 4 was (at least on the surface) super easy: https://reviews.llvm.org/D78328. lmk if you'd prefer that approach. I'm slightly less confident in it since it affects non-Android platforms as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D78116: [AST] dont invaliate VarDecl when the initializer contains errors.

hokein updated this revision to Diff 258169. hokein marked 5 inline comments as done. hokein added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78116/new/ https://reviews.llvm.org/D78116 Files: clang/lib/Sema/SemaDec

[PATCH] D78116: [AST] dont invaliate VarDecl when the initializer contains errors.

hokein added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:11998 ExprResult Result = InitSeq.Perform(*this, Entity, Kind, Args, &DclT); if (Result.isInvalid()) { + auto RecoveryExpr = sammccall wrote: > if the variable is an undeduced au

[PATCH] D77592: [NFC][CodeGen] Add enum for selecting the layout of components in the vtable

leonardchan marked an inline comment as done. leonardchan added a comment. In D77592#1985740 , @rjmccall wrote: > I'm not sure if the AST-level v-table layout abstraction really cares about > these differences. I don't think it vends byte offsets into th

[PATCH] D78024: [FileCheck] - Fix the false positive when -implicit-check-not is used with an unknown -check-prefix.

jdenny marked an inline comment as done. jdenny added a subscriber: SjoerdMeijer. jdenny added inline comments. Comment at: llvm/lib/Support/FileCheck.cpp:1375-1377 + // We do not allow using -implicit-check-not when an explicitly specified + // check prefix is not present in t

[clang] ccc43e3 - Expose ATOMIC in the clang python bindings

Author: Benjamin Kramer Date: 2020-04-16T23:35:55+02:00 New Revision: ccc43e337cfa62b4787c39aefd3559ed39f78556 URL: https://github.com/llvm/llvm-project/commit/ccc43e337cfa62b4787c39aefd3559ed39f78556 DIFF: https://github.com/llvm/llvm-project/commit/ccc43e337cfa62b4787c39aefd3559ed39f78556.dif

[PATCH] D78308: [NFC][PowerPC] Refactor ppcUserFeaturesCheck()

lei updated this revision to Diff 258175. lei added a comment. updated. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78308/new/ https://reviews.llvm.org/D78308 Files: clang/lib/Basic/Targets/PPC.cpp Index: clang/lib/Basic/Targets/PPC.cpp

[PATCH] D76612: [Matrix] Add draft specification for matrix support in Clang.

fhahn updated this revision to Diff 258179. fhahn added a comment. Update wording to allow any real type for scalar -> matrix conversion and scalar,matrix binary ops. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76612/new/ https://reviews.llvm.or

[PATCH] D78116: [AST] dont invaliate VarDecl when the initializer contains errors.

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. oops, meant to approve Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78116/new/ https://reviews.llvm.org/D78116 ___

[PATCH] D76612: [Matrix] Add draft specification for matrix support in Clang.

fhahn marked an inline comment as done. fhahn added inline comments. Comment at: clang/docs/MatrixTypes.rst:29 +A *matrix element type* must be a real type (as in C99 6.2.5p17) excluding +enumeration types or an implementation-defined half-precision floating point +type, otherwis

[PATCH] D78116: [AST] dont invaliate VarDecl when the initializer contains errors.

sammccall added a comment. Most of the new diagnostics look good, as you say. I'm okay with the regression around foreach loops, given that: - per rsmith, the mechanism behind this diagnostic was misdesigned (relying on initializer making things invalid) - it's a C++-only features and we should

[PATCH] D77923: OpenCL: Fix some missing predefined macros

jvesely added a comment. In D77923#1983787 , @yaxunl wrote: > LGTM. The objective of the change is to simplify offline compilation. We want > to avoid asking users to add -D if a proper macro can be inferred from triple > and cpu. Ideally, users only nee

[PATCH] D78190: Add Bfloat IR type

stuij marked an inline comment as done. stuij added inline comments. Comment at: llvm/include/llvm/IR/Constants.h:790 + static Constant *getFP(Type *ElementType, ArrayRef Elts); /// Return a ConstantVector with the specified constant in each element. jdoerf

[PATCH] D78190: Add Bfloat IR type

stuij updated this revision to Diff 258185. stuij marked 4 inline comments as done. stuij added a comment. added some type constraints to the various getFP containter methods, adjusted getFP documentation, and simplified test cases Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[PATCH] D77597: [SveEmitter] Add ExpandOp1SVALL and builtin for svptrue

efriedma added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:7683 +if (TypeFlags.isExpandOp1SVALL()) { + if (Ops.size() <= 1) +Ops.push_back(Builder.getInt32(31)); sdesmalen wrote: > efriedma wrote: > > The `Ops.size() <= 1` seems

[PATCH] D76038: PR45000: Use Sema::SetParamDefaultArgument in TransformLambdaExpr

rsmith added inline comments. Comment at: clang/lib/Sema/TreeTransform.h:12162 for (unsigned I = 0, NumParams = NewCallOperator->getNumParams(); I != NumParams; ++I) { rsmith wrote: > This logic shouldn't even be here in the first place.. this should

[PATCH] D75479: [clangd] go-to-def on names in comments etc that are used nearby.

sammccall updated this revision to Diff 258187. sammccall added a comment. Add tests for SpelledWord Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75479/new/ https://reviews.llvm.org/D75479 Files: clang-tools-extra/clangd/SourceCode.cpp clang-

[PATCH] D78323: [clang] Fix invalid comparator in tablegen

EricWF added a comment. In D78323#1987596 , @sdesmalen wrote: > LGTM, did this comparison introduce any non-determinism? Potentially, but I observed the issue using libc++'s debug mode. I'm unsure if the current inputs would have caused libc++ to read pa

[PATCH] D78323: [clang] Fix invalid comparator in tablegen

EricWF closed this revision. EricWF added a comment. af2968e37f4c95846ffe287b64a4fcd72c765bee Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78323/new/ https://reviews.llvm.org/D

[clang] af2968e - [clang] Fix invalid comparator in tablegen

Author: Eric Fiselier Date: 2020-04-16T18:38:32-04:00 New Revision: af2968e37f4c95846ffe287b64a4fcd72c765bee URL: https://github.com/llvm/llvm-project/commit/af2968e37f4c95846ffe287b64a4fcd72c765bee DIFF: https://github.com/llvm/llvm-project/commit/af2968e37f4c95846ffe287b64a4fcd72c765bee.diff

[clang-tools-extra] b0c4dfb - [clangd] Print PID on windows too

Author: Sam McCall Date: 2020-04-17T01:00:42+02:00 New Revision: b0c4dfb3b160ecde23e668e773d340171880302c URL: https://github.com/llvm/llvm-project/commit/b0c4dfb3b160ecde23e668e773d340171880302c DIFF: https://github.com/llvm/llvm-project/commit/b0c4dfb3b160ecde23e668e773d340171880302c.diff LO

[clang-tools-extra] 63725df - [clangd] Remove unused and underused helpers. NFC

Author: Sam McCall Date: 2020-04-17T01:08:32+02:00 New Revision: 63725df1d66973f623f41bddcaae7a235465ca81 URL: https://github.com/llvm/llvm-project/commit/63725df1d66973f623f41bddcaae7a235465ca81 DIFF: https://github.com/llvm/llvm-project/commit/63725df1d66973f623f41bddcaae7a235465ca81.diff LO

[PATCH] D78239: [SveEmitter] Add builtins for FP conversions

efriedma added a comment. I think the predicate type is something we should fix. Even if it's not causing problems now, it seems like the sort of thing that will bite us later. It doesn't necessarily need to block this patch, I guess, but it at least needs a good comment in EmitAArch64SVEBuil

[PATCH] D76594: [clang][AST] Support AST files larger than 512M

DmitryPolukhin added inline comments. Comment at: clang/include/clang/Serialization/ASTBitCodes.h:228 + /// value in the padding affects AST hash. + uint32_t BitOffsetLow = 0; + uint32_t BitOffsetHigh = 0; sammccall wrote: > consider making this a

[PATCH] D75479: [clangd] go-to-def on names in comments etc that are used nearby.

sammccall marked 3 inline comments as done. sammccall added a comment. OK, I think this is probably finally good for another round - it's pretty well merged with the index-based version, and the common parts are pulled out to SourceCode and tested. I couldn't resist adding support for backtick-i

[PATCH] D77923: OpenCL: Fix some missing predefined macros

yaxunl added a comment. In D77923#1987795 , @jvesely wrote: > will this trigger extra warnings for the user? No. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77923/new/ https://reviews.llvm.org/D77923 __

[PATCH] D75479: [clangd] go-to-def on names in comments etc that are used nearby.

sammccall updated this revision to Diff 258193. sammccall added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75479/new/ https://reviews.llvm.org/D75479 Files: clang-tools-extra/clangd/SourceCode.cpp clang-tools-ext

[PATCH] D76594: [clang][AST] Support AST files larger than 512M

DmitryPolukhin updated this revision to Diff 258192. DmitryPolukhin marked 3 inline comments as done. DmitryPolukhin added a comment. Comments resolved Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76594/new/ https://reviews.llvm.org/D76594 Files:

[PATCH] D77168: Add a flag to debug automatic variable initialization

jfb added a comment. In D77168#1984109 , @jcai19 wrote: > > Right, support needs to be added, and I was wondering if you'd want to do > > this because it seems like a tool that would help you out. > > Sorry for the delay. Yes the biggest advantage of this

[PATCH] D76932: [AIX] emit .extern and .weak directive linkage

hubert.reinterpretcast added inline comments. Comment at: llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp:1496 + +MCSymbol *Name = getSymbol(&F); +if (TM.getTargetTriple().isOSBinFormatXCOFF() && !F.isIntrinsic()) { DiggerLin wrote: > jasonliu wrote: > > This

[PATCH] D78338: [clangd] Enable diagnostic fixes within macro argument expansions.

sammccall created this revision. sammccall added a reviewer: hokein. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. This seems like a pretty safe case, and common enough to be useful. Repository: rG LLVM Gi

[PATCH] D78308: [NFC][PowerPC] Refactor ppcUserFeaturesCheck()

nemanjai accepted this revision. nemanjai added a comment. This revision is now accepted and ready to land. LGTM. Thanks for refactoring this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78308/new/ https://reviews.llvm.org/D78308 _

[PATCH] D77168: Add a flag to debug automatic variable initialization

srhines added a comment. `pragma clang attribute` is interesting, but how do you apply that in a selective fashion to local variables (especially in a way that can be automated)? At first, I didn't think the goal for this should be to create a frequently used option for **most** end users, but

[PATCH] D76038: PR45000: Use Sema::SetParamDefaultArgument in TransformLambdaExpr

aaronpuchert marked 2 inline comments as done. aaronpuchert added inline comments. Comment at: clang/lib/Sema/TreeTransform.h:12162 for (unsigned I = 0, NumParams = NewCallOperator->getNumParams(); I != NumParams; ++I) { rsmith wrote: > rsmith wrote:

[PATCH] D76038: PR45000: Use Sema::SetParamDefaultArgument in TransformLambdaExpr

aaronpuchert marked an inline comment as done. aaronpuchert added inline comments. Comment at: clang/lib/Sema/TreeTransform.h:12162 for (unsigned I = 0, NumParams = NewCallOperator->getNumParams(); I != NumParams; ++I) { aaronpuchert wrote: > rsmith

[PATCH] D78308: [NFC][PowerPC] Refactor ppcUserFeaturesCheck()

jsji added inline comments. Comment at: clang/lib/Basic/Targets/PPC.cpp:243 + bool Passed = CheckVSXSubfeature("+power8-vector", "-mpower8-vector"); + Passed |= CheckVSXSubfeature("+direct-move", "-mdirect-move"); + Passed |= CheckVSXSubfeature("+float128", "-mfloat128");

[PATCH] D77592: [NFC][CodeGen] Add enum for selecting the layout of components in the vtable

rjmccall added a comment. In D77592#1987677 , @leonardchan wrote: > In D77592#1985740 , @rjmccall wrote: > > > I'm not sure if the AST-level v-table layout abstraction really cares about > > these differences. I d

[PATCH] D77168: Add a flag to debug automatic variable initialization

jfb added a comment. In D77168#1988049 , @srhines wrote: > `pragma clang attribute` is interesting, but how do you apply that in a > selective fashion to local variables (especially in a way that can be > automated)? At first, I didn't think the goal for

[PATCH] D76612: [Matrix] Add draft specification for matrix support in Clang.

rjmccall added inline comments. Comment at: clang/docs/LanguageExtensions.rst:511 +*r = *a + (*b * *c); + } + This is kindof an unnecessarily unreadable example. I know you haven't decided on calling convention treatment yet, but maybe the leading example

[PATCH] D77168: Add a flag to debug automatic variable initialization

srhines added a comment. In D77168#1988122 , @jfb wrote: > In D77168#1988049 , @srhines wrote: > > > `pragma clang attribute` is interesting, but how do you apply that in a > > selective fashion to local variables

[PATCH] D78289: [analyzer] Stability improvements for IteratorModeling functions

NoQ added a comment. Tests please! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78289/new/ https://reviews.llvm.org/D78289 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.or

<    1   2