DmitryPolukhin added inline comments.
================ Comment at: clang/include/clang/Serialization/ASTBitCodes.h:228 + /// value in the padding affects AST hash. + uint32_t BitOffsetLow = 0; + uint32_t BitOffsetHigh = 0; ---------------- sammccall wrote: > consider making this a class and these members private I kept members public because they public for all other similar struct in the file. I think initial idea to keep them public was to have POD struct but it is actually not the case due to user defined constructor. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76594/new/ https://reviews.llvm.org/D76594 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
