[PATCH] D77722: [analyzer] Do not report NSError null dereference for _Nonnull params

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/NullabilityChecker.cpp:536 + + auto State = Context.getState(); + That's still too much auto. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D77722: [analyzer] Do not report NSError null dereference for _Nonnull params

NoQ added a comment. In D77722#1969391 , @Szelethus wrote: > Wait, we don't already assume `nonnull` attributed parameters as, well, not > null? That's crazy. That's only for the top frame. For nested stack frames we're not only assuming they're not nu

[PATCH] D77571: [clang-tidy] Add check to find calls to NSInvocation methods under ARC that don't have proper object argument lifetimes.

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM aside from the file names concern. Comment at: clang-tools-extra/clang-tidy/objc/CMakeLists.txt:8 MissingHashCheck.cpp + NsinvocationArgumentLifetimeCheck.cpp ObjCTidyModule.cpp I

[PATCH] D77229: [Analyzer][WIP] Avoid handling of LazyCompundVals in IteratorModeling

NoQ added a comment. > I am totally lost here. What is wrong? Looks like a bug. Every constructor and every function that returns an object by value should have a construction context. Comment at: clang/lib/StaticAnalyzer/Core/ExprEngineCXX.cpp:231-235 +if (dyn_cast_o

[PATCH] D77722: [analyzer] Do not report NSError null dereference for _Nonnull params

vsavchenko updated this revision to Diff 256017. vsavchenko added a comment. Get rid of nonessential 'auto' in variable declaration Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77722/new/ https://reviews.llvm.org/D77722 Files: clang/lib/StaticA

[PATCH] D76605: [analyzer] Display the checker name in the text output

martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. I was just wondering if it would make sense to have a test with `display-checker-name=true`. Other than that, LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76605/new/ https:/

[PATCH] D77393: [X86] Fix implicit sign conversion warnings in X86 headers.

This revision was automatically updated to reflect the committed changes. Closed by commit rG937e63b8d5e9: [X86] Fix x86-header-warnings.c test not detecting regressions as intended. (authored by Pierre Gousseau ). Changed prior to commit: https://reviews.llvm.org/D77

[PATCH] D77393: [X86] Fix implicit sign conversion warnings in X86 headers.

pgousseau added a comment. In D77393#1969419 , @probinson wrote: > It looks like you're not actually interested in the compiled output, but just > whether warnings occurred; in that case you'd be better off with `-verify > -fsyntax-only` and `// expected

[PATCH] D77731: [OPENMP]Fix capturing of global variables in OpenMP regions.

ABataev created this revision. ABataev added a reviewer: jdoerfert. Herald added subscribers: guansong, yaxunl. Herald added a project: clang. The global variable should be captured in the region only if it was privitized in the region or in any of the outer regions. Otherwise, it should not be ca

[PATCH] D77229: [Analyzer][WIP] Avoid handling of LazyCompundVals in IteratorModeling

NoQ added a comment. In D77229#1969455 , @baloghadamsoftware wrote: > The problem is that the `CFGElement` for function `iterator begin() { return > iterator(_start); }` is just a `CFGStmt` and not `CFGCXXRecordTypedCall`. In which code? It's not about

[PATCH] D77732: [clangd] Shard preamble symbols in dynamic index

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. This reduces memory usage by dynamic index from more than 400MB to 32MB when all files in clang-tools-e

[PATCH] D76605: [analyzer] Display the checker name in the text output

Szelethus added a comment. In D76605#1969535 , @martong wrote: > I was just wondering if it would make sense to have a test with > `display-checker-name=true`. Other than that, LGTM! Could do! Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.o

[clang] 937e63b - [X86] Fix x86-header-warnings.c test not detecting regressions as intended.

Author: Pierre Gousseau Date: 2020-04-08T15:22:44+01:00 New Revision: 937e63b8d5e961c2a7da25558bbcdd5388182b67 URL: https://github.com/llvm/llvm-project/commit/937e63b8d5e961c2a7da25558bbcdd5388182b67 DIFF: https://github.com/llvm/llvm-project/commit/937e63b8d5e961c2a7da25558bbcdd5388182b67.dif

[libunwind] 6f1d558 - [libunwind] Fix incorrect lit substitutions in tests

Author: Louis Dionne Date: 2020-04-08T10:50:09-04:00 New Revision: 6f1d558db42cf92351c649a66c00b881eb75537c URL: https://github.com/llvm/llvm-project/commit/6f1d558db42cf92351c649a66c00b881eb75537c DIFF: https://github.com/llvm/llvm-project/commit/6f1d558db42cf92351c649a66c00b881eb75537c.diff

[PATCH] D77722: [analyzer] Do not report NSError null dereference for _Nonnull params

vsavchenko updated this revision to Diff 256020. vsavchenko added a comment. Remove more auto's Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77722/new/ https://reviews.llvm.org/D77722 Files: clang/lib/StaticAnalyzer/Checkers/NullabilityChecker.

[PATCH] D77722: [analyzer] Do not report NSError null dereference for _Nonnull params

NoQ accepted this revision. NoQ added a comment. Thanks! I'll commit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77722/new/ https://reviews.llvm.org/D77722 ___ cfe-commits mailing list cfe-commits@

[PATCH] D75851: [Analyzer][StreamChecker] Added evaluation of fseek.

balazske updated this revision to Diff 256023. balazske added a comment. - Rebase - Improved comments - Changed `UnknownError` to `Unknown` - Test changes (removed unneeded test) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75851/new/ https://revi

[PATCH] D77722: [analyzer] Do not report NSError null dereference for _Nonnull params

vsavchenko added a comment. In D77722#1969551 , @NoQ wrote: > Thanks! > > I'll commit. Awesome! Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77722/new/ https://reviews.llvm.org/D77722

[PATCH] D76066: [ARM][MachineOutliner] Add Machine Outliner support for ARM

yroux added a comment. Hi Sam, Thanks for your comments. Comment at: llvm/lib/Target/ARM/ARMBaseInstrInfo.cpp:5606 + // candidates. + auto CantGuaranteeValueAcrossCall = [&TRI](outliner::Candidate &C) { +// If the unsafe registers in this block are all dead, then we don'

[PATCH] D77305: [Analyzer][VLASize] Support multi-dimensional arrays.

martong accepted this revision. martong added a comment. LGTM, nice work! Comment at: clang/lib/StaticAnalyzer/Checkers/VLASizeChecker.cpp:163 + // Walk over the VLAs for every dimension until a non-VLA is found. + // Collect the sizes, put the most inner VLA to `VLALast`. +

[PATCH] D77632: [TLI] Per-function fveclib for math library used for vectorization

tejohnson added a comment. Needs testing of the inline handling, and of LTO linking IR with different attributes (which is going to hit your assert, see below). Comment at: clang/lib/CodeGen/CGCall.cpp:1987 + // Attach "vect-lib" attribute to function based on '-fveclib' se

[PATCH] D77540: [PATCH] [ARM]: Armv8.6-a Matrix Mul Asm and Intrinsics Support

LukeGeeson marked 2 inline comments as done. LukeGeeson added inline comments. Comment at: clang/lib/Basic/Targets/AArch64.cpp:284 + if (HasMatMul) +Builder.defineMacro("__ARM_FEATURE_MATMUL_INT8", "1"); + DavidSpickett wrote: > I don't see specific tests fo

[PATCH] D77641: [analyzer] StdLibraryFunctionsChecker: Associate summaries to FunctionDecls

martong added a comment. In D77641#1969291 , @Szelethus wrote: > I suspect your change made compiler errors a bit nicer as well, so you don't > get one giant "Well, this huge single argument doesn't match any of the > assignment operators". The rea

[PATCH] D77641: [analyzer] StdLibraryFunctionsChecker: Associate summaries to FunctionDecls

martong added a comment. In D77641#1969412 , @NoQ wrote: > So you only do the lookup in the global scope? What about `namespace std`? > > Do you also plan to support class methods by looking up the class first and > then looking up the method in the class

[PATCH] D77701: [Sema] refactor static functions into private methods NFC

nickdesaulniers added a comment. In D77701#1969132 , @aaron.ballman wrote: > OTOH, this is reasonable, NFC, and I tend to agree about it being a code > smell. > OTOH, this makes parsing Sema.h that much slower and adds even more text for > us to wade t

[PATCH] D76062: [PATCH] [ARM] ARMv8.6-a command-line + BFloat16 Asm Support

LukeGeeson added a comment. apologies please ignore adding here, added reviewers to the wrong diff Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76062/new/ https://reviews.llvm.org/D76062 ___ cfe-commi

[PATCH] D75169: [ARM] Enforcing calling convention for half-precision FP arguments and returns for big-endian AArch32

pratlucas added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75169/new/ https://reviews.llvm.org/D75169 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[PATCH] D77379: [FPEnv] Use single enum to represent rounding mode

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Okay. I can accept this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77379/new/ https://reviews.llvm.org/D77379 __

[PATCH] D77658: [analyzer] StdLibraryFunctionsChecker: Add sanity checks for constraints

martong marked 2 inline comments as done. martong added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:116 +/// Do sanity check on the constraint. +virtual bool validate(const FunctionDecl *) const { return true; } ArgNo

[PATCH] D77701: [Sema] refactor static functions into private methods NFC

aaron.ballman added a comment. In D77701#1969687 , @nickdesaulniers wrote: > In D77701#1969132 , @aaron.ballman > wrote: > > > OTOH, this is reasonable, NFC, and I tend to agree about it being a code > > smell. >

[PATCH] D77728: [Driver][X86] Add an alias for -mpad-max-prefix-size

MaskRay added a comment. > Make -malign-branch-prefix-size an alias for -mpad-max-prefix-size (For GCC > compatibility) I cannot find a discussion on -mpad-max-prefix-size. Is it a planned GNU as option or GCC driver option? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[PATCH] D77519: Fix __is_pointer builtin type trait to work with Objective-C pointer types.

zoecarver marked 2 inline comments as done. zoecarver added inline comments. Comment at: clang/test/SemaObjCXX/type-traits-is-pointer.mm:1 +// RUN: %clang_cc1 -fsyntax-only -fobjc-arc -fobjc-runtime-has-weak -verify %s +// expected-no-diagnostics ldionne wrote: >

[PATCH] D77477: tsan: don't instrument __attribute__((naked)) functions

kcc added a comment. The code is ok, but I'd like to see an ACK from Dmitry. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77477/new/ https://reviews.llvm.org/D77477 ___ cfe-commits mailing list cfe-co

[clang] b25ec45 - Fix __is_pointer builtin type trait to work with Objective-C pointer types.

Author: zoecarver Date: 2020-04-08T10:02:53-07:00 New Revision: b25ec45809fbb71d0db883c0275dc5ddcd61160d URL: https://github.com/llvm/llvm-project/commit/b25ec45809fbb71d0db883c0275dc5ddcd61160d DIFF: https://github.com/llvm/llvm-project/commit/b25ec45809fbb71d0db883c0275dc5ddcd61160d.diff LOG

[PATCH] D77743: [HIP] Emit symbols with kernel name in host binary

yaxunl created this revision. yaxunl added reviewers: tra, rjmccall. HIP provide host API to allow C/C++ programs to launch kernel. A C/C++ program can declare a HIP kernel as an external function and pass it to the kernel launching API. When linked with object files built from HIP programs. These

[PATCH] D77628: [Driver][X86] Add -mpad-max-prefix-size

MaskRay requested changes to this revision. MaskRay added a comment. This revision now requires changes to proceed. > It has similar (but slightly different) effect as GAS's option > -malign-branch-prefix-size, e.g. -mpad-max-prefix-size can also elminate NOPs > emitted by align directive, so we

[PATCH] D74387: [SYCL] Defer __float128 type usage diagnostics

Fznamznon added a comment. In D74387#1967386 , @jdoerfert wrote: > In D74387#1967289 , @Fznamznon wrote: > > > In D74387#1965634 , @jdoerfert > > wrote: > > > > > In D74387#

[PATCH] D77540: [PATCH] [ARM]: Armv8.6-a Matrix Mul Asm and Intrinsics Support

fhahn added a comment. This patch is quite big and I think it would be easier to review if it would be split up into distinct clang/llvm parts and maybe NEON/SVE parts on the LLVM side. Comment at: clang/lib/Driver/ToolChains/Arch/AArch64.cpp:71 + +// +sve implies +f32mm

[PATCH] D77519: Fix __is_pointer builtin type trait to work with Objective-C pointer types.

ldionne added inline comments. Comment at: libcxx/include/type_traits:901 +// In clang 10.0.0 and earlier __is_pointer didn't work with Objective-C types. +#if __has_keyword(__is_pointer) && _LIBCPP_CLANG_VER > 1000 + zoecarver wrote: > ldionne wrote: > > zoecarv

[PATCH] D77519: Fix __is_pointer builtin type trait to work with Objective-C pointer types.

This revision was automatically updated to reflect the committed changes. Closed by commit rGb25ec45809fb: Fix __is_pointer builtin type trait to work with Objective-C pointer types. (authored by zoecarver). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D77746: [Driver] Default arm-linux-androideabi to -z max-page-size=4096

MaskRay created this revision. MaskRay added reviewers: rprichard, srhines, thieta. Herald added subscribers: cfe-commits, danielkiss, kristof.beyls. Herald added a project: clang. Similar to D55029 . The requirement arises when discussing increasing default max-p

[PATCH] D76932: [AIX] emit .extern and .weak directive linkage

DiggerLin marked 16 inline comments as done. DiggerLin added inline comments. Comment at: llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp:1500 + if (cast(Name)->hasContainingCsect()) +emitLinkage(&F, Name); + jasonliu wrote: > 1. We need to rebase here, a

[PATCH] D77571: [clang-tidy] Add check to find calls to NSInvocation methods under ARC that don't have proper object argument lifetimes.

mwyman updated this revision to Diff 256070. mwyman added a comment. Renamed NsinvocationArgumentLifetimeCheck -> NSInvocationArgumentLifetimeCheck to match other ObjC checker names. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77571/new/ https:/

[PATCH] D76932: [AIX] emit .extern and .weak directive linkage

DiggerLin updated this revision to Diff 256067. DiggerLin marked 2 inline comments as done. DiggerLin added a comment. address comment and rebased the patch on D77080 [NFC][XCOFF][AIX] Refactor get/setContainingCsect Repository: rG LLVM Github Monorepo CHAN

[PATCH] D77229: [Analyzer][WIP] Avoid handling of LazyCompundVals in IteratorModeling

baloghadamsoftware marked an inline comment as done. baloghadamsoftware added a comment. In D77229#1969524 , @NoQ wrote: > In D77229#1969455 , > @baloghadamsoftware wrote: > > > The problem is that the `CFGElement`

[PATCH] D75044: [AArch64] __builtin_extract_return_addr for PAuth.

danielkiss updated this revision to Diff 256069. danielkiss added a comment. Rebased and address review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75044/new/ https://reviews.llvm.org/D75044 Files: clang/lib/CodeGen/TargetInfo.cpp clang/test/CodeGen/arm64-extractreturna

[PATCH] D75044: [AArch64] __builtin_extract_return_addr for PAuth.

danielkiss marked 4 inline comments as done. danielkiss added inline comments. Comment at: llvm/include/llvm/CodeGen/ISDOpcodes.h:74 /// the parent's frame or return address, and so on. -FRAMEADDR, RETURNADDR, ADDROFRETURNADDR, SPONENTRY, +FRAMEADDR, RETURNADDR, ADDR

[clang] d2e498b - [CUDA] Improve testing of libdevice detection.

Author: Artem Belevich Date: 2020-04-08T11:19:45-07:00 New Revision: d2e498b1725dd7b792c061387ff76df71cd7728a URL: https://github.com/llvm/llvm-project/commit/d2e498b1725dd7b792c061387ff76df71cd7728a DIFF: https://github.com/llvm/llvm-project/commit/d2e498b1725dd7b792c061387ff76df71cd7728a.diff

[clang] a9627b7 - [CUDA] Add partial support for recent CUDA versions.

Author: Artem Belevich Date: 2020-04-08T11:19:44-07:00 New Revision: a9627b7ea7e2b47488188cb1d80a23b24a8066b2 URL: https://github.com/llvm/llvm-project/commit/a9627b7ea7e2b47488188cb1d80a23b24a8066b2 DIFF: https://github.com/llvm/llvm-project/commit/a9627b7ea7e2b47488188cb1d80a23b24a8066b2.diff

[clang] 33386b2 - [CUDA] Simplify GPU variant handling. NFC.

Author: Artem Belevich Date: 2020-04-08T11:19:43-07:00 New Revision: 33386b20aa82c73e28b871cfa35c89a3808c9f92 URL: https://github.com/llvm/llvm-project/commit/33386b20aa82c73e28b871cfa35c89a3808c9f92 DIFF: https://github.com/llvm/llvm-project/commit/33386b20aa82c73e28b871cfa35c89a3808c9f92.diff

[PATCH] D77697: libc++: adjust modulemap for non-modular C

compnerd added a comment. @dexonsmith - yeah, sadly I dont think that there is a good way to audit that - any change to the public headers can cause issues. Furthermore, the libc headers themselves also influence this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

[PATCH] D57226: [Fixed Point] [AST] Add an AST serialization code for fixed-point literals.

leonardchan added a comment. In D57226#1969227 , @vabridgers wrote: > https://reviews.llvm.org/D77721 depends on this serialization change for > fixed point literals. You could probably take over and land the patch if @ebevhan doesn't respond back soon

[PATCH] D76932: [AIX] emit .extern and .weak directive linkage

jasonliu added inline comments. Comment at: llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp:1500 + if (cast(Name)->hasContainingCsect()) +emitLinkage(&F, Name); + DiggerLin wrote: > jasonliu wrote: > > 1. We need to rebase here, as it is called `hasRepres

[PATCH] D75936: Add a Pass to X86 that builds a Condensed CFG for Load Value Injection (LVI) Gadgets [4/6]

craig.topper updated this revision to Diff 256073. craig.topper added a comment. Address review comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75936/new/ https://reviews.llvm.org/D75936 Files: clang/include/clang/Driver/Options.td clang/lib/Driver/ToolChains/Arch/X86.cpp

[PATCH] D77621: Change BitcodeWriter buffer to std::vector instead of SmallVector.

dexonsmith added a comment. In D77621#1968647 , @browneee wrote: > Do we want to increase the complexity of SmallVector somewhat? or do we want > to keep the limit and affirm SmallVector is for small things? I don't think we should limit `SmallVector` t

[PATCH] D75936: Add a Pass to X86 that builds a Condensed CFG for Load Value Injection (LVI) Gadgets [4/6]

craig.topper marked an inline comment as done. craig.topper added inline comments. Comment at: llvm/lib/Target/X86/X86LoadValueInjectionLoadHardening.cpp:83-85 +#define ARG_NODE nullptr +#define GADGET_EDGE ((int)(-1)) +#define WEIGHT(EdgeValue) ((double)(2 * (EdgeValue) + 1)) --

[PATCH] D77540: [PATCH] [ARM]: Armv8.6-a Matrix Mul Asm and Intrinsics Support

LukeGeeson added a comment. In D77540#1969873 , @fhahn wrote: > This patch is quite big and I think it would be easier to review if it would > be split up into distinct clang/llvm parts and maybe NEON/SVE parts on the > LLVM side. That's a good suggest

[PATCH] D77665: [CUDA] Simplify GPU variant handling. NFC.

This revision was automatically updated to reflect the committed changes. Closed by commit rG33386b20aa82: [CUDA] Simplify GPU variant handling. NFC. (authored by tra). Changed prior to commit: https://reviews.llvm.org/D77665?vs=255756&id=256078#toc Repository: rG LLVM Github Monorepo CHANG

[PATCH] D77743: [HIP] Emit symbols with kernel name in host binary

tra added a comment. Would not this scheme create a conflict between the device-side mangled kernel name and the handle which we emit with the same name? I recall that the distinct stub name was introduced specifically to avoid confusion between device-side kernel and the host-side stub that we

[PATCH] D77688: [CUDA] Improve testing of libdevice detection.

This revision was automatically updated to reflect the committed changes. Closed by commit rGd2e498b1725d: [CUDA] Improve testing of libdevice detection. (authored by tra). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77688/new/ https://reviews.llv

[PATCH] D77670: [CUDA] Add partial support for recent CUDA versions.

This revision was automatically updated to reflect the committed changes. Closed by commit rGa9627b7ea7e2: [CUDA] Add partial support for recent CUDA versions. (authored by tra). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77670/new/ https://revie

[PATCH] D77682: [clang-format] Always break line after enum opening brace

osandov added a comment. The style guide I'm following (the Linux kernel style) wants `AfterEnum: false`. A cursory search suggests that people treat this trailing comma behavior as a feature (https://stackoverflow.com/questions/23072223/clang-format-style-options-for-enums). However, I think

[PATCH] D75936: Add a Pass to X86 that builds a Condensed CFG for Load Value Injection (LVI) Gadgets [4/6]

craig.topper marked 37 inline comments as done and an inline comment as not done. craig.topper added inline comments. Comment at: llvm/lib/Target/X86/ImmutableGraph.h:41 +class ImmutableGraph { + using Traits = GraphTraits *>; + template friend class ImmutableGraphBuilder; --

[PATCH] D77746: [Driver] Default arm-linux-androideabi to -z max-page-size=4096

srhines accepted this revision. srhines added a comment. This revision is now accepted and ready to land. Thank you for making this clear. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77746/new/ https://reviews.llvm.org/D77746 _

[PATCH] D59321: AMDGPU: Teach toolchain to link rocm device libs

arsenm added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59321/new/ https://reviews.llvm.org/D59321 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D77684: [Hexagon] Remove testcases that check for default linker.

bcain accepted this revision. bcain added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77684/new/ https://reviews.llvm.org/D77684 ___ c

[PATCH] D77746: [Driver] Default arm-linux-androideabi to -z max-page-size=4096

thieta accepted this revision. thieta added a comment. Thanks for handling this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77746/new/ https://reviews.llvm.org/D77746 ___ cfe-commits mailing list cf

[clang] 969b91a - [Driver] Default arm-linux-androideabi to -z max-page-size=4096

Author: Fangrui Song Date: 2020-04-08T12:05:28-07:00 New Revision: 969b91af732d83870bb17e1e0ca0202fe4b89965 URL: https://github.com/llvm/llvm-project/commit/969b91af732d83870bb17e1e0ca0202fe4b89965 DIFF: https://github.com/llvm/llvm-project/commit/969b91af732d83870bb17e1e0ca0202fe4b89965.diff

[PATCH] D59321: AMDGPU: Teach toolchain to link rocm device libs

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59321/new/ https://reviews.llvm.org/D59321 ___ cfe-commits mailing list cfe-

[PATCH] D77746: [Driver] Default arm-linux-androideabi to -z max-page-size=4096

MaskRay updated this revision to Diff 256085. MaskRay added a comment. Clarify a comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77746/new/ https://reviews.llvm.org/D77746 Files: clang/lib/Driver/ToolChains/Linux.cpp clang/test/Driver/an

[PATCH] D77743: [HIP] Emit symbols with kernel name in host binary

yaxunl added a comment. In D77743#1970035 , @tra wrote: > Would not this scheme create a conflict between the device-side mangled > kernel name and the handle which we emit with the same name? I recall that > the distinct stub name was introduced specifi

[PATCH] D74813: [RFC] Add hash of block contents to function block names

alexbdv marked an inline comment as done. alexbdv added inline comments. Comment at: clang/lib/AST/Mangle.cpp:56 + + // Strip out addresses + char *ptr = &strStmtBuff[1]; manmanren wrote: > Is this needed to have deterministic behavior? Correct. Repository:

[PATCH] D77746: [Driver] Default arm-linux-androideabi to -z max-page-size=4096

This revision was automatically updated to reflect the committed changes. Closed by commit rG969b91af732d: [Driver] Default arm-linux-androideabi to -z max-page-size=4096 (authored by MaskRay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77746/new/

[clang] 878d960 - [clang][CodeGen] Handle throw expression in conditional operator constant folding

Author: Raul Tambre Date: 2020-04-08T12:32:21-07:00 New Revision: 878d96011acc0314ae7e5f87aca515286abbe4db URL: https://github.com/llvm/llvm-project/commit/878d96011acc0314ae7e5f87aca515286abbe4db DIFF: https://github.com/llvm/llvm-project/commit/878d96011acc0314ae7e5f87aca515286abbe4db.diff L

[PATCH] D74813: [RFC] Add hash of block contents to function block names

alexbdv added a comment. @dexonsmith - any suggestions to move forward on this ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74813/new/ https://reviews.llvm.org/D74813 ___ cfe-commits mailing list cf

[PATCH] D75844: [clang] Set begin loc on GNU attribute parsed attrs

aaron.ballman added a comment. In D75844#1951915 , @tbaeder wrote: > Sorry for taking so long but it seems like I've went down a rabbit hole a > bit. My previous patch sets the range in `parseGNUAttributes()` > unconditionally, but that seems to trigger

[PATCH] D77502: [clang][CodeGen] Handle throw expression in conditional operator constant folding

This revision was automatically updated to reflect the committed changes. Closed by commit rG878d96011acc: [clang][CodeGen] Handle throw expression in conditional operator constant… (authored by tambre, committed by rsmith). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[clang] 30588a7 - Make target features check work with ctor and dtor-

Author: Erich Keane Date: 2020-04-08T13:19:55-07:00 New Revision: 30588a739584bb8ac41715d68656d22bd85198e7 URL: https://github.com/llvm/llvm-project/commit/30588a739584bb8ac41715d68656d22bd85198e7 DIFF: https://github.com/llvm/llvm-project/commit/30588a739584bb8ac41715d68656d22bd85198e7.diff L

[PATCH] D74813: [RFC] Add hash of block contents to function block names

erik.pilkington added a comment. What do you think about using the block type instead of a hash? That should be stable across compiler versions, changes to the block body, and changes to referenced declarations. You'd still have to number blocks of the same type within the same function, but th

[PATCH] D70366: Add new 'flatten' LLVM attribute to fix clang's 'flatten' function attribute

LevitatingLion added a comment. While adding tests to clang I realized the attribute is not working as intended when using an optimization level of zero, because clang adds the noinline attribute to all functions. In this case the optimizer cannot distinguish between functions originally marked

[PATCH] D77743: [HIP] Emit symbols with kernel name in host binary

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. In D77743#1970163 , @yaxunl wrote: > The kernel handle is a variable. Even if it has the same name as kernel, it > is OK for the debugger since the debugger

[PATCH] D75936: Add a Pass to X86 that builds a Condensed CFG for Load Value Injection (LVI) Gadgets [4/6]

craig.topper updated this revision to Diff 256103. craig.topper marked 5 inline comments as done. craig.topper added a comment. -Replace ARG_NODE and GADGET_EDGE defines with static constexpr members CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75936/new/ https://reviews.llvm.org/D7593

[PATCH] D77683: [Docs] Make code review policy clearer about requested pre-commit reviews

jdoerfert updated this revision to Diff 256108. jdoerfert added a comment. Use @lattern 's wording which is more specific and has less spelling errors. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77683/new/ https://reviews.llvm.org/D77683 Files:

[PATCH] D75181: [AArch64] Handle BTI/PAC in case of generated functions.

danielkiss added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:5149-5152 + if (BPI.BranchTargetEnforcement) +Fn->addFnAttr("branch-target-enforcement", "true"); + else +Fn->addFnAttr("branch-target-enforcement", "false");

[PATCH] D77683: [Docs] Make code review policy clearer about requested pre-commit reviews

jdoerfert added a comment. I did like @lattner 's solution so I use that now. Wdyt? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77683/new/ https://reviews.llvm.org/D77683 ___ cfe-commits mailing list

[PATCH] D75936: Add a Pass to X86 that builds a Condensed CFG for Load Value Injection (LVI) Gadgets [4/6]

craig.topper updated this revision to Diff 256106. craig.topper added a comment. -Put llvm:: on the for_each calls in this patch instead of D75937 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75936/new/ https://reviews.llvm.org/D75936 Files: clang/

[PATCH] D77754: [MS] Fix packed struct layout for arrays of aligned non-record types

rnk created this revision. rnk added a reviewer: rjmccall. Herald added a subscriber: jfb. Herald added a project: clang. In particular, this affects Clang's vectors. Users encounter this issue when a struct contains an __m128 type. Fixes PR45420 Repository: rG LLVM Github Monorepo https://r

[PATCH] D77753: Change deprecated -fsanitize-recover flag to apply to all sanitizers, not just UBSan.

rsmith created this revision. rsmith added a reviewer: kcc. Herald added a project: clang. Herald added a subscriber: cfe-commits. This flag has been deprecated, with an on-by-default warning encouraging users to explicitly specify whether they mean "all" or ubsan for 5 years (released in Clang 3.

[PATCH] D77451: Accept -x cu to indicate language is CUDA, transfer CUDA language flag to header-file arguments

ADRAADRA updated this revision to Diff 256111. ADRAADRA added a comment. - Update Types.cpp comment - remove types::TY_CUDA_FATBIN from switch CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77451/new/ https://reviews.llvm.org/D77451 Files: clang/lib/Driver/Types.cpp clang/lib/Toolin

[PATCH] D75917: Expose llvm fence instruction as clang intrinsic

b-sumner added a comment. In addition to predefining `__ATOMIC_RELAXED`, etc., clang also predefines `__OPENCL_MEMORY_SCOPE_WORK_ITEM` and friends. So it doesn't really seem unreasonable for clang to also predefine its known syncscopes, and to require the argument to be one of those integers.

[PATCH] D70366: Add new 'flatten' LLVM attribute to fix clang's 'flatten' function attribute

jdoerfert added a comment. In D70366#1970299 , @LevitatingLion wrote: > While adding tests to clang I realized the attribute is not working as > intended when using an optimization level of zero, because clang adds the > noinline attribute to all functi

[PATCH] D74387: [SYCL] Defer __float128 type usage diagnostics

jdoerfert added a comment. In D74387#1969891 , @Fznamznon wrote: > In D74387#1967386 , @jdoerfert wrote: > > > In D74387#1967289 , @Fznamznon > > wrote: > > > > > In D74387#

[PATCH] D77751: [OPENMP50] Fix PR45469: Consider variable-category of defaultmap clause as optional.

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77751/new/ https://reviews.llvm.org/D77751 _

[PATCH] D77697: libc++: adjust modulemap for non-modular C

joerg added a comment. @ldionne I was updating libc++ from d42baff45d9700a199982ba0ac04dbc6c6d911bb and LLVM itself from 38aebe5c04ab4cb3695dc1bcc60b9a7b55215aff

[PATCH] D77451: Accept -x cu to indicate language is CUDA, transfer CUDA language flag to header-file arguments

tra added a comment. Thank you for the patch. I assume you don't have commit access to LLVM. I can land the patch for you. How should I attribute it? Will `ADRA ` (used in phabricator emails) do or do you prefer some other form? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77451/new/

[PATCH] D70366: Add new 'flatten' LLVM attribute to fix clang's 'flatten' function attribute

dexonsmith added a comment. In D70366#1970375 , @jdoerfert wrote: > TBH, I would issue a warning if we see `flatten` in O0 that says this will > not work and be done with it. I would argue against diagnostics that depend on optimization level, since tha

[PATCH] D75591: [OpenMP] Add firstprivate as a default data-sharing attribute to clang

jdoerfert accepted this revision. jdoerfert added a comment. Apologies for my delay. LGTM. Wait for @lebedev.ri though. Comment at: clang-tools-extra/docs/clang-tidy/checks/openmp-use-default-none.rst:56 + // ``parallel`` directive can have ``default`` clause, and said claus

[PATCH] D70366: Add new 'flatten' LLVM attribute to fix clang's 'flatten' function attribute

dexonsmith added a comment. In D70366#1970299 , @LevitatingLion wrote: > Maybe we can add an additional string attribute when adding the noinline > attribute to functions which are not marked noinline in the source code, > something like "noinline-added

[PATCH] D77731: [OPENMP]Fix capturing of global variables in OpenMP regions.

jdoerfert added a subscriber: fghanim. jdoerfert added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:2117 +if (VD && !VD->hasLocalStorage() && DVarPrivate.CKind == OMPC_unknown && +(DSAStack->getDefaultDSA() != DSA_none || DVarTop.CKind == OMPC_shared))

[PATCH] D70366: Add new 'flatten' LLVM attribute to fix clang's 'flatten' function attribute

dexonsmith added a comment. In D70366#1970526 , @dexonsmith wrote: > In D70366#1970299 , @LevitatingLion > wrote: > > > Maybe we can add an additional string attribute when adding the noinline > > attribute to fun

<    1   2   3   >