aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM aside from the file names concern.
================ Comment at: clang-tools-extra/clang-tidy/objc/CMakeLists.txt:8 MissingHashCheck.cpp + NsinvocationArgumentLifetimeCheck.cpp ObjCTidyModule.cpp ---------------- I think the files should be renamed to `NSInvocationArgumentLifetimeCheck` based on typical naming conventions for NS identifiers. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77571/new/ https://reviews.llvm.org/D77571 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits