[PATCH] D77244: sancov/inline-bool-flag feature + tests + docs.

pratyai updated this revision to Diff 254418. pratyai added a comment. - Switched to Int1Ty. - Switched Atomic::NonAtomic (same as just dropping the two lines?) - C++ files were clang-formatted, but arc lint couldn't find clang-format-diff before. Now it seems to have formatted the lit tests. - W

[PATCH] D77238: [CUDA][NFC] Split math.h functions out of __clang_cuda_device_functions.h

hliao added a comment. this patch breaks the test clang/test/Headers/nvptx_device_cmath_functions.cpp, could you please fix it ASAP? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77238/new/ https://reviews.llvm.org/D77238 __

[PATCH] D70411: [analyzer] CERT: STR31-C

Charusso added a comment. Thanks for the review, hopefully if I ping @NoQ in every round, it will be green-marked soon. Comment at: clang/lib/StaticAnalyzer/Checkers/cert/StrChecker.cpp:55 + // they can cause a not null-terminated string. In this case we store the + // strin

[PATCH] D77233: [NFC] Refactoring PropertyAttributeKind for ObjCPropertyDecl and ObjCDeclSpec.

plotfi marked an inline comment as done. plotfi added inline comments. Comment at: clang/include/clang/AST/DeclObjCCommon.h:21 +/// Keep this list in sync with LLVM's Dwarf.h ApplePropertyAttributes. +enum ObjCPropertyAttributeKind { + OBJC_PR_noattr = 0x00, com

[PATCH] D77028: [NFC] Refactor DeferredDiagsEmitter and skip redundant visit

rjmccall added inline comments. Comment at: clang/lib/Sema/Sema.cpp:1508 void checkFunc(SourceLocation Loc, FunctionDecl *FD) { +auto DiagsCountIt = DiagsCount.find(FD); FunctionDecl *Caller = UseStack.empty() ? nullptr : UseStack.back(); It makes me

[PATCH] D75453: [Driver][ARM] fix undefined behaviour when checking architecture version

compnerd requested changes to this revision. compnerd added a comment. This revision now requires changes to proceed. Herald added a subscriber: danielkiss. Seems reasonable, though this isn't UB, its just use of an uninitialized variable. Please add a test case. Repository: rG LLVM Github M

[PATCH] D70411: [analyzer] CERT: STR31-C

Charusso updated this revision to Diff 254423. Charusso added a comment. - Remove the last dead comment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70411/new/ https://reviews.llvm.org/D70411 Files: clang/docs/analyzer/checkers.rst clang/include/clang/StaticAnalyzer/Checkers/Chec

[PATCH] D70411: [analyzer] CERT: STR31-C

Charusso updated this revision to Diff 254420. Charusso marked 4 inline comments as done. Charusso added a comment. - Simplify tests. - Remove dead code, they are far away to being used. - Add an extra test case. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70411/new/ https://reviews.l

[PATCH] D72959: Relative VTables ABI on Fuchsia

ldionne requested changes to this revision. ldionne added inline comments. Comment at: libcxxabi/src/private_typeinfo.cpp:617 // Get (dynamic_ptr, dynamic_type) from static_ptr +#ifndef __Fuchsia__ void **vtable = *static_cast(static_ptr); Please introd

[PATCH] D77238: [CUDA][NFC] Split math.h functions out of __clang_cuda_device_functions.h

This revision was automatically updated to reflect the committed changes. Closed by commit rGd1705c1196fe: [CUDA][NFC] Split math.h functions out of __clang_cuda_device_functions.h (authored by jdoerfert). Changed prior to commit: https://reviews.llvm.org/D77238?vs=254289&id=254426#toc Reposit

[clang] 410cfc4 - [OpenMP][FIX] Add second include after header was split in d1705c1196

Author: Johannes Doerfert Date: 2020-04-02T00:20:23-05:00 New Revision: 410cfc478f3540d3f07bba920fa3bf99409f6bda URL: https://github.com/llvm/llvm-project/commit/410cfc478f3540d3f07bba920fa3bf99409f6bda DIFF: https://github.com/llvm/llvm-project/commit/410cfc478f3540d3f07bba920fa3bf99409f6bda.d

[PATCH] D68049: Propeller: Clang options for basic block sections

MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:4858 + if (Arg *A = Args.getLastArg(options::OPT_fbasicblock_sections_EQ)) { +CmdArgs.push_back( If we want to pass the option verbatim, `A->render(Args, CmdArgs);` However,

[clang] b0b5f04 - [OpenMP][FIX] Undo changes accidentally already introduced in NFC commit

Author: Johannes Doerfert Date: 2020-04-02T01:33:39-05:00 New Revision: b0b5f0416be60152ddc8d606b1720daba0005518 URL: https://github.com/llvm/llvm-project/commit/b0b5f0416be60152ddc8d606b1720daba0005518 DIFF: https://github.com/llvm/llvm-project/commit/b0b5f0416be60152ddc8d606b1720daba0005518.d

[PATCH] D77238: [CUDA][NFC] Split math.h functions out of __clang_cuda_device_functions.h

jdoerfert added a comment. In D77238#1956547 , @hliao wrote: > this patch breaks the test > clang/test/Headers/nvptx_device_cmath_functions.cpp, could you please fix it > ASAP? > Once NVPTX target is enabled, the following tests failed: > > Failing Test

<    1   2   3