rjmccall added inline comments.
================
Comment at: clang/lib/Sema/Sema.cpp:1508
void checkFunc(SourceLocation Loc, FunctionDecl *FD) {
+ auto DiagsCountIt = DiagsCount.find(FD);
FunctionDecl *Caller = UseStack.empty() ? nullptr : UseStack.back();
----------------
It makes me a little uncomfortable to be holding an iterator this long while
calling a fair amount of other stuff in the meantime.
Your use of DiagsCount is subtle enough that it really needs to be explained in
some comments. You're doing stuff conditionally based on both whether the
entry exists but also whether it's non-zero.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D77028/new/
https://reviews.llvm.org/D77028
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
