ldionne requested changes to this revision.
ldionne added inline comments.
================
Comment at: libcxxabi/src/private_typeinfo.cpp:617
// Get (dynamic_ptr, dynamic_type) from static_ptr
+#ifndef __Fuchsia__
void **vtable = *static_cast<void ** const *>(static_ptr);
----------------
Please introduce a macro that generically expresses that relative vtables are
enabled, and explain what it is. You can then enable that macro only on
`__Fuchsia__`. I'd like to avoid freely adding platform-specific `#ifdef`s in
the code when it's easy to avoid.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D72959/new/
https://reviews.llvm.org/D72959
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
