[PATCH] D75093: clang-cl: Add a `/showIncludes:user` flag.

hans added a comment. Probably worth a mention in clang/docs/ReleaseNotes.rst, and maybe we should call it out in the user manual too, similarly to what we do for /Zc:dllexportInlines- Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75093/new/ http

[PATCH] D73186: [AST] Add fixed-point multiplication constant evaluation.

ebevhan added a comment. So, any more on this or are we in agreement? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73186/new/ https://reviews.llvm.org/D73186 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D75332: [clang-tidy] Add module for llvm-libc and restrict-system-libc-header-check.

PaulkaToast created this revision. PaulkaToast added a reviewer: sivachandra. PaulkaToast added projects: clang-tools-extra, libc-project. Herald added subscribers: cfe-commits, MaskRay, xazax.hun, mgorny. Herald added a project: clang. This adds a new module to enforce standards specific to the l

[PATCH] D75331: [clangd] Get rid of lexer usage in locateMacroAt

kadircet created this revision. kadircet added reviewers: sammccall, hokein. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. kadircet added a parent revision: D75259: [clangd] Get rid of unnecssary source transformations

[PATCH] D75249: [clangd] Use tokenize instead of raw lexer in SourceCode/lex

kadircet updated this revision to Diff 247175. kadircet marked an inline comment as done. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75249/new/ https://reviews.llvm.org/D75249 Files: clang-tools-ex

[clang-tools-extra] 48fad11 - [clangd] Get rid of lexer usage in ObjCLocalizeStringLiteral tweak

Author: Kadir Cetinkaya Date: 2020-02-28T09:38:26+01:00 New Revision: 48fad110e08a5765632d45e6a3c30186b21cc81a URL: https://github.com/llvm/llvm-project/commit/48fad110e08a5765632d45e6a3c30186b21cc81a DIFF: https://github.com/llvm/llvm-project/commit/48fad110e08a5765632d45e6a3c30186b21cc81a.dif

[clang-tools-extra] 98bb094 - [clangd] Use tokenize instead of raw lexer in SourceCode/lex

Author: Kadir Cetinkaya Date: 2020-02-28T09:38:26+01:00 New Revision: 98bb094c1e0580833a79d60dbc853bd1a43aa1a6 URL: https://github.com/llvm/llvm-project/commit/98bb094c1e0580833a79d60dbc853bd1a43aa1a6 DIFF: https://github.com/llvm/llvm-project/commit/98bb094c1e0580833a79d60dbc853bd1a43aa1a6.dif

[clang] b17f292 - [ASTImporter] Improved import of AlignedAttr.

Author: Balázs Kéri Date: 2020-02-28T09:40:59+01:00 New Revision: b17f29201089131bf97de21606097e963ca8614d URL: https://github.com/llvm/llvm-project/commit/b17f29201089131bf97de21606097e963ca8614d DIFF: https://github.com/llvm/llvm-project/commit/b17f29201089131bf97de21606097e963ca8614d.diff L

[PATCH] D73846: make sure to not warn about unused macros from -D

llunak added a comment. Ping... CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73846/new/ https://reviews.llvm.org/D73846 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D69585: PerformPendingInstatiations() already in the PCH

llunak added a comment. Ping.. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69585/new/ https://reviews.llvm.org/D69585 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D75022: clang-format: Extend AllowShortLoopsOnASingleLine to do ... while loops.

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. LGTM, thank you for adding the extra test, please mark the inline comments as done CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75022/new/ https://reviews.llvm.org/D

[PATCH] D72326: [clang-format] Rebased on master: Add option to specify explicit config file

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. LGTM Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72326/new/ https://reviews.llvm.org/D72326 ___ cfe-commits mailing list cfe-commits@lists.llvm

[PATCH] D75251: [clangd] Move the format rename edits from clangdserver to rename API, NFC.

kbobyrev accepted this revision. kbobyrev added a comment. This revision is now accepted and ready to land. LGTM with few nits Comment at: clang-tools-extra/clangd/refactor/Rename.cpp:466 +llvm::Expected formatEdits(FileEdits FE, + const f

[PATCH] D75323: Support relative dest paths in headermap files

sque updated this revision to Diff 247177. sque edited the summary of this revision. sque added a comment. Added test CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75323/new/ https://reviews.llvm.org/D75323 Files: clang/lib/Lex/HeaderSearch.cpp clang/test/Headers/Inputs/empty.hmap

[PATCH] D75249: [clangd] Use tokenize instead of raw lexer in SourceCode/lex

This revision was automatically updated to reflect the committed changes. Closed by commit rG98bb094c1e05: [clangd] Use tokenize instead of raw lexer in SourceCode/lex (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75249/new/

[PATCH] D75048: [ASTImporter] Improved import of AlignedAttr.

This revision was automatically updated to reflect the committed changes. Closed by commit rGb17f29201089: [ASTImporter] Improved import of AlignedAttr. (authored by balazske). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75048/new/ https://reviews

[PATCH] D75230: [clangd] Get rid of lexer usage in ObjCLocalizeStringLiteral tweak

This revision was automatically updated to reflect the committed changes. Closed by commit rG48fad110e08a: [clangd] Get rid of lexer usage in ObjCLocalizeStringLiteral tweak (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75230/

[PATCH] D75332: [clang-tidy] Add module for llvm-libc and restrict-system-libc-header-check.

njames93 added a comment. The test cases need fixing as they are causing the build to fail. Also would it be wise to add a .clang-tidy file to libc/ to enable this module for that subdirectory? Comment at: clang-tools-extra/clang-tidy/llvmlibc/CMakeLists.txt:17 + \ No newli

[PATCH] D75285: Mark restrict pointer or reference to const as invariant

jeroen.dobbelaere added a comment. I don't think that 'restrict' is a good match for this behavior. For c++, the alias_set proposal (http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2014/n4150.pdf) would be a better match. You would put the read access of *p in its own universe; or even bette

[PATCH] D75285: Mark restrict pointer or reference to const as invariant

JonChesterfield added a comment. In D75285#1897247 , @yaxunl wrote: > If users derive a non-const pointer from the const pointer and modify it, > doesn't that result in UB? Thanks. No. Modifying a const object is UB, so e.g. we can segv if it's in .roda

[PATCH] D74361: [Clang] Undef attribute for global variables

JonChesterfield marked an inline comment as done. JonChesterfield added inline comments. Comment at: clang/test/CodeGenCXX/attr-no-zero-initializer.cpp:40 +// CHECK: @unt = global %struct.nontrivial undef +nontrivial unt [[clang::no_zero_initializer]]; Quuxpluson

[PATCH] D75254: [ARM,MVE] Add ACLE intrinsics for VCVT.F32.F16 family.

miyuki accepted this revision. miyuki added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75254/new/ https://reviews.llvm.org/D75254 ___

[PATCH] D75261: [clang-format] Recognize C# nullable types

jbcoe updated this revision to Diff 247193. jbcoe added a comment. Add additional test following review discussion CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75261/new/ https://reviews.llvm.org/D75261 Files: clang/lib/Format/FormatToken.h clang/lib/Format/TokenAnnotator.cpp cl

[PATCH] D75163: [analyzer][StreamChecker] Adding precall and refactoring.

balazske updated this revision to Diff 247192. balazske marked 2 inline comments as done. balazske added a comment. Added a missing argument, lint warning reformat. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75163/new/ https://reviews.llvm.org/D

[PATCH] D75163: [analyzer][StreamChecker] Adding precall and refactoring.

Szelethus accepted this revision. Szelethus added a comment. This revision is now accepted and ready to land. LGTM! It makes much more sense to do the checking in `preCall` and the modeling in `evalCall`, the comments in the patch are precise and helpful, the tests cover everything. While I feel

[PATCH] D75310: [CUDA, clang-cl] Filter out unsupported arguments for device-side compilation.

hans accepted this revision. hans added a comment. It seems a little bit unfortunate to have to sprinkle !isNVPTX everywhere, but I don't have any better ideas, so lgtm. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75310/new/ https://reviews.llvm

[clang] 5f52a93 - [clang-format] Recognize C# nullable types

Author: Jonathan Coe Date: 2020-02-28T11:09:55Z New Revision: 5f52a93b698bab3f7083a6d97d3e3a2e303866e0 URL: https://github.com/llvm/llvm-project/commit/5f52a93b698bab3f7083a6d97d3e3a2e303866e0 DIFF: https://github.com/llvm/llvm-project/commit/5f52a93b698bab3f7083a6d97d3e3a2e303866e0.diff LOG:

[PATCH] D75181: [AArch64] Handle BTI/PAC in case of generated functions.

danielkiss updated this revision to Diff 247201. danielkiss retitled this revision from "[Clang][AArch64] Add default arguments to runtime functions." to "[AArch64] Handle BTI/PAC in case of generated functions.". danielkiss edited the summary of this revision. danielkiss added a project: LLVM. d

[PATCH] D75323: Support relative dest paths in headermap files

takuto.ikuta added inline comments. Comment at: clang/test/Headers/headermap_relpath.cpp:8 + +// RUN: cd %S; %clang_cc1 -I %S/Inputs/empty.hmap %s + generate header map using hmaptool like https://github.com/llvm/llvm-project/blob/e32ff096858578f526b6d05ab97c8f08

[PATCH] D74918: Add method to TargetInfo to get CPU cache line size

kristof.beyls added a comment. In D74918#1896930 , @__simt__ wrote: > (//I assume I'm not seeing a code review being used to veto a C++ Standard > feature, but actually the other points are the reason for the red flag.//) > > I can see a desire for hyper-

[PATCH] D75261: [clang-format] Recognize C# nullable types

This revision was automatically updated to reflect the committed changes. Closed by commit rG5f52a93b698b: [clang-format] Recognize C# nullable types (authored by Jonathan Coe ). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75261/n

[PATCH] D75336: [clang-format] Improve C# handling of spaces in square brackets

jbcoe created this revision. jbcoe added reviewers: MyDeveloperDay, krasimir. jbcoe added a project: clang-format. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D75336 Files: clang/lib/Format/TokenAnnotator

[PATCH] D75331: [clangd] Get rid of lexer usage in locateMacroAt

kadircet updated this revision to Diff 247213. kadircet added a comment. - Update forgotten call site Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75331/new/ https://reviews.llvm.org/D75331 Files: clang-tools-extra/clangd/Hover.cpp clang-tool

[PATCH] D75057: Syndicate, test and fix base64 implementation

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. In D75057#1896114 , @serge-sans-paille wrote: > In D75057#1895550 , @hokein wrote: > > > thanks for doing this

[PATCH] D75289: [clang-tidy] Added virtual isLanguageVersionSupported to ClangTidyCheck

njames93 added a comment. In D75289#1896929 , @Eugene.Zelenko wrote: > In D75289#1896925 , @njames93 wrote: > > > In D75289#1896902 , > > @Eugene.Zelenko wrote: > > > > > L

[clang] f829615 - [clang-format] Improve C# handling of spaces in square brackets

Author: Jonathan Coe Date: 2020-02-28T12:44:15Z New Revision: f829615205f0f671c9b6e1e89d9af78f0d40fe9d URL: https://github.com/llvm/llvm-project/commit/f829615205f0f671c9b6e1e89d9af78f0d40fe9d DIFF: https://github.com/llvm/llvm-project/commit/f829615205f0f671c9b6e1e89d9af78f0d40fe9d.diff LOG:

[PATCH] D75289: [clang-tidy] Added virtual isLanguageVersionSupported to ClangTidyCheck

gribozavr2 accepted this revision. gribozavr2 added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clang-tidy/ClangTidyCheck.h:86 /// matches occur in the order of the AST traversal. virtual void registerMatchers(ast_matchers

[PATCH] D75194: [clang-format] Do not merge very long C# automatic properties

krasimir added inline comments. Comment at: clang/lib/Format/UnwrappedLineFormatter.cpp:489 +// If the Limit is broken, split the default value onto a new line and +// indent it. +// Why not always (not just when Limit is broken) merge the whole autom

[PATCH] D75289: [clang-tidy] Added virtual isLanguageVersionSupported to ClangTidyCheck

gribozavr2 added inline comments. Comment at: clang-tools-extra/clang-tidy/ClangTidyCheck.h:109 + /// \p LangOpts. + virtual bool isLanguageVersionSupported(const LangOptions &LangOpts) const { +return true; Not a critical thing, but I feel like it would be

[PATCH] D75340: [clang-tidy] Change checks to use new isLanguageVersionSupported restriction

gribozavr2 added a comment. Looks good, but please move non-mechanical changes (potentially-semantic changes) into a separate patch. Comment at: clang-tools-extra/clang-tidy/cert/DefaultOperatorNewAlignmentCheck.h:30 + bool isLanguageVersionSupported(const LangOptions &LangO

[PATCH] D75194: [clang-format] Do not merge very long C# automatic properties

jbcoe marked an inline comment as done. jbcoe added inline comments. Comment at: clang/lib/Format/UnwrappedLineFormatter.cpp:489 +// If the Limit is broken, split the default value onto a new line and +// indent it. +// krasimir wrote: > Why not alway

[PATCH] D75289: [clang-tidy] Added virtual isLanguageVersionSupported to ClangTidyCheck

njames93 updated this revision to Diff 247226. njames93 added a comment. - Updated docs to include precondition Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75289/new/ https://reviews.llvm.org/D75289 Files: clang-tools-extra/clang-tidy/ClangTid

[PATCH] D75336: [clang-format] Improve C# handling of spaces in square brackets

This revision was automatically updated to reflect the committed changes. Closed by commit rGf829615205f0: [clang-format] Improve C# handling of spaces in square brackets (authored by Jonathan Coe ). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[PATCH] D75289: [clang-tidy] Added virtual isLanguageVersionSupported to ClangTidyCheck

njames93 updated this revision to Diff 247230. njames93 marked an inline comment as done. njames93 added a comment. - Moved isLanguageVersionSupported above register functions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75289/new/ https://reviews

[clang-tools-extra] 39c4246 - [clang-tidy] Added virtual isLanguageVersionSupported to ClangTidyCheck

Author: Nathan James Date: 2020-02-28T13:05:05Z New Revision: 39c4246e1e5bb76b1bca2e4b0d0ebc4005d75c32 URL: https://github.com/llvm/llvm-project/commit/39c4246e1e5bb76b1bca2e4b0d0ebc4005d75c32 DIFF: https://github.com/llvm/llvm-project/commit/39c4246e1e5bb76b1bca2e4b0d0ebc4005d75c32.diff LOG:

[PATCH] D75289: [clang-tidy] Added virtual isLanguageVersionSupported to ClangTidyCheck

This revision was automatically updated to reflect the committed changes. Closed by commit rG39c4246e1e5b: [clang-tidy] Added virtual isLanguageVersionSupported to ClangTidyCheck (authored by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D7

[PATCH] D75332: [clang-tidy] Add module for llvm-libc and restrict-system-libc-header-check.

Eugene.Zelenko added a comment. Please mention new module in docs/clang-tidy/index.rst and Release Notes (new modules section is above new checks one and please add subsubsection). Comment at: clang-tools-extra/clang-tidy/llvmlibc/LLVMLibcTidyModule.cpp:21 + void addCheckFact

[PATCH] D75331: [clangd] Get rid of lexer usage in locateMacroAt

hokein accepted this revision. hokein added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/SourceCode.h:285 }; /// Gets the macro at a specified \p Loc. It must be a spelling location and /// point to the beginning of ide

[PATCH] D75259: [clangd] Get rid of unnecssary source transformations in locateMacroAt

hokein accepted this revision. hokein added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/unittests/SourceCodeTests.cpp:440 +TEST(SourceCodeTests, WorksAtBeginOfFile) { + Annotations Code("^MACRO;"); + TestTU TU = TestTU:

[PATCH] D75292: [clangd] Remove the word 'toy' from the description of vscode-clangd

hokein added a comment. I think we can even delete this file, since this is boilerplate doc generated by the vscode extension generator. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75292/new/ https://reviews.llvm.org/D75292 __

[PATCH] D75252: [ARM,MVE] Add ACLE intrinsics for VQMOV[U]N family.

dmgreen accepted this revision. dmgreen added a comment. This revision is now accepted and ready to land. I had some code somewhere that was trying to produce VQMOVNbh from codegen, treating them as a saturating truncate. It would only work in certain situations thought, relying on demand bits t

[PATCH] D71775: [ThreadPool] On Windows, extend usage to all CPU sockets and all NUMA groups

mehdi_amini added inline comments. Comment at: llvm/lib/Support/Threading.cpp:94 + // uselessly induce more context-switching and cache eviction. + if (!ThreadsRequested || ThreadsRequested > (unsigned)MaxThreadCount) +return MaxThreadCount; aganea wrote: >

[clang-tools-extra] 365c99f - Skip TemplateSpecializedType in modernize-pass-by-value.

Author: Karasev Nikita Date: 2020-02-28T09:17:16-05:00 New Revision: 365c99fd7d5461be902a5cec54d773cb82b56101 URL: https://github.com/llvm/llvm-project/commit/365c99fd7d5461be902a5cec54d773cb82b56101 DIFF: https://github.com/llvm/llvm-project/commit/365c99fd7d5461be902a5cec54d773cb82b56101.diff

[PATCH] D71227: [cuda][hip] Fix function overload resolution in the global initiailizer.

hliao updated this revision to Diff 247248. hliao added a comment. Fix pre-merge checks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71227/new/ https://reviews.llvm.org/D71227 Files: clang/include/clang/Sema/Sema.h clang/lib/Parse/ParseDecl.

[PATCH] D75350: [OpenMP] Allow const parameters in declare simd linear clause

huntergr created this revision. huntergr added reviewers: ABataev, kkwli0. Herald added a subscriber: guansong. Herald added a reviewer: jdoerfert. Herald added a project: clang. Section 2.19.3 (List Item Privatization) of the OpenMP 5.0 standard does not apply to declarative directives, only to

[PATCH] D75159: [clang-tidy] Fix PR#37210 'Out-of-class template constructor only half-fixed with modernize-pass-by-value'

aaron.ballman closed this revision. aaron.ballman added a comment. In D75159#1897349 , @f00kat wrote: > Can you commit it please? Happy to do so, but you may want to consider getting git access yourself as you've authored quite a few patches. For more i

[PATCH] D75139: [hexagon] Pickup the default crt and libs when the musl target is selected

sidneym updated this revision to Diff 247251. sidneym added a comment. Move selection of the dynamic linker before user args are added. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75139/new/ https://reviews.llvm.org/D75139 Files: clang/lib/Dri

[PATCH] D75350: [OpenMP] Allow const parameters in declare simd linear clause

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75350/new/ https://reviews.llvm.org/D75350 ___

[PATCH] D75210: [Attr] Allow ParsedAttr to be constructor for any Attribute

aaron.ballman added a comment. I think this direction is reasonable to go with, but would prefer to land this with the code actually using this functionality (as there's not really a good way to test it, otherwise). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[PATCH] D75319: Remove unused parameter from CXXRecordDecl::forallBases [NFC]

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75319/new/ https://reviews.llvm.org/D75319 _

[PATCH] D75350: [OpenMP] Allow const parameters in declare simd linear clause

fpetrogalli added inline comments. Comment at: clang/test/OpenMP/declare_simd_codegen.cpp:118 +#pragma omp declare simd notinbranch linear(i) +double constlinear(const int i); + Shouldn't you check that the `_ZGV *` name is generated? Repository: rG LLVM Gith

Re: [clang] d930ed1 - Disallow use of __has_c_attribute in C++ mode.

On Thu, Feb 27, 2020 at 6:04 PM James Y Knight wrote: > > That all makes sense -- especially the bits about the dates needing to be > different. > > But, even with all that, I'm not sure why we shouldn't implement both > __has_cpp_attribute AND __has_c_attribute in C++ mode? > > The subset of C

[PATCH] D75350: [OpenMP] Allow const parameters in declare simd linear clause

huntergr added inline comments. Comment at: clang/test/OpenMP/declare_simd_codegen.cpp:118 +#pragma omp declare simd notinbranch linear(i) +double constlinear(const int i); + fpetrogalli wrote: > Shouldn't you check that the `_ZGV *` name is generated? Ok, and I

[PATCH] D75332: [clang-tidy] Add module for llvm-libc and restrict-system-libc-header-check.

abrachet added inline comments. Comment at: clang-tools-extra/clang-tidy/llvmlibc/RestrictSystemLibcHeadersCheck.cpp:40 +SrcMgr::CharacteristicKind FileType) { + if (SrcMgr::isSystem(FileType)) { +if (!SM.isInMainFile(HashLoc)) { Could you whitelist the

[PATCH] D61634: [clang/llvm] Allow efficient implementation of libc's memory functions in C/C++

tejohnson added a comment. The last patch from my side just went in (D74162 : [Inliner] Inlining should honor nobuiltin attributes). So I think this is now complete. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61

[PATCH] D75210: [Attr] Allow ParsedAttr to be constructor for any Attribute

jdoerfert added a comment. In D75210#1898012 , @aaron.ballman wrote: > I think this direction is reasonable to go with, but would prefer to land > this with the code actually using this functionality (as there's not really a > good way to test it, other

[PATCH] D73186: [AST] Add fixed-point multiplication constant evaluation.

rjmccall added a comment. Since we've settled on not considering that to be overflow, yeah, I think the patch is fine. Might be worth being explicit about that at the point you do the shift: that it's known that this discards precision that could leave the true mathematical value outside of th

[PATCH] D71199: [clang-tidy] New check cppcoreguidelines-prefer-member-initializer

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/PreferMemberInitializerCheck.cpp:25 + isa(S) || + isa(S) || + isa(S) || How about `throw` expressions? Comment at: clang-t

[PATCH] D75285: Mark restrict pointer or reference to const as invariant

rjmccall added a comment. In D75285#1897537 , @JonChesterfield wrote: > In D75285#1897247 , @yaxunl wrote: > > > If users derive a non-const pointer from the const pointer and modify it, > > doesn't that result in

Re: [clang] d930ed1 - Disallow use of __has_c_attribute in C++ mode.

On Fri, Feb 28, 2020 at 10:05 AM Aaron Ballman wrote: > On Thu, Feb 27, 2020 at 6:04 PM James Y Knight > wrote: > > > > That all makes sense -- especially the bits about the dates needing to > be different. > > > > But, even with all that, I'm not sure why we shouldn't implement both > __has_cpp

[PATCH] D75356: [Analyzer][StreamChecker] Introduction of stream error state handling.

balazske created this revision. Herald added subscribers: cfe-commits, martong, Charusso, gamesh411, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a reviewer: Szelethus. Herald added a project: clang. balazske added a parent revisio

[PATCH] D74918: Add method to TargetInfo to get CPU cache line size

__simt__ added a comment. In D74918#1897636 , @kristof.beyls wrote: > If these values are part of the C++ target platform ABI, it seems to me the > values for std::hardware_{constructive,destructive}_interference_size should > be set by whoever has the

[PATCH] D70172: [CUDA][HIP][OpenMP] Emit deferred diagnostics by a post-parsing AST travese

yaxunl updated this revision to Diff 247275. yaxunl added a comment. Do not traverse the whole CU. Record potentially emitted functions and variables in the normal parsing and traverse them instead. Also fixed bug 44948 and regression in check-mlir. CHANGES SINCE LAST ACTION https://reviews.

Re: [clang] d930ed1 - Disallow use of __has_c_attribute in C++ mode.

On Fri, Feb 28, 2020 at 11:23 AM James Y Knight via cfe-commits < cfe-commits@lists.llvm.org> wrote: > On Fri, Feb 28, 2020 at 10:05 AM Aaron Ballman > wrote: > >> On Thu, Feb 27, 2020 at 6:04 PM James Y Knight >> wrote: >> > >> > But, even with all that, I'm not sure why we shouldn't implement

[clang] a06402c - [F16C] Add strict-fp constrained tests

Author: Simon Pilgrim Date: 2020-02-28T16:55:00Z New Revision: a06402cc69c07bc18c729b23bedb53b929411f36 URL: https://github.com/llvm/llvm-project/commit/a06402cc69c07bc18c729b23bedb53b929411f36 DIFF: https://github.com/llvm/llvm-project/commit/a06402cc69c07bc18c729b23bedb53b929411f36.diff LOG:

[clang] bfa0aaf - [AVX512] Add strict-fp cvtph2ps constrained tests

Author: Simon Pilgrim Date: 2020-02-28T16:55:00Z New Revision: bfa0aaf37f8d68cb7fb63eff5c825724c3829d09 URL: https://github.com/llvm/llvm-project/commit/bfa0aaf37f8d68cb7fb63eff5c825724c3829d09 DIFF: https://github.com/llvm/llvm-project/commit/bfa0aaf37f8d68cb7fb63eff5c825724c3829d09.diff LOG:

[PATCH] D75360: [analyzer][NFC] Tie CheckerRegistry to CheckerManager, allow CheckerManager to be constructed for non-analysis purposes

Szelethus created this revision. Szelethus added reviewers: NoQ, xazax.hun, baloghadamsoftware, rnkovacs, balazske, martong, dcoughlin. Szelethus added a project: clang. Herald added subscribers: cfe-commits, steakhal, Charusso, gamesh411, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, szepet, w

[PATCH] D73967: Implement _ExtInt as an extended int type specifier.

aaron.ballman added inline comments. Comment at: clang/include/clang/AST/Type.h:6199-6200 + friend class ASTContext; + bool IsUnsigned; + unsigned NumBits; + Would it be a bad idea to use a bit-field here to smash these fields together? (I don't want to limit

[PATCH] D75271: [Analyzer][NFC] Add AnalyzerOptions parameter to shouldRegisterXXX() functions

Szelethus commandeered this revision. Szelethus edited reviewers, added: baloghadamsoftware; removed: Szelethus. Szelethus added a comment. Yoink. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75271/new/ https://reviews.llvm.org/D75271 _

[PATCH] D75162: [X86][F16C] Remove cvtph2ps intrinsics and use generic half2float conversion (PR37554)

RKSimon updated this revision to Diff 247288. RKSimon added a comment. Add strict fp codegen tests - this means the patch is now dependent on D75304 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75162/new/ https:/

[PATCH] D75360: [analyzer][NFC] Tie CheckerRegistry to CheckerManager, allow CheckerManager to be constructed for non-analysis purposes

Szelethus updated this revision to Diff 247291. Szelethus added a comment. Unforget git add. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75360/new/ https://reviews.llvm.org/D75360 Files: clang/include/clang/StaticAnalyzer/Core/CheckerManager.h clang/include/clang/StaticAnalyzer/F

[PATCH] D75077: [OpenMP5.0] Allow pointer arithmetic in motion/map clause

ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:15499-15501 RelevantExpr = DRE; // Record the component. Components.emplace_back(DRE, DRE->getDecl()); Shall we do this only if `RelevantExpr` is nullptr? C

[PATCH] D75364: [clang-format] Handle macros in function params and return value

tamas.petz created this revision. tamas.petz added reviewers: chandlerc, djasper. tamas.petz added a project: clang-format. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch adds support to handle macros in function parameter list and function return type. Consider

[PATCH] D75360: [analyzer][NFC] Tie CheckerRegistry to CheckerManager, allow CheckerManager to be constructed for non-analysis purposes

Szelethus added a comment. Phabricator didn't pick up on it (because I accidentally used `mv` instead of `git mv`), but `CheckerRegistration.h` was moved to `AnalyzerHelpFlags.h`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75360/new/ https://reviews.llvm.org/D75360 __

[PATCH] D75271: [analyzer][NFC] Change LangOptions to CheckerManager in the shouldRegister* functions.

Szelethus updated this revision to Diff 247292. Szelethus retitled this revision from "[Analyzer][NFC] Add AnalyzerOptions parameter to shouldRegisterXXX() functions" to "[analyzer][NFC] Change LangOptions to CheckerManager in the shouldRegister* functions.". Szelethus edited the summary of this

[PATCH] D75077: [OpenMP5.0] Allow pointer arithmetic in motion/map clause

cchen marked an inline comment as done. cchen added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:15499-15501 RelevantExpr = DRE; // Record the component. Components.emplace_back(DRE, DRE->getDecl()); ABataev wrote: > Shall we do this

[PATCH] D75350: [OpenMP] Allow const parameters in declare simd linear clause

huntergr updated this revision to Diff 247294. huntergr added a comment. - Added a function body to the test so that it would generate symbols - Added check lines to ensure the mangled name is present - Reformatted the params of Sema::CheckOpenMPLinearDecl to comply with coding style. Repositor

[PATCH] D75077: [OpenMP5.0] Allow pointer arithmetic in motion/map clause

ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:15499-15501 RelevantExpr = DRE; // Record the component. Components.emplace_back(DRE, DRE->getDecl()); cchen wrote: > ABataev wrote: > > Shall we do this only if `RelevantExpr

[PATCH] D75077: [OpenMP5.0] Allow pointer arithmetic in motion/map clause

ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:15499-15501 RelevantExpr = DRE; // Record the component. Components.emplace_back(DRE, DRE->getDecl()); ABataev wrote: > cchen wrote: > > ABataev wrote: > > > Shall we do this

[PATCH] D75350: [OpenMP] Allow const parameters in declare simd linear clause

fpetrogalli added inline comments. Comment at: clang/test/OpenMP/declare_simd_codegen.cpp:327 +// CHECK-DAG: "_ZGVbN2l__Z11constlineari" +// CHECK-DAG: "_ZGVcN4l__Z11constlineari" I think we should add the same checks in the AArch64 test: `OpenMP/declare_simd_

[clang] f16d2be - Devirtualize a call on alloca without waiting for post inline cleanup and next DevirtSCCRepeatedPass iteration.

Author: Hiroshi Yamauchi Date: 2020-02-28T09:43:32-08:00 New Revision: f16d2bec40691f4050174c99600847d024486bc5 URL: https://github.com/llvm/llvm-project/commit/f16d2bec40691f4050174c99600847d024486bc5 DIFF: https://github.com/llvm/llvm-project/commit/f16d2bec40691f4050174c99600847d024486bc5.di

[PATCH] D75271: [analyzer][NFC] Change LangOptions to CheckerManager in the shouldRegister* functions.

Szelethus added a comment. Mind that `AnalysisManager`, similarly to `CheckerManager` before D75360 , must be constructed with an `ASTContext` which is not available at the moment when the `shouldRegister*` functions run, and they must run no later than when the

[PATCH] D75365: [AST Matchers] Fix bug in 'optionally' matcher wherein all previous bindings are cleared when all inner matchers fail.

ymandel updated this revision to Diff 247299. ymandel added a comment. removed change to unrelated file. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75365/new/ https://reviews.llvm.org/D75365 Files: clang/lib/ASTMatchers/ASTMatchersInternal.cp

[PATCH] D75077: [OpenMP5.0] Allow pointer arithmetic in motion/map clause

cchen updated this revision to Diff 247298. cchen added a comment. Add assert to make sure that we never overwrite RelevantExpr Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75077/new/ https://reviews.llvm.org/D75077 Files: clang/include/clang/B

[PATCH] D75365: [AST Matchers] Fix bug in 'optionally' matcher wherein all previous bindings are cleared when all inner matchers fail.

ymandel created this revision. ymandel added reviewers: aaron.ballman, sbenza. Herald added a project: clang. ymandel updated this revision to Diff 247299. ymandel added a comment. removed change to unrelated file. The implementation of 'optionally' doesn't preserve bindings when none of the su

[PATCH] D75365: [AST Matchers] Fix bug in 'optionally' matcher wherein all previous bindings are cleared when all inner matchers fail.

ymandel added a comment. Aaron -- when fixing this bug, I had some other questions about the behavior of this matcher. Specifically, instead of adding bindings to the existing map, it creates a new match result for each matching node (with addMatch). But, I'm struggling to see how it makes sen

[PATCH] D75368: [clang-format] Handle ?. ?? and ?[ as C# tokens

jbcoe created this revision. jbcoe added a reviewer: krasimir. jbcoe added a project: clang-format. Herald added a project: clang. Herald added a subscriber: cfe-commits. jbcoe planned changes to this revision. jbcoe added a comment. There's a weird test failure I'm unable to reproduce outside of

[PATCH] D75077: [OpenMP5.0] Allow pointer arithmetic in motion/map clause

cchen updated this revision to Diff 247303. cchen added a comment. return RelevantExpr || Visit(LE); Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75077/new/ https://reviews.llvm.org/D75077 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td

[PATCH] D75368: [clang-format] Handle ?. ?? and ?[ as C# tokens

jbcoe planned changes to this revision. jbcoe added a comment. There's a weird test failure I'm unable to reproduce outside of the tests with real source code where public static void Main(string[] args) { string dirPath = args?[0]; } is (mis)-formatted as public static void Main(

[PATCH] D75370: [test] Fix flang test failures due to not handling .exe

ctetreau created this revision. Herald added subscribers: cfe-commits, DavidTruby. Herald added a project: clang. ctetreau added reviewers: efriedma, rsmith, peterwaller-arm. - Update flang tests to account for the fact that the binary is called flang.exe on windows Repository: rG LLVM Github

  1   2   >