ABataev added inline comments.
================
Comment at: clang/lib/Sema/SemaOpenMP.cpp:15499-15501
RelevantExpr = DRE;
// Record the component.
Components.emplace_back(DRE, DRE->getDecl());
----------------
ABataev wrote:
> cchen wrote:
> > ABataev wrote:
> > > Shall we do this only if `RelevantExpr` is nullptr?
> > Yes, I'm assuming that `RelevantExpr` is nullptr before those assignments,
> > so maybe adding `assert` is sufficient?
> I think assert will crash for something like `x?y:z`.
Though, currently, we just return `false` in this case. Yes, `assert` should be
enough currently probably.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75077/new/
https://reviews.llvm.org/D75077
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
