hokein accepted this revision.
hokein added inline comments.
This revision is now accepted and ready to land.
================
Comment at: clang-tools-extra/clangd/SourceCode.h:285
};
/// Gets the macro at a specified \p Loc. It must be a spelling location and
/// point to the beginning of identifier.
----------------
nit: update the comment.
================
Comment at: clang-tools-extra/clangd/SourceCode.h:287
/// point to the beginning of identifier.
-llvm::Optional<DefinedMacro> locateMacroAt(SourceLocation Loc,
+llvm::Optional<DefinedMacro> locateMacroAt(const syntax::Token &Tok,
Preprocessor &PP);
----------------
nit: would be clearer to name it `SpelledTok`.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75331/new/
https://reviews.llvm.org/D75331
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
