[PATCH] D75022: clang-format: Extend AllowShortLoopsOnASingleLine to do ... while loops.

MyDeveloperDay added a comment. I think its look good, please add the extra tests, then lets give people a couple of days Comment at: unittests/Format/FormatTest.cpp:570 + AllowsMergedLoops); } horrible code though they are, could you add a te

[PATCH] D75034: [clang-format] use spaces for alignment with UT_ForContinuationAndIndentation

MyDeveloperDay added a comment. I tend to agree with your assessment, I think its worth waiting for some others to comment. Comment at: clang/unittests/Format/FormatTest.cpp:10293 Tab)); - EXPECT_EQ("/*\n" -"\t a\t\tcomment\n"

[PATCH] D69560: [clang-tidy] Add 'cppcoreguidelines-avoid-adjacent-arguments-of-same-type' check

whisperity added a comment. In D69560#1890026 , @aaron.ballman wrote: > In D69560#1889925 , @vingeldal wrote: > > > Doesn't clang-tidy exclude warnings from system headers by default though? > > > Third-party SDKs

[PATCH] D75106: [clangd] Fix early selection for non-vardecl declarators

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Selection tree was performing an early claim only for VarDecls, but there are other cases where we can

[PATCH] D69560: [clang-tidy] Add 'cppcoreguidelines-avoid-adjacent-arguments-of-same-type' check

whisperity added a comment. In D69560#1889925 , @vingeldal wrote: > I think this value very well may strike a good balance in that compromise but > I still think it is a clear deviation from the guideline as specified. > IMO all deviations from the guide

[PATCH] D75107: [clang-tidy] hicpp-signed-bitwise IgnorePositiveIntegerLiterals now partially recursive

njames93 created this revision. njames93 added reviewers: aaron.ballman, gribozavr2, alexfh, hokein, JonasToth. Herald added subscribers: cfe-commits, xazax.hun. Herald added a project: clang. Addresses hicpp-signed-bitwise.IgnorePositiveIntegerLiterals should be recursive.

Re: [PATCH] D69876: Support output constraints on "asm goto"

Hi Bill, This commit broke AArch64 bots, logs are available here: http://lab.llvm.org:8011/builders/clang-cmake-aarch64-quick/builds/22291/steps/ninja%20check%201/logs/FAIL%3A%20Clang%3A%3Auninit-asm-goto.cpp Thanks Yvan On Tue, 25 Feb 2020 at 04:01, Bill Wendling via Phabricator via llvm-commit

[PATCH] D75106: [clangd] Fix early selection for non-vardecl declarators

sammccall added inline comments. Comment at: clang-tools-extra/clangd/Selection.cpp:613 // int (*[[s]])(); - else if (auto *VD = llvm::dyn_cast(D)) -return VD->getLocation(); + if (auto *DD = llvm::dyn_cast(D)) +return DD->getLocation(); -

[libclc] 814fb65 - libclc: cmake configure should depend on file list

Author: Jan Vesely Date: 2020-02-25T04:43:14-05:00 New Revision: 814fb658ca262f5c2df47f11d47f91fac188e0d6 URL: https://github.com/llvm/llvm-project/commit/814fb658ca262f5c2df47f11d47f91fac188e0d6 DIFF: https://github.com/llvm/llvm-project/commit/814fb658ca262f5c2df47f11d47f91fac188e0d6.diff LO

[PATCH] D75053: [clangd] Disable ExtractVariable for C

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/refactor/tweaks/ExtractVariable.cpp:453 const ASTContext &Ctx = Inputs.AST->getASTContext(); + // FIXME: Enable C (and mayb

[PATCH] D71018: [ASTImporter] Improved import of TypeSourceInfo (TypeLoc)

teemperor added a comment. My only problem is the reimplementation of the default visit methods with (from what I can tell) the same behavior as the default. If you delete all of these then that would also fix Shafik's point that all the custom dispatch code is technically untested in the unit

[clang] 9fd7ce7 - [analyzer][MallocChecker][NFC] Communicate the allocation family to auxiliary functions with parameters

Author: Kristóf Umann Date: 2020-02-25T11:17:32+01:00 New Revision: 9fd7ce7f4449619bc85ab4d2643e656836a2d5e2 URL: https://github.com/llvm/llvm-project/commit/9fd7ce7f4449619bc85ab4d2643e656836a2d5e2 DIFF: https://github.com/llvm/llvm-project/commit/9fd7ce7f4449619bc85ab4d2643e656836a2d5e2.diff

[PATCH] D71018: [ASTImporter] Improved import of TypeSourceInfo (TypeLoc)

balazske added inline comments. Comment at: clang/lib/AST/ASTImporter.cpp:3281 + // Import the function parameters. + SmallVector Parameters; shafik wrote: > I am curious, why move this chunk of code up? See comments at line 8238? Comment a

[PATCH] D68162: [analyzer][MallocChecker][NFC] Communicate the allocation family to auxiliary functions with parameters

This revision was automatically updated to reflect the committed changes. Closed by commit rG9fd7ce7f4449: [analyzer][MallocChecker][NFC] Communicate the allocation family to auxiliary… (authored by Szelethus). Herald added subscribers: martong, steakhal. Changed prior to commit: https://review

[PATCH] D75048: [ASTImporter] Improved import of AlignedAttr.

balazske updated this revision to Diff 246392. balazske added a comment. - Do not call AlignedAttr::Create with same parameters at 2 places. I think the code duplication was near to each other and only 2 instances that is not a big problem, anyway now it is a bit better. - Improved the comment i

[PATCH] D75047: Add Control Flow Guard in Clang release notes.

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. Excellent. Thanks! Do you have commits access, or would you like me to commit for you? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75047/new/ htt

[PATCH] D75047: Add Control Flow Guard in Clang release notes.

ajpaverd added a comment. In D75047#1890976 , @hans wrote: > Do you have commits access, or would you like me to commit for you? I don't yet have commit access. Please could you commit this for me. Thanks! Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D69746: [analyzer] FixItHint: Apply and test hints with the Clang-Tidy's script

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Frontend/AnalysisConsumer.cpp:92 + + bool IncludePath = false, ShouldEmitAsError = false, FixitsAsRemarks = false, + ApplyFixIts = false; Charusso wrote: > NoQ wrote: > > I'll be perfectly hap

[PATCH] D75093: clang-cl: Add a `/showIncludes:user` flag.

hans added a comment. Instead of replacing the old cc1 "--show-includes" with "--show-includes -sys-header-deps" -- which looks a little ugly maybe -- would it be simpler to just introduce a new cc1 flag instead, e.g. "--show-user-includes", and just expand /showIncludes:user to that? CHANGES

[PATCH] D74878: [remark][diagnostics] [codegen] Fix PR44896

jeroen.dobbelaere accepted this revision. jeroen.dobbelaere added a comment. This revision is now accepted and ready to land. Looks good to me. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74878/new/ https://reviews.llvm.org/D74878 ___ cfe

[PATCH] D75053: [clangd] Disable ExtractVariable for C

kadircet updated this revision to Diff 246406. kadircet marked an inline comment as done. kadircet added a comment. - Update comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75053/new/ https://reviews.llvm.org/D75053 Files: clang-tools-extr

[PATCH] D69746: [analyzer] FixItHint: Apply and test hints with the Clang-Tidy's script

Charusso marked 2 inline comments as done. Charusso added inline comments. Comment at: clang/lib/StaticAnalyzer/Frontend/AnalysisConsumer.cpp:92 + + bool IncludePath = false, ShouldEmitAsError = false, FixitsAsRemarks = false, + ApplyFixIts = false; NoQ wr

[PATCH] D75106: [clangd] Fix early selection for non-vardecl declarators

kadircet updated this revision to Diff 246405. kadircet marked 2 inline comments as done. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75106/new/ https://reviews.llvm.org/D75106 Files: clang-tools-ex

[PATCH] D75047: Add Control Flow Guard in Clang release notes.

hans added a comment. Pushed to 10.x as 3a11c86849c27e1e21d5e8cdf55cfa724164db57 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75047/new/ https://reviews.llvm.org/D75047

[clang-tools-extra] 555d5ad - [clangd] Disable ExtractVariable for C

Author: Kadir Cetinkaya Date: 2020-02-25T12:15:15+01:00 New Revision: 555d5ad85a4986d003040eb94109c72579021423 URL: https://github.com/llvm/llvm-project/commit/555d5ad85a4986d003040eb94109c72579021423 DIFF: https://github.com/llvm/llvm-project/commit/555d5ad85a4986d003040eb94109c72579021423.dif

[PATCH] D73729: [analyzer] AnalyzerOptions: Remove 'fixits-as-remarks'

xazax.hun added a reviewer: Szelethus. xazax.hun added a comment. Herald added subscribers: martong, steakhal. Maybe Kristof has some opinion whether we still need this :) He might be up to date whether CodeChecker is using this feature. Repository: rC Clang CHANGES SINCE LAST ACTION https

[PATCH] D73729: [analyzer] AnalyzerOptions: Remove 'fixits-as-remarks'

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Great, thanks!! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73729/new/ https://reviews.llvm.org/D73729 ___ cfe-commi

[PATCH] D69746: [analyzer] FixItHint: Apply and test hints with the Clang-Tidy's script

NoQ accepted this revision. NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Frontend/AnalysisConsumer.cpp:92 + + bool IncludePath = false, ShouldEmitAsError = false, FixitsAsRemarks = false, + ApplyFixIts = false; Charusso wrote: > NoQ wrot

[PATCH] D75053: [clangd] Disable ExtractVariable for C

This revision was automatically updated to reflect the committed changes. Closed by commit rG555d5ad85a49: [clangd] Disable ExtractVariable for C (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75053/new/ https://reviews.llvm.o

[PATCH] D75045: [analyzer] Improved check of `fgetc` in StreamChecker.

balazske marked 4 inline comments as done. balazske added a comment. An improvement can be made if the check runs only when size of `char` and `int` are equal. And it is possible to avoid the warning if `fgetc` is called after `fgetc` (with no functions in between). (More complicated thing is to

[PATCH] D75061: [RISCV] Fix sysroot tests without GCC on RISC-V hosts with GCC

edward-jones accepted this revision. edward-jones added a comment. This revision is now accepted and ready to land. Looks good to me. Clang tests all pass on my local build. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75061/new/ https://reviews.l

[PATCH] D73729: [analyzer] AnalyzerOptions: Remove 'fixits-as-remarks'

NoQ added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/AnalyzerOptions.def:310 -ANALYZER_OPTION(bool, ShouldEmitFixItHintsAsRemarks, "fixits-as-remarks", -"Emit fix-it hints as remarks for testing purposes", -false)

[PATCH] D73729: [analyzer] AnalyzerOptions: Remove 'fixits-as-remarks'

xazax.hun added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/AnalyzerOptions.def:310 -ANALYZER_OPTION(bool, ShouldEmitFixItHintsAsRemarks, "fixits-as-remarks", -"Emit fix-it hints as remarks for testing purposes", -false) --

[PATCH] D75045: [analyzer] Improved check of `fgetc` in StreamChecker.

NoQ added a comment. In D75045#1891055 , @NoQ wrote: > How many such platforms can you name? I mean, does Clang even support such targets? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75045/new/ https://

[PATCH] D75045: [analyzer] Improved check of `fgetc` in StreamChecker.

NoQ added a comment. In D75045#1891032 , @balazske wrote: > An improvement can be made if the check runs only when size of `char` and > `int` are equal. How many such platforms can you name? Please correct me if i'm wrong but it sounds like we're addin

[PATCH] D75106: [clangd] Fix early selection for non-vardecl declarators

sammccall added inline comments. Comment at: clang-tools-extra/clangd/Selection.cpp:615 + if (isa(D)) +return SourceRange(); + // This will capture Field, Function, MSProperty, NonTypeTemplateParm and we may have to blacklist deduction guides to

[PATCH] D74878: [remark][diagnostics] [codegen] Fix PR44896

lebedev.ri added a comment. SGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74878/new/ https://reviews.llvm.org/D74878 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D75045: [analyzer] Improved check of `fgetc` in StreamChecker.

balazske added a comment. In D75045#1891056 , @NoQ wrote: > In D75045#1891055 , @NoQ wrote: > > > How many such platforms can you name? > > > I mean, does Clang even support such targets? The problem can occur wit

[PATCH] D75093: clang-cl: Add a `/showIncludes:user` flag.

thakis added a comment. This is what -MD passes (which is why the -sys flag already exists), and more orthogonal flags instead of fewer, tangled ones is what we usually go for at the cc1 layer. So I like it more as is. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75093/new/ https://r

[PATCH] D75012: [ReleaseNotes] Mention -fmacro-prefix-map and -ffile-prefix-map.

hans added a comment. > Should such change be committed directly to the release/10.x branch by @hans ? Peter can commit to release/10.x himself, or let me know if he prefers me to do it. Thanks for writing release notes! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[PATCH] D75012: [ReleaseNotes] Mention -fmacro-prefix-map and -ffile-prefix-map.

Lekensteyn updated this revision to Diff 246413. Lekensteyn marked 2 inline comments as done. Lekensteyn added a comment. Updated the comment based on @MaskRay's feedback, thanks! This (and the previous) patch were based on release/10.x, I plan to commit it later today since the final tag is tomo

[PATCH] D75045: [analyzer] Improved check of `fgetc` in StreamChecker.

Szelethus added a comment. In D75045#1891064 , @balazske wrote: > In D75045#1891056 , @NoQ wrote: > > > In D75045#1891055 , @NoQ wrote: > > > > > How many such platforms can

[PATCH] D73729: [analyzer] AnalyzerOptions: Remove 'fixits-as-remarks'

Szelethus accepted this revision. Szelethus added a comment. Looks great! Thanks! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73729/new/ https://reviews.llvm.org/D73729 ___ cfe-commits mailing list cfe-commits@list

[PATCH] D69662: [Checkers] Avoid using evalCall in StreamChecker.

Szelethus added a comment. In D69662#1890007 , @NoQ wrote: > In D69662#1889545 , @Szelethus wrote: > > > Sorry for the slack :) > > > > One should never count on the invocation order of callback funcions in > > bet

[PATCH] D75093: clang-cl: Add a `/showIncludes:user` flag.

thakis updated this revision to Diff 246417. thakis added a comment. add one more test CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75093/new/ https://reviews.llvm.org/D75093 Files: clang/include/clang/Driver/CLCompatOptions.td clang/lib/Driver/ToolChains/Clang.cpp clang/lib/Fro

[PATCH] D75044: [AArch64] __builtin_extract_return_addr for PAuth.

danielkiss marked 2 inline comments as done. danielkiss added inline comments. Comment at: clang/test/CodeGen/arm64-extractreturnaddress.c:15 +// CHECK: define dso_local i8* @bar() #0 { +// CHECK-NEXT:ret i8* inttoptr (i64 42 to i8*) +// CHECK-PAC: %1 = call i8* @llv

[PATCH] D75006: [clang-format] Wrap lines for C# property accessors

krasimir accepted this revision. krasimir added a comment. This is pretty cool! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75006/new/ https://reviews.llvm.org/D75006 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.l

[PATCH] D74131: [analyzer][taint] Add isTainted debug expression inspection check

steakhal updated this revision to Diff 246420. steakhal added a comment. Declaring the purpose of this checker: > [...] > This would help to reduce the *noise* that the `TaintTest` debug checker > would > introduce and let you focus on the `expected-warning`s that you really care > about

[PATCH] D74131: [analyzer][taint] Add isTainted debug expression inspection check

steakhal marked 2 inline comments as done. steakhal added a comment. Marking comments done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74131/new/ https://reviews.llvm.org/D74131 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[PATCH] D69560: [clang-tidy] Add 'cppcoreguidelines-avoid-adjacent-arguments-of-same-type' check

aaron.ballman added a comment. In D69560#1890767 , @vingeldal wrote: > In D69560#1890026 , @aaron.ballman > wrote: > > > That is an option, but it would be better for the check to be usable > > without requiring a

[PATCH] D75006: [clang-format] Wrap lines for C# property accessors

jbcoe marked an inline comment as done. jbcoe added inline comments. Comment at: clang/unittests/Format/FormatTestCSharp.cpp:246 - "get;\n" - "}"); MyDeveloperDay wrote: > Nit: I feel like this layout should really be an option,

[PATCH] D75006: [clang-format] Wrap lines for C# property accessors

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. LGTM Comment at: clang/unittests/Format/FormatTestCSharp.cpp:246 - "get;\n" - "}"); Nit: I feel like this layout should really be an option, (maybe for the

[PATCH] D71199: [clang-tidy] New check cppcoreguidelines-prefer-member-initializer

baloghadamsoftware updated this revision to Diff 246425. baloghadamsoftware added a comment. Herald added subscribers: martong, steakhal. Minor update. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71199/new/ https://reviews.llvm.org/D71199 Files: clang-tools-extra/clang-tidy/cppcore

[PATCH] D69560: [clang-tidy] Add 'cppcoreguidelines-avoid-adjacent-arguments-of-same-type' check

whisperity added a comment. @aaron.ballman @vingeldal I'll go over the findings (as I've run this on LLVM and various other projects, a few examples are uploaded in my first comment as HTML renders of the bug report!) soon, but I want to wait until a research paper I have based on this topic ge

[PATCH] D71199: [clang-tidy] New check cppcoreguidelines-prefer-member-initializer

baloghadamsoftware marked 2 inline comments as done. baloghadamsoftware added inline comments. Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/PreferMemberInitializerCheck.cpp:43 +static bool isLiteral(const Expr *E) { + return isa(E) || + isa(E) || -

[clang] 7b6168e - [ASTImporter] Improved variable template redecl chain handling.

Author: Balázs Kéri Date: 2020-02-25T14:48:37+01:00 New Revision: 7b6168e7bef1cdc355fd28572bd69ea4057c57f8 URL: https://github.com/llvm/llvm-project/commit/7b6168e7bef1cdc355fd28572bd69ea4057c57f8 DIFF: https://github.com/llvm/llvm-project/commit/7b6168e7bef1cdc355fd28572bd69ea4057c57f8.diff L

[PATCH] D74720: [ASTImporter] Improved variable template redecl chain handling.

This revision was automatically updated to reflect the committed changes. Closed by commit rG7b6168e7bef1: [ASTImporter] Improved variable template redecl chain handling. (authored by balazske). Changed prior to commit: https://reviews.llvm.org/D74720?vs=244980&id=246428#toc Repository: rG L

[PATCH] D74966: [PATCH] [ARM] Add Cortex-M55 Support for clang and llvm

LukeGeeson updated this revision to Diff 246427. LukeGeeson marked an inline comment as done. LukeGeeson added a comment. - Addressed dmgreen's comments (removed whitespace, added m55 test) - Added CPU Part number to Host.cpp CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74966/new/ http

[clang] 770ad9f - [Analyzer] Fix for iterator modeling and checkers: handle negative numbers correctly

Author: Adam Balogh Date: 2020-02-25T14:57:34+01:00 New Revision: 770ad9f55e660e0ec89f61d5579dfafad17ab5f5 URL: https://github.com/llvm/llvm-project/commit/770ad9f55e660e0ec89f61d5579dfafad17ab5f5 DIFF: https://github.com/llvm/llvm-project/commit/770ad9f55e660e0ec89f61d5579dfafad17ab5f5.diff L

[PATCH] D72035: [analyzer][NFC] Use CallEvent checker callback in GenericTaintChecker

steakhal marked 5 inline comments as done. steakhal added a comment. In D72035#1889320 , @Szelethus wrote: > Wow. Its a joy to see you do C++. LGTM. Are you planning to introduce > `CallDescriptionMap` at one point? :) Yes, definitely. ==

[PATCH] D69560: [clang-tidy] Add 'cppcoreguidelines-avoid-adjacent-arguments-of-same-type' check

aaron.ballman added a comment. In D69560#1891185 , @whisperity wrote: > @aaron.ballman @vingeldal I'll go over the findings (as I've run this on LLVM > and various other projects, a few examples are uploaded in my first comment > as HTML renders of the b

[PATCH] D74878: [remark][diagnostics] [codegen] Fix PR44896

serge-sans-paille added a comment. Nice work, LGTM too. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74878/new/ https://reviews.llvm.org/D74878 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/

[PATCH] D74760: [Analyzer] Fix for iterator modeling and checkers: handle negative numbers correctly

This revision was automatically updated to reflect the committed changes. Closed by commit rG770ad9f55e66: [Analyzer] Fix for iterator modeling and checkers: handle negative numbers… (authored by baloghadamsoftware). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[PATCH] D69560: [clang-tidy] Add 'cppcoreguidelines-avoid-adjacent-arguments-of-same-type' check

whisperity added a comment. In D69560#1891167 , @aaron.ballman wrote: > Btw, we should update the terminology in the patch to use `parameter` instead > of `argument` (parameters are what the function declares, arguments are what > are passed in at the c

[PATCH] D75041: [WIP][clang-tidy] Approximate implicit conversion issues for the 'cppcoreguidelines-avoid-adjacent-arguments-of-same-type' check

whisperity added a reviewer: aaron.ballman. whisperity added subscribers: vingeldal, zporky. whisperity added a comment. **WIP** because there's a lot of debug stuff that should be cleared out from here. This is a crude patch. It works fancy, but the code is crude. Repository: rG LLVM Github

[PATCH] D74846: fix -fcodegen-modules code when used with PCH (PR44953)

aganea added a comment. @llunak Do you have time to address this patch this week? If not, I can finish it and land it. Please let me know. We'd like to see it merged into 10.0. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74846/new/ https://reviews.llvm.org/D74

[PATCH] D71524: [analyzer] Support tainted objects in GenericTaintChecker

balazske added inline comments. Comment at: clang/test/Analysis/taint-generic.cpp:189 + istream& getline(istream& is, string& str); +} + These `std` declarations are at a better place in `system-header-simulator-cxx.h` or a similar file. CHANGES SINCE LAST AC

[clang] 83f4372 - [CodeGen] fix clang test that runs the optimizer pipeline; NFC

Author: Sanjay Patel Date: 2020-02-25T09:13:49-05:00 New Revision: 83f4372f3a708ceaa800feff8b1bd92ae2c3be5f URL: https://github.com/llvm/llvm-project/commit/83f4372f3a708ceaa800feff8b1bd92ae2c3be5f DIFF: https://github.com/llvm/llvm-project/commit/83f4372f3a708ceaa800feff8b1bd92ae2c3be5f.diff

[clang] 91f7f0d - [RISCV] Fix sysroot tests without GCC on RISC-V hosts with GCC

Author: Luís Marques Date: 2020-02-25T14:17:45Z New Revision: 91f7f0d8e3ef2b6be07bc9621de075ff11c730c9 URL: https://github.com/llvm/llvm-project/commit/91f7f0d8e3ef2b6be07bc9621de075ff11c730c9 DIFF: https://github.com/llvm/llvm-project/commit/91f7f0d8e3ef2b6be07bc9621de075ff11c730c9.diff LOG:

[PATCH] D75113: [docs] dump-ast-matchers removes const from Matcher args and handles template functions slightly better

njames93 created this revision. njames93 added reviewers: aaron.ballman, gribozavr2, joerg. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D75113 Files: clang/docs/LibASTMatchersReference.html clang/docs/t

[PATCH] D69560: [clang-tidy] Add 'cppcoreguidelines-avoid-adjacent-arguments-of-same-type' check

zporky added a comment. Agree that we could make an attempt to detect "related" parameters. A possible heuristic to detect "related arguments" would be to look for interactions between these arguments, e.g. check whether we use them in specific operations, e.g. // tipical for related iterators

[PATCH] D75061: [RISCV] Fix sysroot tests without GCC on RISC-V hosts with GCC

This revision was automatically updated to reflect the committed changes. Closed by commit rG91f7f0d8e3ef: [RISCV] Fix sysroot tests without GCC on RISC-V hosts with GCC (authored by luismarques). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75061/n

[clang] 2bd6974 - [clang-format] Wrap lines for C# property accessors

Author: Jonathan Coe Date: 2020-02-25T14:23:47Z New Revision: 2bd6974aaa664f01e8822514295425fee380b131 URL: https://github.com/llvm/llvm-project/commit/2bd6974aaa664f01e8822514295425fee380b131 DIFF: https://github.com/llvm/llvm-project/commit/2bd6974aaa664f01e8822514295425fee380b131.diff LOG:

[PATCH] D75006: [clang-format] Wrap lines for C# property accessors

This revision was automatically updated to reflect the committed changes. Closed by commit rG2bd6974aaa66: [clang-format] Wrap lines for C# property accessors (authored by Jonathan Coe ). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D68163: [analyzer][MallocChecker][NFC] Change the use of IdentifierInfo* to CallDescription

Szelethus marked 5 inline comments as done. Szelethus added inline comments. Herald added subscribers: martong, steakhal. Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/CallEvent.h:259 /// calls. bool isCalled(const CallDescription &CD) const;

[PATCH] D75001: [OpenMP][cmake] ignore warning on unknown CUDA version

This revision was automatically updated to reflect the committed changes. Closed by commit rGe16e267bb6ee: [OpenMP][cmake] ignore warning on unknown CUDA version (authored by kkwli0). Herald added a project: OpenMP. Herald added a subscriber: openmp-commits. Repository: rG LLVM Github Monorepo

[clang-tools-extra] e09754c - [clangd] Migrate Lexer usages in TypeHierarchy to TokenBuffers

Author: Kadir Cetinkaya Date: 2020-02-25T15:36:45+01:00 New Revision: e09754ccefc8cff7ae5fa18ce73db76339b559f5 URL: https://github.com/llvm/llvm-project/commit/e09754ccefc8cff7ae5fa18ce73db76339b559f5 DIFF: https://github.com/llvm/llvm-project/commit/e09754ccefc8cff7ae5fa18ce73db76339b559f5.dif

[PATCH] D75093: clang-cl: Add a `/showIncludes:user` flag.

hans added a comment. In D75093#1891067 , @thakis wrote: > This is what -MD passes (which is why the -sys flag already exists), and more > orthogonal flags instead of fewer, tangled ones is what we usually go for at > the cc1 layer. So I like it more as

[PATCH] D74850: [clangd] Migrate Lexer usages in TypeHierarchy to TokenBuffers

This revision was automatically updated to reflect the committed changes. Closed by commit rGe09754ccefc8: [clangd] Migrate Lexer usages in TypeHierarchy to TokenBuffers (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74850/new/

[PATCH] D74850: [clangd] Migrate Lexer usages in TypeHierarchy to TokenBuffers

kadircet updated this revision to Diff 246439. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74850/new/ https://reviews.llvm.org/D74850 Files: clang-tools-extra/clangd/XRefs.cpp clang-tools-extra/cl

[clang] e551333 - [analyzer][MallocChecker][NFC] Change the use of IdentifierInfo* to CallDescription

Author: Kristóf Umann Date: 2020-02-25T15:43:33+01:00 New Revision: e5513336aee4a9b10cb98f234145aeb4763fdd69 URL: https://github.com/llvm/llvm-project/commit/e5513336aee4a9b10cb98f234145aeb4763fdd69 DIFF: https://github.com/llvm/llvm-project/commit/e5513336aee4a9b10cb98f234145aeb4763fdd69.diff

[clang] bcda126 - clang-cl: Add a `/showIncludes:user` flag.

Author: Nico Weber Date: 2020-02-25T09:43:52-05:00 New Revision: bcda1269c4c4d5d19d2be425c0a52d19fe09f146 URL: https://github.com/llvm/llvm-project/commit/bcda1269c4c4d5d19d2be425c0a52d19fe09f146 DIFF: https://github.com/llvm/llvm-project/commit/bcda1269c4c4d5d19d2be425c0a52d19fe09f146.diff LO

[PATCH] D68163: [analyzer][MallocChecker][NFC] Change the use of IdentifierInfo* to CallDescription

This revision was automatically updated to reflect the committed changes. Closed by commit rGe5513336aee4: [analyzer][MallocChecker][NFC] Change the use of IdentifierInfo* to… (authored by Szelethus). Changed prior to commit: https://reviews.llvm.org/D68163?vs=222791&id=246441#toc Repository:

[PATCH] D75093: clang-cl: Add a `/showIncludes:user` flag.

This revision was automatically updated to reflect the committed changes. Closed by commit rGbcda1269c4c4: clang-cl: Add a `/showIncludes:user` flag. (authored by thakis). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D7

[PATCH] D75068: libclang: Add static build support for Windows

cristian.adam added a comment. I've tested this patch with: -D LIBCLANG_BUILD_STATIC=OFF -D LLVM_ENABLE_PIC=ON All green https://github.com/cristianadam/llvm-project/actions/runs/44839699 Then: -D LIBCLANG_BUILD_STATIC=ON -D LLVM_ENABLE_PIC=OFF All green https://github.com/cristianada

[PATCH] D75001: [OpenMP][cmake] ignore warning on unknown CUDA version

Hahnfeld added a comment. In D75001#1887876 , @jdoerfert wrote: > I like this way better. I was hoping we could do it in our cmake only :) > > Give others a day or so to comment before your commit but I'm fine with this. Well, that doesn't really work if

[clang] fc466f8 - Make test not write to the source directory

Author: Benjamin Kramer Date: 2020-02-25T16:03:06+01:00 New Revision: fc466f87804f97b322394ef3b9db43ea3febcc15 URL: https://github.com/llvm/llvm-project/commit/fc466f87804f97b322394ef3b9db43ea3febcc15 DIFF: https://github.com/llvm/llvm-project/commit/fc466f87804f97b322394ef3b9db43ea3febcc15.dif

[PATCH] D75077: [OpenMP5.0] Allow pointer arithmetic in motion/map clause

ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:15683 } + bool VisitUnaryOperator(UnaryOperator *UO) { +if (SemaRef.getLangOpts().OpenMP < 50) { I think you need to extend this to support paren expressions, at least. ===

[PATCH] D74966: [PATCH] [ARM] Add Cortex-M55 Support for clang and llvm

chill accepted this revision. chill added a comment. This revision is now accepted and ready to land. LGTM. Please, wait a couple of days before committing. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74966/new/ https://reviews.llvm.org/D74966 __

[PATCH] D68163: [analyzer][MallocChecker][NFC] Change the use of IdentifierInfo* to CallDescription

NoQ added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/CallEvent.h:259 /// calls. bool isCalled(const CallDescription &CD) const; Szelethus wrote: > Szelethus wrote: > > NoQ wrote: > > > I don't fully understand how

[clang] a82ffe9 - [analyzer] Add support for CXXInheritedCtorInitExpr.

Author: Artem Dergachev Date: 2020-02-25T18:37:23+03:00 New Revision: a82ffe9d93a24abf30bcf63081096ea18baf78dc URL: https://github.com/llvm/llvm-project/commit/a82ffe9d93a24abf30bcf63081096ea18baf78dc DIFF: https://github.com/llvm/llvm-project/commit/a82ffe9d93a24abf30bcf63081096ea18baf78dc.dif

[PATCH] D71018: [ASTImporter] Improved import of TypeSourceInfo (TypeLoc)

balazske added inline comments. Comment at: clang/lib/AST/ASTImporter.cpp:8133 + Error VisitTypedefTypeLoc(TypedefTypeLoc From) { +return VisitTypeSpecTypeLoc(From); + } teemperor wrote: > I know the ASTImporter is doing these reimplementation of the defaul

[PATCH] D74735: [analyzer] Add support for CXXInheritedCtorInitExpr.

This revision was automatically updated to reflect the committed changes. Closed by commit rGa82ffe9d93a2: [analyzer] Add support for CXXInheritedCtorInitExpr. (authored by dergachev.a). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74735/new/ https

[PATCH] D73020: [Sema] Perform call checking when building CXXNewExpr

lebedev.ri added a comment. In D73020#1857704 , @rsmith wrote: > Looks good if you change the error to a warning. I'm going to treat that as an implicit accept since the error got changed into a warning. Will commit this soon. Repository: rG LLVM Gi

[PATCH] D75056: [Driver] Default to -fno-common

SjoerdMeijer updated this revision to Diff 246457. SjoerdMeijer retitled this revision from "[ARM][AArch64] Default to -fno-common" to "[Driver] Default to -fno-common". SjoerdMeijer edited the summary of this revision. SjoerdMeijer added reviewers: tstellar, jyknight. SjoerdMeijer added a comment

[clang] e6d0bad - [clang-rename] Add the USR of incomplete decl to the USRSet.

Author: Haojian Wu Date: 2020-02-25T16:56:35+01:00 New Revision: e6d0bad843c4c84bb762cf93a56c5bdd5cc535c0 URL: https://github.com/llvm/llvm-project/commit/e6d0bad843c4c84bb762cf93a56c5bdd5cc535c0 DIFF: https://github.com/llvm/llvm-project/commit/e6d0bad843c4c84bb762cf93a56c5bdd5cc535c0.diff LO

[PATCH] D74829: [clang-rename] Add the USR of incomplete decl to the USRSet.

This revision was automatically updated to reflect the committed changes. Closed by commit rGe6d0bad843c4: [clang-rename] Add the USR of incomplete decl to the USRSet. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74829/new/ ht

[PATCH] D75121: Put microsoft template parameter shadow warning behind separate flag (PR44794)

hans created this revision. hans added reviewers: rnk, thakis. This puts the warning behind a separate -Wmicrosoft-template-shadow flag as suggested on the bug. https://reviews.llvm.org/D75121 Files: clang/include/clang/Basic/DiagnosticGroups.td clang/include/clang/Basic/DiagnosticSemaKind

[clang] 7b65886 - Make builtbot happy.

Author: Haojian Wu Date: 2020-02-25T17:04:38+01:00 New Revision: 7b65886ec2d0de431959f6b1d1801ef43a958f55 URL: https://github.com/llvm/llvm-project/commit/7b65886ec2d0de431959f6b1d1801ef43a958f55 DIFF: https://github.com/llvm/llvm-project/commit/7b65886ec2d0de431959f6b1d1801ef43a958f55.diff LO

[clang] fa755d3 - [Sema][C++] Propagate conversion kind to specialize the diagnostics

Author: Anastasia Stulova Date: 2020-02-25T16:05:37Z New Revision: fa755d3e71ed590ac5c62f0e1eff09435c9593fe URL: https://github.com/llvm/llvm-project/commit/fa755d3e71ed590ac5c62f0e1eff09435c9593fe DIFF: https://github.com/llvm/llvm-project/commit/fa755d3e71ed590ac5c62f0e1eff09435c9593fe.diff

  1   2   3   >