sammccall added inline comments.
================
Comment at: clang-tools-extra/clangd/Selection.cpp:615
+ if (isa<CXXConstructorDecl>(D))
+ return SourceRange();
+ // This will capture Field, Function, MSProperty, NonTypeTemplateParm and
----------------
we may have to blacklist deduction guides too?
================
Comment at: clang-tools-extra/clangd/unittests/SelectionTests.cpp:378
"ObjCPropertyRefExpr"},
+ {"struct foo { [[int has^h<:32:>]]; };", "FieldDecl"},
+ // FIXME: This should be class itself instead.
----------------
can you add the other special cases we discussed offline? conversion operations
should be triggered by `operator`, destructors by `~`.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75106/new/
https://reviews.llvm.org/D75106
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
