[clang] a5040d5 - [SytemZ] Disable vector ABI when using option -march=arch[8|9|10]

Author: Kai Nacke Date: 2020-02-10T04:14:05-05:00 New Revision: a5040d5ec97ecac9940275eb59175f0bdbd26ab4 URL: https://github.com/llvm/llvm-project/commit/a5040d5ec97ecac9940275eb59175f0bdbd26ab4 DIFF: https://github.com/llvm/llvm-project/commit/a5040d5ec97ecac9940275eb59175f0bdbd26ab4.diff LOG

[PATCH] D74146: [SytemZ] Disable vector ABI when using option -march=arch[8|9|10]

This revision was automatically updated to reflect the committed changes. Closed by commit rGa5040d5ec97e: [SytemZ] Disable vector ABI when using option -march=arch[8|9|10] (authored by Kai). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74146/new/

[PATCH] D73916: [clang] Add `forceReload` clangd extension to 'textDocument/didChange'

sammccall added a comment. Looks pretty good now, thanks! Test needs to be more precise (doesn't actually test the behavior at present, I think). Comment at: clang-tools-extra/clangd/Compiler.h:41 bool SuggestMissingIncludes = false; + bool ForceRebuild = false; }; --

[PATCH] D68049: Propeller: Clang options for basic block sections

grimar added inline comments. Comment at: clang/include/clang/Basic/CodeGenOptions.h:120 + std::string BasicBlockSections; + MaskRay wrote: > Comment its allowed values ("all", "labels", "none") I'd suggest to rewrite it somehow. This set of values did not hel

[PATCH] D69043: [RFC] Adding time-trace to LLD?

russell.gallop abandoned this revision. russell.gallop added a comment. This was submitted as the sequence of patches: https://reviews.llvm.org/D70904 - Tidying up in TimeProfiler.cpp https://reviews.llvm.org/D70950 - Add ProcName to TimeTraceProfiler https://reviews.llvm.org/D71059 - [LLD][ELF] A

[clang] 76f888d - Fix handling of destructor names that name typedefs.

Author: Richard Smith Date: 2020-02-10T02:21:01-08:00 New Revision: 76f888d0a5324f4c6ae89cac61077cca4299b159 URL: https://github.com/llvm/llvm-project/commit/76f888d0a5324f4c6ae89cac61077cca4299b159 DIFF: https://github.com/llvm/llvm-project/commit/76f888d0a5324f4c6ae89cac61077cca4299b159.diff

Re: [clang] 0e3a487 - PR12350: Handle remaining cases permitted by CWG DR 244.

On Sun, 9 Feb 2020 at 11:33, Richard Smith wrote: > On Sun, 9 Feb 2020, 01:09 Nico Weber via cfe-commits, < > cfe-commits@lists.llvm.org> wrote: > >> Our code fails to build with "destructor cannot be declared using a type >> alias" after this, without us changing language mode or anything. >> >>

[PATCH] D72867: [clangd] Support renaming designated initializers

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/FindTarget.cpp:639 +void VisitDesignatedInitExpr(const DesignatedInitExpr *DIE) { + for (const DesignatedInitExpr::Des

[PATCH] D73359: [analyzer]StreamChecker refactoring (NFC).

balazske updated this revision to Diff 243488. balazske added a comment. Rebase and not using "ProgramStateRef &". Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73359/new/ https://reviews.llvm.org/D73359 Files: clang/lib/StaticAnalyzer/Checkers/

[PATCH] D61634: [clang/llvm] Allow efficient implementation of libc's memory functions in C/C++

gchatelet abandoned this revision. gchatelet added a comment. This has been implemented in the following patches: - https://reviews.llvm.org/D67923 - https://reviews.llvm.org/D74162 - https://reviews.llvm.org/D73543 - https://reviews.llvm.org/D71710 Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D73719: [AArch64][SVE] Add SVE2 intrinsics for widening DSP operations

This revision was automatically updated to reflect the committed changes. Closed by commit rG5e1d7bb6798d: [AArch64][SVE] Add SVE2 intrinsics for widening DSP operations (authored by kmclaughlin). Changed prior to commit: https://reviews.llvm.org/D73719?vs=241482&id=243489#toc Repository: rG

[PATCH] D74305: [clangd] Expose completion range in code completion results (C++ API)

sammccall created this revision. sammccall added a reviewer: usaxena95. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Informative only, useful for positioning UI, interacting with other sources of completion etc. As requ

[PATCH] D72035: [analyzer][NFC] Use CallEvent checker callback in GenericTaintChecker

steakhal updated this revision to Diff 243492. steakhal added a comment. Rebased on top of master, instead of D71524 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72035/new/ https://reviews.llvm.org/D72035 Files:

[clang-tools-extra] 9f6d8de - [clangd] Support renaming designated initializers

Author: Kirill Bobyrev Date: 2020-02-10T11:53:17+01:00 New Revision: 9f6d8de28ab6b3ac06658b8cb3236ef220712ed4 URL: https://github.com/llvm/llvm-project/commit/9f6d8de28ab6b3ac06658b8cb3236ef220712ed4 DIFF: https://github.com/llvm/llvm-project/commit/9f6d8de28ab6b3ac06658b8cb3236ef220712ed4.diff

[PATCH] D72867: [clangd] Support renaming designated initializers

This revision was automatically updated to reflect the committed changes. Closed by commit rG9f6d8de28ab6: [clangd] Support renaming designated initializers (authored by kbobyrev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72867/new/ https://rev

[PATCH] D73636: [AArch64][SVE] SVE2 intrinsics for complex integer arithmetic

sdesmalen accepted this revision. sdesmalen added a comment. This revision is now accepted and ready to land. Thanks @kmclaughlin , LGTM. Comment at: llvm/include/llvm/IR/IntrinsicsAArch64.td:1115 class AdvSIMD_SVE_LOGB_Intrinsic : AdvSIMD_SVE_CNT_Intrinsic; + class SVE2_C

[PATCH] D74117: [AArch64][SVE] SVE2 intrinsics for character match & histogram generation

This revision was automatically updated to reflect the committed changes. Closed by commit rGe299a0814956: [AArch64][SVE] SVE2 intrinsics for character match & histogram generation (authored by kmclaughlin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D73891: [RISCV] Support experimental/unratified extensions

simoncook updated this revision to Diff 243502. simoncook added a comment. Rebase, incorporate changes suggested by Lewis Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73891/new/ https://reviews.llvm.org/D73891 Files: clang/include/clang/Driver/

[PATCH] D74129: Prefer __vector over vector keyword for altivec use

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. It looks like the current code goes way back, to https://llvm.org/r39093 Do you know why it's started failing now? Consistency is nice though, so I don't see any downside to this. Repository:

[PATCH] D73261: [dwarf5] Support DebugInfo for constexpr for C++ variables and functions

awpandey updated this revision to Diff 243509. awpandey added a comment. Herald added a subscriber: ormris. @probinson I have reimplemented the feature by using DIFlags. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73261/new/ https://reviews.llvm.org/D73261 Files: clang/lib/CodeGen/

[PATCH] D73644: [Mips] Add intrinsics for 4-byte and 8-byte MSA loads/stores.

atanasyan accepted this revision. atanasyan added a comment. This revision is now accepted and ready to land. Looking good to me as-is. - Current naming is okay. But what do you think about reducing name of //quarter// intrinsics: `__builtin_msa_ldr_w` instead of `__builtin_msa_ldrq_w`? Will it

[PATCH] D73636: [AArch64][SVE] SVE2 intrinsics for complex integer arithmetic

This revision was automatically updated to reflect the committed changes. Closed by commit rG92a78750929b: [AArch64][SVE] SVE2 intrinsics for complex integer arithmetic (authored by kmclaughlin). Changed prior to commit: https://reviews.llvm.org/D73636?vs=242683&id=243511#toc Repository: rG

[PATCH] D73966: [analyzer] Add 10.0.0 release notes.

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. Herald added a subscriber: steakhal. Looks good to me. Thanks for writing release notes! If you have commit access, go ahead and push directly to the branch, otherwise let me know and I'll be happ

[PATCH] D73898: [analyzer] StdLibraryFunctionsChecker: Add argument constraints

martong planned changes to this revision. martong added a subscriber: steakhal. martong added a comment. Based on our verbal discussion with @Szelethus and @steakhal and based on the mailing archives , I am going to do the followi

[PATCH] D71600: PowerPC 32-bit - forces 8 byte lock/lock_free decisions at compiled time

adalava updated this revision to Diff 243520. adalava added a comment. fix typo found by @dim Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71600/new/ https://reviews.llvm.org/D71600 Files: clang/lib/AST/ExprConstant.cpp compiler-rt/lib/builti

[PATCH] D74216: [clang-rename] Fix the missing template constructors.

kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/unittests/RenameTests.cpp:144 + template + [[Foo]](); + nit: Maybe also add `^` to this one and the one below? Comment at: clang/lib/Tooling/Refactoring/Rena

[PATCH] D73966: [analyzer] Add 10.0.0 release notes.

Szelethus added a comment. I missed out on the transition to github, so I suspect that the commit access will only be extended to it after tagging rc2. I think it would be better if you committed this on my behalf, thanks! :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73966/new/ ht

[PATCH] D73897: [analyzer] StdLibraryFunctionsChecker refactor: remove macros

martong marked 2 inline comments as done. martong added a comment. Herald added a subscriber: steakhal. Ping @NoQ Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:42-49 // The following standard C functions are currently supported: // // fgetc

[clang] fcea7fb - CWG2445: For function template partial ordering, take reversal of

Author: Richard Smith Date: 2020-02-10T06:07:48-08:00 New Revision: fcea7fbdba1bdf26e2a858a6be2865e6267da023 URL: https://github.com/llvm/llvm-project/commit/fcea7fbdba1bdf26e2a858a6be2865e6267da023 DIFF: https://github.com/llvm/llvm-project/commit/fcea7fbdba1bdf26e2a858a6be2865e6267da023.diff

[PATCH] D73966: [analyzer] Add 10.0.0 release notes.

hans added a comment. Pushed to 10.x in 64515b35844b925bdb76821d03ad4d7ddebe06e7 . Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73966/new/ https://reviews.llvm.org/D73966 __

[PATCH] D74063: [Clang] Remove #pragma clang __debug handle_crash

hans added a comment. Cherry-picked to 10.x in 793d643f6d69e6908a6ece4aacb07b6573e33e18 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74063/new/ https://reviews.llvm.org/D74063

[PATCH] D73413: [clang-tidy] Add check to detect external definitions with no header declaration

njames93 updated this revision to Diff 243545. njames93 added a comment. - Relaxed corresponding header - Added support for tag types Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73413/new/ https://reviews.llvm.org/D73413 Files: clang-tools-ext

[PATCH] D73897: [analyzer] StdLibraryFunctionsChecker refactor: remove macros

NoQ accepted this revision. NoQ added a comment. LGTM, thanks again! Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:537-551 + // The format is as follows: //{ "function name", - // { spec: + // { variant0: //{ argument types list, .

[PATCH] D74070: [Clang] Don't let gen crash diagnostics fail when '#pragma clang __debug crash' is used

hans added a comment. In D74070#1863989 , @aganea wrote: > Relanded as rG75f09b54429bee17a96e2ba7a2ac0f0a8a7f7e74 > . Pushed that to 10.x as 0e1c734fa5b88ec7efc2bcf8d45ed58f6ba48b91 <

[PATCH] D74076: [Clang][Driver] Remove -M group options before generating crash diagnostics

hans added a comment. In D74076#1863987 , @aganea wrote: > Relanded as rG75f09b54429bee17a96e2ba7a2ac0f0a8a7f7e74 > Pushed that to 10.x as 0e1c734fa5b88ec7efc2bcf8d45ed58f6ba48b91

[PATCH] D69825: [Clang][Driver] Re-use the calling process instead of creating a new process for the cc1 invocation

hans added a comment. > @erichkeane Thanks for filing the bugzilla bug. I was having some problems > with my bugzilla login myself and wasn't able to do so. I'll track progress > if this bug and decide shortly if my feature should imply no-integraed-cc1. > Thanks Guys. I think that bug was for

Re: patch via mailing list: Use getLocation() in too few/many arguments diagnostic

Thanks Aaron (and Hubert). I've attached an updated patch that now includes new test cases alongside some existing "too few / too many" test cases in test/Sema/exprs.c. This splits the function declaration over two lines so it can use -verify to validate the source location's line (but not colu

[PATCH] D73897: [analyzer] StdLibraryFunctionsChecker refactor: remove macros

martong updated this revision to Diff 243552. martong marked 7 inline comments as done. martong added a comment. - Ditch comment about (macro) format - Use {} with RetType Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73897/new/ https://reviews.llv

[PATCH] D73052: [clang-tidy] RenamerClangTidy now renames dependent member expr when the member can be resolved

njames93 added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73052/new/ https://reviews.llvm.org/D73052 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D73897: [analyzer] StdLibraryFunctionsChecker refactor: remove macros

martong added a comment. Thanks for the review guys! Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:537-551 + // The format is as follows: //{ "function name", - // { spec: + // { variant0: //{ argument types list, ... }, - //r

[PATCH] D69979: clang: Guess at some platform FTZ/DAZ default settings

arsenm updated this revision to Diff 243553. arsenm added a comment. Rebase and fix check prefix name CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69979/new/ https://reviews.llvm.org/D69979 Files: clang/include/clang/Driver/ToolChain.h clang/lib/Driver/ToolChain.cpp clang/lib/Dr

[PATCH] D72304: [OpenMP][OMPIRBuilder] Add Directives (master and critical) to OMPBuilder.

kadircet added a comment. this breaks under asan http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/38597/steps/check-clang%20asan/logs/stdio Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72304/new/ https://reviews.llvm.org/D7230

[clang] 5731b66 - Revert "[OpenMP] Fix unused variable"

Author: Kadir Cetinkaya Date: 2020-02-10T16:34:59+01:00 New Revision: 5731b6672ded5615f5489c892d7cdc9f4cf1836a URL: https://github.com/llvm/llvm-project/commit/5731b6672ded5615f5489c892d7cdc9f4cf1836a DIFF: https://github.com/llvm/llvm-project/commit/5731b6672ded5615f5489c892d7cdc9f4cf1836a.dif

[PATCH] D71600: PowerPC 32-bit - forces 8 byte lock/lock_free decisions at compiled time

efriedma requested changes to this revision. efriedma added a comment. This revision now requires changes to proceed. For the clang change, we should do something like D72579 , not explicitly check for a specific target in target-independent code. For compiler-r

[clang] f5086b3 - [analyzer] StdLibraryFunctionsChecker refactor: remove macros

Author: Gabor Marton Date: 2020-02-10T16:45:33+01:00 New Revision: f5086b3803ac2f908a734bbb2c7a50018fb3cd8c URL: https://github.com/llvm/llvm-project/commit/f5086b3803ac2f908a734bbb2c7a50018fb3cd8c DIFF: https://github.com/llvm/llvm-project/commit/f5086b3803ac2f908a734bbb2c7a50018fb3cd8c.diff

[clang-tools-extra] 0151ddc - Create a clang-tidy check to warn when -dealloc is implemented inside an ObjC class category.

Author: Michael Wyman Date: 2020-02-10T08:56:28-07:00 New Revision: 0151ddc2e834ab4949789cbed4e03a958284cd54 URL: https://github.com/llvm/llvm-project/commit/0151ddc2e834ab4949789cbed4e03a958284cd54 DIFF: https://github.com/llvm/llvm-project/commit/0151ddc2e834ab4949789cbed4e03a958284cd54.diff

[PATCH] D73897: [analyzer] StdLibraryFunctionsChecker refactor: remove macros

This revision was automatically updated to reflect the committed changes. Closed by commit rGf5086b3803ac: [analyzer] StdLibraryFunctionsChecker refactor: remove macros (authored by martong). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73897/new/

[PATCH] D72876: Create a clang-tidy check to warn when -dealloc is implemented inside an ObjC class category.

This revision was automatically updated to reflect the committed changes. Closed by commit rG0151ddc2e834: Create a clang-tidy check to warn when -dealloc is implemented inside an ObjC… (authored by mwyman, committed by benhamilton). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D74262: [clang-offload-bundler] Enable handling of partially-linked fat objects

ABataev added a comment. Partial linking may lead to some incorrect results with global constructors. How are you going to handle this? Comment at: clang/test/Driver/clang-offload-bundler-missing-size-section.cpp:1-44 +// REQUIRES: x86-registered-target +// RUN: %clangxx -c %

[PATCH] D73720: [Analyzer] Use note tags to track container begin and and changes

baloghadamsoftware updated this revision to Diff 243571. baloghadamsoftware added a comment. Only track the right container. Furthermore, minor updates according to the comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73720/new/ https://reviews.llvm.org/D73720 Files: clang/li

[PATCH] D73720: [Analyzer] Use note tags to track container begin and and changes

baloghadamsoftware marked 4 inline comments as done. baloghadamsoftware added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/ContainerModeling.cpp:731 + } + return C.getNoteTag([Text, Name](BugReport &BR) -> std::string { + SmallString<256> Msg; ---

[PATCH] D72675: [Clang][Driver] Fix -ffast-math/-ffp-contract interaction

uweigand added a comment. In D72675#1829866 , @hfinkel wrote: > > I'm not sure whether this is deliberate (but it seems weird) or just a bug. > > I can ask the GCC developers ... > > Please do. If there's a rationale, we should know. Sorry for the delay

[PATCH] D69979: clang: Guess at some platform FTZ/DAZ default settings

spatel accepted this revision. spatel added a comment. This revision is now accepted and ready to land. LGTM - the PS4 behavior was confirmed off-list. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69979/new/ https://reviews.llvm.org/D69979 ___

[libunwind] 14798b4 - unwind: rename `__personality_routine` to `_Unwind_Personality_Fn`

Author: Saleem Abdulrasool Date: 2020-02-10T08:52:31-08:00 New Revision: 14798b44658c8b30b44afae20d0f391e88eb5bec URL: https://github.com/llvm/llvm-project/commit/14798b44658c8b30b44afae20d0f391e88eb5bec DIFF: https://github.com/llvm/llvm-project/commit/14798b44658c8b30b44afae20d0f391e88eb5bec.

[PATCH] D74332: [ARM,MVE] Add intrinsics for int <-> float conversion.

simon_tatham created this revision. simon_tatham added reviewers: dmgreen, miyuki, MarkMurrayARM, ostannard. Herald added subscribers: cfe-commits, kristof.beyls. Herald added a project: clang. This adds the unpredicated versions of the family of vcvtq intrinsics that convert between a vector of f

[PATCH] D74334: [ARM,MVE] Add the vrev16q, vrev32q, vrev64q family.

simon_tatham created this revision. simon_tatham added reviewers: dmgreen, miyuki, MarkMurrayARM, ostannard. Herald added subscribers: cfe-commits, kristof.beyls. Herald added a project: clang. These intrinsics just reorder the lanes of a vector, so the natural IR representation is as a shufflevec

[PATCH] D74333: [ARM,MVE] Add intrinsics for FP rounding operations.

simon_tatham created this revision. simon_tatham added reviewers: dmgreen, miyuki, MarkMurrayARM, ostannard. Herald added subscribers: llvm-commits, cfe-commits, hiraditya, kristof.beyls. Herald added projects: clang, LLVM. This adds the unpredicated forms of six different MVE intrinsics which all

[PATCH] D74335: [ARM,MVE] Add intrinsics vclzq and vclsq.

simon_tatham created this revision. simon_tatham added reviewers: dmgreen, miyuki, MarkMurrayARM, ostannard. Herald added subscribers: llvm-commits, cfe-commits, hiraditya, kristof.beyls. Herald added projects: clang, LLVM. vclzq maps nicely to the existing target-independent @llvm.ctlz IR intrins

[PATCH] D73742: [Clang][Driver] After default -fintegrated-cc1, fix report_fatal_error no longer generates preprocessed source + reproducer.sh

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. Looks good to me, just a nit about one of the comments. Thanks for making this easier to review by splitting it up! Comment at: llvm/include/llvm/Support/Process.h:205 + + ///

[PATCH] D74331: [ARM,MVE] Add intrinsics for abs, neg and not operations.

simon_tatham created this revision. simon_tatham added reviewers: dmgreen, miyuki, MarkMurrayARM, ostannard. Herald added subscribers: cfe-commits, kristof.beyls. Herald added a project: clang. This commit adds the unpredicated intrinsics for the unary operations vabsq (absolute value), vnegq (ari

[PATCH] D74336: [ARM,MVE] Add the vmovlbq,vmovltq intrinsic family.

simon_tatham created this revision. simon_tatham added reviewers: dmgreen, miyuki, MarkMurrayARM, ostannard. Herald added subscribers: llvm-commits, cfe-commits, hiraditya, kristof.beyls. Herald added projects: clang, LLVM. These intrinsics take a vector of 2n elements, and return a vector of n wi

[PATCH] D74337: [ARM,MVE] Add the vmovnbq,vmovntq intrinsic family.

simon_tatham created this revision. simon_tatham added reviewers: dmgreen, miyuki, MarkMurrayARM, ostannard. Herald added subscribers: llvm-commits, cfe-commits, hiraditya, kristof.beyls. Herald added projects: clang, LLVM. These are in some sense the inverse of vmovl[bt]q: they take a vector of n

[PATCH] D71600: PowerPC 32-bit - forces 8 byte lock/lock_free decisions at compiled time

adalava added a comment. In D71600#1867135 , @efriedma wrote: > For the clang change, we should do something like D72579 > , not explicitly check for a specific target > in target-independent code. right, I'll retest ev

[PATCH] D73966: [analyzer] Add 10.0.0 release notes.

Szelethus closed this revision. Szelethus added a comment. Cheers! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73966/new/ https://reviews.llvm.org/D73966 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-b

[PATCH] D73916: [clang] Add `forceReload` clangd extension to 'textDocument/didChange'

dgoldman updated this revision to Diff 243595. dgoldman marked 3 inline comments as done. dgoldman added a comment. - Fixes for tests and InputFiles Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73916/new/ https://reviews.llvm.org/D73916 Files:

[PATCH] D73916: [clang] Add `forceReload` clangd extension to 'textDocument/didChange'

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. LG, thanks! Just a nit about further simplifying the test, up to you. Comment at: clang-tools-extra/clangd/unittests/TUSchedulerTests.cpp:630 + + auto DoUpdate = [&](s

Re: patch via mailing list: Use getLocation() in too few/many arguments diagnostic

On Mon, Feb 10, 2020 at 10:06 AM John Marshall wrote: > > Thanks Aaron (and Hubert). > > I've attached an updated patch that now includes new test cases alongside > some existing "too few / too many" test cases in test/Sema/exprs.c. This > splits the function declaration over two lines so it can

[PATCH] D68049: Propeller: Clang options for basic block sections

tmsriram added a comment. In D68049#1865967 , @MaskRay wrote: > If you don't mind, I can push a Diff to this Differential which will address > these review comments. Let me update this patch asap as we refactored getBBSectionsList into llvm as it is sh

[PATCH] D68049: Propeller: Clang options for basic block sections

tmsriram updated this revision to Diff 243614. tmsriram marked 3 inline comments as done. tmsriram added a comment. Removed getBBSectionsList (moved to LLVM) and address other reviewer comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68049/new/ https://reviews.llvm.org/D68049 Fi

[PATCH] D73916: [clang] Add `forceReload` clangd extension to 'textDocument/didChange'

dgoldman updated this revision to Diff 243619. dgoldman added a comment. - Minor test fixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73916/new/ https://reviews.llvm.org/D73916 Files: clang-tools-extra/clangd/ClangdLSPServer.cpp clang-tool

[PATCH] D73916: [clang] Add `forceReload` clangd extension to 'textDocument/didChange'

dgoldman marked 2 inline comments as done. dgoldman added inline comments. Comment at: clang-tools-extra/clangd/unittests/TUSchedulerTests.cpp:630 + + auto DoUpdate = [&](std::string Contents, bool ForceRebuild, + llvm::unique_function)> CB) { --

[PATCH] D74347: [CMake] Explicitly specify paths to libc++abi in CrossWinToARMLinux.cmake

broadwaylamb created this revision. broadwaylamb added reviewers: vvereschaka, aorlov, andreil99. Herald added subscribers: cfe-commits, ldionne, kristof.beyls, mgorny. Herald added a reviewer: EricWF. Herald added a project: clang. D69169 , which was necessary for

[clang] b50431d - fix some typos to cycle bots

Author: Nico Weber Date: 2020-02-10T13:51:23-05:00 New Revision: b50431defbaf80c254244cefdce3813576633ae5 URL: https://github.com/llvm/llvm-project/commit/b50431defbaf80c254244cefdce3813576633ae5 DIFF: https://github.com/llvm/llvm-project/commit/b50431defbaf80c254244cefdce3813576633ae5.diff LO

[clang-tools-extra] 6ff0228 - [clang] Add `forceReload` clangd extension to 'textDocument/didChange'

Author: David Goldman Date: 2020-02-10T14:02:02-05:00 New Revision: 6ff0228c6df37e052fa6e8e3927e83b289402cf6 URL: https://github.com/llvm/llvm-project/commit/6ff0228c6df37e052fa6e8e3927e83b289402cf6 DIFF: https://github.com/llvm/llvm-project/commit/6ff0228c6df37e052fa6e8e3927e83b289402cf6.diff

[PATCH] D73916: [clang] Add `forceReload` clangd extension to 'textDocument/didChange'

This revision was automatically updated to reflect the committed changes. dgoldman marked an inline comment as done. Closed by commit rG6ff0228c6df3: [clang] Add `forceReload` clangd extension to 'textDocument/didChange' (authored by dgoldman). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D74129: Prefer __vector over vector keyword for altivec use

serge-sans-paille added a comment. > Do you know why it's started failing now? Not quite, probably a gcc update. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74129/new/ https://reviews.llvm.org/D74129 __

[PATCH] D74129: Prefer __vector over vector keyword for altivec use

This revision was automatically updated to reflect the committed changes. Closed by commit rG3185c30c54d0: Prefer __vector over vector keyword for altivec (authored by serge-sans-paille). Changed prior to commit: https://reviews.llvm.org/D74129?vs=242902&id=243641#toc Repository: rG LLVM Git

[clang] 3185c30 - Prefer __vector over vector keyword for altivec

Author: serge-sans-paille Date: 2020-02-10T20:23:26+01:00 New Revision: 3185c30c54d0af5bffbff3bcfd721668d086ff10 URL: https://github.com/llvm/llvm-project/commit/3185c30c54d0af5bffbff3bcfd721668d086ff10 DIFF: https://github.com/llvm/llvm-project/commit/3185c30c54d0af5bffbff3bcfd721668d086ff10.d

[PATCH] D68720: Support -fstack-clash-protection for x86

serge-sans-paille added a comment. For the record: tests have been updated, option handling cleaned up and expansive check failure fixed in commit e67cbac81211d40332a79d98c9d5953624cc1202 . Repository: rG LLVM Github Monor

Re: [clang] 0e3a487 - PR12350: Handle remaining cases permitted by CWG DR 244.

On Sun, Feb 9, 2020 at 2:34 PM Richard Smith wrote: > On Sun, 9 Feb 2020, 01:09 Nico Weber via cfe-commits, < > cfe-commits@lists.llvm.org> wrote: > >> Our code fails to build with "destructor cannot be declared using a type >> alias" after this, without us changing language mode or anything. >>

[clang] 04a830f - [OPENMP50]Support for acquire clause.

Author: Alexey Bataev Date: 2020-02-10T14:51:46-05:00 New Revision: 04a830f80af97d1b2d2d652984635a774b23ebda URL: https://github.com/llvm/llvm-project/commit/04a830f80af97d1b2d2d652984635a774b23ebda DIFF: https://github.com/llvm/llvm-project/commit/04a830f80af97d1b2d2d652984635a774b23ebda.diff

[PATCH] D67983: [ObjC] Diagnose implicit type coercion from ObjC 'Class' to object pointer types.

arphaman added a comment. In D67983#1863981 , @jyknight wrote: > In D67983#1863019 , @arphaman wrote: > > > @jyknight @rjmccall I'm not sure this change is 100% fine. For example, the > > following code no longer c

[PATCH] D74262: [clang-offload-bundler] Enable handling of partially-linked fat objects

jdoerfert added a comment. (I'll try to actually review this later but I left a comment below) Comment at: clang/test/Driver/clang-offload-bundler-missing-size-section.cpp:1-44 +// REQUIRES: x86-registered-target +// RUN: %clangxx -c %s -o %t_fat.o +// RUN: %clangxx %t_fat.o -

[clang-tools-extra] efcf643 - Reland "[clangd][test] Disable a particular testcase in FindExplicitReferencesTest when LLVM_ENABLE_EXPENSIVE_CHECKS""

Author: Jan Korous Date: 2020-02-10T12:17:02-08:00 New Revision: efcf6430009cc5bcc2024ecec1c4e4bbb328d037 URL: https://github.com/llvm/llvm-project/commit/efcf6430009cc5bcc2024ecec1c4e4bbb328d037 DIFF: https://github.com/llvm/llvm-project/commit/efcf6430009cc5bcc2024ecec1c4e4bbb328d037.diff LO

Re: [clang-tools-extra] 8a68c40 - [clang-tidy] Added option for disabling const qualifiers in readability-qualified-auto

This broke sphinx: http://lab.llvm.org:8011/builders/clang-tools-sphinx-docs/builds/54402/steps/docs-clang-tools-html/logs/stdio Please take a look! On Sun, Feb 2, 2020 at 4:27 PM Nathan James via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > Author: Nathan James > Date: 2020-02-02T21:27:

[PATCH] D73755: [objc_direct] Small updates to help with adoption.

MadCoder updated this revision to Diff 243649. MadCoder added a comment. Add some errors when direct properties are marked @dynamic. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73755/new/ https://reviews.llvm.org/D73755 Files: clang/include/clang/Basic/Attr.td clang/include/cla

[PATCH] D67983: [ObjC] Diagnose implicit type coercion from ObjC 'Class' to object pointer types.

jyknight added a comment. >> Your error looks correct to me -- "self" in a classmethod is not an >> instance, but the class itself. And while instances of X implement >> "Delegate", the Class does not. > > Got it, thanks! We might need to add a flag to allow the old behavior > temporarily to a

[clang] 9559834 - [OPENMP50]Add support for 'release' clause.

Author: Alexey Bataev Date: 2020-02-10T16:01:41-05:00 New Revision: 9559834a5c1286db4e5bc1f5de047bfd67868f4a URL: https://github.com/llvm/llvm-project/commit/9559834a5c1286db4e5bc1f5de047bfd67868f4a DIFF: https://github.com/llvm/llvm-project/commit/9559834a5c1286db4e5bc1f5de047bfd67868f4a.diff

[PATCH] D67588: Add builtin trait for add/remove cv (and similar)

EricWF added a comment. LGTM other than the inline comments. I'll take a second pass at this once they're addressed. Let's land the patch this week! Comment at: clang/include/clang/Sema/DeclSpec.h:419 static bool isTypeRep(TST T) { return (T == TST_typename || T == TST

[PATCH] D74355: [ubsan] Null-check TypeLoc before using it

vsk created this revision. vsk added reviewers: erik.pilkington, delcypher. Herald added a subscriber: dexonsmith. Null-check a TypeLoc before casting it to a FunctionTypeLoc. This fixes a crash in -fsanitize=nullability-return. rdar://59263039 https://reviews.llvm.org/D74355 Files: clang/li

[PATCH] D74355: [ubsan] Null-check and adjust TypeLoc before using it

vsk updated this revision to Diff 243672. vsk retitled this revision from "[ubsan] Null-check TypeLoc before using it" to "[ubsan] Null-check and adjust TypeLoc before using it". vsk edited the summary of this revision. vsk added a comment. - Check adjusted return type per Erik's offline feedback

[PATCH] D74355: [ubsan] Null-check and adjust TypeLoc before using it

erik.pilkington accepted this revision. erik.pilkington added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74355/new/ https://reviews.llvm.org/D74355 ___ cfe-commits mailing

[clang] 8b81ebf - [ubsan] Null-check and adjust TypeLoc before using it

Author: Vedant Kumar Date: 2020-02-10T14:10:06-08:00 New Revision: 8b81ebfe7eba089ed2016d523cc5ee9d05e957a7 URL: https://github.com/llvm/llvm-project/commit/8b81ebfe7eba089ed2016d523cc5ee9d05e957a7 DIFF: https://github.com/llvm/llvm-project/commit/8b81ebfe7eba089ed2016d523cc5ee9d05e957a7.diff

[PATCH] D74355: [ubsan] Null-check and adjust TypeLoc before using it

This revision was automatically updated to reflect the committed changes. Closed by commit rG8b81ebfe7eba: [ubsan] Null-check and adjust TypeLoc before using it (authored by vsk). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D44609: [clang-format] New option BeforeLambdaBody to manage lambda line break inside function parameter call (in Allman style)

Wawha added a comment. Hi @MyDeveloperDay Is the last change ok? That is the next step to be able to validate this patch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D44609/new/ https://reviews.llvm.org/D44609 __

[PATCH] D74361: [Clang] Uninitialize attribute on global variables

JonChesterfield created this revision. JonChesterfield added reviewers: kcc, rjmccall, rsmith, glider, vitalybuka, pcc, eugenis, vlad.tsyrklevich, jdoerfert, gregrodgers. Herald added a project: clang. Herald added a subscriber: cfe-commits. [Clang] Uninitialize attribute on global variables Ext

[PATCH] D74361: [Clang] Uninitialize attribute on global variables

jdoerfert added a comment. FWIW, this would really help us to create an OpenMP device (=GPU) runtime written almost entirely in OpenMP, C++, and very few clang builtins. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74361/new/ https://reviews.llvm

[PATCH] D74371: [DirectoryWatcher] Fix misuse of FSEvents API and data race

benlangmuir created this revision. benlangmuir added reviewers: jkorous, akyrtzi. Herald added subscribers: cfe-commits, dexonsmith. Herald added a project: clang. I observed two bugs in the DirectoryWatcher on macOS 1. We were calling FSEventStreamStop and FSEventStreamInvalidate before

[PATCH] D74371: [DirectoryWatcher] Fix misuse of FSEvents API and data race

jkorous accepted this revision. jkorous added a comment. This revision is now accepted and ready to land. LGTM Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74371/new/ https://reviews.llvm.org/D74371

[clang-tools-extra] 784d441 - Fix Sphinx failure on ReadabilityQualifiedAuto docs

Author: Nathan James Date: 2020-02-11T02:03:37Z New Revision: 784d4417453e2bb792e29f5dad462f7fcebab6d1 URL: https://github.com/llvm/llvm-project/commit/784d4417453e2bb792e29f5dad462f7fcebab6d1 DIFF: https://github.com/llvm/llvm-project/commit/784d4417453e2bb792e29f5dad462f7fcebab6d1.diff LOG:

  1   2   >