atanasyan accepted this revision. atanasyan added a comment. This revision is now accepted and ready to land.
Looking good to me as-is. - Current naming is okay. But what do you think about reducing name of //quarter// intrinsics: `__builtin_msa_ldr_w` instead of `__builtin_msa_ldrq_w`? Will it clash with any future intrinsics' names? - There is almost no documentation on target specific intrinsics. Some articles like Using ARM NEON instructions in big endian mode <https://llvm.org/docs/BigEndianNEON.html> cover specific use cases. It's up to you to write an article for these new intrinsics. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73644/new/ https://reviews.llvm.org/D73644 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
