Author: Jan Korous Date: 2020-02-10T12:17:02-08:00 New Revision: efcf6430009cc5bcc2024ecec1c4e4bbb328d037
URL: https://github.com/llvm/llvm-project/commit/efcf6430009cc5bcc2024ecec1c4e4bbb328d037 DIFF: https://github.com/llvm/llvm-project/commit/efcf6430009cc5bcc2024ecec1c4e4bbb328d037.diff LOG: Reland "[clangd][test] Disable a particular testcase in FindExplicitReferencesTest when LLVM_ENABLE_EXPENSIVE_CHECKS"" The test got re-enabled after d54d71b67e60 landed. However it seems that the order is still not deterministic as it currently passes with -DLLVM_ENABLE_EXPENSIVE_CHECKS=OFF but randomly fails with expensive checks ON. Added: Modified: clang-tools-extra/clangd/unittests/FindTargetTests.cpp Removed: ################################################################################ diff --git a/clang-tools-extra/clangd/unittests/FindTargetTests.cpp b/clang-tools-extra/clangd/unittests/FindTargetTests.cpp index 1d2ea0f1c0b2..be4b37c8f453 100644 --- a/clang-tools-extra/clangd/unittests/FindTargetTests.cpp +++ b/clang-tools-extra/clangd/unittests/FindTargetTests.cpp @@ -823,6 +823,10 @@ TEST_F(FindExplicitReferencesTest, All) { "1: targets = {vector}\n" "2: targets = {x}\n"}, // Handle UnresolvedLookupExpr. + // FIXME + // This case fails when expensive checks are enabled. + // Seems like the order of ns1::func and ns2::func isn't defined. + #ifndef EXPENSIVE_CHECKS {R"cpp( namespace ns1 { void func(char*); } namespace ns2 { void func(int*); } @@ -836,6 +840,7 @@ TEST_F(FindExplicitReferencesTest, All) { )cpp", "0: targets = {ns1::func, ns2::func}\n" "1: targets = {t}\n"}, + #endif // Handle UnresolvedMemberExpr. {R"cpp( struct X { _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
