[PATCH] D73357: [ARM,MVE] Add intrinsics for v[id]dupq and v[id]wdupq.

simon_tatham created this revision. simon_tatham added reviewers: dmgreen, MarkMurrayARM, miyuki, ostannard. Herald added subscribers: llvm-commits, cfe-commits, hiraditya, kristof.beyls. Herald added projects: clang, LLVM. These instructions generate a vector of consecutive elements starting from

[PATCH] D73270: [clang-tidy] Fix false positive in bugprone-infinite-loop

gribozavr2 accepted this revision. gribozavr2 added a comment. This revision is now accepted and ready to land. LGTM! Please commit if you have commit access, or let me know if I should push it for you. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73270/new/ https://reviews.llvm.org/D

[PATCH] D73335: clang-format: [JS] options for arrow functions.

krasimir accepted this revision. krasimir added inline comments. This revision is now accepted and ready to land. Comment at: clang/unittests/Format/FormatTestJS.cpp:1793 verifyFormat("export default [];"); - verifyFormat("export default () => {};"); verifyFormat("export i

[PATCH] D73270: [clang-tidy] Fix false positive in bugprone-infinite-loop

njames93 added a comment. May not be one for this patch, but how does this check handle volatile loop variables and cases where modification isn't visible in the context e.g. extern void mutate(bool &); volatile bool* LoopCond; void foo() { for (bool Cond = true; Cond; mutate(Cond))

[PATCH] D73359: [clang][checkers]StreamChecker refactoring (NFC).

balazske created this revision. Herald added subscribers: cfe-commits, gamesh411, Szelethus, dkrupp. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D73359 Files: clang/lib/StaticAnalyzer/Checkers/StreamChecker.cpp Index: clang/lib/StaticAnalyzer/

[PATCH] D73354: clang-format: insert trailing commas into containers.

sammccall added a comment. For rolling this out, I think the best path is: - check in the option, but don't turn it on with any styles yet - test it by taking a large codebase, formatting it (normal options), format it (with comma insertion), look at the diffs (internally google3diff can do this

[PATCH] D73360: [OpenCL] Restrict address space conversions in nested pointers

Anastasia created this revision. Anastasia added reviewers: rjmccall, jeroen.dobbelaere, bevinh. Herald added subscribers: ebevhan, yaxunl. This patch is fixing the issue reported in: http://lists.llvm.org/pipermail/cfe-dev/2020-January/064273.html and in the bug: https://bugs.llvm.org/show_bug.cg

[PATCH] D73354: clang-format: insert trailing commas into containers.

Bouska added a comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73354/new/ https://reviews.llvm.org/D73354 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mai

[PATCH] D73270: [clang-tidy] Fix false positive in bugprone-infinite-loop

gribozavr2 added a comment. In D73270#1838883 , @njames93 wrote: > May not be one for this patch, but how does this check handle volatile loop > variables and cases where modification isn't visible in the context e.g. Should be OK, see "if (Var->getType

[PATCH] D72811: [WIP][OPENMP5.0] allow lvalue for motion clause

cchen marked 2 inline comments as done. cchen added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:7829 if (EncounteredME) { - const auto *FD = dyn_cast(EncounteredME->getMemberDecl()); - unsigned FieldIndex = FD->getFieldIndex(); -

[PATCH] D73354: clang-format: insert trailing commas into containers.

Bouska added a comment. I have an issue with this change. Currently (at least for C++), the presence of a trailing comma is used as a formatting hint to put all the element in one line or one per line as below: enum test1 = {ONE, TWO, THREE}; enum test2 = { ONE, TWO, TH

[PATCH] D72467: Remove "mask" operand from shufflevector.

ctetreau added inline comments. Comment at: llvm/lib/IR/ConstantsContext.h:153 cast(C1->getType())->getElementType(), - cast(C3->getType())->getElementCount()), + Mask.size(), C1->getType()->getVectorIsScalable()),

[PATCH] D72811: [WIP][OPENMP5.0] allow lvalue for motion clause

ABataev added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:7829 if (EncounteredME) { - const auto *FD = dyn_cast(EncounteredME->getMemberDecl()); - unsigned FieldIndex = FD->getFieldIndex(); - - // Update info about the lo

[PATCH] D73354: clang-format: insert trailing commas into containers.

sammccall added a comment. In D73354#1838964 , @Bouska wrote: > I have an issue with this change. Currently (at least for C++), the presence > of a trailing comma is used as a formatting hint to put all the element in > one line or one per line as below:

[PATCH] D72820: [FPEnv] Add pragma FP_CONTRACT support under strict FP.

craig.topper added inline comments. Comment at: clang/lib/CodeGen/CGExprScalar.cpp:3381 + "constrained mode"); +FMulAdd = Builder.CreateCall( +CGF.CGM.getIntrinsic(llvm::Intrinsic::experimental_constrained_fmuladd, kpn wrote: > craig.topper

[PATCH] D73187: [AST] Add fixed-point division constant evaluation.

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73187/new/ https://reviews.llvm.org/D73187 ___

[PATCH] D72222: [Driver][CodeGen] Add -fpatchable-function-entry=N[,0]

mrutland added a comment. In D7#1837536 , @MaskRay wrote: > > For `BTI c` issue, GCC has several releases that do not work with > -mbranch-protection=bti. The Linux kernel has to develop some mechanism to > detect the undesirable placement of `bt

[PATCH] D73270: [clang-tidy] Fix false positive in bugprone-infinite-loop

njames93 added a comment. In D73270#1838956 , @gribozavr2 wrote: > In D73270#1838883 , @njames93 wrote: > > > May not be one for this patch, but how does this check handle volatile loop > > variables and cases wher

[PATCH] D72630: [clang-tidy] Ignore implicit casts in modernize-use-default-member-init

malcolm.parsons added a comment. In D72630#1823525 , @hans wrote: > It seems that while this commit got pushed to GitHub, it's not actually part > of master or any other branches. This was my first push to llvm's GitHub repository, so I may have done s

[PATCH] D73363: Verify that clang's max alignment is <= LLVM's max alignment

davezarzycki created this revision. davezarzycki added a reviewer: lebedev.ri. davezarzycki added projects: LLVM, clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D73363 Files: clang/include/clang/Sema/Sema.h clang/lib/CodeGen/CGValue.h Index: clang/lib/CodeGen/CGValue

[PATCH] D72820: [FPEnv] Add pragma FP_CONTRACT support under strict FP.

kpn added inline comments. Comment at: clang/lib/CodeGen/CGExprScalar.cpp:3381 + "constrained mode"); +FMulAdd = Builder.CreateCall( +CGF.CGM.getIntrinsic(llvm::Intrinsic::experimental_constrained_fmuladd, craig.topper wrote: > kpn wrote: >

[PATCH] D72829: Implement -fsemantic-interposition

MaskRay added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:2685 + if (Args.hasArg(OPT_fsemantic_interposition)) +Opts.SemanticInterposition = 1; + ` Opts.SemanticInterposition = Args.hasArg(OPT_fsemantic_interposition);` =

[PATCH] D73363: Verify that clang's max alignment is <= LLVM's max alignment

lebedev.ri accepted this revision. lebedev.ri added a comment. This revision is now accepted and ready to land. SGTM, thank you. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73363/new/ https://reviews.llvm.org/D73363 ___

[PATCH] D73367: [clangd] Go-to-definition on 'override' jumps to overridden method(s)

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D73367 Files: clang-tools-extra/cla

[PATCH] D73369: [clangd] Simplify "preferred" vs "definition" logic a bit in XRefs AST code.

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Now Preferred is always the canonical (first) decl, Definition is always the def if available. In pra

[PATCH] D72630: [clang-tidy] Ignore implicit casts in modernize-use-default-member-init

hans added a comment. Ah, you're right, it's there. The reason for my comment was http://lists.llvm.org/pipermail/llvm-branch-commits/2020-January/013555.html but it seems it was also successfully pushed to master. Sorry for the noise. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] 0d61cd2 - Verify that clang's max alignment is <= LLVM's max alignment

Author: David Zarzycki Date: 2020-01-24T12:37:05-05:00 New Revision: 0d61cd25a6927a7700bfb1636faca1ef16c46428 URL: https://github.com/llvm/llvm-project/commit/0d61cd25a6927a7700bfb1636faca1ef16c46428 DIFF: https://github.com/llvm/llvm-project/commit/0d61cd25a6927a7700bfb1636faca1ef16c46428.diff

[PATCH] D73300: [clang-tidy] Add library for clang-tidy main function

DmitryPolukhin updated this revision to Diff 240233. DmitryPolukhin added a comment. Updated comment per review suggestion. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73300/new/ https://reviews.llvm.org/D73300 Files: clang-tools-extra/clang-t

[PATCH] D73363: Verify that clang's max alignment is <= LLVM's max alignment

This revision was automatically updated to reflect the committed changes. Closed by commit rG0d61cd25a692: Verify that clang's max alignment is <= LLVM's max alignment (authored by davezarzycki). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73363/ne

[PATCH] D73307: Unique Names for Functions with Internal Linkage

tmsriram marked an inline comment as done. tmsriram added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp: + this->getFunctionLinkage(GD) == llvm::GlobalValue::InternalLinkage) { +std::string UniqueSuffix = getUniqueModuleId(&getModule(), true); +

[PATCH] D73322: [WebAssembly] Update bleeding-edge CPU features

tlively accepted this revision. tlively added a comment. This revision is now accepted and ready to land. Sounds good to me! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73322/new/ https://reviews.llvm.org/D73322 ___

[PATCH] D73367: [clangd] Go-to-definition on 'override' jumps to overridden method(s)

merge_guards_bot added a comment. {icon times-circle color=red} Unit tests: fail. 62170 tests passed, 5 failed and 813 were skipped. failed: libc++.std/language_support/cmp/cmp_partialord/partialord.pass.cpp failed: libc++.std/language_support/cmp/cmp_strongeq/cmp.strongeq.pass.cpp failed:

[PATCH] D71092: [VFS] More consistent support for Windows

amccarth updated this revision to Diff 240240. amccarth retitled this revision from "[VFS] Use path canonicalization on all paths" to "[VFS] More consistent support for Windows". amccarth edited the summary of this revision. Herald added a subscriber: ormris. CHANGES SINCE LAST ACTION https://r

[PATCH] D73369: [clangd] Simplify "preferred" vs "definition" logic a bit in XRefs AST code.

merge_guards_bot added a comment. {icon times-circle color=red} Unit tests: fail. 62173 tests passed, 5 failed and 815 were skipped. failed: libc++.std/language_support/cmp/cmp_partialord/partialord.pass.cpp failed: libc++.std/language_support/cmp/cmp_strongeq/cmp.strongeq.pass.cpp failed:

[PATCH] D72467: Remove "mask" operand from shufflevector.

efriedma marked 5 inline comments as done. efriedma added a comment. In D72467#1838591 , @spatel wrote: > LGTM, but should get a 2nd opinion since I'm not familiar with some of the > parts. Any specific part you're worried about? Com

[PATCH] D71092: [VFS] More consistent support for Windows

amccarth added a comment. cc: +thakis, who expressed interest in seeing a fix for the text exempted on Windows. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71092/new/ https://reviews.llvm.org/D71092 ___ cfe-commits mailing list cfe-commi

[PATCH] D73307: Unique Names for Functions with Internal Linkage

tmsriram marked an inline comment as done. tmsriram added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:966 OPT_fno_unique_section_names, true); + Opts.UniqueInternalFuncNames = Args.hasFlag( + OPT_funique_i

[PATCH] D73300: [clang-tidy] Add library for clang-tidy main function

DmitryPolukhin updated this revision to Diff 240241. DmitryPolukhin added a comment. Added #include "ClangTidyMain.h" in ClangTidyMain.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73300/new/ https://reviews.llvm.org/D73300 Files: clang-tool

[PATCH] D72222: [Driver][CodeGen] Add -fpatchable-function-entry=N[,0]

MaskRay added a comment. In D7#1838988 , @mrutland wrote: > In D7#1837536 , @MaskRay wrote: > > > > > > > > > For `BTI c` issue, GCC has several releases that do not work with > > -mbranch-protection=bti. T

[PATCH] D73007: [Sema] Avoid Wrange-loop-analysis false positives

hans added a comment. In D73007#1837621 , @rtrieu wrote: > I'm in favor of splitting the warning into subgroups, then deciding which > ones should be in -Wall. We've done this with other warnings such as the > conversion warnings and tautological compar

[clang] c5bd3d0 - Support Swift calling convention for WebAssembly targets

Author: Yuta Saito Date: 2020-01-24T10:30:46-08:00 New Revision: c5bd3d07262ffda5b21576b9e1e2d2dd2e51fb4b URL: https://github.com/llvm/llvm-project/commit/c5bd3d07262ffda5b21576b9e1e2d2dd2e51fb4b DIFF: https://github.com/llvm/llvm-project/commit/c5bd3d07262ffda5b21576b9e1e2d2dd2e51fb4b.diff LO

[PATCH] D73237: [CUDA] Fix order of memcpy arguments in __shfl_*(<64-bit type>).

hans added a comment. In D73237#1837077 , @tra wrote: > Landed in > https://github.com/llvm/llvm-project/commit/cc14de88da27a8178976972bdc8211c31f7ca9ae > @hans -- can we cherry-pick it into 10? Yes, go ahead and "git cherry-pick -x" it and push to the

[PATCH] D71823: Support Swift calling convention for WebAssembly targets

This revision was automatically updated to reflect the committed changes. Closed by commit rGc5bd3d07262f: Support Swift calling convention for WebAssembly targets (authored by kateinoigakukun, committed by dschuff). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[PATCH] D72467: Remove "mask" operand from shufflevector.

spatel added a comment. In D72467#1839172 , @efriedma wrote: > In D72467#1838591 , @spatel wrote: > > > LGTM, but should get a 2nd opinion since I'm not familiar with some of the > > parts. > > > Any specific part

[PATCH] D72841: [RFC] Add support for pragma float_control, to control precision and exception behavior at the source level

mibintc updated this revision to Diff 240245. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72841/new/ https://reviews.llvm.org/D72841 Files: clang/docs/LanguageExtensions.rst clang/include/clang/AST/Stmt.h clang/include/clang/Basic/Diagnostic

[PATCH] D72906: [X86] Improve X86 cmpps/cmppd/cmpss/cmpsd intrinsics with strictfp

craig.topper added a comment. In D72906#1838532 , @uweigand wrote: > In D72906#1837905 , @craig.topper > wrote: > > > In D72906#1826849 , @uweigand > > wrote: > > > > > In

[PATCH] D72841: [RFC] Add support for pragma float_control, to control precision and exception behavior at the source level

mibintc marked 3 inline comments as done. mibintc added a comment. In D72841#1833022 , @sepavloff wrote: > I don't see tests for correctness of the pragma stack (`pragma > float_control(... push)`, `pragma float_control(pop)`). Can you add them? I added

[PATCH] D73307: Unique Names for Functions with Internal Linkage

tmsriram updated this revision to Diff 240249. tmsriram added a comment. Use Hash of Module's source file name directly. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73307/new/ https://reviews.llvm.org/D73307 Files: clang/include/clang/Basic/CodeGenOptions.def clang/include/clang/

[PATCH] D73307: Unique Names for Functions with Internal Linkage

tmsriram updated this revision to Diff 240253. tmsriram added a comment. Remove an unnecessary header file inclusion. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73307/new/ https://reviews.llvm.org/D73307 Files: clang/include/clang/Basic/CodeGenOptions.def clang/include/clang/Dri

[clang] 698d1cd - Make address-space-lambda.cl pass on 32-bit Windows

Author: Hans Wennborg Date: 2020-01-24T20:35:25+01:00 New Revision: 698d1cd3b8154b3b74423386d3e111e6b756e87a URL: https://github.com/llvm/llvm-project/commit/698d1cd3b8154b3b74423386d3e111e6b756e87a DIFF: https://github.com/llvm/llvm-project/commit/698d1cd3b8154b3b74423386d3e111e6b756e87a.diff

[PATCH] D70926: [clang-format] Add option for not breaking line before ObjC params

ghvg1313 marked 2 inline comments as done. ghvg1313 added inline comments. Comment at: clang/docs/ReleaseNotes.rst:164 + +- Clang-format now supports JavaScript null operators. + MyDeveloperDay wrote: > is this line part of this patch? No, rebased again and got r

[PATCH] D73028: Extract ExprTraversal class from Expr

aaron.ballman added a comment. This looks like it's an NFC patch where the only change is to hoist this functionality out into its own interface. Is that correct? If so, can you please be sure to add NFC to the commit log? Comment at: clang/include/clang/AST/ExprTraversal.h:9

[PATCH] D70926: [clang-format] Add option for not breaking line before ObjC params

ghvg1313 updated this revision to Diff 240260. ghvg1313 marked an inline comment as done. ghvg1313 added a comment. - rebase master Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70926/new/ https://reviews.llvm.org/D70926 Files: clang/docs/Clan

[PATCH] D73029: Extend ExprTraversal class with acending traversal

aaron.ballman added a comment. Test cases? Comment at: clang/lib/AST/ASTContext.cpp:1066 +if (Node.getNodeKind().hasPointerIdentity()) { + auto ParentList = + getDynNodeFromMap(Node.getMemoizationData(), PointerParents); Please spell the type

[PATCH] D73028: Extract ExprTraversal class from Expr

rsmith added a comment. > An addition to the API will be concerned with ascending through the AST in > different traversal modes. Ascending through the AST is not possibly by design. (For example, we share AST nodes between template instantiations, and statement nodes don't contain parent poin

[clang-tools-extra] 58592f6 - Include for std::abort() in clangd

Author: Dimitry Andric Date: 2020-01-24T20:52:37+01:00 New Revision: 58592f6c49249293f79698cfcb31dba532e12603 URL: https://github.com/llvm/llvm-project/commit/58592f6c49249293f79698cfcb31dba532e12603 DIFF: https://github.com/llvm/llvm-project/commit/58592f6c49249293f79698cfcb31dba532e12603.diff

[PATCH] D73037: Add a way to set traversal mode in clang-query

aaron.ballman added a comment. There should also be a mention of this in the release notes (especially if the default behavior winds up changing). Comment at: clang-tools-extra/clang-query/Query.cpp:51 +"IgnoreImplicitCastsAndParentheses" +" Omit implicit

[PATCH] D73376: [analyzer] Add FuchsiaLockChecker and C11LockChecker

xazax.hun created this revision. xazax.hun added reviewers: NoQ, haowei. xazax.hun added a project: clang. Herald added subscribers: Charusso, gamesh411, dkrupp, donat.nagy, Szelethus, jfb, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware. Basically, the semantics of C11 and Fuchs

[PATCH] D71566: New checks for fortified sprintf

aaron.ballman added a comment. Continues to LG, do you need me to commit on your behalf? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71566/new/ https://reviews.llvm.org/D71566 ___ cfe-commits mailing

[PATCH] D73028: Extract ExprTraversal class from Expr

steveire updated this revision to Diff 240267. steveire added a comment. Update for review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73028/new/ https://reviews.llvm.org/D73028 Files: clang/include/clang/AST/Expr.h clang/include/cl

[PATCH] D73028: Extract ExprTraversal class from Expr

steveire updated this revision to Diff 240269. steveire marked an inline comment as done. steveire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73028/new/ https://reviews.llvm.org/D73028 Files: clang/include/clang/AST/Ex

[PATCH] D72675: [Clang][Driver] Fix -ffast-math/-ffp-contract interaction

wristow added a comment. > A separate question is the interaction of `-ffast-math` with > `-ffp-contract=`. Currently, there is no such interaction whatsoever in GCC: > `-ffast-math` does not imply any particular `-ffp-contract=` setting, and > vice versa the `-ffp-contract=` setting is not co

[PATCH] D73028: Extract ExprTraversal class from Expr

steveire added a comment. In D73028#1839383 , @rsmith wrote: > > An addition to the API will be concerned with ascending through the AST in > > different traversal modes. > > Ascending through the AST is not possibly by design. (For example, we share > A

[PATCH] D71600: PowerPC 32-bit - forces 8 byte lock/lock_free decisions at compiled time

dim added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:11180 +// Avoid emiting call for runtime decision on PowerPC 32-bit +// The lock free possibilities on this platform are covered by the lines `s/emiting/emitting/` Repository: r

[clang-tools-extra] 3f8b100 - [clang-tidy] Add library for clang-tidy main function

Author: Dmitry Polukhin Date: 2020-01-24T13:00:45-08:00 New Revision: 3f8b100e94b5c848843fa91c9782d9d4df4bb026 URL: https://github.com/llvm/llvm-project/commit/3f8b100e94b5c848843fa91c9782d9d4df4bb026 DIFF: https://github.com/llvm/llvm-project/commit/3f8b100e94b5c848843fa91c9782d9d4df4bb026.dif

[PATCH] D72811: [WIP][OPENMP5.0] allow lvalue for motion clause

cchen marked an inline comment as done. cchen added a comment. In D72811#1837392 , @jdoerfert wrote: > Thanks for working on this! While you are at it, `*this` is probably one of > the most important ones to test and support. Can anyone tell me how to g

[PATCH] D72811: [WIP][OPENMP5.0] allow lvalue for motion clause

cchen marked an inline comment as done. cchen added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:15235 + bool VisitUnaryOperator(UnaryOperator *UO) { +DerefCnt++; +CurComponents.emplace_back(UO, nullptr); cchen wrote: > ABataev wrote: > > N

[PATCH] D73300: [clang-tidy] Add library for clang-tidy main function

This revision was automatically updated to reflect the committed changes. Closed by commit rG3f8b100e94b5: [clang-tidy] Add library for clang-tidy main function (authored by DmitryPolukhin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73300/new/ h

[PATCH] D72811: [WIP][OPENMP5.0] allow lvalue for motion clause

ABataev added a comment. In D72811#1839538 , @cchen wrote: > In D72811#1837392 , @jdoerfert wrote: > > > Thanks for working on this! While you are at it, `*this` is probably one of > > the most important ones to te

[PATCH] D72811: [WIP][OPENMP5.0] allow lvalue for motion clause

cchen marked an inline comment as done. cchen added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:15235 + bool VisitUnaryOperator(UnaryOperator *UO) { +DerefCnt++; +CurComponents.emplace_back(UO, nullptr); ABataev wrote: > cchen wrote: > > c

[PATCH] D73029: Extend ExprTraversal class with acending traversal

rsmith added a comment. We're working on moving the parent map out of `ASTContext` and into something specific to tooling; please don't add more dependencies onto it in the AST library. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73029/new/ htt

[PATCH] D73028: Extract ExprTraversal class from Expr

rsmith added a comment. In D73028#1839494 , @steveire wrote: > In D73028#1839383 , @rsmith wrote: > > > > > > The follow-up is here: https://reviews.llvm.org/D73029 . > > I have the need to change the ascending trav

[PATCH] D73380: [clang] Annotating C++'s `operator new` with more attributes

lebedev.ri created this revision. lebedev.ri added reviewers: rsandifo, erichkeane, rjmccall, jdoerfert, eugenis. lebedev.ri added a project: LLVM. Herald added subscribers: atanasyan, jrtc27. Herald added a project: clang. lebedev.ri added a parent revision: D73020: [Sema] Perform call checking wh

[PATCH] D73028: Extract ExprTraversal class from Expr

aaron.ballman added a comment. In D73028#1839572 , @rsmith wrote: > In D73028#1839494 , @steveire wrote: > > > In D73028#1839383 , @rsmith wrote: > > > > > > > > > > > The fo

[PATCH] D73380: [clang] Annotating C++'s `operator new` with more attributes

xbolva00 added a comment. LLVM already infers noalias nonnull for eg. _Znwm so noalias and nonnull info added by clang will not increase power of LLVM. Or? Alignment info is useful I think. Comment at: clang/test/CodeGenCXX/builtin-operator-new-delete.cpp:54 } -// CHECK: dec

[clang] 8a81daa - [AST] Split parent map traversal logic into ParentMapContext.h

Author: Reid Kleckner Date: 2020-01-24T13:42:28-08:00 New Revision: 8a81daaa8b58aeaa192a47c4ce7f94b4d59ce082 URL: https://github.com/llvm/llvm-project/commit/8a81daaa8b58aeaa192a47c4ce7f94b4d59ce082 DIFF: https://github.com/llvm/llvm-project/commit/8a81daaa8b58aeaa192a47c4ce7f94b4d59ce082.diff

[PATCH] D71313: [AST] Split parent map traversal logic into ParentMapContext.h

This revision was automatically updated to reflect the committed changes. Closed by commit rG8a81daaa8b58: [AST] Split parent map traversal logic into ParentMapContext.h (authored by rnk). Changed prior to commit: https://reviews.llvm.org/D71313?vs=240050&id=240283#toc Repository: rG LLVM Gi

[PATCH] D73380: [clang] Annotating C++'s `operator new` with more attributes

lebedev.ri marked 2 inline comments as done. lebedev.ri added a comment. In D73380#1839603 , @xbolva00 wrote: > LLVM already infers noalias nonnull for eg. _Znwm so noalias and nonnull info > added by clang will not increase power of LLVM. Or? To be hon

[PATCH] D73028: Extract ExprTraversal class from Expr

steveire added a comment. In D73028#1839572 , @rsmith wrote: > In D73028#1839494 , @steveire wrote: > > > In D73028#1839383 , @rsmith wrote: > > > > > > > > > > > The follow-

[PATCH] D73007: [Sema] Avoid Wrange-loop-analysis false positives

aaronpuchert added a comment. Here is a proposal: we add two children to `-Wrange-loop-analysis`. - `-Wrange-loop-construct` warns about possibly unintended constructor calls. This might be in `-Wall`. It contains - `warn_for_range_copy`: loop variable A of type B creates a copy from type C

[PATCH] D71566: New checks for fortified sprintf

serge-sans-paille added a comment. In D71566#1839462 , @aaron.ballman wrote: > Continues to LG, do you need me to commit on your behalf? I was waiting for a last LG as I did some changes, thanks for all the quick iteration, I **really** enjoyed working

[PATCH] D71973: [clang-tidy] Add bugprone-suspicious-memory-comparison check

gbencze added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71973/new/ https://reviews.llvm.org/D71973 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D72675: [Clang][Driver] Fix -ffast-math/-ffp-contract interaction

andrew.w.kaylor added a comment. In D72675#1839492 , @wristow wrote: > 1. Should we enable FMA "by default" at (for example) '-O2'? We recently introduced a new option "-ffp-model=[precise|fast|strict], which is supposed to serve as an umbrella option f

[clang] 764f408 - [WebAssembly] Add reference types target feature

Author: Heejin Ahn Date: 2020-01-24T14:26:27-08:00 New Revision: 764f4089e89e4693b7bb8f1ee18080703ce760dd URL: https://github.com/llvm/llvm-project/commit/764f4089e89e4693b7bb8f1ee18080703ce760dd DIFF: https://github.com/llvm/llvm-project/commit/764f4089e89e4693b7bb8f1ee18080703ce760dd.diff LO

[PATCH] D73320: [WebAssembly] Add reference types target feature

This revision was automatically updated to reflect the committed changes. Closed by commit rG764f4089e89e: [WebAssembly] Add reference types target feature (authored by aheejin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73320/new/ https://revie

[clang] 65eb113 - [WebAssembly] Update bleeding-edge CPU features

Author: Heejin Ahn Date: 2020-01-24T14:27:35-08:00 New Revision: 65eb11306e921bb0299100dfc61e79858f903c1b URL: https://github.com/llvm/llvm-project/commit/65eb11306e921bb0299100dfc61e79858f903c1b DIFF: https://github.com/llvm/llvm-project/commit/65eb11306e921bb0299100dfc61e79858f903c1b.diff LO

[PATCH] D73322: [WebAssembly] Update bleeding-edge CPU features

This revision was automatically updated to reflect the committed changes. Closed by commit rG65eb11306e92: [WebAssembly] Update bleeding-edge CPU features (authored by aheejin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73322/new/ https://review

[PATCH] D73307: Unique Names for Functions with Internal Linkage

pcc added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:1117 +llvm::MD5::stringifyResult(R, Str); +std::string UniqueSuffix = (".$" + Str).str(); +MangledName = MangledName + UniqueSuffix; Why `".$"` and not just `"."`? CHANGES SI

[PATCH] D73307: Unique Names for Functions with Internal Linkage

tmsriram marked an inline comment as done. tmsriram added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:1117 +llvm::MD5::stringifyResult(R, Str); +std::string UniqueSuffix = (".$" + Str).str(); +MangledName = MangledName + UniqueSuffix;

[PATCH] D72970: clang: Only define OBJC_NEW_PROPERTIES when -x objective-c

dexonsmith closed this revision. dexonsmith added a comment. Thanks, committed in 1e487e4c16821b6de3d651f618274df90bd3fad9 . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72970/new/ https://reviews.llvm.org/D72970

[PATCH] D73307: Unique Names for Functions with Internal Linkage

MaskRay added inline comments. Comment at: clang/include/clang/Driver/Options.td:1959 +def fno_unique_internal_funcnames : Flag <["-"], "fno-unique-internal-funcnames">, + Group, Flags<[CC1Option]>; + `, Flags<[CC1Option]>` can be deleted. Co

[clang] 1e487e4 - clang: Only define OBJC_NEW_PROPERTIES when -x objective-c

Author: Duncan P. N. Exon Smith Date: 2020-01-24T14:55:12-08:00 New Revision: 1e487e4c16821b6de3d651f618274df90bd3fad9 URL: https://github.com/llvm/llvm-project/commit/1e487e4c16821b6de3d651f618274df90bd3fad9 DIFF: https://github.com/llvm/llvm-project/commit/1e487e4c16821b6de3d651f618274df90bd3

[PATCH] D73237: [CUDA] Fix order of memcpy arguments in __shfl_*(<64-bit type>).

tra added a comment. In D73237#1839216 , @hans wrote: > In D73237#1837077 , @tra wrote: > > > Landed in > > https://github.com/llvm/llvm-project/commit/cc14de88da27a8178976972bdc8211c31f7ca9ae > > @hans -- can we

[PATCH] D73151: [analyzer] Fix handle leak false positive when the handle dies too early

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/FuchsiaHandleChecker.cpp:133-135 + static HandleState getWithoutError(HandleState S) { +return HandleState(S.K, nullptr); + } It already makes me mildly uncomfortable that our data is

[PATCH] D72675: [Clang][Driver] Fix -ffast-math/-ffp-contract interaction

wristow added a comment. In D72675#1839662 , @andrew.w.kaylor wrote: > In D72675#1839492 , @wristow wrote: > > > 1. Should we enable FMA "by default" at (for example) '-O2'? > > > We recently introduced a new optio

[PATCH] D72675: [Clang][Driver] Fix -ffast-math/-ffp-contract interaction

wristow updated this revision to Diff 240305. wristow added a comment. Update a comment to remove the discussion about enabling the `__FAST_MATH__` preprocessor macro. The handling of the setting of `__FAST_MATH__` is done in "clang/lib/Frontend/InitPreprocessor.cpp", and once we decide on the

[PATCH] D73385: [Sema] Split availability processing into SemaAvailability.cpp

rnk created this revision. rnk added reviewers: arphaman, aaron.ballman, rsmith. Herald added subscribers: dexonsmith, mgorny. Herald added a project: clang. Reduces compile time of SemaDeclAttr.cpp down to 28s from 50s. The new TU does a few RecursiveASTVisitor instantiations, so it takes 30s.

[PATCH] D73151: [analyzer] Fix handle leak false positive when the handle dies too early

xazax.hun marked 2 inline comments as done. xazax.hun added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/FuchsiaHandleChecker.cpp:133-135 + static HandleState getWithoutError(HandleState S) { +return HandleState(S.K, nullptr); + } NoQ wrot

[PATCH] D73307: Unique Names for Functions with Internal Linkage

tmsriram updated this revision to Diff 240312. tmsriram added a comment. Minor changes. Remove CC1option on "-fno", Remove "$" from unique suffix. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73307/new/ https://reviews.llvm.org/D73307 Files: clang/include/clang/Basic/CodeGenOptions

[PATCH] D73376: [analyzer] Add FuchsiaLockChecker and C11LockChecker

NoQ added a comment. Yay, C11 as well!! > If you have any idea how to reduce this boilerplate I'd like to know :) I don't see any immediate solutions to the boilerplate that don't consist in introducing better checker APIs. Eg., we could have introduced a `LazyBugType` - a wrapper around `Opti

<    1   2   3   >