wristow added a comment. In D72675#1839662 <https://reviews.llvm.org/D72675#1839662>, @andrew.w.kaylor wrote:
> In D72675#1839492 <https://reviews.llvm.org/D72675#1839492>, @wristow wrote: > > > 1. Should we enable FMA "by default" at (for example) '-O2'? > > > We recently introduced a new option "-ffp-model=[precise|fast|strict], which > is supposed to serve as an umbrella option for the most common combination of > options. I think our default behavior should be equivalent to > -ffp-model=precise, which enables contraction. It currently seems to enable > -ffp-contract=fast in the precise model (https://godbolt.org/z/c6w8mJ). I'm > not sure that's what it should be doing, but whatever the precise model does > should be our default. That makes sense to me. So `-ffp-model`/`-ffp-contract` interaction should be examined, and possibly adjusted. If an adjustment is needed, I think it makes sense to handle that interaction separately. I'm going to update this patch to adjust the comment that @spatel and I discussed earlier <https://reviews.llvm.org/D72675#1829391>, so it no longer implies that `__FAST_MATH__` is defined only when "all of" `-ffast-math` is enabled. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72675/new/ https://reviews.llvm.org/D72675 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
