[PATCH] D73219: [objc_direct] do not add direct properties to the serialization array

MadCoder marked 2 inline comments as done. MadCoder added inline comments. Comment at: clang/lib/CodeGen/CGObjCMac.cpp:3316-3319 else if (const ObjCCategoryDecl *CD = dyn_cast(OCD)) { for (const auto *P : CD->protocols()) PushProtocolProperties(PropertySet, Propert

[PATCH] D72959: Relative VTables ABI on Fuchsia

rjmccall added a comment. Okay. In that case, I would ask that if you're considering going through the work of adding relocations, please consider adding both scaled and unscaled relative-offset-to-equivalent-symbol. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[PATCH] D68520: [cmake] Fix clang builds with BUILD_SHARED=ON and CLANG_LINK_CLANG_DYLIB=ON

tstellar updated this revision to Diff 239919. tstellar marked 2 inline comments as done. tstellar added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68520/new/ https://reviews.llvm.org/D68520 Files: clang/too

[PATCH] D68520: [cmake] Fix clang builds with BUILD_SHARED=ON and CLANG_LINK_CLANG_DYLIB=ON

tstellar added inline comments. Comment at: clang/tools/clang-shlib/CMakeLists.txt:28 +foreach(lib ${interface}) + string(REGEX MATCH "^clang" is_clang_lib ${lib}) + if (NOT is_clang_lib) mgorny wrote: > Any reason not to use `if(${lib} MATCHES ...)

[clang] e256a77 - clang-cl: Parse /QIntel-jcc-erratum

Author: Hans Wennborg Date: 2020-01-23T18:00:38+01:00 New Revision: e256a775ebfcda5fd5f4d05fe40f6bb029e88f29 URL: https://github.com/llvm/llvm-project/commit/e256a775ebfcda5fd5f4d05fe40f6bb029e88f29 DIFF: https://github.com/llvm/llvm-project/commit/e256a775ebfcda5fd5f4d05fe40f6bb029e88f29.diff

[PATCH] D73257: [AST] Compress the FixedPointSemantics type better.

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Thanks, LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73257/new/ https://reviews.llvm.org/D73257 __

[PATCH] D73186: [AST] Add fixed-point multiplication constant evaluation.

rjmccall added inline comments. Comment at: clang/lib/Basic/FixedPoint.cpp:242 + } else +Overflowed = Result < Min || Result > Max; + ebevhan wrote: > ebevhan wrote: > > rjmccall wrote: > > > If the maximum expressible value is *k*, and the fully-precise >

[PATCH] D73185: [AST] Add fixed-point subtraction constant evaluation.

rjmccall accepted this revision. rjmccall added a comment. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73185/new/ https://reviews.llvm.org/D73185 ___ cfe-commits mailing list cfe-commits@lists.

[PATCH] D73219: [objc_direct] do not add direct properties to the serialization array

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73219/new/ https://reviews.llvm.org/D73219 __

[PATCH] D72994: [Sema] Sanity-check alignment requested via `__attribute__((assume_aligned(imm)))`

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. LGTM. note to other reviewers, D72998 fixes the max alignment constant in this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[clang] 5911268 - [analyzer] Improve FuchsiaHandleChecker's diagnostic messages

Author: Gabor Horvath Date: 2020-01-23T09:16:40-08:00 New Revision: 5911268e441cc78f7c81f931dd64ed2c63078e8e URL: https://github.com/llvm/llvm-project/commit/5911268e441cc78f7c81f931dd64ed2c63078e8e DIFF: https://github.com/llvm/llvm-project/commit/5911268e441cc78f7c81f931dd64ed2c63078e8e.diff

[PATCH] D73229: [analyzer] Improve FuchsiaHandleChecker's diagnostic messages

This revision was automatically updated to reflect the committed changes. Closed by commit rG5911268e441c: [analyzer] Improve FuchsiaHandleChecker's diagnostic messages (authored by xazax.hun). Changed prior to commit: https://reviews.llvm.org/D73229?vs=239698&id=239924#toc Repository: rG LL

[PATCH] D73120: [Clang] Alternate fix for "expansion of response files in -Wp after integrated-cc1 change"

hans added a comment. Cherry-picked to 10.x in 85ee70e86456e3bcb3c706c404db497c5a448602 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73120/new/ https://reviews.llvm.org/D73120

[PATCH] D73005: [Codegen] If reasonable, materialize clang's `AssumeAlignedAttr` as llvm's Alignment Attribute on call-site function return value

erichkeane added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:3836 + + llvm::Value *Alignment;// May or may not be a constant. + llvm::ConstantInt *OffsetCI = nullptr; // Constant, hopefully zero. Does this need an initial value?

[PATCH] D73270: [clang-tidy] Fix false positive in bugprone-infinite-loop

gribozavr2 added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/InfiniteLoopCheck.cpp:186 +} + } + I think this logic should go into `isChanged()`, similarly to how it handles for loops today. Comment at: clang-tools-e

[PATCH] D73019: [Sema] Don't disallow placing `__attribute__((alloc_align(param_idx)))` on `std::align_val_t`-typed parameters

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. This makes a lot of sense to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73019/new/ https://reviews.llvm.org/D73019 ___

[PATCH] D73271: [clang][CodeComplete] Support for designated initializers

sammccall added a comment. oops, needs some more tests. Comment at: clang/lib/Parse/ParseDecl.cpp:2463 +PreferredType.enterVariableInit(Tok.getLocation(), ThisDecl); ExprResult Init(ParseBraceInitializer()); oops, I missed where this was happening.

[PATCH] D71566: New checks for fortified sprintf

serge-sans-paille updated this revision to Diff 239920. serge-sans-paille added a comment. clang-format update. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71566/new/ https://reviews.llvm.org/D71566 Files: clang/include/clang/Basic/DiagnosticS

[PATCH] D73005: [Codegen] If reasonable, materialize clang's `AssumeAlignedAttr` as llvm's Alignment Attribute on call-site function return value

lebedev.ri marked 5 inline comments as done. lebedev.ri added a comment. Thank you for taking a look! Comment at: clang/lib/CodeGen/CGCall.cpp:3836 + + llvm::Value *Alignment;// May or may not be a constant. + llvm::ConstantInt *OffsetCI = nullptr; // Constant

[PATCH] D73270: [clang-tidy] Fix false positive in bugprone-infinite-loop

baloghadamsoftware marked 2 inline comments as done. baloghadamsoftware added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/InfiniteLoopCheck.cpp:186 +} + } + gribozavr2 wrote: > I think this logic should go into `isChanged()`, similarly

[PATCH] D72829: Implement -fsemantic-interposition

MaskRay added a comment. In D72829#1835933 , @serge-sans-paille wrote: > Add Release note and doc. @MaskRay can you confirm current state is ok? I feel that we are still behind a complete `-fsemantic-interposition`... I don't know whether we should men

[PATCH] D72993: [NFC][Codegen] Use MaybeAlign + APInt::getLimitedValue() when creating Alignment attr

lebedev.ri added a comment. In D72993#1828934 , @gchatelet wrote: > Thx! Thank you for the review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72993/new/ https://reviews.llvm.org/D72993 _

[PATCH] D72979: [Codegen] Emit both AssumeAlignedAttr and AllocAlignAttr assumptions if they exist

lebedev.ri added a comment. Thank you for the review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72979/new/ https://reviews.llvm.org/D72979 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

[PATCH] D72994: [Sema] Sanity-check alignment requested via `__attribute__((assume_aligned(imm)))`

lebedev.ri added a comment. In D72994#1836495 , @erichkeane wrote: > LGTM. note to other reviewers, D72998 > fixes the max alignment constant in this. Thank you for the review! Repository: rG LLVM Github Monorepo

[PATCH] D72996: [Sema] Attempt to perform call-size-specific `__attribute__((alloc_align(param_idx)))` validation

lebedev.ri added a comment. Thank you for the review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72996/new/ https://reviews.llvm.org/D72996 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

[PATCH] D72222: [Driver][CodeGen] Add -fpatchable-function-entry=N[,0]

MaskRay added a subscriber: hans. MaskRay added a comment. In D7#1836409 , @peter.smith wrote: > Although this particular commit will not be at fault, it is the option that > enables the feature which is the earliest I can bisect the fault to. There

[PATCH] D73270: [clang-tidy] Fix false positive in bugprone-infinite-loop

baloghadamsoftware updated this revision to Diff 239927. baloghadamsoftware added a comment. Updated according to the comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73270/new/ https://reviews.llvm.org/D73270 Files: clang-tools-extra/clang-tidy/bugprone/InfiniteLoopCheck.cpp

[PATCH] D72998: [IR] Attribute/AttrBuilder: use Value::MaximumAlignment magic constant

lebedev.ri added a comment. Thank you for the reviews! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72998/new/ https://reviews.llvm.org/D72998 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

[PATCH] D73006: [Codegen] If reasonable, materialize clang's `AllocAlignAttr` as llvm's Alignment Attribute on call-site function return value

lebedev.ri updated this revision to Diff 239930. lebedev.ri added a comment. Rebased, NFC. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73006/new/ https://reviews.llvm.org/D73006 Files: clang/lib/CodeGen/CGCall.cpp clang/test/CodeGen/assume-a

[PATCH] D73019: [Sema] Don't disallow placing `__attribute__((alloc_align(param_idx)))` on `std::align_val_t`-typed parameters

lebedev.ri added a comment. In D73019#1836529 , @erichkeane wrote: > This makes a lot of sense to me. Thank you for the review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73019/new/ https://reviews.llv

[PATCH] D73005: [Codegen] If reasonable, materialize clang's `AssumeAlignedAttr` as llvm's Alignment Attribute on call-site function return value

lebedev.ri added a comment. Thank you for the review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73005/new/ https://reviews.llvm.org/D73005 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

[PATCH] D73278: [clangd] Type: ⇨ ∈; 🡺 ⇨ →

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. The blocky arrow is a fairly obscure character, and a couple of fonts I checked don't have it :-( "Ty

[PATCH] D67678: PR17164: Change clang's default behavior from -flax-vector-conversions=all to -flax-vector-conversions=integer.

steven_wu added a subscriber: dexonsmith. steven_wu added a comment. In D67678#1834957 , @rsmith wrote: > In D67678#1834542 , @steven_wu wrote: > > > @rsmith This also breaks macOS SDK. Can we revert this as we disc

[PATCH] D72222: [Driver][CodeGen] Add -fpatchable-function-entry=N[,0]

peter.smith added a comment. >> If the patchable functions is intended for clang-10 we'll need to make sure >> any fix is merged to clang-10. > > This commit was made before release/10.x branch. Maybe the easiest thing is > to revert the driver change in release/10.x (CC @hans), before we had a

[PATCH] D72222: [Driver][CodeGen] Add -fpatchable-function-entry=N[,0]

nickdesaulniers added a comment. In D7#1836610 , @MaskRay wrote: > In D7#1836409 , @peter.smith > wrote: > > > Although this particular commit will not be at fault, it is the option that > > enables the fe

[PATCH] D72222: [Driver][CodeGen] Add -fpatchable-function-entry=N[,0]

peter.smith added a comment. >> @peter.smith @nickdesaulniers What do you think? > > Revert on the 10.0 release sounds reasonable to me. That would prevent the > kernel from enabling the option and would prevent the build failure. I should have been clearer, apologies; we're not blocked by the

[PATCH] D67678: PR17164: Change clang's default behavior from -flax-vector-conversions=all to -flax-vector-conversions=integer.

dexonsmith added a comment. In D67678#1836628 , @steven_wu wrote: > In D67678#1834957 , @rsmith wrote: > > > In D67678#1834542 , @steven_wu > > wrote: > > > > > @rsmith Th

[PATCH] D72222: [Driver][CodeGen] Add -fpatchable-function-entry=N[,0]

hans added a comment. In D7#1836643 , @peter.smith wrote: > >> If the patchable functions is intended for clang-10 we'll need to make > >> sure any fix is merged to clang-10. > > > > This commit was made before release/10.x branch. Maybe the easiest

[PATCH] D72100: Allow matching "any file" in `VerifyDiagnosticConsumer`.

arames marked 3 inline comments as done. arames added inline comments. Comment at: clang/test/Frontend/verify-any-file.c:4 +#include "verify-any-file.h" +// expected-error@*:1 {{unknown type name 'unexpected'}} +#include "verify-any-file.h" While testing, I reali

[PATCH] D72222: [Driver][CodeGen] Add -fpatchable-function-entry=N[,0]

MaskRay added a comment. In D7#1836645 , @nickdesaulniers wrote: > In D7#1836610 , @MaskRay wrote: > > > In D7#1836409 , @peter.smith > > wrote: > > > > > Altho

[PATCH] D72222: [Driver][CodeGen] Add -fpatchable-function-entry=N[,0]

MaskRay added a comment. In D7#1836669 , @hans wrote: > In D7#1836643 , @peter.smith > wrote: > > > >> If the patchable functions is intended for clang-10 we'll need to make > > >> sure any fix is merged t

[PATCH] D73208: [objc_direct] fix codegen for mismatched Decl/Impl return types

dexonsmith added a comment. In D73208#1835264 , @MadCoder wrote: > In D73208#1835051 , @dexonsmith > wrote: > > > Why isn't a similar dance needed for non-direct methods? > > > because non direct methods do not nee

[PATCH] D73208: [objc_direct] fix codegen for mismatched Decl/Impl return types

MadCoder added a comment. In D73208#1836704 , @dexonsmith wrote: > In D73208#1835264 , @MadCoder wrote: > > > In D73208#1835051 , @dexonsmith > > wrote: > > > > > Why isn't

[PATCH] D72829: Implement -fsemantic-interposition

serge-sans-paille added a comment. > I feel that we are still behind a complete `-fsemantic-interposition`... I > don't know whether we should mention that the option is experimental. So do I. I can mention that in the -help output and in the changelog. Repository: rG LLVM Github Monorepo

[PATCH] D73282: Fix debug-info generation for block invocations so that we set the LinkageName instead of the Name

shafik created this revision. shafik added a reviewer: aprantl. clang has an extension for block invocations whose mangled name starts with `___Z`. Currently when generating debug-info for block invo

[PATCH] D72222: [Driver][CodeGen] Add -fpatchable-function-entry=N[,0]

peter.smith added a comment. In D7#1836703 , @MaskRay wrote: > In D7#1836669 , @hans wrote: > > > In D7#1836643 , @peter.smith > > wrote: > > > > > >> If the pat

[PATCH] D73186: [AST] Add fixed-point multiplication constant evaluation.

ebevhan added inline comments. Comment at: clang/lib/Basic/FixedPoint.cpp:242 + } else +Overflowed = Result < Min || Result > Max; + rjmccall wrote: > ebevhan wrote: > > ebevhan wrote: > > > rjmccall wrote: > > > > If the maximum expressible value is *k*, an

[PATCH] D72703: Add a warning, flags and pragmas to limit the number of pre-processor tokens in a translation unit

hans updated this revision to Diff 239944. hans added a comment. Doing max_tokens_here / max_tokens_total. Please take another look. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72703/new/ https://reviews.llvm.org/D72703 Files: clang/include/clang/Basic/DiagnosticGroups.td clang/

[PATCH] D71566: New checks for fortified sprintf

merge_guards_bot added a comment. {icon times-circle color=red} Unit tests: fail. 62134 tests passed, 9 failed and 811 were skipped. failed: LLVM.MC/AArch64/ete-sysregs.s failed: LLVM.MC/AArch64/trace-regs.s failed: LLVM.MC/Disassembler/AArch64/ete.txt failed: LLVM.MC/Disassembler/AArch6

[PATCH] D73005: [Codegen] If reasonable, materialize clang's `AssumeAlignedAttr` as llvm's Alignment Attribute on call-site function return value

lebedev.ri updated this revision to Diff 239928. lebedev.ri marked 4 inline comments as done. lebedev.ri added a comment. Init `Alignment` to `nullptr` by default. While there, tune `maybeRaiseRetAlignmentAttribute()` to do nothing if new alignment is not greater than the existing alignment. Rep

[PATCH] D73006: [Codegen] If reasonable, materialize clang's `AllocAlignAttr` as llvm's Alignment Attribute on call-site function return value

lebedev.ri added a comment. Thank you for the review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73006/new/ https://reviews.llvm.org/D73006 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

[PATCH] D69868: Allow "callbr" to return non-void values

jyknight added a comment. The idea of moving the copies to a new MachineBasicBlock seems a reasonable solution. That said, it does mean there will be allocatable physical registers which are live-in to the following block, which is generally not allowed. As far as I can tell, I _think_ that sho

[PATCH] D73007: [Sema] Avoid Wrange-loop-analysis false positives

hans added a comment. I've cherry-picked this to 10.x in 318677e78def0023d210a29f4b3cf648e02f9fdc . Please let me know if there are any follow-ups. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[PATCH] D73278: [clangd] Type: ⇨ ∈; 🡺 ⇨ →

merge_guards_bot added a comment. {icon times-circle color=red} Unit tests: fail. 62134 tests passed, 7 failed and 811 were skipped. failed: Clangd.Clangd/hover.test failed: Clangd Unit Tests._/ClangdTests/Hover.Present failed: libc++.std/language_support/cmp/cmp_partialord/partialord.pass

[PATCH] D73208: [objc_direct] fix codegen for mismatched Decl/Impl return types

dexonsmith added a comment. In D73208#1836722 , @MadCoder wrote: > In D73208#1836704 , @dexonsmith > wrote: > > > In D73208#1835264 , @MadCoder > > wrote: > > > > > In D732

[PATCH] D73270: [clang-tidy] Fix false positive in bugprone-infinite-loop

gribozavr2 added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/InfiniteLoopCheck.cpp:186 +} + } + baloghadamsoftware wrote: > gribozavr2 wrote: > > I think this logic should go into `isChanged()`, similarly to how it > > handles for loo

[PATCH] D67678: PR17164: Change clang's default behavior from -flax-vector-conversions=all to -flax-vector-conversions=integer.

hans added a comment. I've cherry-picked the revert (edd4398f4cd33a305afbca76ac4e6590e9337f4d ) to the 10.x branch in b079266dcb6d1ee6446d074ebd1d212a13ce0665

[PATCH] D73285: [OpenMP][OMPIRBuilder][BugFix] Handle Unreachable Finalization blocks in `parallel` generation

fghanim created this revision. fghanim added a reviewer: jdoerfert. Herald added subscribers: llvm-commits, cfe-commits, guansong, hiraditya. Herald added projects: clang, LLVM. In some situations (e.g. `while(1);` ) the body block(s) will not contain a branch to the finalization block. In this p

[clang] 458676d - [WPD/VFE] Always emit vcall_visibility metadata for -fwhole-program-vtables

Author: Teresa Johnson Date: 2020-01-23T11:36:01-08:00 New Revision: 458676db6e41e3942a3b9498f6ba90e956897c2a URL: https://github.com/llvm/llvm-project/commit/458676db6e41e3942a3b9498f6ba90e956897c2a DIFF: https://github.com/llvm/llvm-project/commit/458676db6e41e3942a3b9498f6ba90e956897c2a.diff

[PATCH] D73236: [clang-tidy] Add clang-tidy headers to clang distribution

DmitryPolukhin updated this revision to Diff 239953. DmitryPolukhin added a comment. - removed DEPENDS Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73236/new/ https://reviews.llvm.org/D73236 Files: clang-tools-extra/clang-tidy/CMakeLists.txt I

[PATCH] D71907: [WPD/VFE] Always emit vcall_visibility metadata for -fwhole-program-vtables

This revision was automatically updated to reflect the committed changes. Closed by commit rG458676db6e41: [WPD/VFE] Always emit vcall_visibility metadata for -fwhole-program-vtables (authored by tejohnson). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D72994: [Sema] Sanity-check alignment requested via `__attribute__((assume_aligned(imm)))`

lebedev.ri updated this revision to Diff 239955. lebedev.ri added a comment. Rebased, NFC. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72994/new/ https://reviews.llvm.org/D72994 Files: clang/lib/Sema/SemaDeclAttr.cpp clang/test/Sema/builtin-

[PATCH] D73005: [Codegen] If reasonable, materialize clang's `AssumeAlignedAttr` as llvm's Alignment Attribute on call-site function return value

lebedev.ri updated this revision to Diff 239958. lebedev.ri added a comment. Rebased, NFC. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73005/new/ https://reviews.llvm.org/D73005 Files: clang/lib/CodeGen/CGCall.cpp clang/test/CodeGen/assume-a

[PATCH] D72998: [IR] Attribute/AttrBuilder: use Value::MaximumAlignment magic constant

lebedev.ri updated this revision to Diff 239957. lebedev.ri added a comment. Rebased, NFC. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72998/new/ https://reviews.llvm.org/D72998 Files: clang/include/clang/Sema/Sema.h clang/lib/Sema/SemaCheck

[PATCH] D72996: [Sema] Attempt to perform call-size-specific `__attribute__((alloc_align(param_idx)))` validation

lebedev.ri updated this revision to Diff 239956. lebedev.ri added a comment. Rebased, NFC. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72996/new/ https://reviews.llvm.org/D72996 Files: clang/lib/Sema/SemaChecking.cpp clang/test/Sema/alloc-al

[PATCH] D73006: [Codegen] If reasonable, materialize clang's `AllocAlignAttr` as llvm's Alignment Attribute on call-site function return value

lebedev.ri updated this revision to Diff 239959. lebedev.ri added a comment. Rebased, NFC. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73006/new/ https://reviews.llvm.org/D73006 Files: clang/lib/CodeGen/CGCall.cpp clang/test/CodeGen/assume-a

[PATCH] D73019: [Sema] Don't disallow placing `__attribute__((alloc_align(param_idx)))` on `std::align_val_t`-typed parameters

lebedev.ri updated this revision to Diff 239960. lebedev.ri added a comment. Rebased, NFC. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73019/new/ https://reviews.llvm.org/D73019 Files: clang/lib/Sema/SemaDeclAttr.cpp clang/test/SemaCXX/std-a

[PATCH] D73153: [Concepts] Update ReleaseNotes with Concepts support

rsmith accepted this revision. rsmith added inline comments. This revision is now accepted and ready to land. Comment at: clang/docs/ReleaseNotes.rst:127-128 +- The -fno-concept-satisfaction-caching can be used to disable caching for + satisfactions of Concepts. Using this flag

[clang] c2a9061 - [Sema] Attempt to perform call-size-specific `__attribute__((alloc_align(param_idx)))` validation

Author: Roman Lebedev Date: 2020-01-23T22:50:49+03:00 New Revision: c2a9061ac5166e48fe85ea2b6dbce9457c964958 URL: https://github.com/llvm/llvm-project/commit/c2a9061ac5166e48fe85ea2b6dbce9457c964958 DIFF: https://github.com/llvm/llvm-project/commit/c2a9061ac5166e48fe85ea2b6dbce9457c964958.diff

[clang] a4cfb15 - [Sema] Sanity-check alignment requested via `__attribute__((assume_aligned(imm)))`

Author: Roman Lebedev Date: 2020-01-23T22:50:48+03:00 New Revision: a4cfb15d15a8a353fe316f2a9fe1c8c6a6740ef1 URL: https://github.com/llvm/llvm-project/commit/a4cfb15d15a8a353fe316f2a9fe1c8c6a6740ef1 DIFF: https://github.com/llvm/llvm-project/commit/a4cfb15d15a8a353fe316f2a9fe1c8c6a6740ef1.diff

[PATCH] D72998: [IR] Attribute/AttrBuilder: use Value::MaximumAlignment magic constant

This revision was automatically updated to reflect the committed changes. Closed by commit rGd096f8d306b2: [IR] Attribute/AttrBuilder: use Value::MaximumAlignment magic constant (authored by lebedev.ri). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D72994: [Sema] Sanity-check alignment requested via `__attribute__((assume_aligned(imm)))`

This revision was automatically updated to reflect the committed changes. Closed by commit rGa4cfb15d15a8: [Sema] Sanity-check alignment requested via `__attribute__((assume_aligned… (authored by lebedev.ri). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D72996: [Sema] Attempt to perform call-size-specific `__attribute__((alloc_align(param_idx)))` validation

This revision was automatically updated to reflect the committed changes. Closed by commit rGc2a9061ac516: [Sema] Attempt to perform call-size-specific `__attribute__((alloc_align… (authored by lebedev.ri). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D73006: [Codegen] If reasonable, materialize clang's `AllocAlignAttr` as llvm's Alignment Attribute on call-site function return value

This revision was automatically updated to reflect the committed changes. Closed by commit rG5ffe6408ffb6: [Codegen] If reasonable, materialize clang's `AllocAlignAttr` as llvm's… (authored by lebedev.ri). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D73005: [Codegen] If reasonable, materialize clang's `AssumeAlignedAttr` as llvm's Alignment Attribute on call-site function return value

This revision was automatically updated to reflect the committed changes. Closed by commit rGe819f7c9feb4: [Codegen] If reasonable, materialize clang's `AssumeAlignedAttr` as llvm's… (authored by lebedev.ri). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D73019: [Sema] Don't disallow placing `__attribute__((alloc_align(param_idx)))` on `std::align_val_t`-typed parameters

This revision was automatically updated to reflect the committed changes. Closed by commit rGb749af6a1ff4: [Sema] Don't disallow placing `__attribute__((alloc_align(param_idx)))` on `std… (authored by lebedev.ri). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D73150: [Concepts] Remove -fconcepts-ts, enable concepts support under -std=c++2a

rsmith added inline comments. Comment at: clang/include/clang/Basic/LangOptions.def:124 ENUM_LANGOPT(LaxVectorConversions, LaxVectorConversionKind, 2, - LaxVectorConversionKind::All, "lax vector conversions") + LaxVectorConversionKind::Integer, "lax vecto

[PATCH] D72100: Allow matching "any file" in `VerifyDiagnosticConsumer`.

arames updated this revision to Diff 239972. arames added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72100/new/ https://reviews.llvm.org/D72100 Files: clang/include/clang/Frontend/VerifyDiagnosticConsumer.h

[clang] 00756b1 - Revert "[Sema] Attempt to perform call-size-specific `__attribute__((alloc_align(param_idx)))` validation"

Author: Roman Lebedev Date: 2020-01-23T23:10:34+03:00 New Revision: 00756b182398b92abe16559287467079087aa631 URL: https://github.com/llvm/llvm-project/commit/00756b182398b92abe16559287467079087aa631 DIFF: https://github.com/llvm/llvm-project/commit/00756b182398b92abe16559287467079087aa631.diff

[clang] 210f088 - Revert "[Sema] Sanity-check alignment requested via `__attribute__((assume_aligned(imm)))`"

Author: Roman Lebedev Date: 2020-01-23T23:10:35+03:00 New Revision: 210f0882c9e5d6f504b8f29e8a5eae884f812e5c URL: https://github.com/llvm/llvm-project/commit/210f0882c9e5d6f504b8f29e8a5eae884f812e5c DIFF: https://github.com/llvm/llvm-project/commit/210f0882c9e5d6f504b8f29e8a5eae884f812e5c.diff

[PATCH] D72994: [Sema] Sanity-check alignment requested via `__attribute__((assume_aligned(imm)))`

lebedev.ri reopened this revision. lebedev.ri added a comment. This revision is now accepted and ready to land. Seeing some bot failures, reverted this one. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72994/new/ https://reviews.llvm.org/D72994

[PATCH] D72996: [Sema] Attempt to perform call-size-specific `__attribute__((alloc_align(param_idx)))` validation

lebedev.ri reopened this revision. lebedev.ri added a comment. This revision is now accepted and ready to land. Seeing some bot failures, reverted this one. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72996/new/ https://reviews.llvm.org/D72996

[clang-tools-extra] c6c5dbc - [clangd] Add C++20 concepts support to findExplicitReferences() and semantic highlighting

Author: Nathan Ridge Date: 2020-01-23T15:11:46-05:00 New Revision: c6c5dbc824c508c5cd36da450ecfbd12858403c4 URL: https://github.com/llvm/llvm-project/commit/c6c5dbc824c508c5cd36da450ecfbd12858403c4 DIFF: https://github.com/llvm/llvm-project/commit/c6c5dbc824c508c5cd36da450ecfbd12858403c4.diff

[clang-tools-extra] cbcd07a - [clangd] Add C++20 concepts support to TargetFinder

Author: Nathan Ridge Date: 2020-01-23T15:12:21-05:00 New Revision: cbcd07a4815f546739fb1374a7f24f35e5352e17 URL: https://github.com/llvm/llvm-project/commit/cbcd07a4815f546739fb1374a7f24f35e5352e17 DIFF: https://github.com/llvm/llvm-project/commit/cbcd07a4815f546739fb1374a7f24f35e5352e17.diff

[PATCH] D73124: [clangd] Add C++20 concepts support to findExplicitReferences() and semantic highlighting

This revision was automatically updated to reflect the committed changes. Closed by commit rGc6c5dbc824c5: [clangd] Add C++20 concepts support to findExplicitReferences() and semantic… (authored by nridge). Changed prior to commit: https://reviews.llvm.org/D73124?vs=239370&id=239974#toc Reposi

[PATCH] D67678: PR17164: Change clang's default behavior from -flax-vector-conversions=all to -flax-vector-conversions=integer.

rsmith added a comment. In D67678#1836668 , @dexonsmith wrote: > In D67678#1836628 , @steven_wu wrote: > > > In D67678#1834957 , @rsmith wrote: > > > > > In D67678#1834542

[PATCH] D73140: [clangd] Add C++20 concepts support to TargetFinder

This revision was automatically updated to reflect the committed changes. Closed by commit rGcbcd07a4815f: [clangd] Add C++20 concepts support to TargetFinder (authored by nridge). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73140/new/ https://rev

[PATCH] D72553: [clang-tidy] Add performance-prefer-preincrement check

merge_guards_bot added a comment. {icon times-circle color=red} Unit tests: fail. 61939 tests passed, 5 failed and 782 were skipped. failed: libc++.std/language_support/cmp/cmp_partialord/partialord.pass.cpp failed: libc++.std/language_support/cmp/cmp_strongeq/cmp.strongeq.pass.cpp failed:

[clang] fa2fc81 - Re-add documentation for -flax-vector-conversions= removed in

Author: Richard Smith Date: 2020-01-23T12:28:03-08:00 New Revision: fa2fc81d3464aa9b6e5e9d2ad8f512904712d2b7 URL: https://github.com/llvm/llvm-project/commit/fa2fc81d3464aa9b6e5e9d2ad8f512904712d2b7 DIFF: https://github.com/llvm/llvm-project/commit/fa2fc81d3464aa9b6e5e9d2ad8f512904712d2b7.diff

[PATCH] D72222: [Driver][CodeGen] Add -fpatchable-function-entry=N[,0]

nickdesaulniers added a comment. In D7#1836687 , @MaskRay wrote: > (I really dislike how the feature was developed on the GCC side. Yet another > Linux-kernel specific GCC option when there are already 4 existing options > for the same feature) May

[clang] 1624cba - Partially revert "[IR] Attribute/AttrBuilder: use Value::MaximumAlignment magic constant"

Author: Roman Lebedev Date: 2020-01-23T23:30:42+03:00 New Revision: 1624cba7824967c15ac36d9fdd41bb9878463dbe URL: https://github.com/llvm/llvm-project/commit/1624cba7824967c15ac36d9fdd41bb9878463dbe DIFF: https://github.com/llvm/llvm-project/commit/1624cba7824967c15ac36d9fdd41bb9878463dbe.diff

[PATCH] D67678: PR17164: Change clang's default behavior from -flax-vector-conversions=all to -flax-vector-conversions=integer.

dexonsmith added a comment. In D67678#1836922 , @rsmith wrote: > In D67678#1836668 , @dexonsmith > wrote: > > > In D67678#1836628 , @steven_wu > > wrote: > > > > > In D6767

[PATCH] D73237: [CUDA] Fix order of memcpy arguments in __shfl_*(<64-bit type>).

timshen accepted this revision. timshen added a comment. This revision is now accepted and ready to land. What's the test situation for these headers? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73237/new/ https://reviews.llvm.org/D73237 _

[PATCH] D73261: [dwarf5] Support DebugInfo for constexpr for C++ variables and functions

probinson added a comment. I put in a lot of comments about spelling for the new parameter (constExpr, isConstexpr, isConstExpr) which should be named consistently throughout. Please do not use Constant or any variant, as that tends to mean something else. But, what I would rather see instead

[PATCH] D72553: [clang-tidy] Add performance-prefer-preincrement check

njames93 updated this revision to Diff 239988. njames93 added a comment. - Rebase trunk and fix a few nits with test file Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72553/new/ https://reviews.llvm.org/D72553 Files: clang-tools-extra/clang-tid

[PATCH] D73285: [OpenMP][OMPIRBuilder][BugFix] Handle Unreachable Finalization blocks in `parallel` generation

fghanim updated this revision to Diff 239991. fghanim added a comment. - Cleaning up some leftover code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73285/new/ https://reviews.llvm.org/D73285 Files: clang/lib/CodeGen/CGStmtOpenMP.cpp llvm/li

[PATCH] D72553: [clang-tidy] Add performance-prefer-preincrement check

merge_guards_bot added a comment. {icon times-circle color=red} Unit tests: fail. 62129 tests passed, 5 failed and 807 were skipped. failed: libc++.std/language_support/cmp/cmp_partialord/partialord.pass.cpp failed: libc++.std/language_support/cmp/cmp_strongeq/cmp.strongeq.pass.cpp failed:

[clang] cc14de8 - [CUDA] Fix order of memcpy arguments in __shfl_*(<64-bit type>).

Author: Artem Belevich Date: 2020-01-23T13:17:52-08:00 New Revision: cc14de88da27a8178976972bdc8211c31f7ca9ae URL: https://github.com/llvm/llvm-project/commit/cc14de88da27a8178976972bdc8211c31f7ca9ae DIFF: https://github.com/llvm/llvm-project/commit/cc14de88da27a8178976972bdc8211c31f7ca9ae.diff

[clang] 9c2eb22 - [ThinLTO] Summarize vcall_visibility metadata

Author: Teresa Johnson Date: 2020-01-23T13:19:56-08:00 New Revision: 9c2eb220edd5e831a17bfbde65dcc49e402d7540 URL: https://github.com/llvm/llvm-project/commit/9c2eb220edd5e831a17bfbde65dcc49e402d7540 DIFF: https://github.com/llvm/llvm-project/commit/9c2eb220edd5e831a17bfbde65dcc49e402d7540.diff

[PATCH] D73237: [CUDA] Fix order of memcpy arguments in __shfl_*(<64-bit type>).

tra closed this revision. tra added a subscriber: hans. tra added a comment. Landed in https://github.com/llvm/llvm-project/commit/cc14de88da27a8178976972bdc8211c31f7ca9ae @hans -- can we cherry-pick it into 10? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

<    1   2   3   >