sammccall created this revision.
sammccall added a reviewer: kadircet.
Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay,
ilya-biryukov.
Herald added a project: clang.
The blocky arrow is a fairly obscure character, and a couple of fonts I checked
don't have it :-(
"Type" is long and text-y, I do think people will get used to element-of (which
is very commonly present).
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D73278
Files:
clang-tools-extra/clangd/Hover.cpp
Index: clang-tools-extra/clangd/Hover.cpp
===================================================================
--- clang-tools-extra/clangd/Hover.cpp
+++ clang-tools-extra/clangd/Hover.cpp
@@ -550,7 +550,7 @@
// Parameters:
// - `bool param1`
// - `int param2 = 5`
- Output.addParagraph().appendText("🡺").appendCode(*ReturnType);
+ Output.addParagraph().appendText("→").appendCode(*ReturnType);
if (Parameters && !Parameters->empty()) {
Output.addParagraph().appendText("Parameters:");
markup::BulletList &L = Output.addBulletList();
@@ -562,7 +562,7 @@
}
}
} else if (Type) {
- Output.addParagraph().appendText("Type: ").appendCode(*Type);
+ Output.addParagraph().appendText("∈").appendCode(*Type);
}
if (Value) {
Index: clang-tools-extra/clangd/Hover.cpp
===================================================================
--- clang-tools-extra/clangd/Hover.cpp
+++ clang-tools-extra/clangd/Hover.cpp
@@ -550,7 +550,7 @@
// Parameters:
// - `bool param1`
// - `int param2 = 5`
- Output.addParagraph().appendText("🡺").appendCode(*ReturnType);
+ Output.addParagraph().appendText("→").appendCode(*ReturnType);
if (Parameters && !Parameters->empty()) {
Output.addParagraph().appendText("Parameters:");
markup::BulletList &L = Output.addBulletList();
@@ -562,7 +562,7 @@
}
}
} else if (Type) {
- Output.addParagraph().appendText("Type: ").appendCode(*Type);
+ Output.addParagraph().appendText("∈").appendCode(*Type);
}
if (Value) {
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
