[PATCH] D70973: [OPENMP50]Treat context selectors as expressions, not just strings.

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 60709 tests passed, 0 failed and 726 were skipped. {icon times-circle color=red} clang-format: fail. Please format your changes with clang-format by running `git-clang-format HEAD^` or apply this patch

[PATCH] D70973: [OPENMP50]Treat context selectors as expressions, not just strings.

ABataev updated this revision to Diff 233375. ABataev added a comment. Fixed formatting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70973/new/ https://reviews.llvm.org/D70973 Files: clang/include/clang/AST/Decl.h clang/include/clang/Basic/At

[PATCH] D71321: [analyzer] CStringChecker: Warning text fixes.

xazax.hun accepted this revision. xazax.hun added a comment. Cool! :) Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71321/new/ https://reviews.llvm.org/D71321 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

[PATCH] D71322: [analyzer] CStringChecker: Fix overly eager assumption that memcmp arguments overlap.

xazax.hun accepted this revision. xazax.hun added a comment. Less state split, yay! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71322/new/ https://reviews.llvm.org/D71322 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lis

[PATCH] D70469: [attributes] [analyzer] Add handle related attributes

xazax.hun added a comment. In D70469#1778609 , @NoQ wrote: > What about `__attribute__((acquire_handle("fuchsia")))` I would by fine with this as well. Aaron? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70469/new/ https://reviews.llvm.org/D7

[PATCH] D71325: [Remarks][Driver] Ask for line tables when remarks are enabled

aprantl added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:3724 + DebugInfoKind == codegenoptions::LocTrackingOnly || + DebugInfoKind == codegenoptions::DebugDirectivesOnly)) +DebugInfoKind = codegenoptions::DebugLineTablesOnly; -

[PATCH] D71197: llvm premerge: clang format test

goncharov updated this revision to Diff 233376. goncharov added a comment. namespaces Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71197/new/ https://reviews.llvm.org/D71197 Files: clang/tools/clang-check/ClangCheck.cpp clang/tools/clang-diff

[PATCH] D70469: [attributes] [analyzer] Add handle related attributes

xazax.hun marked an inline comment as done. xazax.hun added inline comments. Comment at: clang/lib/Sema/SemaType.cpp:7424 + ParsedAttr &Attr) { + if (CurType->isFunctionType()) { +State.getSema().Diag(Attr.getLoc(), diag::warn_type_attribute_wrong

[PATCH] D70973: [OPENMP50]Treat context selectors as expressions, not just strings.

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 60709 tests passed, 0 failed and 726 were skipped. {icon times-circle color=red} clang-format: fail. Please format your changes with clang-format by running `git-clang-format HEAD^` or apply this patch

[PATCH] D71197: llvm premerge: clang format test

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 60624 tests passed, 0 failed and 726 were skipped. {icon times-circle color=red} clang-format: fail. Please format your changes with clang-format by running `git-clang-format HEAD^` or apply this patch

[PATCH] D71197: llvm premerge: clang format test

goncharov updated this revision to Diff 233380. goncharov added a comment. header Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71197/new/ https://reviews.llvm.org/D71197 Files: clang/include/clang/Analysis/AnalysisDeclContext.h clang/tools/cl

[PATCH] D71197: llvm premerge: clang format test

merge_guards_bot added a comment. {icon check-circle color=green} clang-format: pass. Build artifacts : console-log.txt , CMakeCache.txt <

[PATCH] D71247: [clangd] Rename constructors and destructors in cross-file case

kbobyrev updated this revision to Diff 233381. kbobyrev marked an inline comment as done. kbobyrev added a comment. Address the comments and simplify the code. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71247/new/ https://reviews.llvm.org/D71247 Files: clang-tools-extra/clangd/ref

[PATCH] D71197: llvm premerge: clang format test

goncharov updated this revision to Diff 233383. goncharov added a comment. Herald added subscribers: kadircet, jkorous. more violations Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71197/new/ https://reviews.llvm.org/D71197 Files: clang-tools-e

[PATCH] D71197: llvm premerge: clang format test

merge_guards_bot added a comment. {icon check-circle color=green} clang-format: pass. Build artifacts : console-log.txt , CMakeCache.txt <

[PATCH] D71062: [ARM][MVE] Add vector reduction intrinsics with two vector operands

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 60719 tests passed, 0 failed and 726 were skipped. {icon times-circle color=red} clang-format: fail. Please format your changes with clang-format by running `git-clang-format HEAD^` or apply this patch

[clang] 7b774b7 - [OPENMP50]Add if clause in teams distribute simd directive.

Author: Alexey Bataev Date: 2019-12-11T12:30:18-05:00 New Revision: 7b774b7cd48562e3af3405b1e5c54ea58bd142a6 URL: https://github.com/llvm/llvm-project/commit/7b774b7cd48562e3af3405b1e5c54ea58bd142a6 DIFF: https://github.com/llvm/llvm-project/commit/7b774b7cd48562e3af3405b1e5c54ea58bd142a6.diff

[PATCH] D70872: [clangd] Implement "textDocument/documentLink" protocol support

sammccall added a comment. Ping - how do you want to proceed here? I think the only thing that is really missing here is a unit test, I can add it if you don't have cycles. I'll be gone after this week :-) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D68213: [LTO] Support for embedding bitcode section during LTO

tejohnson accepted this revision. tejohnson added a comment. This revision is now accepted and ready to land. LGTM with a few small suggestions before you commit. Comment at: llvm/lib/LTO/LTOBackend.cpp:317 +static cl::opt EmbedBitcode("lto-embed-bitcode", cl::init(false), +

[PATCH] D71365: expand printf when compiling HIP to AMDGPU

sameerds created this revision. Herald added subscribers: llvm-commits, cfe-commits, hiraditya, t-tye, tpr, dstuttard, yaxunl, mgorny, nhaehnle, wdng, jvesely, kzhuravl. Herald added projects: clang, LLVM. This change implements the expansion in two parts: - Add a utility function emitAMDGPUPrin

[PATCH] D71213: [Alignment][NFC] CreateMemSet use MaybeAlign

gchatelet added a comment. In D71213#1779841 , @foad wrote: > @gchatelet in general would it be possible to make changes like this in a > backwards-compatible way, or in two stages without a "flag day" change? We > have out-of-tree users of CreateMemSet

[PATCH] D71197: llvm premerge: clang format test

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 60624 tests passed, 0 failed and 726 were skipped. {icon times-circle color=red} clang-format: fail. Please format your changes with clang-format by running `git-clang-format HEAD^` or apply this patch

[PATCH] D70854: [Clang] In tests, do not always assume others permissions are set

aganea updated this revision to Diff 233402. aganea added a comment. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Ensure the access-rights commands (setfacl and chmod) won't fail the tests if the user doesn't have the appropriate rights to change permissions. Added `llvm

[PATCH] D71247: [clangd] Rename constructors and destructors in cross-file case

sammccall added inline comments. Comment at: clang-tools-extra/clangd/refactor/Rename.cpp:91 + DeclRelation::Alias | DeclRelation::TemplatePattern)) { +// If the cursor is at the underlying CXXRecordDecl of the +// ClassTemplateDecl, ND will be the CXXRec

[PATCH] D71213: [Alignment][NFC] CreateMemSet use MaybeAlign

foad added a comment. In D71213#1780088 , @gchatelet wrote: > In D71213#1779841 , @foad wrote: > > > @gchatelet in general would it be possible to make changes like this in a > > backwards-compatible way, or in two

[clang] d8c31d4 - [OPENMP50]Fix capturing of if condition in target parallel for simd

Author: Alexey Bataev Date: 2019-12-11T13:18:39-05:00 New Revision: d8c31d41989b0748e2e5b8d7fa9cf7e7023bcbff URL: https://github.com/llvm/llvm-project/commit/d8c31d41989b0748e2e5b8d7fa9cf7e7023bcbff DIFF: https://github.com/llvm/llvm-project/commit/d8c31d41989b0748e2e5b8d7fa9cf7e7023bcbff.diff

[PATCH] D71193: [clang] Turn -fno-builtin flag into an IR Attribute

tejohnson added a comment. This LGTM, although I have a couple of questions that are orthogonal to this patch and shouldn't block it. Please wait to see if @aaron.ballman has any more comments. Comment at: clang/test/CodeGen/libcalls-fno-builtin.c:163 -// CHECK: [[ATTR]] =

[PATCH] D71082: Allow system header to provide their own implementation of some builtin

george.burgess.iv added a comment. Should we also have a quick test-case in Sema/ verifying that we still get the warnings that Eli mentioned? Comment at: clang/lib/AST/Decl.cpp:3006 +bool FunctionDecl::isReplaceableSystemFunction() const { + FunctionDecl const *Definition;

[PATCH] D69785: [OpenMP] Introduce the OpenMP-IR-Builder

jdoerfert updated this revision to Diff 233409. jdoerfert added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69785/new/ https://reviews.llvm.org/D69785 Files: llvm/include/llvm/Frontend/OpenMP/OMPConstants.h llvm/include/llv

[PATCH] D71345: [clangd] Fall back to selecting token-before-cursor if token-after-cursor fails.

sammccall updated this revision to Diff 233410. sammccall added a comment. Use callbacks to avoid creating too many trees eagerly. Add tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71345/new/ https://reviews.llvm.org/D71345 Files: clang-t

[PATCH] D71213: [Alignment][NFC] CreateMemSet use MaybeAlign

gchatelet added a comment. >> Thx for letting me know @foad . I'll make sure to keep the old API with a >> deprecation message from now on. >> Do you have any other suggestions on how to make this less painful for >> out-of-tree users? I'm afraid that the cleanup phase (removal of deprecated >

[PATCH] D71345: [clangd] Fall back to selecting token-before-cursor if token-after-cursor fails.

sammccall added a comment. So a reasonable outcome here is we conclude this does more harm than good. If that happens, I'd like to be clear on whether we have a better way of doing this in general or just don't think it's worth the cost, and should hack around it where possible as in D71284

[PATCH] D70689: [analyzer] Fix SARIF column locations

aaron.ballman added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/SarifDiagnostics.cpp:31 std::string OutputFile; + const Preprocessor &PP; You don't really need the whole preprocessor, just the language options, right? If so, why not thread t

[PATCH] D71356: [Tooling/Syntax] Helpers to find spelled tokens touching a location.

sammccall updated this revision to Diff 233415. sammccall marked 6 inline comments as done. sammccall added a comment. comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71356/new/ https://reviews.llvm.org/D71356 Files: clang/include/clang/T

[PATCH] D71356: [Tooling/Syntax] Helpers to find spelled tokens touching a location.

sammccall added inline comments. Comment at: clang/include/clang/Tooling/Syntax/Tokens.h:320 +const syntax::Token * +spelledIdentifierTouching(SourceLocation Loc, + const syntax::TokenBuffer &Tokens); kbobyrev wrote: > Maybe `llvm::Option

[PATCH] D69785: [OpenMP] Introduce the OpenMP-IR-Builder

merge_guards_bot added a comment. {icon check-circle color=green} clang-format: pass. Build artifacts : console-log.txt , CMakeCache.txt <

[PATCH] D69785: [OpenMP] Introduce the OpenMP-IR-Builder

jdoerfert updated this revision to Diff 233418. jdoerfert added a comment. Adjust path Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69785/new/ https://reviews.llvm.org/D69785 Files: llvm/include/llvm/Frontend/OpenMP/OMPConstants.h llvm/includ

[PATCH] D71369: Detect libdl from cmake variable

raj.khem created this revision. raj.khem added a reviewer: espindola. Herald added subscribers: cfe-commits, mgorny. Herald added a project: clang. This helps in getting right settings for libdl irrespective of platform it also fixes build with -DLLVM_BUILD_LLVM_DYLIB=ON -DLLVM_LINK_LLVM_DYLIB=ON

[PATCH] D71345: [clangd] Fall back to selecting token-before-cursor if token-after-cursor fails.

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 60717 tests passed, 0 failed and 726 were skipped. {icon times-circle color=red} clang-format: fail. Please format your changes with clang-format by running `git-clang-format HEAD^` or apply this patch

[PATCH] D71248: [clangd] Introduce paragraph, the first part of new rendering structs

kadircet updated this revision to Diff 233420. kadircet marked 12 inline comments as done. kadircet added a comment. - Move code blocks out of Paragraph - Provide a way to control vertical spacing - Address comments around naming Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D71248: [clangd] Introduce paragraph, the first part of new rendering structs

kadircet added inline comments. Comment at: clang-tools-extra/clangd/FormattedString.cpp:95 +// Concatanates whitespace blocks into a single ` `. +std::string canonicalizeSpaces(std::string Input) { + // Goes over the string and preserves only a single ` ` for any whitespace ---

[PATCH] D69785: [OpenMP] Introduce the OpenMP-IR-Builder

ABataev added inline comments. Comment at: llvm/include/llvm/Frontend/OpenMP/OMPConstants.h:74 +/// +///{ +namespace types { Extra comments? Comment at: llvm/include/llvm/Frontend/OpenMP/OMPConstants.h:93 +} // namespace types +///} + -

[clang] 134faae - [analyzer] CStringChecker: Improve warning messages.

Author: Artem Dergachev Date: 2019-12-11T11:22:36-08:00 New Revision: 134faae04259b0412a067c73069f61905fc451d7 URL: https://github.com/llvm/llvm-project/commit/134faae04259b0412a067c73069f61905fc451d7 DIFF: https://github.com/llvm/llvm-project/commit/134faae04259b0412a067c73069f61905fc451d7.dif

[clang] 2b3f207 - [analyzer] CStringChecker: Fix overly eager assumption that memcmp args overlap.

Author: Artem Dergachev Date: 2019-12-11T11:22:36-08:00 New Revision: 2b3f2071ec6561c3f10e5291289c47bb3629e354 URL: https://github.com/llvm/llvm-project/commit/2b3f2071ec6561c3f10e5291289c47bb3629e354 DIFF: https://github.com/llvm/llvm-project/commit/2b3f2071ec6561c3f10e5291289c47bb3629e354.dif

[PATCH] D70854: [Clang] In tests, do not always assume others permissions are set

rnk added a comment. I see there is no setfacl on Mac. Personally, I feel like this test doesn't have much value. Rafael added it long ago when we changed how we opened files in some way that I guess affected umask. I'm not sure we really need this regression test given how unportable it seems

[PATCH] D71356: [Tooling/Syntax] Helpers to find spelled tokens touching a location.

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 60699 tests passed, 0 failed and 726 were skipped. {icon check-circle color=green} clang-format: pass. Build artifacts : console-log.txt

[PATCH] D71321: [analyzer] CStringChecker: Warning text fixes.

This revision was automatically updated to reflect the committed changes. Closed by commit rG134faae04259: [analyzer] CStringChecker: Improve warning messages. (authored by dergachev.a). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71321/new/ https

[PATCH] D71371: [analyzer] Do not cache out on some shared implicit AST nodes.

xazax.hun created this revision. xazax.hun added reviewers: NoQ, dcoughlin, Szelethus, baloghadamsoftware, haowei. xazax.hun added a project: clang. Herald added subscribers: Charusso, gamesh411, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet. Some AST nodes that stands for imp

[PATCH] D71322: [analyzer] CStringChecker: Fix overly eager assumption that memcmp arguments overlap.

This revision was automatically updated to reflect the committed changes. Closed by commit rG2b3f2071ec65: [analyzer] CStringChecker: Fix overly eager assumption that memcmp args overlap. (authored by dergachev.a). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews

[PATCH] D71111: [Sema] Improve diagnostic about addr spaces for overload candidates

Anastasia updated this revision to Diff 233424. Anastasia added a comment. - Allow sending address spaces into diagnostics - Change wording of diagnostics for address spaces in overloading CHANGES SINCE LAST ACTION https://reviews.llvm.org/D7/new/ https://reviews.llvm.org/D7 Files:

Re: [clang] 878a24e - Reapply "Fix crash on switch conditions of non-integer types in templates"

After this commit clang started generating assertion failures on valid code. There are tons of instances in our codebase. Here's a reduced test case: template class a { int c : b; void f() { if (c) ; } }; Please take a look. On Wed, Dec 4, 2019 at 12:39 AM Elizabeth Andrews via cf

[PATCH] D69785: [OpenMP] Introduce the OpenMP-IR-Builder

merge_guards_bot added a comment. {icon times-circle color=red} Unit tests: fail. 60698 tests passed, 1 failed and 726 were skipped. failed: LLVM-Unit.Frontend/_/LLVMFrontendTests/OpenMPIRBuilderTest.CreateCancelBarrier {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D69785: [OpenMP] Introduce the OpenMP-IR-Builder

jdoerfert marked 6 inline comments as done. jdoerfert added inline comments. Comment at: llvm/include/llvm/Frontend/OpenMP/OMPConstants.h:74 +/// +///{ +namespace types { ABataev wrote: > Extra comments? I don't know what you want to tell me. C

[PATCH] D71371: [analyzer] Do not cache out on some shared implicit AST nodes.

NoQ added a comment. Ahaa. Ahaa. Okay. So the AST is like | |-DeclStmt 0x7f9f3b8932e0 | | `-VarDecl 0x7f9f3b892f50 col:7 used a 'int [5]' cinit | | `-InitListExpr 0x7f9f3b893268 'int [5]' | | |-array_filler: ImplicitValueInitExpr 0x7f9f3b8932d0 <> 'int' | | |-Int

[clang] 5882e6f - [analyzer] Escape symbols conjured into specific regions during a conservative EvalCall

Author: Gabor Horvath Date: 2019-12-11T11:44:10-08:00 New Revision: 5882e6f36fd9bfc7382e6763c5591b3497428d83 URL: https://github.com/llvm/llvm-project/commit/5882e6f36fd9bfc7382e6763c5591b3497428d83 DIFF: https://github.com/llvm/llvm-project/commit/5882e6f36fd9bfc7382e6763c5591b3497428d83.diff

[clang] 881d877 - [WebAssembly] Add new `export_name` clang attribute for controlling wasm export names

Author: Sam Clegg Date: 2019-12-11T11:54:57-08:00 New Revision: 881d877846e2904c731d616731969421ce8cc825 URL: https://github.com/llvm/llvm-project/commit/881d877846e2904c731d616731969421ce8cc825 DIFF: https://github.com/llvm/llvm-project/commit/881d877846e2904c731d616731969421ce8cc825.diff LOG

[PATCH] D69785: [OpenMP] Introduce the OpenMP-IR-Builder

jdoerfert updated this revision to Diff 233429. jdoerfert marked 2 inline comments as done. jdoerfert added a comment. Remove call caching in anticipation of D69930 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D6978

[PATCH] D71248: [clangd] Introduce paragraph, the first part of new rendering structs

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 60655 tests passed, 0 failed and 726 were skipped. {icon check-circle color=green} clang-format: pass. Build artifacts : console-log.txt

[PATCH] D71224: [analyzer] Escape symbols stored into specific region after a conservative evalcall.

This revision was automatically updated to reflect the committed changes. Closed by commit rG5882e6f36fd9: [analyzer] Escape symbols conjured into specific regions during a conservative… (authored by xazax.hun). Changed prior to commit: https://reviews.llvm.org/D71224?vs=233235&id=233431#toc R

[PATCH] D70520: [WebAssembly] Add new `export_name` clang attribute for controlling wasm export names

This revision was automatically updated to reflect the committed changes. sbc100 marked an inline comment as done. Closed by commit rG881d877846e2: [WebAssembly] Add new `export_name` clang attribute for controlling wasm export… (authored by sbc100). Changed prior to commit: https://reviews.llv

[PATCH] D69785: [OpenMP] Introduce the OpenMP-IR-Builder

ABataev added inline comments. Comment at: llvm/include/llvm/Frontend/OpenMP/OMPConstants.h:74 +/// +///{ +namespace types { jdoerfert wrote: > ABataev wrote: > > Extra comments? > I don't know what you want to tell me. I mean, you have this `///{` here. Do you n

[PATCH] D70872: [clangd] Implement "textDocument/documentLink" protocol support

MForster marked 6 inline comments as done. MForster added a comment. I think I addressed all review comments. PTAL. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70872/new/ https://reviews.llvm.org/D70872

[PATCH] D70872: [clangd] Implement "textDocument/documentLink" protocol support

MForster updated this revision to Diff 233433. MForster marked an inline comment as not done. MForster added a comment. Adress review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70872/new/ https://reviews.llvm.org/D70872 Files: clang

[PATCH] D70401: [WIP][RISCV] Implement ilp32e ABI

luismarques added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVCallingConv.td:36 +// The only physical register that isn't saved is x2 (SP), which is used by the +// processor when the interrupt happens. + Nitpick: "the interrupt happens" -> "an interr

[PATCH] D69785: [OpenMP] Introduce the OpenMP-IR-Builder

jdoerfert marked 2 inline comments as done. jdoerfert added inline comments. Comment at: llvm/include/llvm/Frontend/OpenMP/OMPConstants.h:74 +/// +///{ +namespace types { ABataev wrote: > jdoerfert wrote: > > ABataev wrote: > > > Extra comments? > > I don't know

[PATCH] D71317: [clang][IFS] Prevent Clang-IFS from Leaking symbols from inside a block.

plotfi abandoned this revision. plotfi added a comment. Abandoning. Duplicate diff Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71317/new/ https://reviews.llvm.org/D71317 ___ cfe-commits mailing list

[PATCH] D71301: [clang][IFS] Prevent Clang-IFS from Leaking symbols from inside a block.

plotfi updated this revision to Diff 233435. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71301/new/ https://reviews.llvm.org/D71301 Files: clang/lib/Frontend/InterfaceStubFunctionsConsumer.cpp clang/test/InterfaceStubs/blocks.c clang/test/In

[PATCH] D70469: [attributes] [analyzer] Add handle related attributes

NoQ added inline comments. Comment at: clang/lib/Sema/SemaType.cpp:7424 + ParsedAttr &Attr) { + if (CurType->isFunctionType()) { +State.getSema().Diag(Attr.getLoc(), diag::warn_type_attribute_wrong_type) xazax.hun wrote: > aaron.b

[PATCH] D69785: [OpenMP] Introduce the OpenMP-IR-Builder

This revision was automatically updated to reflect the committed changes. Closed by commit rGd23c61490c28: [OpenMP] Introduce the OpenMP-IR-Builder (authored by jdoerfert). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69785/new/ https://reviews.llv

[PATCH] D70854: [Clang] In tests, do not always assume others permissions are set

aganea added a comment. Yes this was added in rG18627115f4d2db5dc73207e0b5312f52536be7dd and rGe08b59f81d950bd5c8b8528fcb3ac4230c7b736c . It looks like it

[PATCH] D71371: [analyzer] Do not cache out on some shared implicit AST nodes.

NoQ added a comment. One way to criticize the current solution would be to put an `InitListExpr` in a loop and immediately discard it and see how states after different numbers of iterations no longer join together only because they have different `NoCachingOutForConsts` values. Repository:

[PATCH] D71374: Improve support of GNU mempcpy

serge-sans-paille created this revision. serge-sans-paille added a reviewer: ddunbar. Herald added a project: clang. Herald added a subscriber: cfe-commits. - Lower to the memcpy intrinsic - Raise warnings when size/bounds are known Repository: rG LLVM Github Monorepo https://reviews.llvm.org

[PATCH] D70836: [analysis] Fix value tracking for pointers to qualified types

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Hmm, it was supposed to get a green tick mark. Let me re-accept. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70836/new/ https://reviews.llvm.org/D70

[PATCH] D71082: Allow system header to provide their own implementation of some builtin

serge-sans-paille marked an inline comment as done. serge-sans-paille added inline comments. Comment at: clang/lib/AST/Decl.cpp:3006 +bool FunctionDecl::isReplaceableSystemFunction() const { + FunctionDecl const *Definition; george.burgess.iv wrote: > serge-sa

[PATCH] D71374: Improve support of GNU mempcpy

serge-sans-paille added a comment. On going validation: https://github.com/serge-sans-paille/llvm-project/pull/5/checks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71374/new/ https://reviews.llvm.org/D71374 ___

[PATCH] D71111: [Sema] Improve diagnostic about addr spaces for overload candidates

rjmccall added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:3838 +"'this' object is in address space %3, but method expects object in " +"address space %4">; def note_ovl_candidate_bad_gc : Note< I think you need to move

[clang] 0b97894 - [OPENMP50]Add if clause in teams distribute parallel for simd directive.

Author: Alexey Bataev Date: 2019-12-11T16:11:41-05:00 New Revision: 0b9789456b616863ab4dd045a977758f527bab8b URL: https://github.com/llvm/llvm-project/commit/0b9789456b616863ab4dd045a977758f527bab8b DIFF: https://github.com/llvm/llvm-project/commit/0b9789456b616863ab4dd045a977758f527bab8b.diff

[PATCH] D71371: [analyzer] Do not cache out on some shared implicit AST nodes.

xazax.hun added a comment. Hmm loops. Right. So this solution is insufficient because it can prevent legitimate caching out in loops. If we remove those initializers from the CFG wouldn't we loose the Pre/PostStmt callbacks? Is that acceptable? If not, we might need to create a new program poi

[PATCH] D71371: [analyzer] Do not cache out on some shared implicit AST nodes.

NoQ added a comment. I doubt we'll ever need these callbacks. I can't imagine any kind of analysis that would need them. Like, these statements have absolutely no effect on the runtime program state. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D7

[PATCH] D71082: Allow system header to provide their own implementation of some builtin

george.burgess.iv added inline comments. Comment at: clang/lib/AST/Decl.cpp:3006 +bool FunctionDecl::isReplaceableSystemFunction() const { + FunctionDecl const *Definition; serge-sans-paille wrote: > george.burgess.iv wrote: > > serge-sans-paille wrote: > > >

[PATCH] D69770: [APFloat] Add recoverable string parsing errors to APFloat

ekatz added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69770/new/ https://reviews.llvm.org/D69770 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] e0e07a7 - Fix detection of __attribute__((may_alias)) to properly look through

Author: Richard Smith Date: 2019-12-11T14:04:37-08:00 New Revision: e0e07a7e414e818788144511de0c6328285c43cd URL: https://github.com/llvm/llvm-project/commit/e0e07a7e414e818788144511de0c6328285c43cd DIFF: https://github.com/llvm/llvm-project/commit/e0e07a7e414e818788144511de0c6328285c43cd.diff

[PATCH] D70854: [Clang] In tests, do not always assume others permissions are set

rnk added a comment. I think we should remove it. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70854/new/ https://reviews.llvm.org/D70854 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listin

[PATCH] D69922: [OpenMP] Use the OpenMP-IR-Builder

jdoerfert updated this revision to Diff 233448. jdoerfert marked 3 inline comments as done. jdoerfert added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69922/new/ https://reviews.llvm.org/D69922 Files: clang/include/clang/Bas

[PATCH] D70268: [clang][clang-scan-deps] Aggregate the full dependency information.

Bigcheese added a comment. Looks like the test for -full-command-line got dropped. I'll add that when I commit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70268/new/ https://reviews.llvm.org/D70268 ___

[PATCH] D70878: [analyzer] Add support for namespaces to GenericTaintChecker

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Looks great but i keep worrying that you're re-inventing `CallDescription` which already supports this feature (and many more) and we really need a single implementation of this logic because it has

[clang] db4c7ad - Suppress false-positive -Wuninitialized warnings in the constructor of a

Author: Richard Smith Date: 2019-12-11T14:26:28-08:00 New Revision: db4c7adfa365282e8cb9a067c509fa711c4b96fe URL: https://github.com/llvm/llvm-project/commit/db4c7adfa365282e8cb9a067c509fa711c4b96fe DIFF: https://github.com/llvm/llvm-project/commit/db4c7adfa365282e8cb9a067c509fa711c4b96fe.diff

[clang] f978ea4 - [clang][clang-scan-deps] Aggregate the full dependency information.

Author: Michael Spencer Date: 2019-12-11T14:40:51-08:00 New Revision: f978ea498309adaebab8fbf1cd6e520e7e0e11f1 URL: https://github.com/llvm/llvm-project/commit/f978ea498309adaebab8fbf1cd6e520e7e0e11f1 DIFF: https://github.com/llvm/llvm-project/commit/f978ea498309adaebab8fbf1cd6e520e7e0e11f1.dif

[PATCH] D70268: [clang][clang-scan-deps] Aggregate the full dependency information.

This revision was automatically updated to reflect the committed changes. Closed by commit rGf978ea498309: [clang][clang-scan-deps] Aggregate the full dependency information. (authored by Bigcheese). Changed prior to commit: https://reviews.llvm.org/D70268?vs=233233&id=233455#toc Repository:

[clang] b3c06db - [OpenMP] Use the OpenMP-IR-Builder

Author: Johannes Doerfert Date: 2019-12-11T16:51:13-06:00 New Revision: b3c06db45611152f4ec22670bd83f4354078e6a7 URL: https://github.com/llvm/llvm-project/commit/b3c06db45611152f4ec22670bd83f4354078e6a7 DIFF: https://github.com/llvm/llvm-project/commit/b3c06db45611152f4ec22670bd83f4354078e6a7.d

[PATCH] D69922: [OpenMP] Use the OpenMP-IR-Builder

This revision was automatically updated to reflect the committed changes. Closed by commit rGb3c06db45611: [OpenMP] Use the OpenMP-IR-Builder (authored by jdoerfert). Changed prior to commit: https://reviews.llvm.org/D69922?vs=233448&id=233458#toc Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D69922: [OpenMP] Use the OpenMP-IR-Builder

jdoerfert added a comment. > I applied D69853 , D69785 > , D69922 > to my local build and found that D69922 is > referring to OpenMPIRBuilder.h in llvm/Frontend

[PATCH] D69471: [Coverage] Revise format to reduce binary size

vsk added a comment. Sorry for the delay here. An update: I tested this patch with a sanitized build on a Linux install, but could not reproduce the "malformed coverage data" errors seen on the Windows bots. At this point, it seems likely that there is a bug in CoverageMappingReader (this would

[PATCH] D71325: [Remarks][Driver] Ask for line tables when remarks are enabled

thegameg updated this revision to Diff 233459. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71325/new/ https://reviews.llvm.org/D71325 Files: clang/lib/Driver/ToolChains/Clang.cpp clang/test/Driver/debug-options.c Index: clang/test/Driver/debug-options.c ==

[PATCH] D70258: [OpenMP][IR-Builder] Introduce the finalization stack

jdoerfert updated this revision to Diff 233462. jdoerfert added a comment. rebase + ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70258/new/ https://reviews.llvm.org/D70258 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp llvm/include/llvm/Fr

[PATCH] D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior

cameron.mcinally added a comment. In D62731#1779872 , @mibintc wrote: > In D62731#1778597 , > @michele.scandale wrote: > > > >> I've noticed you removed the change for `CompilerInvocation.cpp` about > > >> the ini

[PATCH] D70258: [OpenMP][IR-Builder] Introduce the finalization stack

ABataev added a comment. Tests? Comment at: llvm/include/llvm/Frontend/OpenMP/OMPIRBuilder.h:51 + /// at the time, and location, the callback is invoked. + using FinalizeCallbackTy = std::function; + `llvm::function_ref`? Repository: rG LLVM Github Monore

[PATCH] D71378: Modifying ImportDeclContext(...) to ensure that we complete each FieldDecl of a RecordDecl when we are importing the definiton

shafik created this revision. shafik added reviewers: martong, teemperor. Herald added a subscriber: rnkovacs. This fix was motivated by a crashes in expression parsing during code generation in which we had a `RecordDecl` that had incomplete `FieldDecl`. During code generation when computing th

[PATCH] D70258: [OpenMP][IR-Builder] Introduce the finalization stack

merge_guards_bot added a comment. {icon check-circle color=green} clang-format: pass. Build artifacts : console-log.txt , CMakeCache.txt <

[PATCH] D71345: [clangd] Fall back to selecting token-before-cursor if token-after-cursor fails.

nridge added a comment. I tried to do a less general version of this (for go-to-definition only) in D70727 :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71345/new/ https://reviews.llvm.org/D71345 ___

<    1   2   3   >