george.burgess.iv added inline comments.
================
Comment at: clang/lib/AST/Decl.cpp:3006
+bool FunctionDecl::isReplaceableSystemFunction() const {
+ FunctionDecl const *Definition;
----------------
serge-sans-paille wrote:
> george.burgess.iv wrote:
> > serge-sans-paille wrote:
> > > Note to reviewers: I'm not super happy with that name.
> > Yeah, `isReplaceableBuiltin()` sounds like "can this be replaced at all?"
> > rather than "is this acting as a replacement for something else?"
> >
> > `isReplacementForBuiltin()` pops to mind, though in a lot of cases, these
> > functions may end up calling the "actual" builtin (as you handle later in
> > the patch), so maybe `isProxyForBuiltin()` is better?
> What about `isBuiltInWrapper()` ?
WFM
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D71082/new/
https://reviews.llvm.org/D71082
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
