[PATCH] D71282: Fix bug 44190 - wrong code with #pragma pack(1)

yaxunl updated this revision to Diff 233133. yaxunl added a comment. remove parenthesis CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71282/new/ https://reviews.llvm.org/D71282 Files: clang/lib/CodeGen/CGCall.cpp clang/test/CodeGen/s390x-packed-struct-func-arg.c Index: clang/test

[PATCH] D71286: [SYCL] Add support for auxiliary triple specification to Frontend

bader added a comment. I'm looking for test suggestions as I was not able to find tests covering similar changes for OpenMP compiler. https://github.com/llvm/llvm-project/commit/59d7b77b16bf11810091fe75a4348198783d3fbc modifies driver and front-end, but adds only driver tests. Repository: r

[PATCH] D71193: [clang] Turn -fno-builtin flag into an IR Attribute

aaron.ballman added reviewers: efriedma, tejohnson, hfinkel. aaron.ballman added a comment. Adding a few more reviewers who may know more about LLVM attributes. Comment at: clang/lib/CodeGen/CGCall.cpp:1884 +else { + const auto AddNoBuiltinAttr = [&FuncAttrs](S

[PATCH] D71286: [SYCL] Add support for auxiliary triple specification to Frontend

bader created this revision. bader added a reviewer: ABataev. Herald added subscribers: cfe-commits, Anastasia, ebevhan. Herald added a reviewer: jdoerfert. Herald added a project: clang. bader added a comment. I'm looking for test suggestions as I was not able to find tests covering similar chan

[PATCH] D70469: [attributes] [analyzer] Add handle related attributes

aaron.ballman added a comment. In D70469#1776523 , @NoQ wrote: > It still mildly worries me that the attributes aren't truly reusable, as the > exact meaning of the attribute depends on the domain. In particular, every > domain is expected to have differ

[PATCH] D71286: [SYCL] Add support for auxiliary triple specification to Frontend

ABataev added a comment. Most probably, just missed the testing of the frontend part here Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71286/new/ https://reviews.llvm.org/D71286 ___ cfe-commits mailin

[PATCH] D71199: [clang-tidy][WIP] New check readability-prefer-initialization-list

aaron.ballman added a comment. In D71199#1775083 , @whisperity wrote: > Can you refresh my memory on whether a rule for "if init expr is constant, > initialise in class body instead" exists for init list members? If so, this > will be a funny "two pass n

[PATCH] D71174: [clang-tidy] new check: bugprone-signed-char-misuse

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/SignedCharMisuseCheck.cpp:43-44 + + const auto SignedCharType = expr(hasType(qualType( + allOf(isAnyCharacter(), isSignedInteger(), unless(IntTypedef); + Does this p

[PATCH] D71286: [SYCL] Add support for auxiliary triple specification to Frontend

bader added a comment. In D71286#1777894 , @ABataev wrote: > Most probably, just missed the testing of the frontend part here Should I add test for both: SYCL and OpenMP? What is the right place for this kind of tests: clang/test/Preprocessor/ or clang/

[PATCH] D71286: [SYCL] Add support for auxiliary triple specification to Frontend

merge_guards_bot added a comment. Build result: pass - 60674 tests passed, 0 failed and 726 were skipped. Log files: console-log.txt , CMakeCache.txt

[PATCH] D70469: [attributes] [analyzer] Add handle related attributes

xazax.hun added a comment. In D70469#1777858 , @aaron.ballman wrote: > In D70469#1776523 , @NoQ wrote: > > > It still mildly worries me that the attributes aren't truly reusable, as > > the exact meaning of the at

[clang] 21b4388 - Fix bug 44190 - wrong code with #pragma pack(1)

Author: Yaxun (Sam) Liu Date: 2019-12-10T13:56:34-05:00 New Revision: 21b43885b81a6180e7231e575b5433202582f2fb URL: https://github.com/llvm/llvm-project/commit/21b43885b81a6180e7231e575b5433202582f2fb DIFF: https://github.com/llvm/llvm-project/commit/21b43885b81a6180e7231e575b5433202582f2fb.dif

[PATCH] D71286: [SYCL] Add support for auxiliary triple specification to Frontend

ABataev added a comment. In D71286#1777917 , @bader wrote: > In D71286#1777894 , @ABataev wrote: > > > Most probably, just missed the testing of the frontend part here > > > Should I add test for both: SYCL and Open

[PATCH] D68213: [LTO] Support for embedding bitcode section during LTO

tejohnson added inline comments. Comment at: llvm/lib/LTO/LTOBackend.cpp:335 + .Case("bitcode", EmbedBitcodeKind::Embed_Bitcode) + .Case("marker", EmbedBitcodeKind::Embed_Marker) + .Default(~0U); z

[PATCH] D71239: [clang-format] Fix ObjC keywords following try/catch getting split.

MyDeveloperDay added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:1849 + } while (FormatTok->is(tok::comment)); +} if (!(FormatTok->isOneOf(tok::kw_catch, Keywords.kw___except, can you use `FormatTok->getNextNonComment()`?

[PATCH] D70819: [ASTImporter] Support functions with placeholder return types ...

shafik accepted this revision. shafik added a comment. Besides my comments about different scenarios this LGTM Comment at: clang/lib/AST/ASTImporter.cpp:3018 + +bool ASTNodeImporter::hasAutoReturnTypeDeclaredInside(FunctionDecl *D) { + QualType FromTy = D->getType(); -

[PATCH] D71282: Fix bug 44190 - wrong code with #pragma pack(1)

This revision was automatically updated to reflect the committed changes. yaxunl marked an inline comment as done. Closed by commit rG21b43885b81a: Fix bug 44190 - wrong code with #pragma pack(1) (authored by yaxunl). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES S

[PATCH] D71241: [OpenMP][WIP] Use overload centric declare variants

jdoerfert marked an inline comment as done. jdoerfert added a comment. In D71241#109 , @ABataev wrote: > In D71241#1777661 , @jdoerfert wrote: > > > In D71241#1776798 , @

[PATCH] D71227: [cuda][hip] Fix function overload resolution in the global initiailizer.

hliao added a comment. File PR44266 to track that bug. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71227/new/ https://reviews.llvm.org/D71227 ___ cfe-com

[PATCH] D71224: [analyzer] Escape symbols stored into specific region after a conservative evalcall.

xazax.hun marked an inline comment as done. xazax.hun added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/ExprEngineCallAndReturn.cpp:624 +if (const MemRegion *MR = Call.getArgSVal(Arg).getAsRegion()) + if (!MR->hasStackStorage()) +Escape

[clang] 6ef0158 - [DWARF5] Start emitting DW_AT_dwo_name when -gdwarf-5 is specified.

Author: Sourabh Singh Tomar Date: 2019-12-11T01:18:02+05:30 New Revision: 6ef01588f4d75ef43da4ed2a37ba7a8b8daab259 URL: https://github.com/llvm/llvm-project/commit/6ef01588f4d75ef43da4ed2a37ba7a8b8daab259 DIFF: https://github.com/llvm/llvm-project/commit/6ef01588f4d75ef43da4ed2a37ba7a8b8daab259

[clang] 439cb88 - [cxx_status] Add missed Belfast paper affecting three-way comparisons.

Author: Richard Smith Date: 2019-12-10T11:49:04-08:00 New Revision: 439cb88e26d64670ea577e32c179360eb0fbe1cb URL: https://github.com/llvm/llvm-project/commit/439cb88e26d64670ea577e32c179360eb0fbe1cb DIFF: https://github.com/llvm/llvm-project/commit/439cb88e26d64670ea577e32c179360eb0fbe1cb.diff

[clang] bbaaeb4 - Add missed #include in llvmorg-10-init-11532-g848934c67d4.

Author: Richard Smith Date: 2019-12-10T11:49:04-08:00 New Revision: bbaaeb409904e375d8c44223b37a71502192c17c URL: https://github.com/llvm/llvm-project/commit/bbaaeb409904e375d8c44223b37a71502192c17c DIFF: https://github.com/llvm/llvm-project/commit/bbaaeb409904e375d8c44223b37a71502192c17c.diff

[clang] d82b6ba - Revert "[DWARF5] Start emitting DW_AT_dwo_name when -gdwarf-5 is specified."

Author: Sourabh Singh Tomar Date: 2019-12-11T01:20:40+05:30 New Revision: d82b6ba21b32ddf00af886b9160feef88211773e URL: https://github.com/llvm/llvm-project/commit/d82b6ba21b32ddf00af886b9160feef88211773e DIFF: https://github.com/llvm/llvm-project/commit/d82b6ba21b32ddf00af886b9160feef88211773e

[PATCH] D71224: [analyzer] Escape symbols stored into specific region after a conservative evalcall.

xazax.hun marked an inline comment as done. xazax.hun added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/ExprEngineCallAndReturn.cpp:624 +if (const MemRegion *MR = Call.getArgSVal(Arg).getAsRegion()) + if (!MR->hasStackStorage()) +Escape

Re: [clang] d82b6ba - Revert "[DWARF5] Start emitting DW_AT_dwo_name when -gdwarf-5 is specified."

You don't need to revert for a missing differential revision, just close the revision yourself :) -eric On Tue, Dec 10, 2019 at 11:51 AM Sourabh Singh Tomar via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > Author: Sourabh Singh Tomar > Date: 2019-12-11T01:20:40+05:30 > New Revision: d82b

[clang] fb4d8fe - Recommit "[DWARF5] Start emitting DW_AT_dwo_name when -gdwarf-5 is specified."

Author: Sourabh Singh Tomar Date: 2019-12-11T01:24:50+05:30 New Revision: fb4d8fe1a86232f4711c911e6feccce778e27afa URL: https://github.com/llvm/llvm-project/commit/fb4d8fe1a86232f4711c911e6feccce778e27afa DIFF: https://github.com/llvm/llvm-project/commit/fb4d8fe1a86232f4711c911e6feccce778e27afa

[PATCH] D71294: [OpenMP] Emit warning message about undefined number of evaluation for atomic update/capture

cchen created this revision. cchen added a reviewer: ABataev. Herald added subscribers: cfe-commits, jfb, guansong. Herald added a reviewer: jdoerfert. Herald added a project: clang. The total number of evaluation of X is undefined for atomic construct, therefore, we emit warning message for them.

[PATCH] D71185: [DWARF5] Start emitting DW_AT_dwo_name when -gdwarf-5 is specified.

This revision was automatically updated to reflect the committed changes. Closed by commit rGfb4d8fe1a862: Recommit "[DWARF5] Start emitting DW_AT_dwo_name when -gdwarf-5 is specified." (authored by SouraVX). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D68261: [clangd] Add "inline" keyword to prevent ODR-violations in DefineInline

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. I think we probably want to do the vice-versa thing (remove the inline keyword) in define-outline. Comment at: clang-tools-extra/clangd/refactor/tweaks/DefineInline.cpp:373

[PATCH] D71294: [OpenMP] Emit warning message about undefined number of evaluation for atomic update/capture

ABataev added a comment. I don't think this kind of analysis must be here. clang has a special analysis phase, maybe better to implement it there? Currently, it may produce false-positive warnings. Also, why only check for array accesses? Are they the only constructs that may lead to undefined

[clang] b972f2d - [Wdocumentation] Properly place deprecated attribute

Author: Mark de Wever Date: 2019-12-10T21:16:12+01:00 New Revision: b972f2d05e8b39dd84e586756e7078d79134e2fb URL: https://github.com/llvm/llvm-project/commit/b972f2d05e8b39dd84e586756e7078d79134e2fb DIFF: https://github.com/llvm/llvm-project/commit/b972f2d05e8b39dd84e586756e7078d79134e2fb.diff

[clang] 85fff89 - [Wdocumentation] Use the command marker.

Author: Mark de Wever Date: 2019-12-10T21:16:07+01:00 New Revision: 85fff898bb3175693e12536a837c8ad0ec8b2cdd URL: https://github.com/llvm/llvm-project/commit/85fff898bb3175693e12536a837c8ad0ec8b2cdd DIFF: https://github.com/llvm/llvm-project/commit/85fff898bb3175693e12536a837c8ad0ec8b2cdd.diff

[PATCH] D71224: [analyzer] Escape symbols stored into specific region after a conservative evalcall.

xazax.hun marked an inline comment as done. xazax.hun added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/ExprEngineCallAndReturn.cpp:624 +if (const MemRegion *MR = Call.getArgSVal(Arg).getAsRegion()) + if (!MR->hasStackStorage()) +Escape

[PATCH] D71294: [OpenMP] Emit warning message about undefined number of evaluation for atomic update/capture

cchen planned changes to this revision. cchen added a comment. Don't know there is an analysis phase in Clang, I'll investigate later, thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71294/new/ https://reviews.llvm.org/D71294 _

[PATCH] D71139: [Wdocumentation] Use the command marker

This revision was automatically updated to reflect the committed changes. Closed by commit rG85fff898bb31: [Wdocumentation] Use the command marker. (authored by Mordante). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71139/new/ https://reviews.llvm

[PATCH] D71140: [Wdocumentation] Properly place deprecated attribute

This revision was automatically updated to reflect the committed changes. Closed by commit rGb972f2d05e8b: [Wdocumentation] Properly place deprecated attribute (authored by Mordante). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71140/new/ https://

[PATCH] D71227: [cuda][hip] Fix function overload resolution in the global initiailizer.

tra added a subscriber: rsmith. tra added a comment. Looks good to me overall. I've pinged rsmith@ to double-check that we're covering all possibilities for non-local variable init. Comment at: clang/include/clang/Sema/Sema.h:11037 +bool

[PATCH] D71141: [Wdocumentation] Use C2x/C++14 deprecated attribute

This revision was automatically updated to reflect the committed changes. Mordante marked 2 inline comments as done. Closed by commit rGb6d386f6f996: [Wdocumentation] Use C2x/C++14 deprecated attribute (authored by Mordante). Changed prior to commit: https://reviews.llvm.org/D71141?vs=232695&id

RE: [clang] d82b6ba - Revert "[DWARF5] Start emitting DW_AT_dwo_name when -gdwarf-5 is specified."

[AMD Official Use Only - Internal Distribution Only] Thank You! Eric for clarifying this. I wasn't sure about this. I don't know why my git script missed that string in commit message, and allowed me to commit it. Any way thanks again. From: Eric Christopher Sent: Wednesday, December 11, 2019 1

[PATCH] D71241: [OpenMP][WIP] Use overload centric declare variants

ABataev added a comment. In D71241#1777972 , @jdoerfert wrote: > In D71241#109 , @ABataev wrote: > > > In D71241#1777661 , @jdoerfert > > wrote: > > > > > In D71241#1776

[clang] ef94cd1 - [OPENMP50]Add if clause in target simd directive.

Author: Alexey Bataev Date: 2019-12-10T15:33:18-05:00 New Revision: ef94cd1cf81d6e66838e1d7395fdaa6795ec7165 URL: https://github.com/llvm/llvm-project/commit/ef94cd1cf81d6e66838e1d7395fdaa6795ec7165 DIFF: https://github.com/llvm/llvm-project/commit/ef94cd1cf81d6e66838e1d7395fdaa6795ec7165.diff

[PATCH] D71227: [cuda][hip] Fix function overload resolution in the global initiailizer.

tra added a comment. I wonder if this patch will help with this case: https://godbolt.org/z/X4KdsV __device__ float fn(int) { return threadIdx.x; }; __host__ float fn(float); float gvar1 = []()__device__ { return fn(1);} (); // This ends up calling fn(int) on *host* We seem to happily

[clang] 3e315ba - Deprecate the hasDefaultArgument matcher

Author: Stephen Kelly Date: 2019-12-10T20:48:45Z New Revision: 3e315ba2547cbbfd6055e38bbca03f4d11bacbea URL: https://github.com/llvm/llvm-project/commit/3e315ba2547cbbfd6055e38bbca03f4d11bacbea DIFF: https://github.com/llvm/llvm-project/commit/3e315ba2547cbbfd6055e38bbca03f4d11bacbea.diff LOG:

[PATCH] D71166: Deprecate the hasDefaultArgument matcher

This revision was automatically updated to reflect the committed changes. Closed by commit rG3e315ba2547c: Deprecate the hasDefaultArgument matcher (authored by stephenkelly). Changed prior to commit: https://reviews.llvm.org/D71166?vs=232711&id=233177#toc Repository: rG LLVM Github Monorepo

[clang] 68009c2 - [c++20] Return type deduction for defaulted three-way comparisons.

Author: Richard Smith Date: 2019-12-10T13:03:12-08:00 New Revision: 68009c245dbe4c420ca06c0fea2a908f918137bb URL: https://github.com/llvm/llvm-project/commit/68009c245dbe4c420ca06c0fea2a908f918137bb DIFF: https://github.com/llvm/llvm-project/commit/68009c245dbe4c420ca06c0fea2a908f918137bb.diff

[clang] 336ac71 - [cxx_status] Fix table layout.

Author: Richard Smith Date: 2019-12-10T13:03:12-08:00 New Revision: 336ac7197eeeb4ab083f7402ec4edbb9b7bb252c URL: https://github.com/llvm/llvm-project/commit/336ac7197eeeb4ab083f7402ec4edbb9b7bb252c DIFF: https://github.com/llvm/llvm-project/commit/336ac7197eeeb4ab083f7402ec4edbb9b7bb252c.diff

[PATCH] D63640: [clang] Improve Serialization/Imporing/Dumping of APValues

Tyker added a comment. now that the issue with uniqueness of expressions is solved. we should be able to keep going on that review @rsmith. https://reviews.llvm.org/D63960 should be i think close to completion. so maybe for testing i could use immediate invocation as a source for ConstantExpr i

[PATCH] D70613: Add method to ignore invisible AST nodes

aaron.ballman added inline comments. Comment at: clang/include/clang/AST/Expr.h:769-770 + /// implicit conversions. + Expr *IgnoreInvisible(); + const Expr *IgnoreInvisible() const { +return const_cast(this)->IgnoreInvisible(); `Invisible` is a bit of an o

[PATCH] D71224: [analyzer] Escape symbols stored into specific region after a conservative evalcall.

NoQ added a comment. In any case, every checker is allowed to make their own decisions about escaping. Escape on its own is not material, it's all about how the checker reacts to escapes. Say, it's up to MallocChecker to decide whether the function may or may not release memory that escapes on

[clang] 3bd7cbb - [Remarks][Docs] Enhance documentation for opt-remarks driver options

Author: Francis Visoiu Mistrih Date: 2019-12-10T13:19:49-08:00 New Revision: 3bd7cbb90cdb9cf2ca481107ec66a75d9c885782 URL: https://github.com/llvm/llvm-project/commit/3bd7cbb90cdb9cf2ca481107ec66a75d9c885782 DIFF: https://github.com/llvm/llvm-project/commit/3bd7cbb90cdb9cf2ca481107ec66a75d9c885

[PATCH] D68896: PR43080: Do not build context-sensitive expressions during name classification.

kianm added a comment. Hi, I am still seeing problems with this assertion. Could we please get a fix? I've posted the reduced test case and reproducible command on this Phabricator patch. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D6889

[PATCH] D71224: [analyzer] Escape symbols stored into specific region after a conservative evalcall.

xazax.hun added a comment. In D71224#1778179 , @NoQ wrote: > In any case, every checker is allowed to make their own decisions about > escaping. Escape on its own is not material, it's all about how the checker > reacts to escapes. Say, it's up to Malloc

[clang] 02d04d5 - [OPENMP50]Do not mark the function as used if referenced only in declare

Author: Alexey Bataev Date: 2019-12-10T16:30:14-05:00 New Revision: 02d04d569edd39a17f27995565b7b65ac06afb35 URL: https://github.com/llvm/llvm-project/commit/02d04d569edd39a17f27995565b7b65ac06afb35 DIFF: https://github.com/llvm/llvm-project/commit/02d04d569edd39a17f27995565b7b65ac06afb35.diff

[clang] 3e1562e - Debug Info: Strengthen the synthesized-property-cleanup.mm test, NFC

Author: Vedant Kumar Date: 2019-12-10T13:39:22-08:00 New Revision: 3e1562e83339bb1e18fb36a5a2fc629c75f5f239 URL: https://github.com/llvm/llvm-project/commit/3e1562e83339bb1e18fb36a5a2fc629c75f5f239 DIFF: https://github.com/llvm/llvm-project/commit/3e1562e83339bb1e18fb36a5a2fc629c75f5f239.diff

[PATCH] D70613: Add method to ignore invisible AST nodes

steveire marked 10 inline comments as done. steveire added a comment. It wasn't possible to add the `const` because of the return type. Comment at: clang/include/clang/AST/Expr.h:769-770 + /// implicit conversions. + Expr *IgnoreInvisible(); + const Expr *IgnoreInvisible() c

[PATCH] D70613: Add method to ignore invisible AST nodes

steveire updated this revision to Diff 233183. steveire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70613/new/ https://reviews.llvm.org/D70613 Files: clang/include/clang/AST/ASTNodeTraverser.h clang/include/clang/AST/

[PATCH] D71224: [analyzer] Escape symbols stored into specific region after a conservative evalcall.

NoQ added a comment. In D71224#1778204 , @xazax.hun wrote: > I don't think this is a good enough model currently. The problem is that, it > does not play well with annotations. E.g. the checker can see a symbol > escaping, but it does not have a whole lo

[PATCH] D71300: [clangd] Deduplicate refs from index for cross-file rename.

hokein created this revision. hokein added a reviewer: ilya-biryukov. Herald added subscribers: usaxena95, kadircet, arphaman, mgrang, jkorous, MaskRay. Herald added a project: clang. If the index returns duplicated refs, it will trigger the assertion in BuildRenameEdit (we expect the processing

[PATCH] D71301: [clang][IFS] Prevent Clang-IFS from Leaking symbols from inside a block.

plotfi created this revision. plotfi added reviewers: compnerd, cishida. Herald added subscribers: cfe-commits, dexonsmith. Herald added a project: clang. Built libdispatch with clang interface stubs. Ran into some block related issues. Basically VarDecl symbols can leak out because I wasn't chec

[PATCH] D71226: Also synthesize _cmd and self for properties

liuliu added a comment. Thanks. Verified in our codebase this patch indeed fixed the crashes! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71226/new/ https://reviews.llvm.org/D71226 ___ cfe-commits ma

[PATCH] D71224: [analyzer] Escape symbols stored into specific region after a conservative evalcall.

xazax.hun added a comment. In D71224#1778231 , @NoQ wrote: > In D71224#1778204 , @xazax.hun wrote: > > > I don't think this is a good enough model currently. The problem is that, > > it does not play well with anno

[PATCH] D71300: [clangd] Deduplicate refs from index for cross-file rename.

merge_guards_bot added a comment. Build result: pass - 60688 tests passed, 0 failed and 726 were skipped. Log files: console-log.txt , CMakeCache.txt

[PATCH] D71224: [analyzer] Escape symbols stored into specific region after a conservative evalcall.

NoQ added a comment. In D71224#1778284 , @xazax.hun wrote: > So I was wondering if we got the default right. Maybe a checker should do > more work to get the escaping rather than more work preventing it? But that's exactly how it works right now(?) If y

[PATCH] D71224: [analyzer] Escape symbols stored into specific region after a conservative evalcall.

xazax.hun added a comment. In D71224#1778303 , @NoQ wrote: > In D71224#1778284 , @xazax.hun wrote: > > > So I was wondering if we got the default right. Maybe a checker should do > > more work to get the escaping r

[PATCH] D71224: [analyzer] Escape symbols stored into specific region after a conservative evalcall.

xazax.hun added a comment. I think I found the main problem with the current model, at least for the FuchsiaHandleCheck. Consider the following two snippets: zx_handle_t *get_handle_address(); void escape_store_to_escaped_region01() { zx_handle_t sb; if (zx_channel_create(0, get_han

[PATCH] D71239: [clang-format] Fix ObjC keywords following try/catch getting split.

Bigcheese marked an inline comment as done. Bigcheese added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:1849 + } while (FormatTok->is(tok::comment)); +} if (!(FormatTok->isOneOf(tok::kw_catch, Keywords.kw___except, MyDevelo

[PATCH] D71152: [analyzer] Keep track of escaped locals.

xazax.hun updated this revision to Diff 233198. xazax.hun added a comment. - A first take on trying to reuse `processPointerEscapedOnBind`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71152/new/ https://reviews.llvm.org/D71152 Files: clang/include/clang/StaticAnalyzer/Checkers/Chec

[PATCH] D71152: [analyzer] Keep track of escaped locals.

xazax.hun added a comment. Whoops, this one was updated accidentally. Wrong tab :( CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71152/new/ https://reviews.llvm.org/D71152 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://list

[PATCH] D71224: [analyzer] Escape symbols stored into specific region after a conservative evalcall.

xazax.hun updated this revision to Diff 233200. xazax.hun added a comment. - First take on trying to reuse `processPointerEscapedOnBind`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71224/new/ https://reviews.llvm.org/D71224 Files: clang/include/clang/StaticAnalyzer/Checkers/Checke

[clang] f4a7d56 - Remove debugging printf and reformat code.

Author: Eric Christopher Date: 2019-12-10T15:04:45-08:00 New Revision: f4a7d5659df7cb56c1baa34a39e9fe2639472741 URL: https://github.com/llvm/llvm-project/commit/f4a7d5659df7cb56c1baa34a39e9fe2639472741 DIFF: https://github.com/llvm/llvm-project/commit/f4a7d5659df7cb56c1baa34a39e9fe2639472741.di

Re: [clang] 7f9b513 - Reapply af57dbf12e54 "Add support for options -frounding-math, ftrapping-math, -ffp-model=, and -ffp-exception-behavior="

So you left some debugging code in that I've fixed thusly: "Enclosing function uses fp intrinsics" commit f4a7d5659df7cb56c1baa34a39e9fe2639472741 Author: Eric Christopher Date: Tue Dec 10 15:02:29 2019 -0800 Remove debugging printf and reformat code. On Thu, Dec 5, 2019 at 3:48 AM Melan

[PATCH] D71224: [analyzer] Escape symbols stored into specific region after a conservative evalcall.

NoQ added a comment. In D71224#1778332 , @xazax.hun wrote: > So basically what I am wonder/worrying about is the following: > The analyzer core will decide that the stack region is escaped and the > checkers has no word about this. Yup, you got me. Pre

[PATCH] D71179: [OpenMP][WIP] Initial support for `begin/end declare variant`

hfinkel added a comment. In D71179#1776761 , @ABataev wrote: > In D71179#1776528 , @hfinkel wrote: > > > In D71179#1776491 , @ABataev wrote: > > > > > In D71179#1776487

[PATCH] D70244: [Analyzer] Iterator Checkers: Replace `UnknownVal` in comparison result by a conjured value

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. That's a fair point, these days we always have to account for unknown values. I'm still curious (for science!) about how exactly it came to be in the tests. Repository: rC Clang CHANGES SINCE LA

[PATCH] D71313: [AST] Split parent map traversal logic into ParentMapContext.h

rnk created this revision. rnk added reviewers: bkramer, klimek, rsmith. Herald added subscribers: lldb-commits, kbarton, mgorny, nemanjai. Herald added projects: clang, LLDB. The only part of ASTContext.h that requires most AST types to be complete is the parent map. Nothing in Clang proper uses

[PATCH] D71179: [OpenMP][WIP] Initial support for `begin/end declare variant`

ABataev added a comment. In D71179#1778512 , @hfinkel wrote: > In D71179#1776761 , @ABataev wrote: > > > In D71179#1776528 , @hfinkel wrote: > > > > > In D71179#1776491

[PATCH] D70439: [Analyzer][Docs][NFC] Add CodeChecker to the command line tools

NoQ accepted this revision. NoQ added a comment. Thanks!!~ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70439/new/ https://reviews.llvm.org/D70439 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

[PATCH] D68213: [LTO] Support for embedding bitcode section during LTO

steven_wu added inline comments. Comment at: llvm/lib/LTO/LTOBackend.cpp:335 + .Case("bitcode", EmbedBitcodeKind::Embed_Bitcode) + .Case("marker", EmbedBitcodeKind::Embed_Marker) + .Default(~0U); t

[PATCH] D71241: [OpenMP][WIP] Use overload centric declare variants

hfinkel added a comment. In D71241#1778134 , @ABataev wrote: > ... >> >> >>> Also, check how -ast-print works with your solution. It returns different >>> result than expected because you're transform the code too early. It is >>> incorrect behavior

[PATCH] D70912: [Analyzer] Iterator Modeling: Print Container Data and Iterator Positions when printing the Program State

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Fantastic, thanks!! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70912/new/ https://reviews.llvm.org/D70912 ___ cfe-commits mailing list cfe-

[PATCH] D71314: Emit a warning if a variable is uninitialized in indirect ASM goto destination.

void created this revision. void added reviewers: jyknight, nickdesaulniers, hfinkel. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D71314 Files: clang/lib/Analysis/UninitializedValues.cpp clang/test/Anal

[PATCH] D70320: [Analyzer] [NFC] Iterator Checkers - Separate iterator modeling and the actual checkers

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. > I plan some refactoring but this first patch is meant to be a single > separation of code. Sounds great! Comment at: clang/lib/StaticAnalyzer/Checkers/IteratorModeling.cpp:1308

[PATCH] D70469: [attributes] [analyzer] Add handle related attributes

NoQ added a comment. What about `__attribute__((acquire_handle("fuchsia")))`? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70469/new/ https://reviews.llvm.org/D70469 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llv

[PATCH] D70805: [analyzer] SValHasDescendant: Determine whether the SVal has an SVal descendant

NoQ added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/SValHasDescendant.h:55 + bool VisitSymbolRegionValue(const SymbolRegionValue *S) { +return Visit(S->getRegion()); + } Arithmetic is indeed easy, but for example th

[PATCH] D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior

michele.scandale added a comment. In D62731#1775046 , @mibintc wrote: > In D62731#1773854 , > @michele.scandale wrote: > > > I've noticed you removed the change for `CompilerInvocation.cpp` about the > > initializ

[PATCH] D71241: [OpenMP][WIP] Use overload centric declare variants

ABataev added a comment. In D71241#1778564 , @hfinkel wrote: > In D71241#1778134 , @ABataev wrote: > > > > > > ... > > >> > >> > >>> Also, check how -ast-print works with your solution. It returns different > >>>

[PATCH] D71241: [OpenMP][WIP] Use overload centric declare variants

ABataev added a comment. In D71241#1778564 , @hfinkel wrote: > In D71241#1778134 , @ABataev wrote: > > > > > > ... > > >> > >> > >>> Also, check how -ast-print works with your solution. It returns different > >>>

[clang] 8434fbb - Revert "[analyzer] Keep track of escaped locals"

Author: Gabor Horvath Date: 2019-12-10T16:42:03-08:00 New Revision: 8434fbbee62e382376a39787785909bd55ae1696 URL: https://github.com/llvm/llvm-project/commit/8434fbbee62e382376a39787785909bd55ae1696 DIFF: https://github.com/llvm/llvm-project/commit/8434fbbee62e382376a39787785909bd55ae1696.diff

[PATCH] D71317: [clang][IFS] Prevent Clang-IFS from Leaking symbols from inside a block.

plotfi created this revision. plotfi added reviewers: compnerd, cishida. Herald added subscribers: cfe-commits, dexonsmith. Herald added a project: clang. Built libdispatch with clang interface stubs. Ran into some block related issues. Basically VarDecl symbols can leak out because I wasn't chec

[PATCH] D70268: [clang][clang-scan-deps] Aggregate the full dependency information.

Bigcheese updated this revision to Diff 233233. Bigcheese added a comment. Refactored `FullDependencies::getAdditionalCommandLine` and `ModuleDeps::getFullCommandLine` to share code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70268/new/ https:/

[PATCH] D71241: [OpenMP][WIP] Use overload centric declare variants

ABataev added a comment. There can be another one issue with this solution with inline assembly. I’m not completely sure about it, will try to investigate it tomorrow. I suggest to discuss this solution with Richard Smith (or John McCall). If he/they are ok with this transformation of the AST,

[PATCH] D71179: [OpenMP][WIP] Initial support for `begin/end declare variant`

jdoerfert updated this revision to Diff 233234. jdoerfert added a comment. Diff against TOT Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71179/new/ https://reviews.llvm.org/D71179 Files: clang/include/clang/AST/Decl.h clang/include/clang/AST/

[PATCH] D71179: [OpenMP][WIP] Initial support for `begin/end declare variant`

jdoerfert updated this revision to Diff 233232. jdoerfert added a comment. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Consistent overload based solution. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71179/new/ https://r

[PATCH] D71224: [analyzer] Escape symbols stored into specific region after a conservative evalcall.

xazax.hun updated this revision to Diff 233235. xazax.hun added a comment. - Rebasing after reverting the pre-escaping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71224/new/ https://reviews.llvm.org/D71224 Files: clang/include/clang/StaticAnalyzer/Checkers/Checkers.td clang/incl

Buildbot numbers for the week of 11/24/2019 - 11/30/2019

Hello everyone, Below are some buildbot numbers for the week of 11/24/2019 - 11/30/2019. Please see the same data in attached csv files: The longest time each builder was red during the week; "Status change ratio" by active builder (percent of builds that changed the builder status from greed to

Buildbot numbers for the week of 12/1/2019 - 12/7/2019

Hello everyone, Below are some buildbot numbers for the last week of 12/1/2019 - 12/7/2019. Please see the same data in attached csv files: The longest time each builder was red during the week; "Status change ratio" by active builder (percent of builds that changed the builder status from greed

[PATCH] D71224: [analyzer] Escape symbols stored into specific region after a conservative evalcall.

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Thanks!! Nothing controversial remains here, right? :) Comment at: clang/include/clang/StaticAnalyzer/Core/CheckerManager.h:91 + /// that the analyzer cannot follow during a conse

[clang] d5e66f0 - NFC: Get rid of an unused parameter to CGObjCMac::EmitSelectorAddr.

Author: Erik Pilkington Date: 2019-12-10T16:54:48-08:00 New Revision: d5e66f0e060da7f175cedf4f545fb4e13df7707e URL: https://github.com/llvm/llvm-project/commit/d5e66f0e060da7f175cedf4f545fb4e13df7707e DIFF: https://github.com/llvm/llvm-project/commit/d5e66f0e060da7f175cedf4f545fb4e13df7707e.dif

[PATCH] D71179: [OpenMP][WIP] Initial support for `begin/end declare variant`

merge_guards_bot added a comment. Build result: FAILURE - Could not check out parent git hash "9a3d576b08c13533597182498ba5e739924f892f". It was not found in the repository. Did you configure the "Parent Revision" in Phabricator properly? Trying to apply the patch to the master branch instead..

<    1   2   3   >