hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land.
I think we probably want to do the vice-versa thing (remove the inline keyword) in define-outline. ================ Comment at: clang-tools-extra/clangd/refactor/tweaks/DefineInline.cpp:373 + + const SourceManager &SM = FD->getASTContext().getSourceManager(); + llvm::StringRef FileName = SM.getFilename(FD->getLocation()); ---------------- nit: use `isHeaderFile` in SourceCode.h. ================ Comment at: clang-tools-extra/clangd/unittests/TweakTests.cpp:1913 + + // Specializations needs to be marked "inline". + ExtraFiles["a.h"] = R"cpp( ---------------- could you add a test case for partial template specializations? I think we don't need the inline for that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68261/new/ https://reviews.llvm.org/D68261 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
